CharacterCollection::get() - Code Metrics - Inspection of "Add get method to CharacterCollection + add Except..." - jeroendesloovere/character-collection - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 038339...49cf48 )

by Jeroen

created 2018-04-03 09:24 UTC

CharacterCollection::get() A

↳ Parent: CharacterCollection

Complexity

Conditions	2
Paths	2

Size

Total Lines	8
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	8
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	4
nc	2
nop	1

<?php

namespace JeroenDesloovere\CharacterCollection;

class CharacterCollection
{
    /** @var array */
    private $characters;

    public function __construct(string $sentence)
    {
        /** @var array $characters */
        $characters = str_split($sentence);

        foreach ($characters as $position => $character) {
            $this->add($position, $character);
        }
    }

    public function __toString(): string
    {
        $sentences = [];
        foreach ($this->characters as $position => $character) {
            foreach ($character->getPositions() as $position) {
                $sentences[$position] = $character->getValue();
            }
        }

        ksort($sentences);

        return implode($sentences);
    }

    public function add(int $position, string $character): void
    {
        if ($character === '') {
            return;
        }

        if (!isset($this->characters[$character])) {
            $this->characters[$character] = new Character($character);
        }

        $this->characters[$character]->addPosition($position);
    }

    public function get(string $character): Character
    {
        if (!array_key_exists($character, $this->characters)) {
            throw Exception::characterNotFound($character);
        }

        return $this->characters[$character];
    }
}


1			<?php
2
3			namespace JeroenDesloovere\CharacterCollection;
4
5			class CharacterCollection
6			{
7			/** @var array */
8			private $characters;
9
10			public function __construct(string $sentence)
11			{
12			/** @var array $characters */
13			$characters = str_split($sentence);
14
15			foreach ($characters as $position => $character) {
16			$this->add($position, $character);
17			}
18			}
19
20			public function __toString(): string
21			{
22			$sentences = [];
23			foreach ($this->characters as $position => $character) {
24			foreach ($character->getPositions() as $position) {
25			$sentences[$position] = $character->getValue();
26			}
27			}
28
29			ksort($sentences);
30
31			return implode($sentences);
32			}
33
34			public function add(int $position, string $character): void
35			{
36			if ($character === '') {
37			return;
38			}
39
40			if (!isset($this->characters[$character])) {
41			$this->characters[$character] = new Character($character);
42			}
43
44			$this->characters[$character]->addPosition($position);
45			}
46
47			public function get(string $character): Character
48			{
49			if (!array_key_exists($character, $this->characters)) {
50			throw Exception::characterNotFound($character);
51			}
52
53			return $this->characters[$character];
54			}
55			}
56

jeroendesloovere / character-collection

Push — master ( 038339...49cf48 )

CharacterCollection::get() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like