IrcMessageParser::parseSingle() - Code Metrics - Inspection of "Track users on a channel" - jerodev/php-irc-client - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( ac9c3e...191d3f )

by Jeroen

created 2019-02-28 18:38 UTC

IrcMessageParser::parseSingle() A

↳ Parent: IrcMessageParser

Complexity

Conditions	2
Paths	2

Size

Total Lines	15
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
eloc	9
nc	2
nop	1
dl	0
loc	15
rs	9.9666
c	0
b	0
f	0

<?php

namespace Jerodev\PhpIrcClient;

use Jerodev\PhpIrcClient\Messages\IrcMessage;
use Jerodev\PhpIrcClient\Messages\NameReplyMessage;

class IrcMessageParser
{
    /**
     *  Parse one ore more irc messages
     *
     *  @param string $message A string received from the irc server
     *
     *  @return IrcMessage[]
     */
    public function parse(string $message)
    {
        if ($messages = preg_split('/\r?\n\r?/', $message, -1, PREG_SPLIT_NO_EMPTY)) {
            foreach ($messages as $msg) {
                yield $this->parseSingle($msg);

            }
        }
    }

    /**
     *  Parse a single message to a corresponding object
     *
     *  @param string $message
     *
     *  @return IrcMessage
     */
    private function parseSingle(string $message): IrcMessage
    {
        $command = preg_replace('/^(?::[^\s]+\s+)?([^\s]+).*?$/', '$1', $message);
        switch ($command)
        {
            case IrcCommand::RPL_NAMREPLY:
                $msg = new NameReplyMessage($message);
                break;

            default:
                $msg = new IrcMessage($message);
                break;
        }

        return $msg;
    }
}


1			<?php
2
3			namespace Jerodev\PhpIrcClient;
4
5			use Jerodev\PhpIrcClient\Messages\IrcMessage;
6			use Jerodev\PhpIrcClient\Messages\NameReplyMessage;
7
8			class IrcMessageParser
9			{
10			/**
11			* Parse one ore more irc messages
12			*
13			* @param string $message A string received from the irc server
14			*
15			* @return IrcMessage[]
16			*/
17			public function parse(string $message)
18			{
19			if ($messages = preg_split('/\r?\n\r?/', $message, -1, PREG_SPLIT_NO_EMPTY)) {
20			foreach ($messages as $msg) {
21			yield $this->parseSingle($msg);
			0 ignored issues – show Bug Best Practice introduced 2019-02-28 18:39 UTC by Report Bug Copy Issue Report The expression `yield $this->parseSingle($msg)` returns the type `Generator` which is incompatible with the documented return type `Jerodev\PhpIrcClient\Messages\IrcMessage[]`. Loading history...
22			}
23			}
24			}
25
26			/**
27			* Parse a single message to a corresponding object
28			*
29			* @param string $message
30			*
31			* @return IrcMessage
32			*/
33			private function parseSingle(string $message): IrcMessage
34			{
35			$command = preg_replace('/^(?::[^\s]+\s+)?([^\s]+).*?$/', '$1', $message);
36			switch ($command)
37			{
38			case IrcCommand::RPL_NAMREPLY:
39			$msg = new NameReplyMessage($message);
40			break;
41
42			default:
43			$msg = new IrcMessage($message);
44			break;
45			}
46
47			return $msg;
48			}
49			}
50

jerodev / php-irc-client

Push — master ( ac9c3e...191d3f )

IrcMessageParser::parseSingle() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like