jeremykenedy / laravel2step

src/App/Notifications/SendVerificationCodeEmail.php

<?php

namespace jeremykenedy\laravel2step\App\Notifications;

use Illuminate\Bus\Queueable;
use Illuminate\Contracts\Queue\ShouldQueue;
use Illuminate\Notifications\Messages\MailMessage;
use Illuminate\Notifications\Notification;

class SendVerificationCodeEmail extends Notification implements ShouldQueue
{
    use Queueable;

    protected $code;
    protected $user;

    /**
     * Create a new notification instance.
     */
    public function __construct($user, $code)
    {
        $this->code = $code;
        $this->user = $user;
    }

    /**
     * Get the notification's delivery channels.
     *
     * @param mixed $notifiable
     *
     * @return array
     */
    public function via($notifiable)

The parameter $notifiable is not used and could be removed.

    {
        return ['mail'];
    }

    /**
     * Get the mail representation of the notification.
     *
     * @param mixed $notifiable
     *
     * @return \Illuminate\Notifications\Messages\MailMessage
     */
    public function toMail($notifiable)

The parameter $notifiable is not used and could be removed.

    {
        $message = new MailMessage();
        $message
            ->from(config('laravel2step.verificationEmailFrom'), config('laravel2step.verificationEmailFromName'))
            ->subject(trans('laravel2step::laravel-verification.verificationEmailSubject'))

It seems like trans('laravel2step::laravel-verification.verificationEmailSubject') can also be of type array and array; however, parameter $subject of Illuminate\Notifications\Messages\SimpleMessage::subject() does only seem to accept string, maybe add an additional type check?

            ->greeting(trans('laravel2step::laravel-verification.verificationEmailGreeting', ['username' => $this->user->name]))

It seems like trans('laravel2step::laravel-verification.verificationEmailGreeting', array('username' => $this->user->name)) can also be of type array and array; however, parameter $greeting of Illuminate\Notifications\Messages\SimpleMessage::greeting() does only seem to accept string, maybe add an additional type check?

            ->line(trans('laravel2step::laravel-verification.verificationEmailMessage'))
            ->line($this->code)
            ->action(trans('laravel2step::laravel-verification.verificationEmailButton'), route('laravel2step::verificationNeeded'));

It seems like trans('laravel2step::laravel-verification.verificationEmailButton') can also be of type array and array; however, parameter $text of Illuminate\Notifications\Messages\SimpleMessage::action() does only seem to accept string, maybe add an additional type check?

        return $message;
    }
}