jeremykenedy / laravel-soundboard

app/Http/Controllers/UserController.php

<?php

namespace App\Http\Controllers;

use App\Http\Requests\UserRequest;
use App\Models\User;
use Illuminate\Support\Facades\Hash;

class UserController extends Controller
{
    /**
     * Display a listing of the users.
     *
     * @param \App\User $model

The type App\User was not found. Maybe you did not declare it correctly or list all dependencies?

     *
     * @return \Illuminate\View\View
     */
    public function index(User $model)
    {
        $data = [
            'users' => $model->paginate(15),
        ];

        return view('users.index', $data);
    }

    /**
     * Show the form for creating a new user.
     *
     * @return \Illuminate\View\View
     */
    public function create()
    {
        $roles = config('roles.models.role')::all();
        $data = [
            'roles'  => $roles,
        ];

        return view('users.create', $data);
    }

    /**
     * Store a newly created user in storage.
     *
     * @param \App\Http\Requests\UserRequest $request
     * @param \App\User                      $model
     *
     * @return \Illuminate\Http\RedirectResponse
     */
    public function store(UserRequest $request, User $model)
    {
        $newUser = $model->create($request->merge(['password' => Hash::make($request->get('password'))])->all());
        $role = config('roles.models.role')::find($request->role);
        $newUser->attachRole($role);

        return redirect()->route('user.index')->withStatus(__('User successfully created.'));
    }

    /**
     * Show the form for editing the specified user.
     *
     * @param \App\User $user
     *
     * @return \Illuminate\View\View
     */
    public function edit(User $user)
    {
        $roles = [];

The assignment to $roles is dead and can be removed.

        $currentRole = '';
        $roles = config('roles.models.role')::all();

        foreach ($user->roles as $user_role) {

The property $roles is declared protected in App\Models\User. Since you implement __get, consider adding a @property or @property-read.

            $currentRole = $user_role;
        }

        $data = [
            'currentRole'   => $currentRole,
            'roles'         => $roles,
            'user'          => $user,
        ];

        return view('users.edit', $data);
    }

    /**
     * Update the specified user in storage.
     *
     * @param \App\Http\Requests\UserRequest $request
     * @param \App\User                      $user
     *
     * @return \Illuminate\Http\RedirectResponse
     */
    public function update(UserRequest $request, User $user)
    {
        $user->update(
            $request->merge(['password' => Hash::make($request->get('password'))])
                ->except(
                    [$request->get('password') ? '' : 'password']
                )
        );

        $role = config('roles.models.role')::find($request->role);
        $user->detachAllRoles();
        $user->attachRole($role);

        return redirect()->route('user.index')->withStatus(__('User successfully updated.'));
    }

    /**
     * Remove the specified user from storage.
     *
     * @param \App\User $user
     *
     * @return \Illuminate\Http\RedirectResponse
     */
    public function destroy(User $user)
    {
        $user->delete();

        return redirect()->route('user.index')->withStatus(__('User successfully deleted.'));
    }
}