jeremykenedy / laravel-roles

src/App/Http/Controllers/LaravelRolesController.php

<?php

namespace jeremykenedy\LaravelRoles\App\Http\Controllers;

use App\Http\Controllers\Controller;
use Illuminate\Http\Request;
use jeremykenedy\LaravelRoles\App\Http\Requests\StoreRoleRequest;
use jeremykenedy\LaravelRoles\App\Http\Requests\UpdateRoleRequest;
use jeremykenedy\LaravelRoles\App\Services\RoleFormFields;
use jeremykenedy\LaravelRoles\Traits\RolesAndPermissionsHelpersTrait;
use jeremykenedy\LaravelRoles\Traits\RolesUsageAuthTrait;

class LaravelRolesController extends Controller
{
    use RolesAndPermissionsHelpersTrait;

The trait jeremykenedy\LaravelRoles\Traits\RolesAndPermissionsHelpersTrait requires some properties which are not provided by jeremykenedy\LaravelRoles\App\Http\Controllers\LaravelRolesController: $role_id, $user_id, $id, $roles, $permission_id

    use RolesUsageAuthTrait;

    /**
     * Show the roles and Permissions dashboard.
     *
     * @return \Illuminate\Http\Response
     */
    public function index()
    {
        $data = $this->getDashboardData();

        return view($data['view'], $data['data']);

The expression return view($data['view'], $data['data']) returns the type Illuminate\View\View which is incompatible with the documented return type Illuminate\Http\Response.

    }

    /**
     * Show the form for creating a new resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function create()
    {
        $service = new RoleFormFields();
        $data = $service->handle();

Are you sure the assignment to $data is correct as $service->handle() targeting jeremykenedy\LaravelRoles\App\Services\RoleFormFields::handle() seems to always return null.

        return view('laravelroles::laravelroles.crud.roles.create', $data);

The expression return view('laravelroles::laravelroles.crud.roles.create', $data) returns the type Illuminate\View\View which is incompatible with the documented return type Illuminate\Http\Response.

$data of type void is incompatible with the type Illuminate\Contracts\Support\Arrayable|array expected by parameter $data of view().

    }

    /**
     * Store a newly created role in storage.
     *
     * @param \jeremykenedy\LaravelRoles\App\Http\Requests\StoreRoleRequest $request
     *
     * @return \Illuminate\Http\Response
     */
    public function store(StoreRoleRequest $request)
    {
        $roleData = $request->roleFillData();
        $rolePermissions = $request->get('permissions');
        $role = $this->storeRoleWithPermissions($roleData, $rolePermissions);

        return redirect()->route('laravelroles::roles.index')

The expression return redirect()->route('laravelroles::roles.index')->with('success', trans('laravelroles::laravelroles.flash-messages.role-create', array('role' => $role->name))) returns the type Illuminate\Http\RedirectResponse which is incompatible with the documented return type Illuminate\Http\Response.

                            ->with('success', trans('laravelroles::laravelroles.flash-messages.role-create', ['role' => $role->name]));
    }

    /**
     * Display the specified resource.
     *
     * @param int $id
     *
     * @return \Illuminate\Http\Response
     */
    public function show($id)
    {
        $item = $this->getRole($id);

        return view('laravelroles::laravelroles.crud.roles.show', compact('item'));

The expression return view('laravelroles::laravelroles.crud.roles.show', compact('item')) returns the type Illuminate\View\View which is incompatible with the documented return type Illuminate\Http\Response.

    }

    /**
     * Edit the specified resource.
     *
     * @param int $id
     *
     * @return \Illuminate\Http\Response
     */
    public function edit(Request $request, $id)
    {
        $service = new RoleFormFields($id);
        $data = $service->handle();

Are you sure the assignment to $data is correct as $service->handle() targeting jeremykenedy\LaravelRoles\App\Services\RoleFormFields::handle() seems to always return null.

        return view('laravelroles::laravelroles.crud.roles.edit', $data);

The expression return view('laravelroles::laravelroles.crud.roles.edit', $data) returns the type Illuminate\View\View which is incompatible with the documented return type Illuminate\Http\Response.

$data of type void is incompatible with the type Illuminate\Contracts\Support\Arrayable|array expected by parameter $data of view().

    }

    /**
     * Update the specified resource in storage.
     *
     * @param \jeremykenedy\LaravelRoles\App\Http\Requests\UpdateRoleRequest $request
     * @param int                                                            $id
     *
     * @return \Illuminate\Http\Response
     */
    public function update(UpdateRoleRequest $request, $id)
    {
        $roleData = $request->roleFillData();
        $rolePermissions = $request->get('permissions');
        $role = $this->updateRoleWithPermissions($id, $roleData, $rolePermissions);

        return redirect()->route('laravelroles::roles.index')

The expression return redirect()->route('laravelroles::roles.index')->with('success', trans('laravelroles::laravelroles.flash-messages.role-updated', array('role' => $role->name))) returns the type Illuminate\Http\RedirectResponse which is incompatible with the documented return type Illuminate\Http\Response.

            ->with('success', trans('laravelroles::laravelroles.flash-messages.role-updated', ['role' => $role->name]));
    }

    /**
     * Remove the specified resource from storage.
     *
     * @param int $id
     *
     * @return \Illuminate\Http\Response
     */
    public function destroy($id)
    {
        $role = $this->deleteRole($id);

        return redirect(route('laravelroles::roles.index'))

The expression return redirect(route('laravelroles::roles.index'))->with('success', trans('laravelroles::laravelroles.flash-messages.successDeletedItem', array('type' => 'Role', 'item' => $role->name))) returns the type Illuminate\Http\RedirectResponse which is incompatible with the documented return type Illuminate\Http\Response.

                    ->with('success', trans('laravelroles::laravelroles.flash-messages.successDeletedItem', ['type' => 'Role', 'item' => $role->name]));
    }
}