jeremykenedy / laravel-roles

src/App/Services/PermissionFormFields.php

<?php

namespace jeremykenedy\LaravelRoles\App\Services;

use jeremykenedy\LaravelRoles\Traits\RolesAndPermissionsHelpersTrait;

class PermissionFormFields
{
    use RolesAndPermissionsHelpersTrait;

The trait jeremykenedy\LaravelRoles\Traits\RolesAndPermissionsHelpersTrait requires some properties which are not provided by jeremykenedy\LaravelRoles\App\Services\PermissionFormFields: $role_id, $user_id, $roles, $permission_id

    /**
     * List of fields and default value for each field.
     *
     * @var array
     */
    protected $fieldList = [
        'name'          => '',
        'slug'          => '',
        'description'   => '',
        'model'         => '',
    ];

    /**
     * Create a new job instance.
     *
     * @param int $id
     *
     * @return void
     */
    public function __construct($id = null)
    {
        $this->id = $id;

The property id does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

    }

    /**
     * Execute the job.
     *
     * @return void
     */
    public function handle()
    {
        $fields = $this->fieldList;

        if ($this->id) {

The expression $this->id of type integer|null is loosely compared to true; this is ambiguous if the integer can be 0. You might want to explicitly use !== null instead.

            $fields = $this->fieldsFromModel($this->id, $fields);
        }

        foreach ($fields as $fieldName => $fieldValue) {
            $fields[$fieldName] = old($fieldName, $fieldValue);
        }

        // Get the additional data for the form fields
        $permissionFormFieldData = $this->permissionFormFieldData();

        return array_merge(

The expression return array_merge($fields, $permissionFormFieldData) returns the type array which is incompatible with the documented return type void.

            $fields,
            $permissionFormFieldData
        );

        return $fields;

return $fields is not reachable.

    }

    /**
     * Return the field values from the model.
     *
     * @param int   $id
     * @param array $fields
     *
     * @return array
     */
    protected function fieldsFromModel($id, array $fields)
    {
        $permission = config('roles.models.permission')::findOrFail($id);

        $fieldNames = array_keys(array_except($fields, ['permissions']));

The function array_except() has been deprecated: Arr::except() should be used directly instead. Will be removed in Laravel 6.0.

        $fields = [
            'id' => $id,
        ];
        foreach ($fieldNames as $field) {
            $fields[$field] = $permission->{$field};
        }

        return $fields;
    }

    /**
     * Get the additonal form fields data.
     *
     * @return array
     */
    protected function permissionFormFieldData()
    {
        return [
            'permissionModels' => $this->getPermissionModels(),
        ];
    }
}