LaravelRolesApiController::store() - Code Metrics - Inspection of "Add GUI" - jeremykenedy/laravel-roles - Measure and Improve Code Quality continuously with Scrutinizer

Test Setup Failed

Pull Request — master (#55)

by Jeremy

created 2019-05-28 07:25 UTC

LaravelRolesApiController::store() A

↳ Parent: LaravelRolesApiController

Complexity

Conditions	1
Paths	1

Size

Total Lines	12
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	9
nc	1
nop	1
dl	0
loc	12
rs	9.9666
c	0
b	0
f	0

<?php

namespace jeremykenedy\LaravelRoles\App\Http\Controllers\Api;

use App\Http\Controllers\Controller;
use jeremykenedy\LaravelRoles\App\Http\Requests\StoreRoleRequest;
use jeremykenedy\LaravelRoles\Traits\RolesAndPermissionsHelpersTrait;
use jeremykenedy\LaravelRoles\Traits\RolesUsageAuthTrait;

class LaravelRolesApiController extends Controller
{
    use RolesAndPermissionsHelpersTrait;

    // use RolesUsageAuthTrait;

    /**
     * Return all the roles, Permissions, and Users data.
     *
     * @return \Illuminate\Http\Response
     */
    public function index()
    {
        $data = $this->getDashboardData();

        return response()->json([

            'code'      => 200,
            'status'    => 'success',
            'message'   => 'Success returning all roles and permissions data.',
            'data'      => $data['data'],
        ], 200);
    }

    /**
     * Show the form for creating a new resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function store(StoreRoleRequest $request)
    {
        $roleData = $request->roleFillData();
        $rolePermissions = $request->get('permissions');
        $role = $this->storeRoleWithPermissions($roleData, $rolePermissions);

        return response()->json([

            'code'      => 201,
            'status'    => 'created',
            'message'   => 'Success created new role.',
            'role'      => $role,
        ], 201);
    }
}


1			<?php
2
3			namespace jeremykenedy\LaravelRoles\App\Http\Controllers\Api;
4
5			use App\Http\Controllers\Controller;
6			use jeremykenedy\LaravelRoles\App\Http\Requests\StoreRoleRequest;
7			use jeremykenedy\LaravelRoles\Traits\RolesAndPermissionsHelpersTrait;
8			use jeremykenedy\LaravelRoles\Traits\RolesUsageAuthTrait;
9
10			class LaravelRolesApiController extends Controller
11			{
12			use RolesAndPermissionsHelpersTrait;
			0 ignored issues – show introduced 2019-05-28 07:32 UTC by Report Bug Copy Issue Report The trait `jeremykenedy\LaravelRole...PermissionsHelpersTrait` requires some properties which are not provided by `jeremykenedy\LaravelRole...ravelRolesApiController`: `$role_id`, `$user_id`, `$id`, `$roles`, `$permission_id` Loading history...
13			// use RolesUsageAuthTrait;
14
15			/**
16			* Return all the roles, Permissions, and Users data.
17			*
18			* @return \Illuminate\Http\Response
19			*/
20			public function index()
21			{
22			$data = $this->getDashboardData();
23
24			return response()->json([
			0 ignored issues – show Bug Best Practice introduced 2019-05-28 07:32 UTC by Report Bug Copy Issue Report The expression `return response()->json(...=> $data['data']), 200)` returns the type `Illuminate\Http\JsonResponse` which is incompatible with the documented return type `Illuminate\Http\Response`. Loading history...
25			'code' => 200,
26			'status' => 'success',
27			'message' => 'Success returning all roles and permissions data.',
28			'data' => $data['data'],
29			], 200);
30			}
31
32			/**
33			* Show the form for creating a new resource.
34			*
35			* @return \Illuminate\Http\Response
36			*/
37			public function store(StoreRoleRequest $request)
38			{
39			$roleData = $request->roleFillData();
40			$rolePermissions = $request->get('permissions');
41			$role = $this->storeRoleWithPermissions($roleData, $rolePermissions);
42
43			return response()->json([
			0 ignored issues – show Bug Best Practice introduced 2019-05-28 07:32 UTC by Report Bug Copy Issue Report The expression `return response()->json(... 'role' => $role), 201)` returns the type `Illuminate\Http\JsonResponse` which is incompatible with the documented return type `Illuminate\Http\Response`. Loading history...
44			'code' => 201,
45			'status' => 'created',
46			'message' => 'Success created new role.',
47			'role' => $role,
48			], 201);
49			}
50			}
51

jeremykenedy / laravel-roles

Pull Request — master (#55)

LaravelRolesApiController::store() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like