View GitHub Repository laravel-roles

Schedule Inspection
Subscribe
Test Setup Failed
Pull Request — master (#194)
by
unknown
05:58
created
Status
Category
Toggle Patches
tests/Feature/NPlusOneQueriesTest.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch 
@@ -27,7 +27,7 @@  discard block
 
 block discarded – undo
27 27 
         $this->assertEquals($this->rolesCount, config('roles.models.role')::count());
28 28 
         $this->assertEquals($this->permissionsCount, config('roles.models.permission')::count());
29 29
30 
-        DB::listen(function (QueryExecuted $query) {
30 
+        DB::listen(function(QueryExecuted $query) {
31 31 
             $this->queries++;
32 32 
         });
33 33 
     }
 
@@ -38,7 +38,7 @@  discard block
 
 block discarded – undo
38 38 
         $roleIds = config('roles.models.role')::pluck('id');
39 39
40 40 
         User::factory($this->usersCount)->create()
41 
-            ->each(function (User $user) use ($roleIds) {
41 
+            ->each(function(User $user) use ($roleIds) {
42 42 
                 $user->roles()->attach($roleIds);
43 43 
             });
44 44 
         $this->assertEquals($this->usersCount, User::count());
 
@@ -49,7 +49,7 @@  discard block
 
 block discarded – undo
49 49 
         $users = User::get();
50 50 
         $this->assertQueries(1);
51 51
52 
-        $users->each(function (User $user) {
52 
+        $users->each(function(User $user) {
53 53 
             $user->getRoles();
54 54 
         });
55 55 
         $this->assertQueries($this->usersCount);
 
@@ -58,7 +58,7 @@  discard block
 
 block discarded – undo
58 58 
         $users = User::with('roles')->get();
59 59 
         $this->assertQueries(2);
60 60
61 
-        $users->each(function (User $user) {
61 
+        $users->each(function(User $user) {
62 62 
             $user->getRoles();
63 63 
         });
64 64 
         $this->assertQueries(0);
 
@@ -136,7 +136,7 @@  discard block
 
 block discarded – undo
136 136 
         $roleIds = config('roles.models.role')::pluck('id');
137 137
138 138 
         User::factory($this->usersCount)->create()
139 
-            ->each(function (User $user) use ($roleIds) {
139 
+            ->each(function(User $user) use ($roleIds) {
140 140 
                 $user->roles()->attach($roleIds);
141 141 
             });
142 142 
         $this->assertEquals($this->usersCount, User::count());
 
@@ -147,7 +147,7 @@  discard block
 
 block discarded – undo
147 147 
         $users = User::get();
148 148 
         $this->assertQueries(1);
149 149
150 
-        $users->each(function (User $user) {
150 
+        $users->each(function(User $user) {
151 151 
             $user->getPermissions();
152 152 
         });
153 153 
         // rolePermissions(+getRoles) + userPermissions
 
@@ -158,7 +158,7 @@  discard block
 
 block discarded – undo
158 158 
         $users = User::with('roles', 'userPermissions')->get();
159 159 
         $this->assertQueries(3);
160 160
161 
-        $users->each(function (User $user) {
161 
+        $users->each(function(User $user) {
162 162 
             $user->getPermissions();
163 163 
         });
164 164 
         // TODO: optimize via relations: userPermissions and rolePermissions
Please login to merge, or discard this patch.
tests/TestCase.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -44,7 +44,7 @@
 
 block discarded – undo
44 44 
      */
45 45 
     public function getEnvironmentSetUp($app)
46 46 
     {
47 
-        $app->singleton('seed.handler', function ($app) {
47 
+        $app->singleton('seed.handler', function($app) {
48 48 
             return new SeedHandler($app, collect());
49 49 
         });
50 50
Please login to merge, or discard this patch.