jeremykenedy\LaravelRoles\App\Http\Controllers\Api\LaravelRolesApiController

Complexity

Total Complexity

2

Size/Duplication

Total Lines	39
Duplicated Lines	0 %

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	store()	0	12	1
A	index()	0	10	1

<?php

namespace jeremykenedy\LaravelRoles\App\Http\Controllers\Api;

use App\Http\Controllers\Controller;
use jeremykenedy\LaravelRoles\App\Http\Requests\StoreRoleRequest;
use jeremykenedy\LaravelRoles\Traits\RolesAndPermissionsHelpersTrait;
use jeremykenedy\LaravelRoles\Traits\RolesUsageAuthTrait;

class LaravelRolesApiController extends Controller
{
    use RolesAndPermissionsHelpersTrait;

The trait jeremykenedy\LaravelRoles\Traits\RolesAndPermissionsHelpersTrait requires some properties which are not provided by jeremykenedy\LaravelRoles\App\Http\Controllers\Api\LaravelRolesApiController: $role_id, $user_id, $id, $roles, $permission_id

    // use RolesUsageAuthTrait;

    /**
     * Return all the roles, Permissions, and Users data.
     *
     * @return \Illuminate\Http\Response
     */
    public function index()
    {
        $data = $this->getDashboardData();

        return response()->json([

The expression return response()->json(array('code' => 200, 'status' => 'success', 'message' => 'Success returning all roles and permissions data.', 'data' => $data['data']), 200) returns the type Illuminate\Http\JsonResponse which is incompatible with the documented return type Illuminate\Http\Response.

            'code'      => 200,
            'status'    => 'success',
            'message'   => 'Success returning all roles and permissions data.',
            'data'      => $data['data'],
        ], 200);
    }

    /**
     * Show the form for creating a new resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function store(StoreRoleRequest $request)
    {
        $roleData = $request->roleFillData();
        $rolePermissions = $request->get('permissions');
        $role = $this->storeRoleWithPermissions($roleData, $rolePermissions);

        return response()->json([

The expression return response()->json(array('code' => 201, 'status' => 'created', 'message' => 'Success created new role.', 'role' => $role), 201) returns the type Illuminate\Http\JsonResponse which is incompatible with the documented return type Illuminate\Http\Response.

            'code'      => 201,
            'status'    => 'created',
            'message'   => 'Success created new role.',
            'role'      => $role,
        ], 201);
    }
}