PermissionFormFields::__construct() - Code Metrics - jeremykenedy/laravel-roles - Measure and Improve Code Quality continuously with Scrutinizer

PermissionFormFields::__construct() A
last analyzed 2025-04-03 16:54 UTC

↳ Parent: PermissionFormFields

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
eloc	1
c	1
b	0
f	0
nc	1
nop	1
dl	0
loc	3
rs	10

<?php

namespace jeremykenedy\LaravelRoles\App\Services;

use jeremykenedy\LaravelRoles\Traits\RolesAndPermissionsHelpersTrait;

class PermissionFormFields
{
    use RolesAndPermissionsHelpersTrait;


    /**
     * List of fields and default value for each field.
     *
     * @var array
     */
    protected $fieldList = [
        'name'          => '',
        'slug'          => '',
        'description'   => '',
        'model'         => '',
    ];

    /**
     * Create a new job instance.
     *
     * @param int $id
     *
     * @return void
     */
    public function __construct($id = null)
    {
        $this->id = $id;

    }

    /**
     * Execute the job.
     *
     * @return void
     */
    public function handle()
    {
        $fields = $this->fieldList;

        if ($this->id) {
0   == false // true
0   == null  // true
123 == false // false
123 == null  // false

// It is often better to use strict comparison
0 === false // false
0 === null  // false
            $fields = $this->fieldsFromModel($this->id, $fields);
        }

        foreach ($fields as $fieldName => $fieldValue) {
            $fields[$fieldName] = old($fieldName, $fieldValue);
        }

        // Get the additional data for the form fields
        $permissionFormFieldData = $this->permissionFormFieldData();

        return array_merge(

            $fields,
            $permissionFormFieldData
        );

        return $fields;
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}
    }

    /**
     * Return the field values from the model.
     *
     * @param int   $id
     * @param array $fields
     *
     * @return array
     */
    protected function fieldsFromModel($id, array $fields)
    {
        $permission = config('roles.models.permission')::findOrFail($id);

        $fieldNames = array_keys(array_except($fields, ['permissions']));

        $fields = [
            'id' => $id,
        ];
        foreach ($fieldNames as $field) {
            $fields[$field] = $permission->{$field};
        }

        return $fields;
    }

    /**
     * Get the additonal form fields data.
     *
     * @return array
     */
    protected function permissionFormFieldData()
    {
        return [
            'permissionModels' => $this->getPermissionModels(),
        ];
    }
}


1			<?php
2
3			namespace jeremykenedy\LaravelRoles\App\Services;
4
5			use jeremykenedy\LaravelRoles\Traits\RolesAndPermissionsHelpersTrait;
6
7			class PermissionFormFields
8			{
9			use RolesAndPermissionsHelpersTrait;
			0 ignored issues – show introduced 2019-05-28 07:32 UTC by Report Bug Copy Issue Report The trait `jeremykenedy\LaravelRole...PermissionsHelpersTrait` requires some properties which are not provided by `jeremykenedy\LaravelRole...es\PermissionFormFields`: `$role_id`, `$user_id`, `$roles`, `$permission_id` Loading history...
10
11			/**
12			* List of fields and default value for each field.
13			*
14			* @var array
15			*/
16			protected $fieldList = [
17			'name' => '',
18			'slug' => '',
19			'description' => '',
20			'model' => '',
21			];
22
23			/**
24			* Create a new job instance.
25			*
26			* @param int $id
27			*
28			* @return void
29			*/
30			public function __construct($id = null)
31			{
32			$this->id = $id;
			0 ignored issues – show Bug Best Practice introduced 2019-05-28 07:32 UTC by Report Bug Copy Issue Report The property `id` does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly. Loading history...
33			}
34
35			/**
36			* Execute the job.
37			*
38			* @return void
39			*/
40			public function handle()
41			{
42			$fields = $this->fieldList;
43
44			if ($this->id) {
			0 ignored issues – show Bug Best Practice introduced 2019-05-28 07:32 UTC by Report Bug Copy Issue Report The expression `$this->id` of type `integer\|null` is loosely compared to `true`; this is ambiguous if the integer can be 0. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `integer` values, zero is a special case, in particular the following results might be unexpected: 0 == false // true 0 == null // true 123 == false // false 123 == null // false // It is often better to use strict comparison 0 === false // false 0 === null // false Loading history...
45			$fields = $this->fieldsFromModel($this->id, $fields);
46			}
47
48			foreach ($fields as $fieldName => $fieldValue) {
49			$fields[$fieldName] = old($fieldName, $fieldValue);
50			}
51
52			// Get the additional data for the form fields
53			$permissionFormFieldData = $this->permissionFormFieldData();
54
55			return array_merge(
			0 ignored issues – show Bug Best Practice introduced 2019-05-28 07:32 UTC by Report Bug Copy Issue Report The expression `return array_merge($fiel...ermissionFormFieldData)` returns the type `array` which is incompatible with the documented return type `void`. Loading history...
56			$fields,
57			$permissionFormFieldData
58			);
59
60			return $fields;
			0 ignored issues – show Unused Code introduced 2019-05-28 07:32 UTC by Report Bug Copy Issue Report `return $fields` is not reachable. This check looks for unreachable code. It uses sophisticated control flow analysis techniques to find statements which will never be executed. Unreachable code is most often the result of `return`, `die` or `exit` statements that have been added for debug purposes. function fx() { try { doSomething(); return true; } catch (\Exception $e) { return false; } return false; } In the above example, the last `return false` will never be executed, because a return statement has already been met in every possible execution path. Loading history...
61			}
62
63			/**
64			* Return the field values from the model.
65			*
66			* @param int $id
67			* @param array $fields
68			*
69			* @return array
70			*/
71			protected function fieldsFromModel($id, array $fields)
72			{
73			$permission = config('roles.models.permission')::findOrFail($id);
74
75			$fieldNames = array_keys(array_except($fields, ['permissions']));
76
77			$fields = [
78			'id' => $id,
79			];
80			foreach ($fieldNames as $field) {
81			$fields[$field] = $permission->{$field};
82			}
83
84			return $fields;
85			}
86
87			/**
88			* Get the additonal form fields data.
89			*
90			* @return array
91			*/
92			protected function permissionFormFieldData()
93			{
94			return [
95			'permissionModels' => $this->getPermissionModels(),
96			];
97			}
98			}
99

jeremykenedy / laravel-roles

PermissionFormFields::__construct() A last analyzed 2025-04-03 16:54 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

PermissionFormFields::__construct() A
last analyzed 2025-04-03 16:54 UTC