jeremykenedy\LaravelRoles\App\Http\Controllers\LaravelPermissionsController

Complexity

Total Complexity

7

Size/Duplication

Total Lines	105
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	1

7 Methods

Rating	Name	Duplication	Size	Complexity
A	edit()	0	6	1
A	create()	0	6	1
A	update()	0	7	1
A	store()	0	7	1
A	destroy()	0	6	1
A	index()	0	5	1
A	show()	0	5	1

<?php

namespace jeremykenedy\LaravelRoles\App\Http\Controllers;

use App\Http\Controllers\Controller;
use Illuminate\Http\Request;
use jeremykenedy\LaravelRoles\App\Http\Requests\StorePermissionRequest;
use jeremykenedy\LaravelRoles\App\Http\Requests\UpdatePermissionRequest;
use jeremykenedy\LaravelRoles\App\Services\PermissionFormFields;
use jeremykenedy\LaravelRoles\Traits\RolesAndPermissionsHelpersTrait;
use jeremykenedy\LaravelRoles\Traits\RolesUsageAuthTrait;

class LaravelPermissionsController extends Controller
{
    use RolesAndPermissionsHelpersTrait;

The trait jeremykenedy\LaravelRoles\Traits\RolesAndPermissionsHelpersTrait requires some properties which are not provided by jeremykenedy\LaravelRoles\App\Http\Controllers\LaravelPermissionsController: $role_id, $user_id, $id, $roles, $permission_id

    use RolesUsageAuthTrait;

    /**
     * Show the roles and Permissions dashboard.
     *
     * @return \Illuminate\Http\Response
     */
    public function index()
    {
        $data = $this->getDashboardData();

        return view($data['view'], $data['data']);

The expression return view($data['view'], $data['data']) returns the type Illuminate\View\View which is incompatible with the documented return type Illuminate\Http\Response.

    }

    /**
     * Show the form for creating a new resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function create()
    {
        $service = new PermissionFormFields();
        $data = $service->handle();

Are you sure the assignment to $data is correct as $service->handle() targeting jeremykenedy\LaravelRoles\App\Services\PermissionFormFields::handle() seems to always return null.

        return view('laravelroles::laravelroles.crud.permissions.create', $data);

$data of type void is incompatible with the type Illuminate\Contracts\Support\Arrayable|array expected by parameter $data of view().

The expression return view('laravelroles::laravelroles.crud.permissions.create', $data) returns the type Illuminate\View\View which is incompatible with the documented return type Illuminate\Http\Response.

    }

    /**
     * Store a newly created permission in storage.
     *
     * @param \jeremykenedy\LaravelRoles\App\Http\Requests\StorePermissionRequest $request
     *
     * @return \Illuminate\Http\Response
     */
    public function store(StorePermissionRequest $request)
    {
        $permissionData = $request->permissionFillData();
        $permission = $this->storeNewPermission($permissionData);

        return redirect()->route('laravelroles::roles.index')

The expression return redirect()->route('laravelroles::roles.index')->with('success', trans('laravelroles::laravelroles.flash-messages.permission-create', array('permission' => $permission->name))) returns the type Illuminate\Http\RedirectResponse which is incompatible with the documented return type Illuminate\Http\Response.

                            ->with('success', trans('laravelroles::laravelroles.flash-messages.permission-create', ['permission' => $permission->name]));
    }

    /**
     * Display the specified resource.
     *
     * @param int $id
     *
     * @return \Illuminate\Http\Response
     */
    public function show($id)
    {
        $data = $this->getPermissionItemData($id);

        return view('laravelroles::laravelroles.crud.permissions.show', $data);

The expression return view('laravelroles::laravelroles.crud.permissions.show', $data) returns the type Illuminate\View\View which is incompatible with the documented return type Illuminate\Http\Response.

    }

    /**
     * Edit the specified resource.
     *
     * @param int $id
     *
     * @return \Illuminate\Http\Response
     */
    public function edit(Request $request, $id)
    {
        $service = new PermissionFormFields($id);
        $data = $service->handle();

Are you sure the assignment to $data is correct as $service->handle() targeting jeremykenedy\LaravelRoles\App\Services\PermissionFormFields::handle() seems to always return null.

        return view('laravelroles::laravelroles.crud.permissions.edit', $data);

The expression return view('laravelroles::laravelroles.crud.permissions.edit', $data) returns the type Illuminate\View\View which is incompatible with the documented return type Illuminate\Http\Response.

$data of type void is incompatible with the type Illuminate\Contracts\Support\Arrayable|array expected by parameter $data of view().

    }

    /**
     * Update the specified resource in storage.
     *
     * @param \jeremykenedy\LaravelRoles\App\Http\Requests\UpdatePermissionRequest $request
     * @param int                                                                  $id
     *
     * @return \Illuminate\Http\Response
     */
    public function update(UpdatePermissionRequest $request, $id)
    {
        $permissionData = $request->permissionFillData($id);

The call to jeremykenedy\LaravelRoles\App\Http\Requests\StorePermissionRequest::permissionFillData() has too many arguments starting with $id.

        $permission = $this->updatePermission($id, $permissionData);

        return redirect()->route('laravelroles::roles.index')

The expression return redirect()->route('laravelroles::roles.index')->with('success', trans('laravelroles::laravelroles.flash-messages.permission-updated', array('permission' => $permission->name))) returns the type Illuminate\Http\RedirectResponse which is incompatible with the documented return type Illuminate\Http\Response.

            ->with('success', trans('laravelroles::laravelroles.flash-messages.permission-updated', ['permission' => $permission->name]));
    }

    /**
     * Remove the specified resource from storage.
     *
     * @param int $id
     *
     * @return \Illuminate\Http\Response
     */
    public function destroy($id)
    {
        $permission = $this->deletePermission($id);

        return redirect(route('laravelroles::roles.index'))

The expression return redirect(route('laravelroles::roles.index'))->with('success', trans('laravelroles::laravelroles.flash-messages.successDeletedItem', array('type' => 'Permission', 'item' => $permission->name))) returns the type Illuminate\Http\RedirectResponse which is incompatible with the documented return type Illuminate\Http\Response.

                    ->with('success', trans('laravelroles::laravelroles.flash-messages.successDeletedItem', ['type' => 'Permission', 'item' => $permission->name]));
    }
}