Conditions | 2 |
Paths | 2 |
Total Lines | 52 |
Code Lines | 39 |
Lines | 0 |
Ratio | 0 % |
Changes | 1 | ||
Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
61 | public function store(Request $request) |
||
62 | { |
||
63 | $validator = Validator::make( |
||
64 | $request->all(), |
||
65 | [ |
||
66 | 'name' => 'required|max:255|unique:users', |
||
67 | 'first_name' => '', |
||
68 | 'last_name' => '', |
||
69 | 'email' => 'required|email|max:255|unique:users', |
||
70 | 'password' => 'required|min:6|max:20|confirmed', |
||
71 | 'password_confirmation' => 'required|same:password', |
||
72 | 'role' => 'required', |
||
73 | ], |
||
74 | [ |
||
75 | 'name.unique' => trans('auth.userNameTaken'), |
||
76 | 'name.required' => trans('auth.userNameRequired'), |
||
77 | 'first_name.required' => trans('auth.fNameRequired'), |
||
78 | 'last_name.required' => trans('auth.lNameRequired'), |
||
79 | 'email.required' => trans('auth.emailRequired'), |
||
80 | 'email.email' => trans('auth.emailInvalid'), |
||
81 | 'password.required' => trans('auth.passwordRequired'), |
||
82 | 'password.min' => trans('auth.PasswordMin'), |
||
83 | 'password.max' => trans('auth.PasswordMax'), |
||
84 | 'role.required' => trans('auth.roleRequired'), |
||
85 | ] |
||
86 | ); |
||
87 | |||
88 | if ($validator->fails()) { |
||
89 | $this->throwValidationException( |
||
90 | $request, |
||
91 | $validator |
||
92 | ); |
||
93 | } else { |
||
94 | $ipAddress = new CaptureIpTrait(); |
||
95 | $profile = new Profile(); |
||
96 | |||
97 | $user = User::create([ |
||
98 | 'name' => $request->input('name'), |
||
99 | 'first_name' => $request->input('first_name'), |
||
100 | 'last_name' => $request->input('last_name'), |
||
101 | 'email' => $request->input('email'), |
||
102 | 'password' => bcrypt($request->input('password')), |
||
103 | 'token' => str_random(64), |
||
104 | 'admin_ip_address' => $ipAddress->getClientIp(), |
||
105 | 'activated' => 1, |
||
106 | ]); |
||
107 | |||
108 | $user->profile()->save($profile); |
||
109 | $user->attachRole($request->input('role')); |
||
110 | $user->save(); |
||
111 | |||
112 | return redirect('users')->with('success', trans('usersmanagement.createSuccess')); |
||
113 | } |
||
235 |