jeremykenedy / laravel-auth

app/Notifications/SendGoodbyeEmail.php

<?php

namespace App\Notifications;

use Illuminate\Bus\Queueable;
use Illuminate\Contracts\Queue\ShouldQueue;
use Illuminate\Notifications\Messages\MailMessage;
use Illuminate\Notifications\Notification;

class SendGoodbyeEmail extends Notification implements ShouldQueue
{
    use Queueable;

    protected $token;

    /**
     * Create a new notification instance.
     */
    public function __construct($token)
    {
        $this->token = $token;
    }

    /**
     * Get the notification's delivery channels.
     *
     * @param mixed $notifiable
     *
     * @return array
     */
    public function via($notifiable)

The parameter $notifiable is not used and could be removed.

    {
        return ['mail'];
    }

    /**
     * Get the mail representation of the notification.
     *
     * @param mixed $notifiable
     *
     * @return \Illuminate\Notifications\Messages\MailMessage
     */
    public function toMail($notifiable)

The parameter $notifiable is not used and could be removed.

    {
        $message = new MailMessage();
        $message->subject(trans('emails.goodbyeSubject'))

It seems like trans('emails.goodbyeSubject') can also be of type array and array; however, parameter $subject of Illuminate\Notifications\Messages\SimpleMessage::subject() does only seem to accept string, maybe add an additional type check?

            ->greeting(trans('emails.goodbyeGreeting', ['username' => \Auth::User()->name]))

Accessing name on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

It seems like trans('emails.goodbyeGreeting', array('username' => Auth::User()->name)) can also be of type array and array; however, parameter $greeting of Illuminate\Notifications\Messages\SimpleMessage::greeting() does only seem to accept string, maybe add an additional type check?

            ->line(trans('emails.goodbyeMessage'))
            ->action(trans('emails.goodbyeButton'), route('user.reactivate', ['token' => $this->token]))

It seems like trans('emails.goodbyeButton') can also be of type array and array; however, parameter $text of Illuminate\Notifications\Messages\SimpleMessage::action() does only seem to accept string, maybe add an additional type check?

            ->line(trans('emails.goodbyeThanks'));

        return $message;
    }

    /**
     * Get the array representation of the notification.
     *
     * @param mixed $notifiable
     *
     * @return array
     */
    public function toArray($notifiable)

The parameter $notifiable is not used and could be removed.

    {
        return [
            //
        ];
    }
}