App\Http\Controllers\Auth\SocialController::getSocialHandle()

Complexity

Conditions	12
Paths	74

Size

Total Lines	96
Code Lines	57

Duplication

Lines	0
Ratio	0 %

Importance

Changes	10
Bugs	2	Features	0

<?php
    public function getSocialHandle($provider, Request $request)
    {
        $denied = $request->denied ? $request->denied : null;
        $socialUser = null;

        if ($denied != null || $denied != '') {
            return redirect()->to('login')

The expression return redirect()->to('login')->with('status', 'danger')->with('message', trans('socials.denied')) returns the type Illuminate\Http\RedirectResponse which is incompatible with the documented return type App\Http\Controllers\Auth\Redirect.

                ->with('status', 'danger')
                ->with('message', trans('socials.denied'));
        }

        $socialUserObject = Socialite::driver($provider)->user();

        // Check if email is already registered
        $userCheck = User::where('email', '=', $socialUserObject->email)->first();

Accessing email on the interface Laravel\Socialite\Contracts\User suggest that you code against a concrete implementation. How about adding an instanceof check?

        $email = $socialUserObject->email;

        if (! $socialUserObject->email) {
            $email = 'missing'.str_random(10).'@'.str_random(10).'.example.org';
        }

        // If user is not registered
        if (empty($userCheck)) {
            $sameSocialId = Social::where('social_id', '=', $socialUserObject->id)

Accessing id on the interface Laravel\Socialite\Contracts\User suggest that you code against a concrete implementation. How about adding an instanceof check?

                ->where('provider', '=', $provider)
                ->first();

            if (empty($sameSocialId)) {
                $ipAddress = new CaptureIpTrait();
                $socialData = new Social();
                $profile = new Profile();
                $role = Role::where('slug', '=', 'user')->first();
                $fullname = explode(' ', $socialUserObject->name);

Accessing name on the interface Laravel\Socialite\Contracts\User suggest that you code against a concrete implementation. How about adding an instanceof check?

                if (count($fullname) == 1) {
                    $fullname[1] = '';
                }
                $username = $socialUserObject->nickname;

Accessing nickname on the interface Laravel\Socialite\Contracts\User suggest that you code against a concrete implementation. How about adding an instanceof check?

                if ($username == null) {
                    foreach ($fullname as $name) {
                        $username .= $name;
                    }
                }

                // Check to make sure username does not already exist in DB before recording
                $username = $this->checkUserName($username, $email);

                $user = User::create([
                    'name'                 => $username,
                    'first_name'           => $fullname[0],
                    'last_name'            => $fullname[1],
                    'email'                => $email,
                    'password'             => bcrypt(str_random(40)),
                    'token'                => str_random(64),
                    'activated'            => true,
                    'signup_sm_ip_address' => $ipAddress->getClientIp(),

                ]);

                $socialData->social_id = $socialUserObject->id;
                $socialData->provider = $provider;
                $user->social()->save($socialData);
                $user->attachRole($role);
                $user->activated = true;

                $user->profile()->save($profile);
                $user->save();

                if ($socialData->provider == 'github') {
                    $user->profile->github_username = $socialUserObject->nickname;
                }

                // Twitter User Object details: https://developer.twitter.com/en/docs/tweets/data-dictionary/overview/user-object
                if ($socialData->provider == 'twitter') {
                    //$user->profile()->twitter_username = $socialUserObject->screen_name;
                    //If the above fails try (The documentation shows screen_name however so Twitters docs may be out of date.):
                    $user->profile()->twitter_username = $socialUserObject->nickname;
                }
                $user->profile->save();

                $socialUser = $user;
            } else {
                $socialUser = $sameSocialId->user;
            }

            auth()->login($socialUser, true);

            return redirect($this->redirectSuccessLogin)->with('success', trans('socials.registerSuccess'));

The expression return redirect($this->redirectSuccessLogin)->with('success', trans('socials.registerSuccess')) returns the type Illuminate\Http\RedirectResponse which is incompatible with the documented return type App\Http\Controllers\Auth\Redirect.

        }

        $socialUser = $userCheck;

        auth()->login($socialUser, true);

        return redirect($this->redirectSuccessLogin);

The expression return redirect($this->redirectSuccessLogin) returns the type Illuminate\Http\RedirectResponse which is incompatible with the documented return type App\Http\Controllers\Auth\Redirect.

    }