App\Http\Controllers\Auth\ActivateController

Complexity

Total Complexity

26

Size/Duplication

Total Lines	284
Duplicated Lines	0 %

Importance

Changes	2
Bugs	1	Features	0

11 Methods

Rating	Name	Duplication	Size	Complexity
A	getAdminHomeRoute()	0	3	1
A	__construct()	0	3	1
A	getUserHomeRoute()	0	3	1
A	getActivationView()	0	3	1
A	getActivationRoute()	0	3	1
A	initial()	0	17	2
A	activationRequired()	0	36	5
A	activeRedirect()	0	22	4
A	exceeded()	0	23	2
A	resend()	0	36	3
A	activate()	0	46	5

<?php

namespace App\Http\Controllers\Auth;

use App\Http\Controllers\Controller;
use App\Models\Activation;
use App\Models\Profile;
use App\Models\User;
use App\Traits\ActivationTrait;
use App\Traits\CaptureIpTrait;
use Auth;
use Carbon\Carbon;
use Illuminate\Support\Facades\Log;
use Illuminate\Support\Facades\Route;
use jeremykenedy\LaravelRoles\Models\Role;

class ActivateController extends Controller
{
    use ActivationTrait;

The trait App\Traits\ActivationTrait requires the property $email which is not provided by App\Http\Controllers\Auth\ActivateController.

    private static $userHomeRoute = 'public.home';
    private static $adminHomeRoute = 'public.home';
    private static $activationView = 'auth.activation';
    private static $activationRoute = 'activation-required';

    /**
     * Create a new controller instance.
     *
     * @return void
     */
    public function __construct()
    {
        $this->middleware('auth');
    }

    /**
     * Gets the user home route.
     *
     * @return string
     */
    public static function getUserHomeRoute()
    {
        return self::$userHomeRoute;
    }

    /**
     * Gets the admin home route.
     *
     * @return string
     */
    public static function getAdminHomeRoute()
    {
        return self::$adminHomeRoute;
    }

    /**
     * Gets the activation view.
     *
     * @return string
     */
    public static function getActivationView()
    {
        return self::$activationView;
    }

    /**
     * Gets the activation route.
     *
     * @return string
     */
    public static function getActivationRoute()
    {
        return self::$activationRoute;
    }

    /**
     * Redirect the user after activation with admin logic.
     *
     * @param $user             The user
     * @param currentRoute      The current route
     *
     * @return Redirect
     */
    public static function activeRedirect($user, $currentRoute)
    {
        if ($user->activated) {
            Log::info('Activated user attempted to visit '.$currentRoute.'. ', [$user]);

            $message = trans('auth.regThanks');
            if (config('settings.activation')) {
                $message = trans('auth.alreadyActivated');
            }

            if ($user->isAdmin()) {
                return redirect()->route(self::getAdminHomeRoute())
                ->with('status', 'info')
                ->with('message', $message);
            }

            return redirect()->route(self::getUserHomeRoute())
                ->with('status', 'info')
                ->with('message', $message);
        }

        return false;
    }

    /**
     * Initial Activation View.
     *
     * @return Redirect
     */
    public function initial()
    {
        $user = Auth::user();
        $lastActivation = Activation::where('user_id', $user->id)->get()->last();

Accessing id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

        $currentRoute = Route::currentRouteName();

        $rCheck = $this->activeRedirect($user, $currentRoute);

It seems like $currentRoute can also be of type string; however, parameter $currentRoute of App\Http\Controllers\Auth\ActivateController::activeRedirect() does only seem to accept App\Http\Controllers\Auth\The, maybe add an additional type check?

        if ($rCheck) {

$rCheck is of type App\Http\Controllers\Auth\Redirect, thus it always evaluated to true.

            return $rCheck;
        }

        $data = [
            'email' => $user->email,
            'date'  => $lastActivation->created_at->format('m/d/Y'),
        ];

        return view($this->getActivationView())->with($data);
    }

    /**
     * Check if actication is required.
     *
     * @return View

The type App\Http\Controllers\Auth\View was not found. Did you mean View? If so, make sure to prefix the type with \.

     */
    public function activationRequired()
    {
        $user = Auth::user();
        $lastActivation = Activation::where('user_id', $user->id)->get()->last();

Accessing id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

        $currentRoute = Route::currentRouteName();

        $rCheck = $this->activeRedirect($user, $currentRoute);

It seems like $currentRoute can also be of type string; however, parameter $currentRoute of App\Http\Controllers\Auth\ActivateController::activeRedirect() does only seem to accept App\Http\Controllers\Auth\The, maybe add an additional type check?

        if ($rCheck) {

$rCheck is of type App\Http\Controllers\Auth\Redirect, thus it always evaluated to true.

            return $rCheck;
        }

        if ($user->activated === false) {
            $activationsCount = Activation::where('user_id', $user->id)
                ->where('created_at', '>=', Carbon::now()->subHours(config('settings.timePeriod')))
                ->count();

            if ($activationsCount > config('settings.maxAttempts')) {
                Log::info('Exceded max resends in last '.config('settings.timePeriod').' hours. '.$currentRoute.'. ', [$user]);

                $data = [
                    'email' => $user->email,
                    'hours' => config('settings.timePeriod'),
                ];

                return view('auth.exceeded')->with($data);
            }
        }

        Log::info('Registered attempted to navigate while unactivate. '.$currentRoute.'. ', [$user]);

        $data = [
            'email' => $user->email,
            'date'  => $lastActivation ? $lastActivation->created_at->format('m/d/Y') : null, //
        ];

        return view($this->getActivationView())->with($data);
    }

    /**
     * Activate a valid user with a token.
     *
     * @param string $token The token
     *
     * @return Redirect
     */
    public function activate($token)
    {
        $user = Auth::user();
        $currentRoute = Route::currentRouteName();
        $ipAddress = new CaptureIpTrait();
        $role = Role::where('slug', '=', 'user')->first();

        $rCheck = $this->activeRedirect($user, $currentRoute);

It seems like $currentRoute can also be of type string; however, parameter $currentRoute of App\Http\Controllers\Auth\ActivateController::activeRedirect() does only seem to accept App\Http\Controllers\Auth\The, maybe add an additional type check?

        if ($rCheck) {

$rCheck is of type App\Http\Controllers\Auth\Redirect, thus it always evaluated to true.

            return $rCheck;
        }

        $activation = Activation::where('token', $token)->get()
            ->where('user_id', $user->id)
            ->first();

        if (empty($activation)) {
            Log::info('Registered user attempted to activate with an invalid token: '.$currentRoute.'. ', [$user]);

            return redirect()->route(self::getActivationRoute())
                ->with('status', 'danger')
                ->with('message', trans('auth.invalidToken'));
        }

        $user->activated = true;
        $user->detachAllRoles();
        $user->attachRole($role);
        $user->signup_confirmation_ip_address = $ipAddress->getClientIp();
        $user->save();

        $allActivations = Activation::where('user_id', $user->id)->get();
        foreach ($allActivations as $anActivation) {
            $anActivation->delete();
        }

        Log::info('Registered user successfully activated. '.$currentRoute.'. ', [$user]);

        if ($user->isAdmin()) {
            return redirect()->route(self::getAdminHomeRoute())
            ->with('status', 'success')
            ->with('message', trans('auth.successActivated'));
        }

        return redirect()->route(self::getUserHomeRoute())
            ->with('status', 'success')
            ->with('message', trans('auth.successActivated'));
    }

    /**
     * Resend Activation.
     *
     * @return Redirect
     */
    public function resend()
    {
        $user = Auth::user();
        $lastActivation = Activation::where('user_id', $user->id)->get()->last();

The assignment to $lastActivation is dead and can be removed.

Accessing id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

        $currentRoute = Route::currentRouteName();

        if ($user->activated === false) {

Accessing activated on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

            $activationsCount = Activation::where('user_id', $user->id)
                ->where('created_at', '>=', Carbon::now()->subHours(config('settings.timePeriod')))
                ->count();

            if ($activationsCount >= config('settings.maxAttempts')) {
                Log::info('Exceded max resends in last '.config('settings.timePeriod').' hours. '.$currentRoute.'. ', [$user]);

                $data = [
                    'email' => $user->email,

Accessing email on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

                    'hours' => config('settings.timePeriod'),
                ];

                return view('auth.exceeded')->with($data);
            }

            $sendEmail = $this->initiateEmailActivation($user);

It seems like $user can also be of type null; however, parameter $user of App\Http\Controllers\Auth\ActivateController::initiateEmailActivation() does only seem to accept App\Models\User, maybe add an additional type check?

The assignment to $sendEmail is dead and can be removed.

Are you sure the assignment to $sendEmail is correct as $this->initiateEmailActivation($user) targeting App\Http\Controllers\Auth\ActivateController::initiateEmailActivation() seems to always return null.

            Log::info('Activation resent to registered user. '.$currentRoute.'. ', [$user]);

            return redirect()->route(self::getActivationRoute())
                ->with('status', 'success')
                ->with('message', trans('auth.activationSent'));
        }

        Log::info('Activated user attempte to navigate to '.$currentRoute.'. ', [$user]);

        return $this->activeRedirect($user, $currentRoute)

It seems like $currentRoute can also be of type string; however, parameter $currentRoute of App\Http\Controllers\Auth\ActivateController::activeRedirect() does only seem to accept App\Http\Controllers\Auth\The, maybe add an additional type check?

            ->with('status', 'info')
            ->with('message', trans('auth.alreadyActivated'));
    }

    /**
     * Check if use is already activated.
     *
     * @return Redirect
     */
    public function exceeded()
    {
        $user = Auth::user();
        $currentRoute = Route::currentRouteName();
        $timePeriod = config('settings.timePeriod');
        $lastActivation = Activation::where('user_id', $user->id)->get()->last();

Accessing id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

        $activationsCount = Activation::where('user_id', $user->id)
            ->where('created_at', '>=', Carbon::now()->subHours($timePeriod))
            ->count();

        if ($activationsCount >= config('settings.maxAttempts')) {
            Log::info('Locked non-activated user attempted to visit '.$currentRoute.'. ', [$user]);

            $data = [
                'hours'    => config('settings.timePeriod'),
                'email'    => $user->email,

Accessing email on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

                'lastDate' => $lastActivation->created_at->format('m/d/Y'),
            ];

            return view('auth.exceeded')->with($data);
        }

        return redirect()->route(self::getActivationRoute());
    }
}