jeremykenedy / larablog

app/Services/PostFormFields.php

<?php

namespace App\Services;

use App\Models\Post;
use App\Models\Tag;
use Carbon\Carbon;

class PostFormFields
{
    /**
     * List of fields and default value for each field.
     *
     * @var array
     */
    protected $fieldList = [
        'title'             => '',
        'subtitle'          => '',
        'post_image'        => '',
        'content'           => '',
        'meta_description'  => '',
        'is_draft'          => '1',
        'author'            => '',
        'slug'              => '',
        'publish_date'      => '',
        'publish_time'      => '',
        'layout'            => 'blog.post',
        'tags'              => [],
    ];

    /**
     * Create a new job instance.
     *
     * @param int $id
     *
     * @return void
     */
    public function __construct($id = null)
    {
        $this->id = $id;

The property id does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

    }

    /**
     * Execute the job.
     *
     * @return void
     */
    public function handle()
    {
        $fields = $this->fieldList;

        if ($this->id) {

The expression $this->id of type integer|null is loosely compared to true; this is ambiguous if the integer can be 0. You might want to explicitly use !== null instead.

            $fields = $this->fieldsFromModel($this->id, $fields);
            $fields['publish_time'] = $fields['publish_date']->format('g:i A');
            $fields['publish_date'] = $fields['publish_date']->format('M-d-Y');
        } else {
            $when = Carbon::now()->addHour();
            $fields['publish_date'] = $when->format('M-j-Y');
            $fields['publish_time'] = $when->format('g:i A');
        }

        foreach ($fields as $fieldName => $fieldValue) {
            $fields[$fieldName] = old($fieldName, $fieldValue);
        }

        // Get the additional data for the form fields
        $postFormFieldData = $this->postFormFieldData();

        return array_merge(

The expression return array_merge($fields, array('allTags' => App\Models\Tag::pluck('tag')->all()), $postFormFieldData) returns the type array which is incompatible with the documented return type void.

            $fields,
            [
                'allTags' => Tag::pluck('tag')->all(),
            ],
            $postFormFieldData
        );
    }

    /**
     * Return the field values from the model.
     *
     * @param int   $id
     * @param array $fields
     *
     * @return array
     */
    protected function fieldsFromModel($id, array $fields)
    {
        $page = Post::findOrFail($id);

        $fieldNames = array_keys(array_except($fields, ['tags']));

The function array_except() has been deprecated: Arr::except() should be used directly instead. Will be removed in Laravel 6.0.

        $fields = [
            'id' => $id,
        ];
        foreach ($fieldNames as $field) {
            $fields[$field] = $page->{$field};
        }

        $fields['tags'] = $page->tags()->pluck('tag')->all();

        return $fields;
    }

    /**
     * Get the additonal post form fields data.
     *
     * @return array
     */
    protected function postFormFieldData()
    {
        $allAvailableAuthors = PostAuthors::all();
        $postTemplates = PostTemplates::list();

        return [
            'allAvailableAuthors'   => $allAvailableAuthors,
            'postTemplates'         => $postTemplates,
        ];
    }
}