App\Http\Controllers\BlogController

Complexity

Total Complexity

10

Size/Duplication

Total Lines	107
Duplicated Lines	0 %

Importance

Changes	3
Bugs	0	Features	0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	rss()	0	5	1
A	showPost()	0	26	4
A	author()	0	13	1
A	authors()	0	14	2
A	index()	0	9	2

<?php

namespace App\Http\Controllers;

use App\Models\Post;
use App\Models\Tag;
use App\Services\PostProcesses;
use Illuminate\Http\Request;

class BlogController extends Controller
{
    /**
     * Display a listing of the published blog posts.
     *
     * @return \Illuminate\Http\Response
     */
    public function index(Request $request)
    {
        $tag = $request->get('tag');
        $service = new PostProcesses($tag);
        $data = $service->getResponse();

        $layout = $tag ? Tag::layout($tag) : 'blog.roll-layouts.home';

        return view($layout, $data);

The expression return view($layout, $data) returns the type Illuminate\View\View which is incompatible with the documented return type Illuminate\Http\Response.

    }

    /**
     * Display the specified resource.
     *
     * @param string  $slug
     * @param Request $request
     *
     * @return \Illuminate\Http\Response
     */
    public function showPost(Request $request, $slug)
    {
        $user = \Auth::user();

        // Allow writers to view posts in draft mode and future dates
        if ($user && $user->level() > 2) {

The method level() does not exist on Illuminate\Contracts\Auth\Authenticatable. It seems like you code against a sub-type of Illuminate\Contracts\Auth\Authenticatable such as Illuminate\Foundation\Auth\User.

            $post = Post::with('tags')
                            ->bySlug($slug)
                            ->firstOrFail();
        } else {
            $post = Post::with('tags')
                            ->bySlug($slug)
                            ->publishedTimePast()
                            ->isNotDraft()
                            ->firstOrFail();
        }

        $tag = $request->get('tag');

        if ($tag) {
            $tag = Tag::whereTag($tag)->firstOrFail();
        }

        $data = compact('post', 'tag', 'slug');

        return view($post->layout, $data);

The expression return view($post->layout, $data) returns the type Illuminate\View\View which is incompatible with the documented return type Illuminate\Http\Response.

    }

    /**
     * Display a listing of the authors with published content.
     *
     * @return \Illuminate\Http\Response
     */
    public function authors(Request $request)

The parameter $request is not used and could be removed.

    {
        $authors = Post::activeAuthors()->get();

        if (!$authors) {

$authors is of type Illuminate\Database\Eloquent\Collection, thus it always evaluated to true.

            $authors = [];
        }

        $data = [
            'authors'   => $authors,
            'image'     => config('blog.authors_page_image'),
        ];

        return view('blog.pages.authors', $data);

The expression return view('blog.pages.authors', $data) returns the type Illuminate\View\View which is incompatible with the documented return type Illuminate\Http\Response.

    }

    /**
     * Display a listing of an authors published posts.
     *
     * @return \Illuminate\Http\Response
     */
    public function author(Request $request, $author)
    {
        $tag = $request->get('tag');
        $posts = Post::postsByAuthors($author)->get();

        $data = [
            'author'    => $author,
            'image'     => config('blog.author_page_image'),
            'posts'     => $posts,
            'tag'       => $tag,
        ];

        return view('blog.pages.author', $data);

The expression return view('blog.pages.author', $data) returns the type Illuminate\View\View which is incompatible with the documented return type Illuminate\Http\Response.

    }

    /**
     * Get the RSS feed.
     *
     * @param RssFeed $feed
     *
     * @return \Illuminate\Http\Response
     */
    public function rss(RssFeed $feed)

The type App\Http\Controllers\RssFeed was not found. Maybe you did not declare it correctly or list all dependencies?

    {
        $rss = $feed->getRSS();

        return response($rss)->header('Content-type', 'application/rss+xml');
    }
}