App\Http\Controllers\Admin\TagController

Complexity

Total Complexity

9

Size/Duplication

Total Lines	112
Duplicated Lines	0 %

Importance

Changes	2
Bugs	0	Features	0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	3	1
A	store()	0	11	2
A	destroy()	0	9	1
A	edit()	0	6	1
A	create()	0	5	1
A	index()	0	5	1
A	update()	0	13	2

<?php

namespace App\Http\Controllers\Admin;

use App\Http\Controllers\Controller;
use App\Http\Requests\DestroyTagRequest;
use App\Http\Requests\StoreTagRequest;
use App\Http\Requests\UpdateTagRequest;
use App\Models\Tag;
use App\Services\TagFormFields;
use Illuminate\Http\Request;

class TagController extends Controller
{
    /**
     * Create a new controller instance.
     *
     * @return void
     */
    public function __construct()
    {
        $this->middleware('auth');
    }

    /**
     * Display a listing of the resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function index()
    {
        $tags = Tag::all();

        return view('admin.tag.index')->withTags($tags);

The expression return view('admin.tag.index')->withTags($tags) returns the type Illuminate\View\View which is incompatible with the documented return type Illuminate\Http\Response.

    }

    /**
     * Show the form for creating a new resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function create()
    {
        $data = TagFormFields::formData();

        return view('admin.tag.create', $data);

The expression return view('admin.tag.create', $data) returns the type Illuminate\View\View which is incompatible with the documented return type Illuminate\Http\Response.

    }

    /**
     * Store a newly created resource in storage.
     *
     * @param \App\Http\Requests\StoreTagRequest $request
     *
     * @return \Illuminate\Http\Response
     */
    public function store(StoreTagRequest $request)
    {
        $tag = new Tag();
        $fields = TagFormFields::fields();
        foreach (array_keys($fields) as $field) {
            $tag->$field = $request->get($field);
        }
        $tag->save();

        return redirect('/admin/tags')

The expression return redirect('/admin/tags')->withSuccess(trans('messages.success.tag-created', array('tag' => $tag->tag))) also could return the type Illuminate\Http\RedirectResponse which is incompatible with the documented return type Illuminate\Http\Response.

                ->withSuccess(trans('messages.success.tag-created', ['tag' => $tag->tag]));
    }

    /**
     * Show the form for editing the specified resource.
     *
     * @param \Illuminate\Http\Request $request
     * @param int                      $id
     *
     * @return \Illuminate\Http\Response
     */
    public function edit(Request $request, $id)
    {
        $tag = Tag::findOrFail($id);
        $data = TagFormFields::formData($tag);

        return view('admin.tag.edit', $data);

The expression return view('admin.tag.edit', $data) returns the type Illuminate\View\View which is incompatible with the documented return type Illuminate\Http\Response.

    }

    /**
     * Update the specified resource in storage.
     *
     * @param \App\Http\Requests\UpdateTagRequest $request
     * @param int                                 $id
     *
     * @return \Illuminate\Http\Response
     */
    public function update(UpdateTagRequest $request, $id)
    {
        $tag = Tag::findOrFail($id);
        $fields = TagFormFields::fields();

        foreach (array_keys($fields) as $field) {
            $tag->$field = $request->get($field);
        }

        $tag->save();

        return redirect("/admin/tags/$id/edit")

The expression return redirect('/admin/tags/'.$id.'/edit')->withSuccess(trans('messages.success.tag-updated', array('tag' => $tag->tag))) also could return the type Illuminate\Http\RedirectResponse which is incompatible with the documented return type Illuminate\Http\Response.

                    ->withSuccess(trans('messages.success.tag-updated', ['tag' => $tag->tag]));
    }

    /**
     * Remove the specified resource from storage.
     *
     * @param \App\Http\Requests\DestroyTagRequest $request
     * @param int                                  $id
     *
     * @return \Illuminate\Http\Response
     */
    public function destroy(DestroyTagRequest $request, $id)

The parameter $request is not used and could be removed.

    {
        $tag = Tag::findOrFail($id);
        $tag->posts()->detach();
        $tag->delete();

        return redirect()

The expression return redirect()->route('showtags')->withSuccess(trans('messages.success.tag-deleted', array('tag' => $tag->tag))) also could return the type Illuminate\Http\RedirectResponse which is incompatible with the documented return type Illuminate\Http\Response.

            ->route('showtags')
            ->withSuccess(trans('messages.success.tag-deleted', ['tag' => $tag->tag]));
    }
}