App\Http\Controllers\Admin\PostController

Complexity

Total Complexity

7

Size/Duplication

Total Lines	111
Duplicated Lines	0 %

Importance

Changes	2
Bugs	0	Features	0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	3	1
A	edit()	0	6	1
A	create()	0	6	1
A	store()	0	7	1
A	update()	0	10	1
A	index()	0	11	1
A	destroy()	0	9	1

<?php

namespace App\Http\Controllers\Admin;

use App\Http\Controllers\Controller;
use App\Http\Requests\DestroyPostRequest;
use App\Http\Requests\StorePostRequest;
use App\Http\Requests\UpdatePostRequest;
use App\Models\Post;
use App\Services\PostFormFields;
use Illuminate\Http\Request;

class PostController extends Controller
{
    /**
     * Create a new controller instance.
     *
     * @return void
     */
    public function __construct()
    {
        $this->middleware('auth');
    }

    /**
     * Display a listing of the resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function index(Request $request)

The parameter $request is not used and could be removed.

    {
        $posts = Post::with('tags')
            ->orderBy('id', 'desc')
            ->paginate(config('admin.posts_per_page'));

        $data = [
            'posts' => $posts,
        ];

        return view('admin.post.index')->with($data);

The expression return view('admin.post.index')->with($data) returns the type Illuminate\View\View which is incompatible with the documented return type Illuminate\Http\Response.

    }

    /**
     * Show the form for creating a new resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function create()
    {
        $service = new PostFormFields();
        $data = $service->handle();

Are you sure the assignment to $data is correct as $service->handle() targeting App\Services\PostFormFields::handle() seems to always return null.

        return view('admin.post.create', $data);

The expression return view('admin.post.create', $data) returns the type Illuminate\View\View which is incompatible with the documented return type Illuminate\Http\Response.

$data of type void is incompatible with the type Illuminate\Contracts\Support\Arrayable|array expected by parameter $data of view().

    }

    /**
     * Store a newly created post in storage.
     *
     * @param \App\Http\Requests\StorePostRequest $request
     *
     * @return \Illuminate\Http\Response
     */
    public function store(StorePostRequest $request)
    {
        $post = Post::create($request->postFillData());
        $post->syncTags($request->get('tags', []));

        return redirect()->route('editpost', [$post])

The expression return redirect()->route('editpost', array($post))->withSuccess(trans('messages.success.post-created')) also could return the type Illuminate\Http\RedirectResponse which is incompatible with the documented return type Illuminate\Http\Response.

                            ->withSuccess(trans('messages.success.post-created'));
    }

    /**
     * Show the form for editing the specified post.
     *
     * @param int $id
     *
     * @return \Illuminate\Http\Response
     */
    public function edit(Request $request, $id)
    {
        $service = new PostFormFields($id);
        $data = $service->handle();

Are you sure the assignment to $data is correct as $service->handle() targeting App\Services\PostFormFields::handle() seems to always return null.

        return view('admin.post.edit')->with($data);

$data of type void is incompatible with the type array|string expected by parameter $key of Illuminate\View\View::with().

The expression return view('admin.post.edit')->with($data) returns the type Illuminate\View\View which is incompatible with the documented return type Illuminate\Http\Response.

    }

    /**
     * Update the specified resource in storage.
     *
     * @param \App\Http\Requests\UpdatePostRequest $request
     * @param int                                  $id
     *
     * @return \Illuminate\Http\Response
     */
    public function update(UpdatePostRequest $request, $id)
    {
        $post = Post::findOrFail($id);
        $post->fill($request->postFillData());
        $post->save();
        $post->syncTags($request->get('tags', []));

        return redirect()

The expression return redirect()->back()->withSuccess(trans('messages.success.post-updated')) also could return the type Illuminate\Http\RedirectResponse which is incompatible with the documented return type Illuminate\Http\Response.

            ->back()
            ->withSuccess(trans('messages.success.post-updated'));
    }

    /**
     * Remove the specified resource from storage.
     *
     * @param \App\Http\Requests\DestroyPostRequest $request
     * @param int                                   $id
     *
     * @return \Illuminate\Http\Response
     */
    public function destroy(DestroyPostRequest $request, $id)

The parameter $request is not used and could be removed.

    {
        $post = Post::findOrFail($id);
        $post->tags()->detach();
        $post->delete();

        return redirect()

The expression return redirect()->route('admin.posts')->withSuccess(trans('messages.success.post-deleted')) also could return the type Illuminate\Http\RedirectResponse which is incompatible with the documented return type Illuminate\Http\Response.

            ->route('admin.posts')
            ->withSuccess(trans('messages.success.post-deleted'));
    }
}