Passed
Push — develop ( 278ae4...27fb2a )
by Jens
02:34
created
cloudcontrol/templates/cms/documents/brick.php 1 patch
Braces   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -9,8 +9,10 @@
 block discarded – undo
9 9
 				<? if (isset($dynamicBrick)) :
10 10
 					$fieldSlug = $field->slug;
11 11
 					$value = isset($dynamicBrick->fields->$fieldSlug) ? current($dynamicBrick->fields->$fieldSlug) : '';
12
-				else :
12
+				else {
13
+					:
13 14
 					$value = '';
15
+				}
14 16
 				endif ?>
15 17
 				<? if ($field->multiple == true && $field->type != 'Rich Text') : ?>
16 18
 				<ul class="grid-wrapper sortable">
Please login to merge, or discard this patch.
cloudcontrol/library/images/methods/Watermark.php 1 patch
Braces   +9 added lines, -3 removed lines patch added patch discarded remove patch
@@ -61,7 +61,9 @@  discard block
 block discarded – undo
61 61
 		 */
62 62
 		protected function calculateX($imageResource)
63 63
 		{
64
-			if (intval($this->_x) === $this->_x) return $this->_x;
64
+			if (intval($this->_x) === $this->_x) {
65
+				return $this->_x;
66
+			}
65 67
 			
66 68
 			$x = strtolower($this->_x);
67 69
 			
@@ -86,7 +88,9 @@  discard block
 block discarded – undo
86 88
 		 */
87 89
 		public function calculateY($imageResource)
88 90
 		{
89
-			if (intval($this->_y) === $this->_y) return $this->_y;
91
+			if (intval($this->_y) === $this->_y) {
92
+				return $this->_y;
93
+			}
90 94
 		
91 95
 			$y = strtolower($this->_y);
92 96
 			
@@ -123,7 +127,9 @@  discard block
 block discarded – undo
123 127
 		 */
124 128
 		public function GetWatermark()
125 129
 		{
126
-			if ($this->_watermark == null) throw new \Exception('A watermark is not set. Please supply a \library\image\Image using $this->SetWatermark');
130
+			if ($this->_watermark == null) {
131
+				throw new \Exception('A watermark is not set. Please supply a \library\image\Image using $this->SetWatermark');
132
+			}
127 133
 			return $this->_watermark;
128 134
 		}
129 135
 		
Please login to merge, or discard this patch.
cloudcontrol/library/images/methods/BoxCrop.php 1 patch
Braces   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -26,7 +26,9 @@
 block discarded – undo
26 26
 			
27 27
 			// Define which ratio will be used, depending on which is the smallest side
28 28
 			$ratio = min($hRatio, $wRatio);
29
-			if($ratio > 1) $ratio = 1;
29
+			if($ratio > 1) {
30
+				$ratio = 1;
31
+			}
30 32
 			
31 33
 			// Define sizes
32 34
 			$this->_destWidth = floor($originalWidth * $ratio);
Please login to merge, or discard this patch.
cloudcontrol/library/images/methods/SmartCrop.php 1 patch
Braces   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -40,7 +40,9 @@
 block discarded – undo
40 40
 			
41 41
 			// Define which ratio will be used, depending on which is the biggest side
42 42
 			$ratio = $wRatio < $hRatio ? $wRatio : $hRatio;
43
-			if ($ratio < 1) $ratio = 1;
43
+			if ($ratio < 1) {
44
+				$ratio = 1;
45
+			}
44 46
 			
45 47
 			// Calculate the destination width, height, x and y
46 48
 			$this->_destWidth = $originalWidth / $ratio;
Please login to merge, or discard this patch.
cloudcontrol/library/components/LanguageComponent.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -105,7 +105,7 @@
 block discarded – undo
105 105
     /**
106 106
      * Detect if the language is switched manually
107 107
      *
108
-     * @param $request
108
+     * @param Request $request
109 109
      */
110 110
     private function checkLanguageSwitch($request)
111 111
     {
Please login to merge, or discard this patch.
cloudcontrol/library/cc/cc.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -116,7 +116,7 @@
 block discarded – undo
116 116
  * @param array  $replace
117 117
  * @param string $delimiter
118 118
  *
119
- * @return mixed|string
119
+ * @return string
120 120
  */
121 121
 function slugify($str, $replace=array(), $delimiter='-') {
122 122
 	if( !empty($replace) ) {
Please login to merge, or discard this patch.
Braces   +9 added lines, -6 removed lines patch added patch discarded remove patch
@@ -74,12 +74,15 @@
 block discarded – undo
74 74
  * @return string
75 75
  */
76 76
 function humanFileSize($size,$unit="") {
77
-	if( (!$unit && $size >= 1<<30) || $unit == "GB")
78
-		return number_format($size/(1<<30),2)."GB";
79
-	if( (!$unit && $size >= 1<<20) || $unit == "MB")
80
-		return number_format($size/(1<<20),2)."MB";
81
-	if( (!$unit && $size >= 1<<10) || $unit == "KB")
82
-		return number_format($size/(1<<10),2)."KB";
77
+	if( (!$unit && $size >= 1<<30) || $unit == "GB") {
78
+			return number_format($size/(1<<30),2)."GB";
79
+	}
80
+	if( (!$unit && $size >= 1<<20) || $unit == "MB") {
81
+			return number_format($size/(1<<20),2)."MB";
82
+	}
83
+	if( (!$unit && $size >= 1<<10) || $unit == "KB") {
84
+			return number_format($size/(1<<10),2)."KB";
85
+	}
83 86
 	return number_format($size)." bytes";
84 87
 }
85 88
 
Please login to merge, or discard this patch.
cloudcontrol/library/cc/errorhandler.php 2 patches
Doc Comments   +5 added lines patch added patch discarded remove patch
@@ -149,6 +149,11 @@
 block discarded – undo
149 149
     }
150 150
 }
151 151
 
152
+/**
153
+ * @param string $message
154
+ * @param string $file
155
+ * @param integer $code
156
+ */
152 157
 function renderCliException($message, $file, $line, $code, $trace, $lines)
153 158
 {
154 159
     echo PHP_EOL;
Please login to merge, or discard this patch.
Braces   +4 added lines, -2 removed lines patch added patch discarded remove patch
@@ -33,7 +33,7 @@  discard block
 block discarded – undo
33 33
 	$error = error_get_last(); 
34 34
     if (isset($error['type'], $error['message'], $error['file'], $error['line'])) { 
35 35
         errorHandler($error['type'],$error['message'],$error['file'],$error['line']);
36
-    }elseif ($error['type'] == 1) {
36
+    } elseif ($error['type'] == 1) {
37 37
         dump($error);
38 38
     }
39 39
 }
@@ -85,7 +85,9 @@  discard block
 block discarded – undo
85 85
  * @param string $httpHeader
86 86
  */
87 87
 function renderError ($message='', $file='', $line='', $code=0, $trace=array(), $httpHeader = 'HTTP/1.0 500 Internal Server Error') {
88
-    if (ob_get_contents()) ob_end_clean();
88
+    if (ob_get_contents()) {
89
+    	ob_end_clean();
90
+    }
89 91
 
90 92
     if (canShowError()) {
91 93
         $file_lines = file_exists($file) ? file($file) : array();
Please login to merge, or discard this patch.
cloudcontrol/templates/cms/documents/document-form-form.php 1 patch
Braces   +16 added lines, -6 removed lines patch added patch discarded remove patch
@@ -1,7 +1,8 @@  discard block
 block discarded – undo
1 1
 <form method="<?= isset($documentType) ? 'post' : 'get' ?>" onsubmit="return processRtes();" action="<?=isset($formId) ? '#' . $formId : '' ?>">
2 2
     <? if (!isset($hideTitleAndState)) : ?>
3 3
     <input type="hidden" name="path" value="<?=$request::$get['path']?>" />
4
-    <? else : ?>
4
+    <? else {
5
+	: ?>
5 6
     <input type="hidden" name="formId" value="<?=$formId?>" />
6 7
     <a name="<?=$formId?>"></a>
7 8
     <? endif ?>
@@ -20,15 +21,19 @@  discard block
 block discarded – undo
20 21
                     <input<?=isset($document) && $document->state == 'published' ? ' checked="checked"' : '' ?> type="checkbox" id="state" name="state" placeholder="State" />
21 22
                 </div>
22 23
 			<? endif ?>
23
-			<?$fieldPrefix='fields';?>
24
+			<?$fieldPrefix='fields';
25
+}
26
+?>
24 27
 			<? foreach ($documentType->fields as $field) : ?>
25 28
 				<div class="form-element">
26 29
 					<label for="<?=$field->slug?>"><?=$field->title?></label>
27 30
 					<? if (isset($document)) :
28 31
 						$fieldSlug = $field->slug;
29 32
 						$value = isset($document->fields->$fieldSlug) ? current($document->fields->$fieldSlug) : '';
30
-					else :
33
+					else {
34
+						:
31 35
 						$value = '';
36
+					}
32 37
 					endif ?>
33 38
 					<? if ($field->multiple == true && $field->type != 'Rich Text') : ?>
34 39
 					<ul class="grid-wrapper sortable">
@@ -138,8 +143,11 @@  discard block
 block discarded – undo
138 143
 					</ul>
139 144
 					<a class="btn" onclick="addDynamicBrick(this, 'true', 'newBrickDropzone_<?=$static_brick_nr?>');">+</a>
140 145
 					<?$static_brick_nr += 1?>
141
-				<? else : ?>
142
-					<?$fieldPrefix='bricks[' . $brick->slug . '][fields]';?>
146
+				<? else {
147
+	: ?>
148
+					<?$fieldPrefix='bricks[' . $brick->slug . '][fields]';
149
+}
150
+?>
143 151
 					<input type="hidden" name="bricks[<?=$brick->slug?>][type]" value="<?=$brick->brickSlug?>" />
144 152
 					<? foreach ($brick->structure->fields as $field) : ?>
145 153
 						<div class="form-element">
@@ -148,8 +156,10 @@  discard block
 block discarded – undo
148 156
 							$brickSlug = $brick->slug;
149 157
 							$fieldSlug = $field->slug;
150 158
 							$value = isset($document->bricks->$brickSlug->fields->$fieldSlug) ? current($document->bricks->$brickSlug->fields->$fieldSlug) : '';
151
-						else :
159
+						else {
160
+							:
152 161
 							$value = '';
162
+						}
153 163
 						endif ?>
154 164
 						<? if ($field->multiple == true && $field->type != 'Rich Text') : ?>
155 165
 						<ul class="grid-wrapper sortable">
Please login to merge, or discard this patch.
cloudcontrol/library/components/FormComponent.php 1 patch
Doc Comments   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -111,7 +111,7 @@  discard block
 block discarded – undo
111 111
 	/**
112 112
 	 * Sets variables needed for rendering the form template
113 113
 	 *
114
-	 * @param $storage
114
+	 * @param Storage $storage
115 115
 	 */
116 116
 	private function initialize($storage)
117 117
 	{
@@ -147,7 +147,7 @@  discard block
 block discarded – undo
147 147
 	 * submitting the form
148 148
 	 *
149 149
 	 * @param $postValues
150
-	 * @param $storage
150
+	 * @param Storage $storage
151 151
 	 */
152 152
 	protected function postSubmit($postValues, $storage)
153 153
 	{
@@ -171,7 +171,7 @@  discard block
 block discarded – undo
171 171
 	/**
172 172
 	 * Checks if this form has been submitted
173 173
 	 *
174
-	 * @param $request
174
+	 * @param \library\cc\Request $request
175 175
 	 *
176 176
 	 * @return bool
177 177
 	 */
@@ -183,7 +183,7 @@  discard block
 block discarded – undo
183 183
 	/**
184 184
 	 *
185 185
 	 *
186
-	 * @param $request
186
+	 * @param \library\cc\Request $request
187 187
 	 */
188 188
 	private function getPostValues($request)
189 189
 	{
@@ -308,7 +308,7 @@  discard block
 block discarded – undo
308 308
 
309 309
 	/**
310 310
 	 * @param $get
311
-	 * @param $request
311
+	 * @param \library\cc\Request $request
312 312
 	 */
313 313
 	private function resetPathBackup($get, $request)
314 314
 	{
@@ -320,7 +320,7 @@  discard block
 block discarded – undo
320 320
 	}
321 321
 
322 322
 	/**
323
-	 * @param $form
323
+	 * @param string|null $form
324 324
 	 */
325 325
 	private function setFormParameter($form)
326 326
 	{
Please login to merge, or discard this patch.