View GitHub Repository cloudcontrol

Schedule Inspection
Subscribe
Passed
Push — develop ( b61b19...76c0b8 )
by Jens
02:35
created
Status
Category
Toggle Patches
src/components/CmsComponent.php 1 patch
Doc Comments   +7 added lines, -4 removed lines patch added patch discarded remove patch 
@@ -195,7 +195,7 @@  discard block
 
 block discarded – undo
195 195 
         }
196 196
197 197 
         /**
198 
-         * @param $request
198 
+         * @param \CloudControl\Cms\cc\Request $request
199 199 
          *
200 200 
          * @return mixed|string
201 201 
          */
 
@@ -228,6 +228,9 @@  discard block
 
 block discarded – undo
228 228 
             }
229 229 
         }
230 230
231 
+        /**
232 
+         * @param \CloudControl\Cms\cc\Request $request
233 
+         */
231 234 
         private function logOffRouting($request, $relativeCmsUri)
232 235 
         {
233 236 
             if ($relativeCmsUri == '/log-off') {
 
@@ -327,7 +330,7 @@  discard block
 
 block discarded – undo
327 330 
         }
328 331
329 332 
         /**
330 
-         * @param $crypt
333 
+         * @param Crypt $crypt
331 334 
          * @param $request
332 335 
          */
333 336 
         protected function invalidCredentials($crypt, $request)
 
@@ -339,7 +342,7 @@  discard block
 
 block discarded – undo
339 342
340 343 
         /**
341 344 
          * @param $user
342 
-         * @param $crypt
345 
+         * @param Crypt $crypt
343 346 
          * @param $request
344 347 
          */
345 348 
         protected function checkPassword($user, $crypt, $request)
 
@@ -359,7 +362,7 @@  discard block
 
 block discarded – undo
359 362 
         }
360 363
361 364 
         /**
362 
-         * @param $request
365 
+         * @param \CloudControl\Cms\cc\Request $request
363 366 
          */
364 367 
         protected function checkLoginAttempt($request)
365 368 
         {
Please login to merge, or discard this patch.
src/templates/documents.php 1 patch
Braces   +5 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -20,7 +20,8 @@  discard block
 
 block discarded – undo
20 20 
               <a href="<?= $request::$subfolders ?><?= $cmsPrefix ?>/search/update-index?returnUrl=<?=urlencode($request::$subfolders . $cmsPrefix . '/documents')?>" title="Update Index">Update Index</a>
21 21 
             <? endif ?>
22 22 
         </div>
23 
-      <? else : ?>
23 
+      <? else {
24 
+    : ?>
24 25 
         <div class="message valid">
25 26 
           <i class="fa fa-check"></i> Search index is in sync with documents.
26 27 
         </div>
 
@@ -52,7 +53,9 @@  discard block
 
 block discarded – undo
52 53 
           <? foreach ($documents as $document) : ?>
53 54 
             <li class="grid-container">
54 55 
                 <? if ($document->type == 'document') : ?>
55 
-                    <? renderDocument($document, $cmsPrefix, '', $request); ?>
56 
+                    <? renderDocument($document, $cmsPrefix, '', $request);
57 
+}
58 
+?>
56 59 
                 <? elseif ($document->type == 'folder') : ?>
57 60 
                     <? renderFolder($document, $cmsPrefix, '', true, $request); ?>
58 61 
                 <? endif ?>
Please login to merge, or discard this patch.
src/components/cms/configuration/BricksRouting.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch 
@@ -45,7 +45,7 @@  discard block
 
 block discarded – undo
45 45 
     }
46 46
47 47 
     /**
48 
-     * @param $request
48 
+     * @param Request $request
49 49 
      * @param CmsComponent $cmsComponent
50 50 
      */
51 51 
     private function newRoute($request, $cmsComponent)
 
@@ -60,7 +60,7 @@  discard block
 
 block discarded – undo
60 60 
     }
61 61
62 62 
     /**
63 
-     * @param $request
63 
+     * @param Request $request
64 64 
      * @param CmsComponent $cmsComponent
65 65 
      */
66 66 
     private function editRoute($request, $cmsComponent)
 
@@ -78,7 +78,7 @@  discard block
 
 block discarded – undo
78 78 
     }
79 79
80 80 
     /**
81 
-     * @param $request
81 
+     * @param Request $request
82 82 
      * @param CmsComponent $cmsComponent
83 83 
      */
84 84 
     private function deleteRoute($request, $cmsComponent)
Please login to merge, or discard this patch.
src/components/cms/configuration/DocumentTypeRouting.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch 
@@ -45,7 +45,7 @@  discard block
 
 block discarded – undo
45 45 
     }
46 46
47 47 
     /**
48 
-     * @param $request
48 
+     * @param Request $request
49 49 
      * @param CmsComponent $cmsComponent
50 50 
      */
51 51 
     private function newRoute($request, $cmsComponent)
 
@@ -60,7 +60,7 @@  discard block
 
 block discarded – undo
60 60 
     }
61 61
62 62 
     /**
63 
-     * @param $request
63 
+     * @param Request $request
64 64 
      * @param CmsComponent $cmsComponent
65 65 
      */
66 66 
     private function editRoute($request, $cmsComponent)
 
@@ -78,7 +78,7 @@  discard block
 
 block discarded – undo
78 78 
     }
79 79
80 80 
     /**
81 
-     * @param $request
81 
+     * @param Request $request
82 82 
      * @param CmsComponent $cmsComponent
83 83 
      */
84 84 
     private function deleteRoute($request, $cmsComponent)
Please login to merge, or discard this patch.
src/components/cms/document/FolderRouting.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch 
@@ -32,7 +32,7 @@  discard block
 
 block discarded – undo
32 32 
         }
33 33
34 34 
         /**
35 
-         * @param $request
35 
+         * @param Request $request
36 36 
          * @param CmsComponent $cmsComponent
37 37 
          */
38 38 
         private function newFolderRoute($request, $cmsComponent)
 
@@ -48,7 +48,7 @@  discard block
 
 block discarded – undo
48 48 
         }
49 49
50 50 
         /**
51 
-         * @param $request
51 
+         * @param Request $request
52 52 
          * @param CmsComponent $cmsComponent
53 53 
          */
54 54 
         private function editFolderRoute($request, $cmsComponent)
 
@@ -75,7 +75,7 @@  discard block
 
 block discarded – undo
75 75 
         }
76 76
77 77 
         /**
78 
-         * @param $request
78 
+         * @param Request $request
79 79 
          * @param CmsComponent $cmsComponent
80 80 
          */
81 81 
         private function deleteFolderRoute($request, $cmsComponent)
Please login to merge, or discard this patch.
src/components/cms/document/ValuelistRouting.php 1 patch
Doc Comments   +12 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -33,6 +33,9 @@  discard block
 
 block discarded – undo
33 33 
         }
34 34 
     }
35 35
36 
+    /**
37 
+     * @param CmsComponent $cmsComponent
38 
+     */
36 39 
     private function valuelistsRoute($cmsComponent)
37 40 
     {
38 41 
         $cmsComponent->subTemplate = 'documents/valuelists';
 
@@ -41,7 +44,7 @@  discard block
 
 block discarded – undo
41 44 
     }
42 45
43 46 
     /**
44 
-     * @param $request
47 
+     * @param Request $request
45 48 
      * @param CmsComponent $cmsComponent
46 49 
      */
47 50 
     private function newValuelistRoute($request, $cmsComponent)
 
@@ -57,6 +60,10 @@  discard block
 
 block discarded – undo
57 60 
         }
58 61 
     }
59 62
63 
+    /**
64 
+     * @param Request $request
65 
+     * @param CmsComponent $cmsComponent
66 
+     */
60 67 
     private function editValuelistRoute($request, $cmsComponent)
61 68 
     {
62 69 
         $cmsComponent->subTemplate = 'documents/valuelist-form';
 
@@ -74,6 +81,10 @@  discard block
 
 block discarded – undo
74 81 
         $cmsComponent->setParameter(CmsComponent::PARAMETER_VALUELIST, $folder);
75 82 
     }
76 83
84 
+    /**
85 
+     * @param Request $request
86 
+     * @param CmsComponent $cmsComponent
87 
+     */
77 88 
     private function deleteValuelistRoute($request, $cmsComponent)
78 89 
     {
79 90 
         $cmsComponent->storage->getValuelists()->deleteValuelistBySlug($request::$get[CmsComponent::GET_PARAMETER_SLUG]);
Please login to merge, or discard this patch.
src/components/cms/DocumentRouting.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -35,8 +35,8 @@
 
 block discarded – undo
35 35
36 36
37 37 
     /**
38 
-     * @param $request
39 
-     * @param $relativeCmsUri
38 
+     * @param Request $request
39 
+     * @param string $relativeCmsUri
40 40 
      * @param CmsComponent $cmsComponent
41 41 
      * @throws \Exception
42 42 
      */
Please login to merge, or discard this patch.
src/components/cms/ImagesRouting.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch 
@@ -56,7 +56,7 @@  discard block
 
 block discarded – undo
56 56 
     }
57 57
58 58 
     /**
59 
-     * @param $request
59 
+     * @param Request $request
60 60 
      * @param CmsComponent $cmsComponent
61 61 
      */
62 62 
     private function newRoute($request, $cmsComponent)
 
@@ -71,7 +71,7 @@  discard block
 
 block discarded – undo
71 71 
     }
72 72
73 73 
     /**
74 
-     * @param $request
74 
+     * @param Request $request
75 75 
      * @param CmsComponent $cmsComponent
76 76 
      */
77 77 
     private function deleteRoute($request, $cmsComponent)
 
@@ -82,7 +82,7 @@  discard block
 
 block discarded – undo
82 82 
     }
83 83
84 84 
     /**
85 
-     * @param $request
85 
+     * @param Request $request
86 86 
      * @param CmsComponent $cmsComponent
87 87 
      */
88 88 
     private function showRoute($request, $cmsComponent)
Please login to merge, or discard this patch.
src/components/cms/SitemapRouting.php 1 patch
Doc Comments   +8 added lines, -4 removed lines patch added patch discarded remove patch 
@@ -37,7 +37,7 @@  discard block
 
 block discarded – undo
37 37 
     }
38 38
39 39 
     /**
40 
-     * @param $request
40 
+     * @param Request $request
41 41 
      * @param CmsComponent $cmsComponent
42 42 
      */
43 43 
     private function overviewRoute($request, $cmsComponent)
 
@@ -51,7 +51,7 @@  discard block
 
 block discarded – undo
51 51 
     }
52 52
53 53 
     /**
54 
-     * @param $request
54 
+     * @param Request $request
55 55 
      * @param CmsComponent $cmsComponent
56 56 
      */
57 57 
     private function newRoute($request, $cmsComponent)
 
@@ -66,7 +66,7 @@  discard block
 
 block discarded – undo
66 66 
     }
67 67
68 68 
     /**
69 
-     * @param $request
69 
+     * @param Request $request
70 70 
      * @param CmsComponent $cmsComponent
71 71 
      */
72 72 
     private function editRoute($request, $cmsComponent)
 
@@ -83,7 +83,7 @@  discard block
 
 block discarded – undo
83 83 
     }
84 84
85 85 
     /**
86 
-     * @param $request
86 
+     * @param Request $request
87 87 
      * @param CmsComponent $cmsComponent
88 88 
      */
89 89 
     private function deleteRoute($request, $cmsComponent)
 
@@ -93,6 +93,10 @@  discard block
 
 block discarded – undo
93 93 
         exit;
94 94 
     }
95 95
96 
+    /**
97 
+     * @param Request $request
98 
+     * @param CmsComponent $cmsComponent
99 
+     */
96 100 
     private function redirectRoutes($relativeCmsUri, $request, $cmsComponent)
97 101 
     {
98 102 
         if ($relativeCmsUri == '/sitemap/redirects') {
Please login to merge, or discard this patch.