UsersRouting - Code Metrics - Inspection of "Minor tweak in composer file" - jenskooij/cloudcontrol - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 9c6499...c22bc5 )

by Jens

created 2017-08-23 14:50 UTC

UsersRouting A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	75
Duplicated Lines	100 %

Coupling/Cohesion

Components	0
Dependencies	4

Importance

Changes

Metric	Value
dl	75
loc	75
rs	10
c	0
b	0
f	0
wmc	13
lcom	0
cbo	4

5 Methods

Rating	Name	Duplication	Size	Complexity
B	__construct()	12	12	7
A	overviewRoute()	6	6	1
A	newRoute()	10	10	2
A	deleteRoute()	6	6	1
A	editRoute()	11	11	2

How to fix Duplicated Code

<?php
/**
 * Created by IntelliJ IDEA.
 * User: jensk
 * Date: 30-1-2017
 * Time: 13:08
 */

namespace CloudControl\Cms\components\cms\configuration;


use CloudControl\Cms\cc\Request;
use CloudControl\Cms\components\cms\CmsRouting;
use CloudControl\Cms\components\CmsComponent;

class UsersRouting implements CmsRouting

{

	/**
	 * CmsRouting constructor.
	 *
	 * @param Request      $request
	 * @param string       $relativeCmsUri
	 * @param CmsComponent $cmsComponent
	 */
	public function __construct($request, $relativeCmsUri, $cmsComponent)
	{
		if ($relativeCmsUri == '/configuration/users') {
			$this->overviewRoute($cmsComponent);
		} elseif ($relativeCmsUri == '/configuration/users/new') {
			$this->newRoute($request, $cmsComponent);
		} elseif ($relativeCmsUri == '/configuration/users/delete' && isset($request::$get[CmsComponent::GET_PARAMETER_SLUG])) {
			$this->deleteRoute($request, $cmsComponent);
		} elseif ($relativeCmsUri == '/configuration/users/edit' && isset($request::$get[CmsComponent::GET_PARAMETER_SLUG])) {
			$this->editRoute($request, $cmsComponent);
		}
	}

	/**
	 * @param CmsComponent $cmsComponent
	 */
	private function overviewRoute($cmsComponent)
	{
		$cmsComponent->subTemplate = 'configuration/users';
		$cmsComponent->setParameter(CmsComponent::PARAMETER_MAIN_NAV_CLASS, CmsComponent::PARAMETER_CONFIGURATION);
		$cmsComponent->setParameter(CmsComponent::PARAMETER_USERS, $cmsComponent->storage->getUsers()->getUsers());
	}

	/**
	 * @param $request
	 * @param CmsComponent $cmsComponent
	 */
	private function newRoute($request, $cmsComponent)
	{
		$cmsComponent->subTemplate = 'configuration/users-form';
		$cmsComponent->setParameter(CmsComponent::PARAMETER_MAIN_NAV_CLASS, CmsComponent::PARAMETER_CONFIGURATION);
		if (isset($request::$post[CmsComponent::POST_PARAMETER_USERNAME])) {
			$cmsComponent->storage->getUsers()->addUser($request::$post);
			header('Location: ' . $request::$subfolders . $cmsComponent->getParameter(CmsComponent::PARAMETER_CMS_PREFIX) . '/configuration/users');
			exit;
		}
	}

	/**
	 * @param $request
	 * @param CmsComponent $cmsComponent
	 */
	private function deleteRoute($request, $cmsComponent)
	{
		$cmsComponent->storage->getUsers()->deleteUserBySlug($request::$get[CmsComponent::GET_PARAMETER_SLUG]);
		header('Location: ' . $request::$subfolders . $cmsComponent->getParameter(CmsComponent::PARAMETER_CMS_PREFIX) . '/configuration/users');
		exit;
	}

	/**
	 * @param $request
	 * @param CmsComponent $cmsComponent
	 */
	private function editRoute($request, $cmsComponent)
	{
		$cmsComponent->subTemplate = 'configuration/users-form';
		$cmsComponent->setParameter(CmsComponent::PARAMETER_MAIN_NAV_CLASS, CmsComponent::PARAMETER_CONFIGURATION);
		$cmsComponent->setParameter(CmsComponent::PARAMETER_USER, $cmsComponent->storage->getUsers()->getUserBySlug($request::$get[CmsComponent::GET_PARAMETER_SLUG]));
		if (isset($_POST[CmsComponent::POST_PARAMETER_USERNAME])) {
			$cmsComponent->storage->getUsers()->saveUser($request::$get[CmsComponent::GET_PARAMETER_SLUG], $request::$post);
			header('Location: ' . $request::$subfolders . $cmsComponent->getParameter(CmsComponent::PARAMETER_CMS_PREFIX) . '/configuration/users');
			exit;
		}
	}
}

1		<?php
2		/**
3		* Created by IntelliJ IDEA.
4		* User: jensk
5		* Date: 30-1-2017
6		* Time: 13:08
7		*/
8
9		namespace CloudControl\Cms\components\cms\configuration;
10
11
12		use CloudControl\Cms\cc\Request;
13		use CloudControl\Cms\components\cms\CmsRouting;
14		use CloudControl\Cms\components\CmsComponent;
15
16	View Code Duplication	class UsersRouting implements CmsRouting
		0 ignored issues – show Duplication introduced 2017-01-30 13:00 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
17		{
18
19		/**
20		* CmsRouting constructor.
21		*
22		* @param Request $request
23		* @param string $relativeCmsUri
24		* @param CmsComponent $cmsComponent
25		*/
26		public function __construct($request, $relativeCmsUri, $cmsComponent)
27		{
28		if ($relativeCmsUri == '/configuration/users') {
29		$this->overviewRoute($cmsComponent);
30		} elseif ($relativeCmsUri == '/configuration/users/new') {
31		$this->newRoute($request, $cmsComponent);
32		} elseif ($relativeCmsUri == '/configuration/users/delete' && isset($request::$get[CmsComponent::GET_PARAMETER_SLUG])) {
33		$this->deleteRoute($request, $cmsComponent);
34		} elseif ($relativeCmsUri == '/configuration/users/edit' && isset($request::$get[CmsComponent::GET_PARAMETER_SLUG])) {
35		$this->editRoute($request, $cmsComponent);
36		}
37		}
38
39		/**
40		* @param CmsComponent $cmsComponent
41		*/
42		private function overviewRoute($cmsComponent)
43		{
44		$cmsComponent->subTemplate = 'configuration/users';
45		$cmsComponent->setParameter(CmsComponent::PARAMETER_MAIN_NAV_CLASS, CmsComponent::PARAMETER_CONFIGURATION);
46		$cmsComponent->setParameter(CmsComponent::PARAMETER_USERS, $cmsComponent->storage->getUsers()->getUsers());
47		}
48
49		/**
50		* @param $request
51		* @param CmsComponent $cmsComponent
52		*/
53		private function newRoute($request, $cmsComponent)
54		{
55		$cmsComponent->subTemplate = 'configuration/users-form';
56		$cmsComponent->setParameter(CmsComponent::PARAMETER_MAIN_NAV_CLASS, CmsComponent::PARAMETER_CONFIGURATION);
57		if (isset($request::$post[CmsComponent::POST_PARAMETER_USERNAME])) {
58		$cmsComponent->storage->getUsers()->addUser($request::$post);
59		header('Location: ' . $request::$subfolders . $cmsComponent->getParameter(CmsComponent::PARAMETER_CMS_PREFIX) . '/configuration/users');
60		exit;
61		}
62		}
63
64		/**
65		* @param $request
66		* @param CmsComponent $cmsComponent
67		*/
68		private function deleteRoute($request, $cmsComponent)
69		{
70		$cmsComponent->storage->getUsers()->deleteUserBySlug($request::$get[CmsComponent::GET_PARAMETER_SLUG]);
71		header('Location: ' . $request::$subfolders . $cmsComponent->getParameter(CmsComponent::PARAMETER_CMS_PREFIX) . '/configuration/users');
72		exit;
73		}
74
75		/**
76		* @param $request
77		* @param CmsComponent $cmsComponent
78		*/
79		private function editRoute($request, $cmsComponent)
80		{
81		$cmsComponent->subTemplate = 'configuration/users-form';
82		$cmsComponent->setParameter(CmsComponent::PARAMETER_MAIN_NAV_CLASS, CmsComponent::PARAMETER_CONFIGURATION);
83		$cmsComponent->setParameter(CmsComponent::PARAMETER_USER, $cmsComponent->storage->getUsers()->getUserBySlug($request::$get[CmsComponent::GET_PARAMETER_SLUG]));
84		if (isset($_POST[CmsComponent::POST_PARAMETER_USERNAME])) {
85		$cmsComponent->storage->getUsers()->saveUser($request::$get[CmsComponent::GET_PARAMETER_SLUG], $request::$post);
86		header('Location: ' . $request::$subfolders . $cmsComponent->getParameter(CmsComponent::PARAMETER_CMS_PREFIX) . '/configuration/users');
87		exit;
88		}
89		}
90		}

jenskooij / cloudcontrol

Push — master ( 9c6499...c22bc5 )

UsersRouting A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

5 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like