View GitHub Repository cloudcontrol

Schedule Inspection
Subscribe
Passed
Push — develop ( f31b27...ac6bc8 )
by Jens
03:16
created
Status
Category
Toggle Patches
cloudcontrol/library/components/cms/configuration/BricksRouting.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch 
@@ -33,7 +33,7 @@  discard block
 
 block discarded – undo
33 33 
 			$cmsComponent->setParameter(CmsComponent::PARAMETER_MAIN_NAV_CLASS, CmsComponent::PARAMETER_CONFIGURATION);
34 34 
 			if (isset($request::$post[CmsComponent::POST_PARAMETER_TITLE])) {
35 35 
 				$cmsComponent->storage->addBrick($request::$post);
36 
-				header('Location: ' . $request::$subfolders . $cmsComponent->getParameter(CmsComponent::PARAMETER_CMS_PREFIX) . '/configuration/bricks');
36 
+				header('Location: '.$request::$subfolders.$cmsComponent->getParameter(CmsComponent::PARAMETER_CMS_PREFIX).'/configuration/bricks');
37 37 
 				exit;
38 38 
 			}
39 39 
 		} elseif ($relativeCmsUri == '/configuration/bricks/edit' && isset($request::$get[CmsComponent::GET_PARAMETER_SLUG])) {
 
@@ -42,13 +42,13 @@  discard block
 
 block discarded – undo
42 42 
 			$brick = $cmsComponent->storage->getBrickBySlug($request::$get[CmsComponent::GET_PARAMETER_SLUG]);
43 43 
 			if (isset($request::$post[CmsComponent::POST_PARAMETER_TITLE])) {
44 44 
 				$cmsComponent->storage->saveBrick($request::$get[CmsComponent::GET_PARAMETER_SLUG], $request::$post);
45 
-				header('Location: ' . $request::$subfolders . $cmsComponent->getParameter(CmsComponent::PARAMETER_CMS_PREFIX) . '/configuration/bricks');
45 
+				header('Location: '.$request::$subfolders.$cmsComponent->getParameter(CmsComponent::PARAMETER_CMS_PREFIX).'/configuration/bricks');
46 46 
 				exit;
47 47 
 			}
48 48 
 			$cmsComponent->setParameter(CmsComponent::PARAMETER_BRICK, $brick);
49 49 
 		} elseif ($relativeCmsUri == '/configuration/bricks/delete' && isset($request::$get[CmsComponent::GET_PARAMETER_SLUG])) {
50 50 
 			$cmsComponent->storage->deleteBrickBySlug($request::$get[CmsComponent::GET_PARAMETER_SLUG]);
51 
-			header('Location: ' . $request::$subfolders . $cmsComponent->getParameter(CmsComponent::PARAMETER_CMS_PREFIX) . '/configuration/bricks');
51 
+			header('Location: '.$request::$subfolders.$cmsComponent->getParameter(CmsComponent::PARAMETER_CMS_PREFIX).'/configuration/bricks');
52 52 
 			exit;
53 53 
 		} elseif ($relativeCmsUri == '/configuration/image-set') {
54 54 
 			$cmsComponent->subTemplate = 'cms/configuration/image-set';
Please login to merge, or discard this patch.
cloudcontrol/library/components/cms/configuration/ImageSetRouting.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch 
@@ -34,7 +34,7 @@  discard block
 
 block discarded – undo
34 34 
 			$imageSet = $cmsComponent->storage->getImageSetBySlug($request::$get[CmsComponent::GET_PARAMETER_SLUG]);
35 35 
 			if (isset($request::$post[CmsComponent::POST_PARAMETER_TITLE])) {
36 36 
 				$cmsComponent->storage->saveImageSet($request::$get[CmsComponent::GET_PARAMETER_SLUG], $request::$post);
37 
-				header('Location: ' . $request::$subfolders . $cmsComponent->getParameter(CmsComponent::PARAMETER_CMS_PREFIX) . '/configuration/image-set');
37 
+				header('Location: '.$request::$subfolders.$cmsComponent->getParameter(CmsComponent::PARAMETER_CMS_PREFIX).'/configuration/image-set');
38 38 
 				exit;
39 39 
 			}
40 40 
 			$cmsComponent->setParameter(CmsComponent::PARAMETER_IMAGE_SET, $imageSet);
 
@@ -43,12 +43,12 @@  discard block
 
 block discarded – undo
43 43 
 			$cmsComponent->setParameter(CmsComponent::PARAMETER_MAIN_NAV_CLASS, CmsComponent::PARAMETER_CONFIGURATION);
44 44 
 			if (isset($request::$post[CmsComponent::POST_PARAMETER_TITLE])) {
45 45 
 				$cmsComponent->storage->addImageSet($request::$post);
46 
-				header('Location: ' . $request::$subfolders . $cmsComponent->getParameter(CmsComponent::PARAMETER_CMS_PREFIX) . '/configuration/image-set');
46 
+				header('Location: '.$request::$subfolders.$cmsComponent->getParameter(CmsComponent::PARAMETER_CMS_PREFIX).'/configuration/image-set');
47 47 
 				exit;
48 48 
 			}
49 49 
 		} elseif ($relativeCmsUri == '/configuration/image-set/delete' && isset($request::$get[CmsComponent::GET_PARAMETER_SLUG])) {
50 50 
 			$cmsComponent->storage->deleteImageSetBySlug($request::$get[CmsComponent::GET_PARAMETER_SLUG]);
51 
-			header('Location: ' . $request::$subfolders . $cmsComponent->getParameter(CmsComponent::PARAMETER_CMS_PREFIX) . '/configuration/image-set');
51 
+			header('Location: '.$request::$subfolders.$cmsComponent->getParameter(CmsComponent::PARAMETER_CMS_PREFIX).'/configuration/image-set');
52 52 
 			exit;
53 53 
 		}
54 54 
 	}
Please login to merge, or discard this patch.
library/components/cms/configuration/ApplicationComponentRouting.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch 
@@ -33,7 +33,7 @@  discard block
 
 block discarded – undo
33 33 
 			$cmsComponent->setParameter(CmsComponent::PARAMETER_MAIN_NAV_CLASS, CmsComponent::PARAMETER_CONFIGURATION);
34 34 
 			if (isset($request::$post[CmsComponent::POST_PARAMETER_TITLE])) {
35 35 
 				$cmsComponent->storage->addApplicationComponent($request::$post);
36 
-				header('Location: ' . $request::$subfolders . $cmsComponent->getParameter(CmsComponent::PARAMETER_CMS_PREFIX) . '/configuration/application-components');
36 
+				header('Location: '.$request::$subfolders.$cmsComponent->getParameter(CmsComponent::PARAMETER_CMS_PREFIX).'/configuration/application-components');
37 37 
 				exit;
38 38 
 			}
39 39 
 		} elseif ($relativeCmsUri == '/configuration/application-components/edit' && isset($request::$get[CmsComponent::GET_PARAMETER_SLUG])) {
 
@@ -42,14 +42,14 @@  discard block
 
 block discarded – undo
42 42 
 			$applicationComponent = $cmsComponent->storage->getApplicationComponentBySlug($request::$get[CmsComponent::GET_PARAMETER_SLUG]);
43 43 
 			if (isset($request::$post[CmsComponent::POST_PARAMETER_TITLE])) {
44 44 
 				$cmsComponent->storage->saveApplicationComponent($request::$get[CmsComponent::GET_PARAMETER_SLUG], $request::$post);
45 
-				header('Location: ' . $request::$subfolders . $cmsComponent->getParameter(CmsComponent::PARAMETER_CMS_PREFIX) . '/configuration/application-components');
45 
+				header('Location: '.$request::$subfolders.$cmsComponent->getParameter(CmsComponent::PARAMETER_CMS_PREFIX).'/configuration/application-components');
46 46 
 				exit;
47 47 
 			}
48 48
49 49 
 			$cmsComponent->setParameter(CmsComponent::PARAMETER_APPLICATION_COMPONENT, $applicationComponent);
50 50 
 		} elseif ($relativeCmsUri == '/configuration/application-components/delete' && isset($request::$get[CmsComponent::GET_PARAMETER_SLUG])) {
51 51 
 			$cmsComponent->storage->deleteApplicationComponentBySlug($request::$get[CmsComponent::GET_PARAMETER_SLUG]);
52 
-			header('Location: ' . $request::$subfolders . $cmsComponent->getParameter(CmsComponent::PARAMETER_CMS_PREFIX) . '/configuration/application-components');
52 
+			header('Location: '.$request::$subfolders.$cmsComponent->getParameter(CmsComponent::PARAMETER_CMS_PREFIX).'/configuration/application-components');
53 53 
 			exit;
54 54 
 		}
55 55 
 	}
Please login to merge, or discard this patch.
cloudcontrol/library/components/cms/configuration/DocumentTypeRouting.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch 
@@ -34,7 +34,7 @@  discard block
 
 block discarded – undo
34 34 
 			$bricks = $cmsComponent->storage->getBricks();
35 35 
 			if (isset($request::$post[CmsComponent::POST_PARAMETER_TITLE])) {
36 36 
 				$cmsComponent->storage->addDocumentType($request::$post);
37 
-				header('Location: ' . $request::$subfolders . $cmsComponent->getParameter(CmsComponent::PARAMETER_CMS_PREFIX) . '/configuration/document-types');
37 
+				header('Location: '.$request::$subfolders.$cmsComponent->getParameter(CmsComponent::PARAMETER_CMS_PREFIX).'/configuration/document-types');
38 38 
 				exit;
39 39 
 			}
40 40 
 			$cmsComponent->setParameter(CmsComponent::PARAMETER_BRICKS, $bricks);
 
@@ -45,14 +45,14 @@  discard block
 
 block discarded – undo
45 45 
 			$bricks = $cmsComponent->storage->getBricks();
46 46 
 			if (isset($request::$post[CmsComponent::POST_PARAMETER_TITLE])) {
47 47 
 				$cmsComponent->storage->saveDocumentType($request::$get[CmsComponent::GET_PARAMETER_SLUG], $request::$post);
48 
-				header('Location: ' . $request::$subfolders . $cmsComponent->getParameter(CmsComponent::PARAMETER_CMS_PREFIX) . '/configuration/document-types');
48 
+				header('Location: '.$request::$subfolders.$cmsComponent->getParameter(CmsComponent::PARAMETER_CMS_PREFIX).'/configuration/document-types');
49 49 
 				exit;
50 50 
 			}
51 51 
 			$cmsComponent->setParameter(CmsComponent::PARAMETER_DOCUMENT_TYPE, $documentType);
52 52 
 			$cmsComponent->setParameter(CmsComponent::PARAMETER_BRICKS, $bricks);
53 53 
 		} elseif ($relativeCmsUri == '/configuration/document-types/delete' && isset($request::$get[CmsComponent::GET_PARAMETER_SLUG])) {
54 54 
 			$cmsComponent->storage->deleteDocumentTypeBySlug($request::$get[CmsComponent::GET_PARAMETER_SLUG]);
55 
-			header('Location: ' . $request::$subfolders . $cmsComponent->getParameter(CmsComponent::PARAMETER_CMS_PREFIX) . '/configuration/document-types');
55 
+			header('Location: '.$request::$subfolders.$cmsComponent->getParameter(CmsComponent::PARAMETER_CMS_PREFIX).'/configuration/document-types');
56 56 
 			exit;
57 57 
 		}
58 58 
 	}
Please login to merge, or discard this patch.
cloudcontrol/library/components/cms/configuration/UsersRouting.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch 
@@ -34,12 +34,12 @@  discard block
 
 block discarded – undo
34 34 
 			$cmsComponent->setParameter(CmsComponent::PARAMETER_MAIN_NAV_CLASS, CmsComponent::PARAMETER_CONFIGURATION);
35 35 
 			if (isset($request::$post[CmsComponent::POST_PARAMETER_USERNAME])) {
36 36 
 				$cmsComponent->storage->addUser($request::$post);
37 
-				header('Location: ' . $request::$subfolders . $cmsComponent->getParameter(CmsComponent::PARAMETER_CMS_PREFIX) . '/configuration/users');
37 
+				header('Location: '.$request::$subfolders.$cmsComponent->getParameter(CmsComponent::PARAMETER_CMS_PREFIX).'/configuration/users');
38 38 
 				exit;
39 39 
 			}
40 40 
 		} elseif ($relativeCmsUri == '/configuration/users/delete' && isset($request::$get[CmsComponent::GET_PARAMETER_SLUG])) {
41 41 
 			$cmsComponent->storage->deleteUserBySlug($request::$get[CmsComponent::GET_PARAMETER_SLUG]);
42 
-			header('Location: ' . $request::$subfolders . $cmsComponent->getParameter(CmsComponent::PARAMETER_CMS_PREFIX) . '/configuration/users');
42 
+			header('Location: '.$request::$subfolders.$cmsComponent->getParameter(CmsComponent::PARAMETER_CMS_PREFIX).'/configuration/users');
43 43 
 			exit;
44 44 
 		} elseif ($relativeCmsUri == '/configuration/users/edit' && isset($request::$get[CmsComponent::GET_PARAMETER_SLUG])) {
45 45 
 			$cmsComponent->subTemplate = 'cms/configuration/users-form';
 
@@ -47,7 +47,7 @@  discard block
 
 block discarded – undo
47 47 
 			$cmsComponent->setParameter(CmsComponent::PARAMETER_USER, $cmsComponent->storage->getUserBySlug($request::$get[CmsComponent::GET_PARAMETER_SLUG]));
48 48 
 			if (isset($_POST[CmsComponent::POST_PARAMETER_USERNAME])) {
49 49 
 				$cmsComponent->storage->saveUser($request::$get[CmsComponent::GET_PARAMETER_SLUG], $request::$post);
50 
-				header('Location: ' . $request::$subfolders . $cmsComponent->getParameter(CmsComponent::PARAMETER_CMS_PREFIX) . '/configuration/users');
50 
+				header('Location: '.$request::$subfolders.$cmsComponent->getParameter(CmsComponent::PARAMETER_CMS_PREFIX).'/configuration/users');
51 51 
 				exit;
52 52 
 			}
53 53 
 		}
Please login to merge, or discard this patch.
cloudcontrol/library/components/CmsComponent.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch 
@@ -199,7 +199,7 @@  discard block
 
 block discarded – undo
199 199 
                 $whitelistIps = explode(',', $this->parameters[self::PARAMETER_WHITELIST_IPS]);
200 200 
                 $whitelistIps = array_map("trim", $whitelistIps);
201 201 
                 if (!in_array($remoteAddress, $whitelistIps)) {
202 
-                    throw new \Exception('Ip address ' . $remoteAddress . ' is not on whitelist');
202 
+                    throw new \Exception('Ip address '.$remoteAddress.' is not on whitelist');
203 203 
                 }
204 204 
             }
205 205 
         }
 
@@ -214,7 +214,7 @@  discard block
 
 block discarded – undo
214 214 
                 $blacklistIps = explode(',', $this->parameters[self::PARAMETER_BLACKLIST_IPS]);
215 215 
                 $blacklistIps = array_map("trim", $blacklistIps);
216 216 
                 if (in_array($remoteAddress, $blacklistIps)) {
217 
-                    throw new \Exception('Ip address ' . $remoteAddress . ' is on blacklist');
217 
+                    throw new \Exception('Ip address '.$remoteAddress.' is on blacklist');
218 218 
                 }
219 219 
             }
220 220 
         }
 
@@ -256,7 +256,7 @@  discard block
 
 block discarded – undo
256 256 
             if ($relativeCmsUri == '/log-off') {
257 257 
                 $_SESSION[self::SESSION_PARAMETER_CLOUD_CONTROL] = null;
258 258 
                 unset($_SESSION[self::SESSION_PARAMETER_CLOUD_CONTROL]);
259 
-                header('Location: ' . $request::$subfolders . $this->parameters[self::PARAMETER_CMS_PREFIX]);
259 
+                header('Location: '.$request::$subfolders.$this->parameters[self::PARAMETER_CMS_PREFIX]);
260 260 
                 exit;
261 261 
             }
262 262 
         }
Please login to merge, or discard this patch.