Inspection of "Refactored Application Components Storage" - jenskooij/cloudcontrol - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — develop ( 34ad04...e3baf2 )

by Jens

created 2017-03-17 11:26 UTC

Status

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -56,7 +56,7 @@  discard block
 block discarded – undo
 		$cmsComponent->setParameter(CmsComponent::PARAMETER_MAIN_NAV_CLASS, CmsComponent::PARAMETER_CONFIGURATION);
 		if (isset($request::$post[CmsComponent::POST_PARAMETER_USERNAME])) {
 			$cmsComponent->storage->getUsers()->addUser($request::$post);
-			header('Location: ' . $request::$subfolders . $cmsComponent->getParameter(CmsComponent::PARAMETER_CMS_PREFIX) . '/configuration/users');
+			header('Location: '.$request::$subfolders.$cmsComponent->getParameter(CmsComponent::PARAMETER_CMS_PREFIX).'/configuration/users');
 			exit;
 		}
 	}
@@ -68,7 +68,7 @@  discard block
 block discarded – undo
 	private function deleteRoute($request, $cmsComponent)
 	{
 		$cmsComponent->storage->getUsers()->deleteUserBySlug($request::$get[CmsComponent::GET_PARAMETER_SLUG]);
-		header('Location: ' . $request::$subfolders . $cmsComponent->getParameter(CmsComponent::PARAMETER_CMS_PREFIX) . '/configuration/users');
+		header('Location: '.$request::$subfolders.$cmsComponent->getParameter(CmsComponent::PARAMETER_CMS_PREFIX).'/configuration/users');
 		exit;
 	}
 
@@ -83,7 +83,7 @@  discard block
 block discarded – undo
 		$cmsComponent->setParameter(CmsComponent::PARAMETER_USER, $cmsComponent->storage->getUsers()->getUserBySlug($request::$get[CmsComponent::GET_PARAMETER_SLUG]));
 		if (isset($_POST[CmsComponent::POST_PARAMETER_USERNAME])) {
 			$cmsComponent->storage->getUsers()->saveUser($request::$get[CmsComponent::GET_PARAMETER_SLUG], $request::$post);
-			header('Location: ' . $request::$subfolders . $cmsComponent->getParameter(CmsComponent::PARAMETER_CMS_PREFIX) . '/configuration/users');
+			header('Location: '.$request::$subfolders.$cmsComponent->getParameter(CmsComponent::PARAMETER_CMS_PREFIX).'/configuration/users');
 			exit;
 		}
 	}

Please login to merge, or discard this patch.

cloudcontrol/library/storage/storage/AbstractStorage.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -35,19 +35,19 @@
 block discarded – undo
 			array_pop($fileParts);
 			$fileNameWithoutExtension = implode('-', $fileParts);
 			$fileNameWithoutExtension = slugify($fileNameWithoutExtension);
-			$filename = $fileNameWithoutExtension . '.' . $extension;
+			$filename = $fileNameWithoutExtension.'.'.$extension;
 		} else {
 			$filename = slugify($filename);
 		}
 
-		if (file_exists($path . '/' . $filename)) {
+		if (file_exists($path.'/'.$filename)) {
 			$fileParts = explode('.', $filename);
 			if (count($fileParts) > 1) {
 				$extension = end($fileParts);
 				array_pop($fileParts);
 				$fileNameWithoutExtension = implode('-', $fileParts);
 				$fileNameWithoutExtension .= '-copy';
-				$filename = $fileNameWithoutExtension . '.' . $extension;
+				$filename = $fileNameWithoutExtension.'.'.$extension;
 			} else {
 				$filename .= '-copy';
 			}

Please login to merge, or discard this patch.

cloudcontrol/library/components/cms/configuration/BricksRouting.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -55,7 +55,7 @@  discard block
 block discarded – undo
 		$cmsComponent->setParameter(CmsComponent::PARAMETER_MAIN_NAV_CLASS, CmsComponent::PARAMETER_CONFIGURATION);
 		if (isset($request::$post[CmsComponent::POST_PARAMETER_TITLE])) {
 			$cmsComponent->storage->getBricks()->addBrick($request::$post);
-			header('Location: ' . $request::$subfolders . $cmsComponent->getParameter(CmsComponent::PARAMETER_CMS_PREFIX) . '/configuration/bricks');
+			header('Location: '.$request::$subfolders.$cmsComponent->getParameter(CmsComponent::PARAMETER_CMS_PREFIX).'/configuration/bricks');
 			exit;
 		}
 	}
@@ -71,7 +71,7 @@  discard block
 block discarded – undo
 		$brick = $cmsComponent->storage->getBricks()->getBrickBySlug($request::$get[CmsComponent::GET_PARAMETER_SLUG]);
 		if (isset($request::$post[CmsComponent::POST_PARAMETER_TITLE])) {
 			$cmsComponent->storage->getBricks()->saveBrick($request::$get[CmsComponent::GET_PARAMETER_SLUG], $request::$post);
-			header('Location: ' . $request::$subfolders . $cmsComponent->getParameter(CmsComponent::PARAMETER_CMS_PREFIX) . '/configuration/bricks');
+			header('Location: '.$request::$subfolders.$cmsComponent->getParameter(CmsComponent::PARAMETER_CMS_PREFIX).'/configuration/bricks');
 			exit;
 		}
 		$cmsComponent->setParameter(CmsComponent::PARAMETER_BRICK, $brick);
@@ -84,7 +84,7 @@  discard block
 block discarded – undo
 	private function deleteRoute($request, $cmsComponent)
 	{
 		$cmsComponent->storage->getBricks()->deleteBrickBySlug($request::$get[CmsComponent::GET_PARAMETER_SLUG]);
-		header('Location: ' . $request::$subfolders . $cmsComponent->getParameter(CmsComponent::PARAMETER_CMS_PREFIX) . '/configuration/bricks');
+		header('Location: '.$request::$subfolders.$cmsComponent->getParameter(CmsComponent::PARAMETER_CMS_PREFIX).'/configuration/bricks');
 		exit;
 	}
 }
\ No newline at end of file

Please login to merge, or discard this patch.

cloudcontrol/library/components/cms/configuration/DocumentTypeRouting.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -56,7 +56,7 @@  discard block
 block discarded – undo
 		$bricks = $cmsComponent->storage->getBricks()->getBricks();
 		if (isset($request::$post[CmsComponent::POST_PARAMETER_TITLE])) {
 			$cmsComponent->storage->getDocumentTypes()->addDocumentType($request::$post);
-			header('Location: ' . $request::$subfolders . $cmsComponent->getParameter(CmsComponent::PARAMETER_CMS_PREFIX) . '/configuration/document-types');
+			header('Location: '.$request::$subfolders.$cmsComponent->getParameter(CmsComponent::PARAMETER_CMS_PREFIX).'/configuration/document-types');
 			exit;
 		}
 		$cmsComponent->setParameter(CmsComponent::PARAMETER_BRICKS, $bricks);
@@ -74,7 +74,7 @@  discard block
 block discarded – undo
 		$bricks = $cmsComponent->storage->getBricks()->getBricks();
 		if (isset($request::$post[CmsComponent::POST_PARAMETER_TITLE])) {
 			$cmsComponent->storage->getDocumentTypes()->saveDocumentType($request::$get[CmsComponent::GET_PARAMETER_SLUG], $request::$post);
-			header('Location: ' . $request::$subfolders . $cmsComponent->getParameter(CmsComponent::PARAMETER_CMS_PREFIX) . '/configuration/document-types');
+			header('Location: '.$request::$subfolders.$cmsComponent->getParameter(CmsComponent::PARAMETER_CMS_PREFIX).'/configuration/document-types');
 			exit;
 		}
 		$cmsComponent->setParameter(CmsComponent::PARAMETER_DOCUMENT_TYPE, $documentType);
@@ -88,7 +88,7 @@  discard block
 block discarded – undo
 	private function deleteRoute($request, $cmsComponent)
 	{
 		$cmsComponent->storage->getDocumentTypes()->deleteDocumentTypeBySlug($request::$get[CmsComponent::GET_PARAMETER_SLUG]);
-		header('Location: ' . $request::$subfolders . $cmsComponent->getParameter(CmsComponent::PARAMETER_CMS_PREFIX) . '/configuration/document-types');
+		header('Location: '.$request::$subfolders.$cmsComponent->getParameter(CmsComponent::PARAMETER_CMS_PREFIX).'/configuration/document-types');
 		exit;
 	}
 }
\ No newline at end of file

Please login to merge, or discard this patch.

cloudcontrol/library/search/DocumentTokenizer.php 1 patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -89,11 +89,11 @@  discard block
 block discarded – undo
 
 	private function tokenizeBrick($brick, $brickSlug)
 	{
-		$fields  = $brick->fields;
+		$fields = $brick->fields;
 		$brickDefinition = $this->storage->getBricks()->getBrickBySlug($brick->type);
 		foreach ($fields as $fieldName => $field) {
 			$fieldType = $this->getFieldType($fieldName, $brickDefinition);
-			$this->tokenizeField($field, $brickSlug . '__' . $fieldName, $fieldType);
+			$this->tokenizeField($field, $brickSlug.'__'.$fieldName, $fieldType);
 		}
 	}
 
@@ -101,7 +101,7 @@  discard block
 block discarded – undo
 	{
 		$dynamicBricks = $this->document->dynamicBricks;
 		foreach ($dynamicBricks as $key => $brick) {
-			$this->tokenizeBrick($brick, 'dynamicBricks__' . $brick->type . $key);
+			$this->tokenizeBrick($brick, 'dynamicBricks__'.$brick->type.$key);
 		}
 	}
 
@@ -154,6 +154,6 @@  discard block
 block discarded – undo
 			}
 		}
 
-		throw new \Exception('Unknown field type for field' . $fieldName . ' in document ' . $this->document->path);
+		throw new \Exception('Unknown field type for field'.$fieldName.' in document '.$this->document->path);
 	}
 }
\ No newline at end of file

Please login to merge, or discard this patch.

library/components/cms/configuration/ApplicationComponentRouting.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -55,7 +55,7 @@  discard block
 block discarded – undo
 		$cmsComponent->setParameter(CmsComponent::PARAMETER_MAIN_NAV_CLASS, CmsComponent::PARAMETER_CONFIGURATION);
 		if (isset($request::$post[CmsComponent::POST_PARAMETER_TITLE])) {
 			$cmsComponent->storage->getApplicationComponents()->addApplicationComponent($request::$post);
-			header('Location: ' . $request::$subfolders . $cmsComponent->getParameter(CmsComponent::PARAMETER_CMS_PREFIX) . '/configuration/application-components');
+			header('Location: '.$request::$subfolders.$cmsComponent->getParameter(CmsComponent::PARAMETER_CMS_PREFIX).'/configuration/application-components');
 			exit;
 		}
 	}
@@ -71,7 +71,7 @@  discard block
 block discarded – undo
 		$applicationComponent = $cmsComponent->storage->getApplicationComponents()->getApplicationComponentBySlug($request::$get[CmsComponent::GET_PARAMETER_SLUG]);
 		if (isset($request::$post[CmsComponent::POST_PARAMETER_TITLE])) {
 			$cmsComponent->storage->getApplicationComponents()->saveApplicationComponent($request::$get[CmsComponent::GET_PARAMETER_SLUG], $request::$post);
-			header('Location: ' . $request::$subfolders . $cmsComponent->getParameter(CmsComponent::PARAMETER_CMS_PREFIX) . '/configuration/application-components');
+			header('Location: '.$request::$subfolders.$cmsComponent->getParameter(CmsComponent::PARAMETER_CMS_PREFIX).'/configuration/application-components');
 			exit;
 		}
 
@@ -85,7 +85,7 @@  discard block
 block discarded – undo
 	private function deleteRoute($request, $cmsComponent)
 	{
 		$cmsComponent->storage->getApplicationComponents()->deleteApplicationComponentBySlug($request::$get[CmsComponent::GET_PARAMETER_SLUG]);
-		header('Location: ' . $request::$subfolders . $cmsComponent->getParameter(CmsComponent::PARAMETER_CMS_PREFIX) . '/configuration/application-components');
+		header('Location: '.$request::$subfolders.$cmsComponent->getParameter(CmsComponent::PARAMETER_CMS_PREFIX).'/configuration/application-components');
 		exit;
 	}
 }
\ No newline at end of file

Please login to merge, or discard this patch.

		@@ -35,19 +35,19 @@
		block discarded – undo
35	35	array_pop($fileParts);
36	36	$fileNameWithoutExtension = implode('-', $fileParts);
37	37	$fileNameWithoutExtension = slugify($fileNameWithoutExtension);
38		- $filename = $fileNameWithoutExtension . '.' . $extension;
	38	+ $filename = $fileNameWithoutExtension.'.'.$extension;
39	39	} else {
40	40	$filename = slugify($filename);
41	41	}
42	42
43		- if (file_exists($path . '/' . $filename)) {
	43	+ if (file_exists($path.'/'.$filename)) {
44	44	$fileParts = explode('.', $filename);
45	45	if (count($fileParts) > 1) {
46	46	$extension = end($fileParts);
47	47	array_pop($fileParts);
48	48	$fileNameWithoutExtension = implode('-', $fileParts);
49	49	$fileNameWithoutExtension .= '-copy';
50		- $filename = $fileNameWithoutExtension . '.' . $extension;
	50	+ $filename = $fileNameWithoutExtension.'.'.$extension;
51	51	} else {
52	52	$filename .= '-copy';
53	53	}

		@@ -56,7 +56,7 @@ discard block
		block discarded – undo
56	56	$bricks = $cmsComponent->storage->getBricks()->getBricks();
57	57	if (isset($request::$post[CmsComponent::POST_PARAMETER_TITLE])) {
58	58	$cmsComponent->storage->getDocumentTypes()->addDocumentType($request::$post);
59		- header('Location: ' . $request::$subfolders . $cmsComponent->getParameter(CmsComponent::PARAMETER_CMS_PREFIX) . '/configuration/document-types');
	59	+ header('Location: '.$request::$subfolders.$cmsComponent->getParameter(CmsComponent::PARAMETER_CMS_PREFIX).'/configuration/document-types');
60	60	exit;
61	61	}
62	62	$cmsComponent->setParameter(CmsComponent::PARAMETER_BRICKS, $bricks);
		@@ -74,7 +74,7 @@ discard block
		block discarded – undo
74	74	$bricks = $cmsComponent->storage->getBricks()->getBricks();
75	75	if (isset($request::$post[CmsComponent::POST_PARAMETER_TITLE])) {
76	76	$cmsComponent->storage->getDocumentTypes()->saveDocumentType($request::$get[CmsComponent::GET_PARAMETER_SLUG], $request::$post);
77		- header('Location: ' . $request::$subfolders . $cmsComponent->getParameter(CmsComponent::PARAMETER_CMS_PREFIX) . '/configuration/document-types');
	77	+ header('Location: '.$request::$subfolders.$cmsComponent->getParameter(CmsComponent::PARAMETER_CMS_PREFIX).'/configuration/document-types');
78	78	exit;
79	79	}
80	80	$cmsComponent->setParameter(CmsComponent::PARAMETER_DOCUMENT_TYPE, $documentType);
		@@ -88,7 +88,7 @@ discard block
		block discarded – undo
88	88	private function deleteRoute($request, $cmsComponent)
89	89	{
90	90	$cmsComponent->storage->getDocumentTypes()->deleteDocumentTypeBySlug($request::$get[CmsComponent::GET_PARAMETER_SLUG]);
91		- header('Location: ' . $request::$subfolders . $cmsComponent->getParameter(CmsComponent::PARAMETER_CMS_PREFIX) . '/configuration/document-types');
	91	+ header('Location: '.$request::$subfolders.$cmsComponent->getParameter(CmsComponent::PARAMETER_CMS_PREFIX).'/configuration/document-types');
92	92	exit;
93	93	}
94	94	}
95	95	\ No newline at end of file

		@@ -89,11 +89,11 @@ discard block
		block discarded – undo
89	89
90	90	private function tokenizeBrick($brick, $brickSlug)
91	91	{
92		- $fields = $brick->fields;
	92	+ $fields = $brick->fields;
93	93	$brickDefinition = $this->storage->getBricks()->getBrickBySlug($brick->type);
94	94	foreach ($fields as $fieldName => $field) {
95	95	$fieldType = $this->getFieldType($fieldName, $brickDefinition);
96		- $this->tokenizeField($field, $brickSlug . '__' . $fieldName, $fieldType);
	96	+ $this->tokenizeField($field, $brickSlug.'__'.$fieldName, $fieldType);
97	97	}
98	98	}
99	99
		@@ -101,7 +101,7 @@ discard block
		block discarded – undo
101	101	{
102	102	$dynamicBricks = $this->document->dynamicBricks;
103	103	foreach ($dynamicBricks as $key => $brick) {
104		- $this->tokenizeBrick($brick, 'dynamicBricks__' . $brick->type . $key);
	104	+ $this->tokenizeBrick($brick, 'dynamicBricks__'.$brick->type.$key);
105	105	}
106	106	}
107	107
		@@ -154,6 +154,6 @@ discard block
		block discarded – undo
154	154	}
155	155	}
156	156
157		- throw new \Exception('Unknown field type for field' . $fieldName . ' in document ' . $this->document->path);
	157	+ throw new \Exception('Unknown field type for field'.$fieldName.' in document '.$this->document->path);
158	158	}
159	159	}
160	160	\ No newline at end of file

		@@ -55,7 +55,7 @@ discard block
		block discarded – undo
55	55	$cmsComponent->setParameter(CmsComponent::PARAMETER_MAIN_NAV_CLASS, CmsComponent::PARAMETER_CONFIGURATION);
56	56	if (isset($request::$post[CmsComponent::POST_PARAMETER_TITLE])) {
57	57	$cmsComponent->storage->getBricks()->addBrick($request::$post);
58		- header('Location: ' . $request::$subfolders . $cmsComponent->getParameter(CmsComponent::PARAMETER_CMS_PREFIX) . '/configuration/bricks');
	58	+ header('Location: '.$request::$subfolders.$cmsComponent->getParameter(CmsComponent::PARAMETER_CMS_PREFIX).'/configuration/bricks');
59	59	exit;
60	60	}
61	61	}
		@@ -71,7 +71,7 @@ discard block
		block discarded – undo
71	71	$brick = $cmsComponent->storage->getBricks()->getBrickBySlug($request::$get[CmsComponent::GET_PARAMETER_SLUG]);
72	72	if (isset($request::$post[CmsComponent::POST_PARAMETER_TITLE])) {
73	73	$cmsComponent->storage->getBricks()->saveBrick($request::$get[CmsComponent::GET_PARAMETER_SLUG], $request::$post);
74		- header('Location: ' . $request::$subfolders . $cmsComponent->getParameter(CmsComponent::PARAMETER_CMS_PREFIX) . '/configuration/bricks');
	74	+ header('Location: '.$request::$subfolders.$cmsComponent->getParameter(CmsComponent::PARAMETER_CMS_PREFIX).'/configuration/bricks');
75	75	exit;
76	76	}
77	77	$cmsComponent->setParameter(CmsComponent::PARAMETER_BRICK, $brick);
		@@ -84,7 +84,7 @@ discard block
		block discarded – undo
84	84	private function deleteRoute($request, $cmsComponent)
85	85	{
86	86	$cmsComponent->storage->getBricks()->deleteBrickBySlug($request::$get[CmsComponent::GET_PARAMETER_SLUG]);
87		- header('Location: ' . $request::$subfolders . $cmsComponent->getParameter(CmsComponent::PARAMETER_CMS_PREFIX) . '/configuration/bricks');
	87	+ header('Location: '.$request::$subfolders.$cmsComponent->getParameter(CmsComponent::PARAMETER_CMS_PREFIX).'/configuration/bricks');
88	88	exit;
89	89	}
90	90	}
91	91	\ No newline at end of file

jenskooij / cloudcontrol

Push — develop ( 34ad04...e3baf2 )

Status

Category

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch