Passed
Push — develop ( fc7043...b7cd40 )
by Jens
02:53
created
cloudcontrol/library/storage/Repository.php 1 patch
Spacing   +31 added lines, -31 removed lines patch added patch discarded remove patch
@@ -102,7 +102,7 @@  discard block
 block discarded – undo
102 102
             if (in_array($name, $this->fileBasedSubsets)) {
103 103
                 return $this->loadSubset($name);
104 104
             } else {
105
-                throw new \Exception('Trying to get undefined property from Repository: ' . $name);
105
+                throw new \Exception('Trying to get undefined property from Repository: '.$name);
106 106
             }
107 107
         }
108 108
     }
@@ -111,10 +111,10 @@  discard block
 block discarded – undo
111 111
     {
112 112
         if (in_array($name, $this->fileBasedSubsets)) {
113 113
             $this->$name = $value;
114
-            $changes = $name . 'Changes';
114
+            $changes = $name.'Changes';
115 115
             $this->$changes = true;
116 116
         } else {
117
-            throw new \Exception('Trying to persist unknown subset in repository: ' . $name . ' <br /><pre>' . print_r($value, true) . '</pre>');
117
+            throw new \Exception('Trying to persist unknown subset in repository: '.$name.' <br /><pre>'.print_r($value, true).'</pre>');
118 118
         }
119 119
     }
120 120
 
@@ -133,15 +133,15 @@  discard block
 block discarded – undo
133 133
     protected function saveSubset($subset)
134 134
     {
135 135
         $json = json_encode($this->$subset);
136
-        $subsetStoragePath = $this->storagePath . DIRECTORY_SEPARATOR . $subset . '.json';
136
+        $subsetStoragePath = $this->storagePath.DIRECTORY_SEPARATOR.$subset.'.json';
137 137
         file_put_contents($subsetStoragePath, $json);
138
-        $changes = $subset . 'Changes';
138
+        $changes = $subset.'Changes';
139 139
         $this->$changes = false;
140 140
     }
141 141
 
142 142
     protected function loadSubset($subset)
143 143
     {
144
-        $subsetStoragePath = $this->storagePath . DIRECTORY_SEPARATOR . $subset . '.json';
144
+        $subsetStoragePath = $this->storagePath.DIRECTORY_SEPARATOR.$subset.'.json';
145 145
         $json = file_get_contents($subsetStoragePath);
146 146
         $json = json_decode($json);
147 147
         $this->$subset = $json;
@@ -189,7 +189,7 @@  discard block
 block discarded – undo
189 189
     protected function getContentDbHandle()
190 190
     {
191 191
         if ($this->contentDbHandle === null) {
192
-            $this->contentDbHandle = new \PDO('sqlite:' . $this->storagePath . DIRECTORY_SEPARATOR . 'content.db');
192
+            $this->contentDbHandle = new \PDO('sqlite:'.$this->storagePath.DIRECTORY_SEPARATOR.'content.db');
193 193
         }
194 194
         return $this->contentDbHandle;
195 195
     }
@@ -202,14 +202,14 @@  discard block
 block discarded – undo
202 202
     public function getDocumentsByPath($folderPath)
203 203
     {
204 204
         $db = $this->getContentDbHandle();
205
-        $folderPathWithWildcard = $folderPath . '%';
205
+        $folderPathWithWildcard = $folderPath.'%';
206 206
 
207 207
         $stmt = $this->getDbStatement('
208 208
             SELECT *
209 209
               FROM documents
210
-             WHERE `path` LIKE ' . $db->quote($folderPathWithWildcard) . '
211
-               AND substr(`path`, ' . (strlen($folderPath) + 1) . ') NOT LIKE "%/%"
212
-               AND path != ' . $db->quote($folderPath) . '
210
+             WHERE `path` LIKE ' . $db->quote($folderPathWithWildcard).'
211
+               AND substr(`path`, ' . (strlen($folderPath) + 1).') NOT LIKE "%/%"
212
+               AND path != ' . $db->quote($folderPath).'
213 213
           ORDER BY `type` DESC, `path` ASC
214 214
         ');
215 215
 
@@ -253,7 +253,7 @@  discard block
 block discarded – undo
253 253
         $document = $this->fetchDocument('
254 254
             SELECT *
255 255
               FROM documents
256
-             WHERE path = ' . $db->quote($path) . '
256
+             WHERE path = ' . $db->quote($path).'
257 257
         ');
258 258
         if ($document instanceof Document && $document->type === 'folder') {
259 259
             $document->dbHandle = $db;
@@ -285,7 +285,7 @@  discard block
 block discarded – undo
285 285
         if ($stmt === false) {
286 286
             $errorInfo = $db->errorInfo();
287 287
             $errorMsg = $errorInfo[2];
288
-            throw new \Exception('SQLite Exception: ' . $errorMsg . ' in SQL: <br /><pre>' . $sql . '</pre>');
288
+            throw new \Exception('SQLite Exception: '.$errorMsg.' in SQL: <br /><pre>'.$sql.'</pre>');
289 289
         }
290 290
         return $stmt;
291 291
     }
@@ -309,19 +309,19 @@  discard block
 block discarded – undo
309 309
         $stmt = $this->getDbStatement('
310 310
             INSERT OR REPLACE INTO documents (`path`,`title`,`slug`,`type`,`documentType`,`documentTypeSlug`,`state`,`lastModificationDate`,`creationDate`,`lastModifiedBy`,`fields`,`bricks`,`dynamicBricks`)
311 311
             VALUES(
312
-              ' . $db->quote($documentObject->path) . ',
313
-              ' . $db->quote($documentObject->title) . ',
314
-              ' . $db->quote($documentObject->slug) . ',
315
-              ' . $db->quote($documentObject->type) . ',
316
-              ' . $db->quote($documentObject->documentType) . ',
317
-              ' . $db->quote($documentObject->documentTypeSlug) . ',
318
-              ' . $db->quote($documentObject->state) . ',
319
-              ' . $db->quote($documentObject->lastModificationDate) . ',
320
-              ' . $db->quote($documentObject->creationDate) . ',
321
-              ' . $db->quote($documentObject->lastModifiedBy) . ',
322
-              ' . $db->quote(json_encode($documentObject->fields)) . ',
323
-              ' . $db->quote(json_encode($documentObject->bricks)) . ',
324
-              ' . $db->quote(json_encode($documentObject->dynamicBricks)) . '
312
+              ' . $db->quote($documentObject->path).',
313
+              ' . $db->quote($documentObject->title).',
314
+              ' . $db->quote($documentObject->slug).',
315
+              ' . $db->quote($documentObject->type).',
316
+              ' . $db->quote($documentObject->documentType).',
317
+              ' . $db->quote($documentObject->documentTypeSlug).',
318
+              ' . $db->quote($documentObject->state).',
319
+              ' . $db->quote($documentObject->lastModificationDate).',
320
+              ' . $db->quote($documentObject->creationDate).',
321
+              ' . $db->quote($documentObject->lastModifiedBy).',
322
+              ' . $db->quote(json_encode($documentObject->fields)).',
323
+              ' . $db->quote(json_encode($documentObject->bricks)).',
324
+              ' . $db->quote(json_encode($documentObject->dynamicBricks)).'
325 325
             )
326 326
         ');
327 327
         $result = $stmt->execute();
@@ -336,15 +336,15 @@  discard block
 block discarded – undo
336 336
             if ($documentToDelete->type == 'document') {
337 337
                 $stmt = $this->getDbStatement('
338 338
                     DELETE FROM documents
339
-                          WHERE path = ' . $db->quote($path) . '
339
+                          WHERE path = ' . $db->quote($path).'
340 340
                 ');
341 341
             } elseif ($documentToDelete->type == 'folder') {
342
-                $folderPathWithWildcard = $path . '%';
342
+                $folderPathWithWildcard = $path.'%';
343 343
                 $stmt = $this->getDbStatement('
344 344
                     DELETE FROM documents
345
-                          WHERE (path LIKE ' . $db->quote($folderPathWithWildcard) . '
346
-                            AND substr(`path`, ' . (strlen($path) + 1) . ', 1) = "/")
347
-                            OR path = ' . $db->quote($path) . '
345
+                          WHERE (path LIKE ' . $db->quote($folderPathWithWildcard).'
346
+                            AND substr(`path`, ' . (strlen($path) + 1).', 1) = "/")
347
+                            OR path = ' . $db->quote($path).'
348 348
                 ');
349 349
             }
350 350
         }
Please login to merge, or discard this patch.
cloudcontrol/library/storage/Document.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -39,7 +39,7 @@  discard block
 block discarded – undo
39 39
             }
40 40
         } elseif ($name === 'content') {
41 41
             if ($this->dbHandle === null) {
42
-                throw new \Exception('Document doesnt have a dbHandle handle. (path: ' . $this->path . ')');
42
+                throw new \Exception('Document doesnt have a dbHandle handle. (path: '.$this->path.')');
43 43
             } else {
44 44
                 if ($this->content === null) {
45 45
                     $this->getContent();
@@ -68,19 +68,19 @@  discard block
 block discarded – undo
68 68
      */
69 69
     protected function getContent()
70 70
     {
71
-        $folderPathWithWildcard = $this->path . '%';
71
+        $folderPathWithWildcard = $this->path.'%';
72 72
         $sql = '    SELECT *
73 73
                       FROM documents
74
-                     WHERE `path` LIKE ' . $this->dbHandle->quote($folderPathWithWildcard) . '
75
-                       AND substr(`path`, ' . (strlen($this->path) + 2) . ') NOT LIKE "%/%"
76
-                       AND substr(`path`, ' . (strlen($this->path) + 1) . ', 1) = "/"
77
-                       AND path != ' . $this->dbHandle->quote($this->path) . '
74
+                     WHERE `path` LIKE ' . $this->dbHandle->quote($folderPathWithWildcard).'
75
+                       AND substr(`path`, ' . (strlen($this->path) + 2).') NOT LIKE "%/%"
76
+                       AND substr(`path`, ' . (strlen($this->path) + 1).', 1) = "/"
77
+                       AND path != ' . $this->dbHandle->quote($this->path).'
78 78
                     ';
79 79
         $stmt = $this->dbHandle->query($sql);
80 80
         if ($stmt === false) {
81 81
             $errorInfo = $this->dbHandle->errorInfo();
82 82
             $errorMsg = $errorInfo[2];
83
-            throw new \Exception('SQLite Exception: ' . $errorMsg . ' in SQL: <br /><pre>' . $sql . '</pre>');
83
+            throw new \Exception('SQLite Exception: '.$errorMsg.' in SQL: <br /><pre>'.$sql.'</pre>');
84 84
         }
85 85
         $contents = $stmt->fetchAll(\PDO::FETCH_CLASS, '\library\storage\Document');
86 86
         foreach ($contents as $key => $document) {
Please login to merge, or discard this patch.
cloudcontrol/library/storage/JsonStorage.php 1 patch
Spacing   +28 added lines, -28 removed lines patch added patch discarded remove patch
@@ -36,7 +36,7 @@  discard block
 block discarded – undo
36 36
 		 */
37 37
 		private function config()
38 38
 		{
39
-			$storagePath = __DIR__ . '/../../' . $this->storageDir;
39
+			$storagePath = __DIR__.'/../../'.$this->storageDir;
40 40
 			if (realpath($storagePath) === false) {
41 41
 				initFramework($storagePath);
42 42
 				if (Repository::create($storagePath)) {
@@ -44,7 +44,7 @@  discard block
 block discarded – undo
44 44
 					$repository->init();
45 45
 					$this->repository = $repository;
46 46
 				} else {
47
-					throw new \Exception('Could not create repository directory: ' . $storagePath);
47
+					throw new \Exception('Could not create repository directory: '.$storagePath);
48 48
 				}
49 49
 			} else {
50 50
 				$this->repository = new Repository($storagePath);
@@ -194,20 +194,20 @@  discard block
 block discarded – undo
194 194
 		 */
195 195
 		public function getDocumentBySlug($slug)
196 196
 		{
197
-            $path = '/' . $slug;
197
+            $path = '/'.$slug;
198 198
 			return $this->repository->getDocumentByPath($path);
199 199
 		}
200 200
 
201 201
 		public function saveDocument($postValues)
202 202
 		{
203
-            $oldPath = '/' . $postValues['path'];
203
+            $oldPath = '/'.$postValues['path'];
204 204
 
205 205
             $container = $this->getDocumentContainerByPath($oldPath);
206 206
             $documentObject = $this->createDocumentFromPostValues($postValues);
207 207
             if ($container->path === '/') {
208
-                $newPath = $container->path . $documentObject->slug;
208
+                $newPath = $container->path.$documentObject->slug;
209 209
             } else {
210
-                $newPath = $container->path . '/' . $documentObject->slug;
210
+                $newPath = $container->path.'/'.$documentObject->slug;
211 211
             }
212 212
             $documentObject->path = $newPath;
213 213
             $this->repository->saveDocument($documentObject);
@@ -217,9 +217,9 @@  discard block
 block discarded – undo
217 217
 		{
218 218
 			$documentObject = $this->createDocumentFromPostValues($postValues);
219 219
             if ($postValues['path'] === '/') {
220
-                $documentObject->path = $postValues['path'] . $documentObject->slug;
220
+                $documentObject->path = $postValues['path'].$documentObject->slug;
221 221
             } else {
222
-                $documentObject->path = $postValues['path'] . '/' . $documentObject->slug;
222
+                $documentObject->path = $postValues['path'].'/'.$documentObject->slug;
223 223
             }
224 224
 
225 225
             $this->repository->saveDocument($documentObject);
@@ -227,7 +227,7 @@  discard block
 block discarded – undo
227 227
 
228 228
 		public function deleteDocumentBySlug($slug)
229 229
 		{
230
-            $path = '/' . $slug;
230
+            $path = '/'.$slug;
231 231
 			$this->repository->deleteDocumentByPath($path);
232 232
 		}
233 233
 
@@ -309,9 +309,9 @@  discard block
 block discarded – undo
309 309
 		{
310 310
             $documentFolderObject = $this->createDocumentFolderFromPostValues($postValues);
311 311
             if ($postValues['path'] === '/') {
312
-                $documentFolderObject->path = $postValues['path'] . $documentFolderObject->slug;
312
+                $documentFolderObject->path = $postValues['path'].$documentFolderObject->slug;
313 313
             } else {
314
-                $documentFolderObject->path = $postValues['path'] . '/' . $documentFolderObject->slug;
314
+                $documentFolderObject->path = $postValues['path'].'/'.$documentFolderObject->slug;
315 315
             }
316 316
             $this->repository->saveDocument($documentFolderObject);
317 317
 		}
@@ -325,7 +325,7 @@  discard block
 block discarded – undo
325 325
 		 */
326 326
 		public function deleteDocumentFolderBySlug($slug)
327 327
 		{
328
-            $path = '/' . $slug;
328
+            $path = '/'.$slug;
329 329
 			$this->repository->deleteDocumentByPath($path);
330 330
 		}
331 331
 
@@ -339,7 +339,7 @@  discard block
 block discarded – undo
339 339
 		 */
340 340
 		public function getDocumentFolderBySlug($slug)
341 341
 		{
342
-            $path = '/' . $slug;
342
+            $path = '/'.$slug;
343 343
 			return $this->repository->getDocumentByPath($path);
344 344
 		}
345 345
 
@@ -550,13 +550,13 @@  discard block
 block discarded – undo
550 550
 
551 551
 		public function addImage($postValues)
552 552
 		{
553
-			$destinationPath = realpath(__DIR__ . '/../../www/images/');
553
+			$destinationPath = realpath(__DIR__.'/../../www/images/');
554 554
 
555 555
 			$filename = $this->validateFilename($postValues['name'], $destinationPath);
556
-			$destination = $destinationPath . '/' . $filename;
556
+			$destination = $destinationPath.'/'.$filename;
557 557
 
558 558
 			if ($postValues['error'] != '0') {
559
-				throw new \Exception('Error uploading file. Error code: ' . $postValues['error']);
559
+				throw new \Exception('Error uploading file. Error code: '.$postValues['error']);
560 560
 			}
561 561
 
562 562
 			if (move_uploaded_file($postValues['tmp_name'], $destination)) {
@@ -581,14 +581,14 @@  discard block
 block discarded – undo
581 581
 
582 582
 		public function deleteImageByName($filename)
583 583
 		{
584
-			$destinationPath = realpath(__DIR__ . '/../../www/images/');
584
+			$destinationPath = realpath(__DIR__.'/../../www/images/');
585 585
 
586 586
 			$images = $this->getImages();
587 587
 
588 588
 			foreach ($images as $key => $image) {
589 589
 				if ($image->file == $filename) {
590 590
 					foreach ($image->set as $imageSetFilename) {
591
-						$destination = $destinationPath . '/' . $imageSetFilename;
591
+						$destination = $destinationPath.'/'.$imageSetFilename;
592 592
 						if (file_exists($destination)) {
593 593
 							unlink($destination);
594 594
 						} else {
@@ -630,7 +630,7 @@  discard block
 block discarded – undo
630 630
 		 */
631 631
 		public function getFiles()
632 632
 		{
633
-			$files =  $this->repository->files;
633
+			$files = $this->repository->files;
634 634
 			usort($files, array($this, 'compareFiles'));
635 635
 			return $files;
636 636
 		}
@@ -642,13 +642,13 @@  discard block
 block discarded – undo
642 642
 
643 643
 		public function addFile($postValues)
644 644
 		{
645
-			$destinationPath = realpath(__DIR__ . '/../../www/files/');
645
+			$destinationPath = realpath(__DIR__.'/../../www/files/');
646 646
 
647 647
 			$filename = $this->validateFilename($postValues['name'], $destinationPath);
648
-			$destination = $destinationPath . '/' . $filename;
648
+			$destination = $destinationPath.'/'.$filename;
649 649
 
650 650
 			if ($postValues['error'] != '0') {
651
-				throw new \Exception('Error uploading file. Error code: ' . $postValues['error']);
651
+				throw new \Exception('Error uploading file. Error code: '.$postValues['error']);
652 652
 			}
653 653
 
654 654
 			if (move_uploaded_file($postValues['tmp_name'], $destination)) {
@@ -674,23 +674,23 @@  discard block
 block discarded – undo
674 674
 				array_pop($fileParts);
675 675
 				$fileNameWithoutExtension = implode('-', $fileParts);
676 676
 				$fileNameWithoutExtension = slugify($fileNameWithoutExtension);
677
-				$filename = $fileNameWithoutExtension . '.' . $extension;
677
+				$filename = $fileNameWithoutExtension.'.'.$extension;
678 678
 			} else {
679 679
 				$filename = slugify($filename);
680 680
 			}
681 681
 
682
-			if (file_exists($path . '/' . $filename)) {
682
+			if (file_exists($path.'/'.$filename)) {
683 683
 				$fileParts = explode('.', $filename);
684 684
 				if (count($fileParts) > 1) {
685 685
 					$extension = end($fileParts);
686 686
 					array_pop($fileParts);
687 687
 					$fileNameWithoutExtension = implode('-', $fileParts);
688 688
 					$fileNameWithoutExtension .= '-copy';
689
-					$filename = $fileNameWithoutExtension . '.' . $extension;
689
+					$filename = $fileNameWithoutExtension.'.'.$extension;
690 690
 				} else {
691 691
 					$filename .= '-copy';
692 692
 				}
693
-				return $this->validateFilename($filename,$path);
693
+				return $this->validateFilename($filename, $path);
694 694
 			}
695 695
 			return $filename;
696 696
 		}
@@ -716,8 +716,8 @@  discard block
 block discarded – undo
716 716
          */
717 717
 		public function deleteFileByName($filename)
718 718
 		{
719
-			$destinationPath = realpath(__DIR__ . '/../../www/files/');
720
-			$destination = $destinationPath . '/' . $filename;
719
+			$destinationPath = realpath(__DIR__.'/../../www/files/');
720
+			$destination = $destinationPath.'/'.$filename;
721 721
 
722 722
 			if (file_exists($destination)) {
723 723
 				$files = $this->getFiles();
Please login to merge, or discard this patch.