Inspection of "Refactored cms routings with some method extractio..." - jenskooij/cloudcontrol - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — develop ( 190495...6fc664 )

by Jens

created 2017-01-30 13:44 UTC

Status

Indentation +14 added lines, -14 removed lines patch added patch discarded remove patch

@@ -14,24 +14,24 @@
 block discarded – undo
 class SitemapRouting implements CmsRouting
 {
 
-    /**
-     * SitemapRouting constructor.
-     * @param \library\cc\Request $request
-     * @param mixed|string $relativeCmsUri
-     * @param CmsComponent $cmsComponent
-     */
-    public function __construct($request, $relativeCmsUri, $cmsComponent)
-    {
-        if ($relativeCmsUri == '/sitemap') {
+	/**
+	 * SitemapRouting constructor.
+	 * @param \library\cc\Request $request
+	 * @param mixed|string $relativeCmsUri
+	 * @param CmsComponent $cmsComponent
+	 */
+	public function __construct($request, $relativeCmsUri, $cmsComponent)
+	{
+		if ($relativeCmsUri == '/sitemap') {
 			$this->overviewRoute($request, $cmsComponent);
-        } elseif ($relativeCmsUri == '/sitemap/new') {
+		} elseif ($relativeCmsUri == '/sitemap/new') {
 			$this->newRoute($request, $cmsComponent);
-        } elseif ($relativeCmsUri == '/sitemap/edit' && isset($request::$get[CmsComponent::GET_PARAMETER_SLUG])) {
+		} elseif ($relativeCmsUri == '/sitemap/edit' && isset($request::$get[CmsComponent::GET_PARAMETER_SLUG])) {
 			$this->editRoute($request, $cmsComponent);
-        } elseif ($relativeCmsUri == '/sitemap/delete' && isset($request::$get[CmsComponent::GET_PARAMETER_SLUG])) {
+		} elseif ($relativeCmsUri == '/sitemap/delete' && isset($request::$get[CmsComponent::GET_PARAMETER_SLUG])) {
 			$this->deleteRoute($request, $cmsComponent);
-        }
-    }
+		}
+	}
 
 	/**
 	 * @param $request

Please login to merge, or discard this patch.

cloudcontrol/library/components/cms/ImagesRouting.php 1 patch

Indentation +15 added lines, -15 removed lines patch added patch discarded remove patch

@@ -13,26 +13,26 @@
 block discarded – undo
 class ImagesRouting implements CmsRouting
 {
 
-    /**
-     * ImagesRouting constructor.
-     * @param \library\cc\Request $request
-     * @param mixed|string $relativeCmsUri
-     * @param CmsComponent $cmsComponent
-     */
-    public function __construct($request, $relativeCmsUri, $cmsComponent)
-    {
-        if ($relativeCmsUri == '/images') {
+	/**
+	 * ImagesRouting constructor.
+	 * @param \library\cc\Request $request
+	 * @param mixed|string $relativeCmsUri
+	 * @param CmsComponent $cmsComponent
+	 */
+	public function __construct($request, $relativeCmsUri, $cmsComponent)
+	{
+		if ($relativeCmsUri == '/images') {
 			$this->overviewRoute($cmsComponent);
-        } elseif ($relativeCmsUri == '/images.json') {
+		} elseif ($relativeCmsUri == '/images.json') {
 			$this->jsonRoute($cmsComponent);
-        } elseif ($relativeCmsUri == '/images/new') {
+		} elseif ($relativeCmsUri == '/images/new') {
 			$this->newRoute($request, $cmsComponent);
-        } elseif ($relativeCmsUri == '/images/delete' && isset($request::$get[CmsComponent::FILES_PARAMETER_FILE])) {
+		} elseif ($relativeCmsUri == '/images/delete' && isset($request::$get[CmsComponent::FILES_PARAMETER_FILE])) {
 			$this->deleteRoute($request, $cmsComponent);
-        } elseif ($relativeCmsUri == '/images/show' && isset($request::$get[CmsComponent::FILES_PARAMETER_FILE])) {
+		} elseif ($relativeCmsUri == '/images/show' && isset($request::$get[CmsComponent::FILES_PARAMETER_FILE])) {
 			$this->showRoute($request, $cmsComponent);
-        }
-    }
+		}
+	}
 
 	/**
 	 * @param $cmsComponent

Please login to merge, or discard this patch.

cloudcontrol/library/components/cms/DocumentRouting.php 1 patch

Indentation +45 added lines, -45 removed lines patch added patch discarded remove patch

@@ -12,58 +12,58 @@
 block discarded – undo
 
 class DocumentRouting implements CmsRouting
 {
-    /**
-     * DocumentRouting constructor.
-     * @param $request
-     * @param $relativeCmsUri
-     * @param CmsComponent $cmsComponent
-     */
-    public function __construct($request, $relativeCmsUri, $cmsComponent)
-    {
-        if ($relativeCmsUri == '/documents') {
-            $cmsComponent->subTemplate = 'cms/documents';
-            $cmsComponent->setParameter(CmsComponent::PARAMETER_DOCUMENTS, $cmsComponent->storage->getDocuments());
-            $cmsComponent->setParameter(CmsComponent::PARAMETER_MAIN_NAV_CLASS, CmsComponent::PARAMETER_DOCUMENTS);
-        }
-        $this->documentRouting($request, $relativeCmsUri, $cmsComponent);
-        $this->folderRouting($request, $relativeCmsUri, $cmsComponent);
-    }
-
-
-    /**
-     * @param $request
-     * @param $relativeCmsUri
-     * @param CmsComponent $cmsComponent
-     * @throws \Exception
-     */
-    private function documentRouting($request, $relativeCmsUri, $cmsComponent)
-    {
-        if ($relativeCmsUri == '/documents/new-document' && isset($request::$get[CmsComponent::GET_PARAMETER_PATH])) {
+	/**
+	 * DocumentRouting constructor.
+	 * @param $request
+	 * @param $relativeCmsUri
+	 * @param CmsComponent $cmsComponent
+	 */
+	public function __construct($request, $relativeCmsUri, $cmsComponent)
+	{
+		if ($relativeCmsUri == '/documents') {
+			$cmsComponent->subTemplate = 'cms/documents';
+			$cmsComponent->setParameter(CmsComponent::PARAMETER_DOCUMENTS, $cmsComponent->storage->getDocuments());
+			$cmsComponent->setParameter(CmsComponent::PARAMETER_MAIN_NAV_CLASS, CmsComponent::PARAMETER_DOCUMENTS);
+		}
+		$this->documentRouting($request, $relativeCmsUri, $cmsComponent);
+		$this->folderRouting($request, $relativeCmsUri, $cmsComponent);
+	}
+
+
+	/**
+	 * @param $request
+	 * @param $relativeCmsUri
+	 * @param CmsComponent $cmsComponent
+	 * @throws \Exception
+	 */
+	private function documentRouting($request, $relativeCmsUri, $cmsComponent)
+	{
+		if ($relativeCmsUri == '/documents/new-document' && isset($request::$get[CmsComponent::GET_PARAMETER_PATH])) {
 			$this->documentOverviewRoute($request, $cmsComponent);
-        } elseif ($relativeCmsUri == '/documents/edit-document' && isset($request::$get[CmsComponent::GET_PARAMETER_SLUG])) {
+		} elseif ($relativeCmsUri == '/documents/edit-document' && isset($request::$get[CmsComponent::GET_PARAMETER_SLUG])) {
 			$this->editDocumentRoute($request, $cmsComponent);
-        } elseif ($relativeCmsUri == '/documents/get-brick' && isset($request::$get[CmsComponent::GET_PARAMETER_SLUG])) {
+		} elseif ($relativeCmsUri == '/documents/get-brick' && isset($request::$get[CmsComponent::GET_PARAMETER_SLUG])) {
 			$this->getBrickRoute($request, $cmsComponent);
-        } else if ($relativeCmsUri == '/documents/delete-document' && isset($request::$get[CmsComponent::GET_PARAMETER_SLUG])) {
+		} else if ($relativeCmsUri == '/documents/delete-document' && isset($request::$get[CmsComponent::GET_PARAMETER_SLUG])) {
 			$this->deleteDocumentRoute($request, $cmsComponent);
-        }
-    }
-
-    /**
-     * @param $request
-     * @param $relativeCmsUri
-     * @param CmsComponent $cmsComponent
-     */
-    private function folderRouting($request, $relativeCmsUri, $cmsComponent)
-    {
-        if ($relativeCmsUri == '/documents/new-folder' && isset($request::$get[CmsComponent::GET_PARAMETER_PATH])) {
+		}
+	}
+
+	/**
+	 * @param $request
+	 * @param $relativeCmsUri
+	 * @param CmsComponent $cmsComponent
+	 */
+	private function folderRouting($request, $relativeCmsUri, $cmsComponent)
+	{
+		if ($relativeCmsUri == '/documents/new-folder' && isset($request::$get[CmsComponent::GET_PARAMETER_PATH])) {
 			$this->newFolderRoute($request, $cmsComponent);
-        } else if ($relativeCmsUri == '/documents/edit-folder' && isset($request::$get[CmsComponent::GET_PARAMETER_SLUG])) {
+		} else if ($relativeCmsUri == '/documents/edit-folder' && isset($request::$get[CmsComponent::GET_PARAMETER_SLUG])) {
 			$this->editFolderRoute($request, $cmsComponent);
-        } else if ($relativeCmsUri == '/documents/delete-folder' && isset($request::$get[CmsComponent::GET_PARAMETER_SLUG])) {
+		} else if ($relativeCmsUri == '/documents/delete-folder' && isset($request::$get[CmsComponent::GET_PARAMETER_SLUG])) {
 			$this->deleteFolderRoute($request, $cmsComponent);
-        }
-    }
+		}
+	}
 
 	/**
 	 * @param $request

Please login to merge, or discard this patch.

		@@ -14,24 +14,24 @@
		block discarded – undo
14	14	class SitemapRouting implements CmsRouting
15	15	{
16	16
17		- /**
18		- * SitemapRouting constructor.
19		- * @param \library\cc\Request $request
20		- * @param mixed\|string $relativeCmsUri
21		- * @param CmsComponent $cmsComponent
22		- */
23		- public function __construct($request, $relativeCmsUri, $cmsComponent)
24		- {
25		- if ($relativeCmsUri == '/sitemap') {
	17	+ /**
	18	+ * SitemapRouting constructor.
	19	+ * @param \library\cc\Request $request
	20	+ * @param mixed\|string $relativeCmsUri
	21	+ * @param CmsComponent $cmsComponent
	22	+ */
	23	+ public function __construct($request, $relativeCmsUri, $cmsComponent)
	24	+ {
	25	+ if ($relativeCmsUri == '/sitemap') {
26	26	$this->overviewRoute($request, $cmsComponent);
27		- } elseif ($relativeCmsUri == '/sitemap/new') {
	27	+ } elseif ($relativeCmsUri == '/sitemap/new') {
28	28	$this->newRoute($request, $cmsComponent);
29		- } elseif ($relativeCmsUri == '/sitemap/edit' && isset($request::$get[CmsComponent::GET_PARAMETER_SLUG])) {
	29	+ } elseif ($relativeCmsUri == '/sitemap/edit' && isset($request::$get[CmsComponent::GET_PARAMETER_SLUG])) {
30	30	$this->editRoute($request, $cmsComponent);
31		- } elseif ($relativeCmsUri == '/sitemap/delete' && isset($request::$get[CmsComponent::GET_PARAMETER_SLUG])) {
	31	+ } elseif ($relativeCmsUri == '/sitemap/delete' && isset($request::$get[CmsComponent::GET_PARAMETER_SLUG])) {
32	32	$this->deleteRoute($request, $cmsComponent);
33		- }
34		- }
	33	+ }
	34	+ }
35	35
36	36	/**
37	37	* @param $request

		@@ -13,26 +13,26 @@
		block discarded – undo
13	13	class ImagesRouting implements CmsRouting
14	14	{
15	15
16		- /**
17		- * ImagesRouting constructor.
18		- * @param \library\cc\Request $request
19		- * @param mixed\|string $relativeCmsUri
20		- * @param CmsComponent $cmsComponent
21		- */
22		- public function __construct($request, $relativeCmsUri, $cmsComponent)
23		- {
24		- if ($relativeCmsUri == '/images') {
	16	+ /**
	17	+ * ImagesRouting constructor.
	18	+ * @param \library\cc\Request $request
	19	+ * @param mixed\|string $relativeCmsUri
	20	+ * @param CmsComponent $cmsComponent
	21	+ */
	22	+ public function __construct($request, $relativeCmsUri, $cmsComponent)
	23	+ {
	24	+ if ($relativeCmsUri == '/images') {
25	25	$this->overviewRoute($cmsComponent);
26		- } elseif ($relativeCmsUri == '/images.json') {
	26	+ } elseif ($relativeCmsUri == '/images.json') {
27	27	$this->jsonRoute($cmsComponent);
28		- } elseif ($relativeCmsUri == '/images/new') {
	28	+ } elseif ($relativeCmsUri == '/images/new') {
29	29	$this->newRoute($request, $cmsComponent);
30		- } elseif ($relativeCmsUri == '/images/delete' && isset($request::$get[CmsComponent::FILES_PARAMETER_FILE])) {
	30	+ } elseif ($relativeCmsUri == '/images/delete' && isset($request::$get[CmsComponent::FILES_PARAMETER_FILE])) {
31	31	$this->deleteRoute($request, $cmsComponent);
32		- } elseif ($relativeCmsUri == '/images/show' && isset($request::$get[CmsComponent::FILES_PARAMETER_FILE])) {
	32	+ } elseif ($relativeCmsUri == '/images/show' && isset($request::$get[CmsComponent::FILES_PARAMETER_FILE])) {
33	33	$this->showRoute($request, $cmsComponent);
34		- }
35		- }
	34	+ }
	35	+ }
36	36
37	37	/**
38	38	* @param $cmsComponent

		@@ -12,58 +12,58 @@
		block discarded – undo
12	12
13	13	class DocumentRouting implements CmsRouting
14	14	{
15		- /**
16		- * DocumentRouting constructor.
17		- * @param $request
18		- * @param $relativeCmsUri
19		- * @param CmsComponent $cmsComponent
20		- */
21		- public function __construct($request, $relativeCmsUri, $cmsComponent)
22		- {
23		- if ($relativeCmsUri == '/documents') {
24		- $cmsComponent->subTemplate = 'cms/documents';
25		- $cmsComponent->setParameter(CmsComponent::PARAMETER_DOCUMENTS, $cmsComponent->storage->getDocuments());
26		- $cmsComponent->setParameter(CmsComponent::PARAMETER_MAIN_NAV_CLASS, CmsComponent::PARAMETER_DOCUMENTS);
27		- }
28		- $this->documentRouting($request, $relativeCmsUri, $cmsComponent);
29		- $this->folderRouting($request, $relativeCmsUri, $cmsComponent);
30		- }
31		-
32		-
33		- /**
34		- * @param $request
35		- * @param $relativeCmsUri
36		- * @param CmsComponent $cmsComponent
37		- * @throws \Exception
38		- */
39		- private function documentRouting($request, $relativeCmsUri, $cmsComponent)
40		- {
41		- if ($relativeCmsUri == '/documents/new-document' && isset($request::$get[CmsComponent::GET_PARAMETER_PATH])) {
	15	+ /**
	16	+ * DocumentRouting constructor.
	17	+ * @param $request
	18	+ * @param $relativeCmsUri
	19	+ * @param CmsComponent $cmsComponent
	20	+ */
	21	+ public function __construct($request, $relativeCmsUri, $cmsComponent)
	22	+ {
	23	+ if ($relativeCmsUri == '/documents') {
	24	+ $cmsComponent->subTemplate = 'cms/documents';
	25	+ $cmsComponent->setParameter(CmsComponent::PARAMETER_DOCUMENTS, $cmsComponent->storage->getDocuments());
	26	+ $cmsComponent->setParameter(CmsComponent::PARAMETER_MAIN_NAV_CLASS, CmsComponent::PARAMETER_DOCUMENTS);
	27	+ }
	28	+ $this->documentRouting($request, $relativeCmsUri, $cmsComponent);
	29	+ $this->folderRouting($request, $relativeCmsUri, $cmsComponent);
	30	+ }
	31	+
	32	+
	33	+ /**
	34	+ * @param $request
	35	+ * @param $relativeCmsUri
	36	+ * @param CmsComponent $cmsComponent
	37	+ * @throws \Exception
	38	+ */
	39	+ private function documentRouting($request, $relativeCmsUri, $cmsComponent)
	40	+ {
	41	+ if ($relativeCmsUri == '/documents/new-document' && isset($request::$get[CmsComponent::GET_PARAMETER_PATH])) {
42	42	$this->documentOverviewRoute($request, $cmsComponent);
43		- } elseif ($relativeCmsUri == '/documents/edit-document' && isset($request::$get[CmsComponent::GET_PARAMETER_SLUG])) {
	43	+ } elseif ($relativeCmsUri == '/documents/edit-document' && isset($request::$get[CmsComponent::GET_PARAMETER_SLUG])) {
44	44	$this->editDocumentRoute($request, $cmsComponent);
45		- } elseif ($relativeCmsUri == '/documents/get-brick' && isset($request::$get[CmsComponent::GET_PARAMETER_SLUG])) {
	45	+ } elseif ($relativeCmsUri == '/documents/get-brick' && isset($request::$get[CmsComponent::GET_PARAMETER_SLUG])) {
46	46	$this->getBrickRoute($request, $cmsComponent);
47		- } else if ($relativeCmsUri == '/documents/delete-document' && isset($request::$get[CmsComponent::GET_PARAMETER_SLUG])) {
	47	+ } else if ($relativeCmsUri == '/documents/delete-document' && isset($request::$get[CmsComponent::GET_PARAMETER_SLUG])) {
48	48	$this->deleteDocumentRoute($request, $cmsComponent);
49		- }
50		- }
51		-
52		- /**
53		- * @param $request
54		- * @param $relativeCmsUri
55		- * @param CmsComponent $cmsComponent
56		- */
57		- private function folderRouting($request, $relativeCmsUri, $cmsComponent)
58		- {
59		- if ($relativeCmsUri == '/documents/new-folder' && isset($request::$get[CmsComponent::GET_PARAMETER_PATH])) {
	49	+ }
	50	+ }
	51	+
	52	+ /**
	53	+ * @param $request
	54	+ * @param $relativeCmsUri
	55	+ * @param CmsComponent $cmsComponent
	56	+ */
	57	+ private function folderRouting($request, $relativeCmsUri, $cmsComponent)
	58	+ {
	59	+ if ($relativeCmsUri == '/documents/new-folder' && isset($request::$get[CmsComponent::GET_PARAMETER_PATH])) {
60	60	$this->newFolderRoute($request, $cmsComponent);
61		- } else if ($relativeCmsUri == '/documents/edit-folder' && isset($request::$get[CmsComponent::GET_PARAMETER_SLUG])) {
	61	+ } else if ($relativeCmsUri == '/documents/edit-folder' && isset($request::$get[CmsComponent::GET_PARAMETER_SLUG])) {
62	62	$this->editFolderRoute($request, $cmsComponent);
63		- } else if ($relativeCmsUri == '/documents/delete-folder' && isset($request::$get[CmsComponent::GET_PARAMETER_SLUG])) {
	63	+ } else if ($relativeCmsUri == '/documents/delete-folder' && isset($request::$get[CmsComponent::GET_PARAMETER_SLUG])) {
64	64	$this->deleteFolderRoute($request, $cmsComponent);
65		- }
66		- }
	65	+ }
	66	+ }
67	67
68	68	/**
69	69	* @param $request

jenskooij / cloudcontrol

Push — develop ( 190495...6fc664 )

Status

Category

Indentation +14 added lines, -14 removed lines patch added patch discarded remove patch

Indentation +15 added lines, -15 removed lines patch added patch discarded remove patch

Indentation +45 added lines, -45 removed lines patch added patch discarded remove patch