Inspection of "Implemented the FormComponent" - jenskooij/cloudcontrol - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — develop ( bfc038...8eb1da )

by Jens

created 2016-05-11 10:17 UTC

Status

Indentation +121 added lines, -121 removed lines patch added patch discarded remove patch

@@ -14,125 +14,125 @@
 block discarded – undo
 
 class FormComponent Extends BaseComponent
 {
-    protected $documentType = null;
-    protected $responseFolder = null;
-    protected $subTemplate = 'cms/documents/document-form-form';
-    protected $formParameterName = 'form';
-    protected $thankYouMessage = 'Thank you for sending us your response.';
-
-    private $formId;
-    private $getPathBackup = null;
-
-    public function run(Storage $storage)
-    {
-        parent::run($storage);
-
-        $this->checkParameters();
-
-        if ($this->documentType === null || $this->responseFolder === null) {
-            throw new \Exception('Parameters `documentType` and `responseFolder` are required for usage with this form');
-        }
-
-        $this->setFormId();
-        $this->initialize($storage);
-        $this->checkSubmit($storage);
-    }
-
-    public function render($application = null)
-    {
-        $request = $this->request;
-        if (isset($request::$get['path'])) {
-            $this->getPathBackup = $request::$get['path'];
-        }
-        $request::$get['path'] = $this->responseFolder;
-        $form = $this->renderTemplate($this->subTemplate);
-        if ($this->getPathBackup !== null) {
-            $request::$get['path'] = $this->getPathBackup;
-        } else {
-            unset($request::$get['path']);
-        }
-        if (!empty($request::$post) && isset($request::$post['formId']) && $request::$post['formId'] === $this->formId && isset($_SESSION['FormComponent'][$this->formParameterName]) && $_SESSION['FormComponent'][$this->formParameterName] === $this->formId) {
-            $this->parameters[$this->formParameterName] = $this->thankYouMessage;
-        } else {
-            $this->parameters[$this->formParameterName] = $form;
-        }
-
-        parent::render($application);
-    }
-
-    private function checkParameters()
-    {
-        if (isset($this->parameters['documentType'])) {
-            $this->documentType = $this->parameters['documentType'];
-            unset($this->parameters['documentType']);
-        }
-
-        if (isset($this->parameters['responseFolder'])) {
-            $this->responseFolder = $this->parameters['responseFolder'];
-            unset($this->parameters['responseFolder']);
-        }
-
-        if (isset($this->parameters['subTemplate'])) {
-            $this->subTemplate = $this->parameters['subTemplate'];
-            unset($this->parameters['subTemplate']);
-        }
-
-        if (isset($this->parameters['formParameterName'])) {
-            $this->formParameterName = $this->parameters['formParameterName'];
-            unset($this->parameters['formParameterName']);
-        }
-
-        if (isset($this->parameters['thankYouMessage'])) {
-            $this->thankYouMessage = $this->parameters['thankYouMessage'];
-            unset($this->parameters['thankYouMessage']);
-        }
-    }
-
-    private function initialize($storage)
-    {
-        $this->parameters['smallestImage'] = $storage->getSmallestImageSet()->slug;
-        $this->parameters['cmsPrefix'] = '';
-
-        $this->parameters['documentType'] = $this->storage->getDocumentTypeBySlug($this->documentType, true);
-        $this->parameters['documentTypes'] = $this->storage->getDocumentTypes();
-        $this->parameters['hideTitleAndState'] = true;
-        $this->parameters['formId'] = $this->formId;
-    }
-
-    private function checkSubmit($storage)
-    {
-        $request = $this->request;
-        if (!empty($request::$post) && isset($request::$post['formId']) && $request::$post['formId'] === $this->formId && isset($_SESSION['FormComponent'][$this->formParameterName]) && $_SESSION['FormComponent'][$this->formParameterName] === $this->formId) {
-            $postValues = $request::$post;
-            $postValues['documentType'] = $this->documentType;
-            $postValues['path'] = $this->responseFolder;
-            $postValues['title'] = date('r') . ' - From: ' . $request::$requestUri;
-
-            $backup = null;
-            if (isset($_SESSION['cloudcontrol'])) {
-                $backup = $_SESSION['cloudcontrol'];
-            }
-            $fakeUser = new \stdClass();
-            $fakeUser->username = 'FormComponent';
-            $_SESSION['cloudcontrol'] = $fakeUser;
-
-            $storage->addDocument($postValues);
-
-            if ($backup === null) {
-                unset($_SESSION['cloudcontrol']);
-            } else {
-                $_SESSION['cloudcontrol'] = $backup;
-            }
-        }
-    }
-
-    private function setFormId()
-    {
-        if (isset($_SESSION['FormComponent'][$this->formParameterName])) {
-            $this->formId = $_SESSION['FormComponent'][$this->formParameterName];
-        } else {
-            $_SESSION['FormComponent'][$this->formParameterName] = (string) microtime(true);
-            $this->formId = $_SESSION['FormComponent'][$this->formParameterName];
-        }
-    }
+	protected $documentType = null;
+	protected $responseFolder = null;
+	protected $subTemplate = 'cms/documents/document-form-form';
+	protected $formParameterName = 'form';
+	protected $thankYouMessage = 'Thank you for sending us your response.';
+
+	private $formId;
+	private $getPathBackup = null;
+
+	public function run(Storage $storage)
+	{
+		parent::run($storage);
+
+		$this->checkParameters();
+
+		if ($this->documentType === null || $this->responseFolder === null) {
+			throw new \Exception('Parameters `documentType` and `responseFolder` are required for usage with this form');
+		}
+
+		$this->setFormId();
+		$this->initialize($storage);
+		$this->checkSubmit($storage);
+	}
+
+	public function render($application = null)
+	{
+		$request = $this->request;
+		if (isset($request::$get['path'])) {
+			$this->getPathBackup = $request::$get['path'];
+		}
+		$request::$get['path'] = $this->responseFolder;
+		$form = $this->renderTemplate($this->subTemplate);
+		if ($this->getPathBackup !== null) {
+			$request::$get['path'] = $this->getPathBackup;
+		} else {
+			unset($request::$get['path']);
+		}
+		if (!empty($request::$post) && isset($request::$post['formId']) && $request::$post['formId'] === $this->formId && isset($_SESSION['FormComponent'][$this->formParameterName]) && $_SESSION['FormComponent'][$this->formParameterName] === $this->formId) {
+			$this->parameters[$this->formParameterName] = $this->thankYouMessage;
+		} else {
+			$this->parameters[$this->formParameterName] = $form;
+		}
+
+		parent::render($application);
+	}
+
+	private function checkParameters()
+	{
+		if (isset($this->parameters['documentType'])) {
+			$this->documentType = $this->parameters['documentType'];
+			unset($this->parameters['documentType']);
+		}
+
+		if (isset($this->parameters['responseFolder'])) {
+			$this->responseFolder = $this->parameters['responseFolder'];
+			unset($this->parameters['responseFolder']);
+		}
+
+		if (isset($this->parameters['subTemplate'])) {
+			$this->subTemplate = $this->parameters['subTemplate'];
+			unset($this->parameters['subTemplate']);
+		}
+
+		if (isset($this->parameters['formParameterName'])) {
+			$this->formParameterName = $this->parameters['formParameterName'];
+			unset($this->parameters['formParameterName']);
+		}
+
+		if (isset($this->parameters['thankYouMessage'])) {
+			$this->thankYouMessage = $this->parameters['thankYouMessage'];
+			unset($this->parameters['thankYouMessage']);
+		}
+	}
+
+	private function initialize($storage)
+	{
+		$this->parameters['smallestImage'] = $storage->getSmallestImageSet()->slug;
+		$this->parameters['cmsPrefix'] = '';
+
+		$this->parameters['documentType'] = $this->storage->getDocumentTypeBySlug($this->documentType, true);
+		$this->parameters['documentTypes'] = $this->storage->getDocumentTypes();
+		$this->parameters['hideTitleAndState'] = true;
+		$this->parameters['formId'] = $this->formId;
+	}
+
+	private function checkSubmit($storage)
+	{
+		$request = $this->request;
+		if (!empty($request::$post) && isset($request::$post['formId']) && $request::$post['formId'] === $this->formId && isset($_SESSION['FormComponent'][$this->formParameterName]) && $_SESSION['FormComponent'][$this->formParameterName] === $this->formId) {
+			$postValues = $request::$post;
+			$postValues['documentType'] = $this->documentType;
+			$postValues['path'] = $this->responseFolder;
+			$postValues['title'] = date('r') . ' - From: ' . $request::$requestUri;
+
+			$backup = null;
+			if (isset($_SESSION['cloudcontrol'])) {
+				$backup = $_SESSION['cloudcontrol'];
+			}
+			$fakeUser = new \stdClass();
+			$fakeUser->username = 'FormComponent';
+			$_SESSION['cloudcontrol'] = $fakeUser;
+
+			$storage->addDocument($postValues);
+
+			if ($backup === null) {
+				unset($_SESSION['cloudcontrol']);
+			} else {
+				$_SESSION['cloudcontrol'] = $backup;
+			}
+		}
+	}
+
+	private function setFormId()
+	{
+		if (isset($_SESSION['FormComponent'][$this->formParameterName])) {
+			$this->formId = $_SESSION['FormComponent'][$this->formParameterName];
+		} else {
+			$_SESSION['FormComponent'][$this->formParameterName] = (string) microtime(true);
+			$this->formId = $_SESSION['FormComponent'][$this->formParameterName];
+		}
+	}
 }
\ No newline at end of file

Please login to merge, or discard this patch.

		@@ -14,125 +14,125 @@
		block discarded – undo
14	14
15	15	class FormComponent Extends BaseComponent
16	16	{
17		- protected $documentType = null;
18		- protected $responseFolder = null;
19		- protected $subTemplate = 'cms/documents/document-form-form';
20		- protected $formParameterName = 'form';
21		- protected $thankYouMessage = 'Thank you for sending us your response.';
22		-
23		- private $formId;
24		- private $getPathBackup = null;
25		-
26		- public function run(Storage $storage)
27		- {
28		- parent::run($storage);
29		-
30		- $this->checkParameters();
31		-
32		- if ($this->documentType === null \|\| $this->responseFolder === null) {
33		- throw new \Exception('Parameters `documentType` and `responseFolder` are required for usage with this form');
34		- }
35		-
36		- $this->setFormId();
37		- $this->initialize($storage);
38		- $this->checkSubmit($storage);
39		- }
40		-
41		- public function render($application = null)
42		- {
43		- $request = $this->request;
44		- if (isset($request::$get['path'])) {
45		- $this->getPathBackup = $request::$get['path'];
46		- }
47		- $request::$get['path'] = $this->responseFolder;
48		- $form = $this->renderTemplate($this->subTemplate);
49		- if ($this->getPathBackup !== null) {
50		- $request::$get['path'] = $this->getPathBackup;
51		- } else {
52		- unset($request::$get['path']);
53		- }
54		- if (!empty($request::$post) && isset($request::$post['formId']) && $request::$post['formId'] === $this->formId && isset($_SESSION['FormComponent'][$this->formParameterName]) && $_SESSION['FormComponent'][$this->formParameterName] === $this->formId) {
55		- $this->parameters[$this->formParameterName] = $this->thankYouMessage;
56		- } else {
57		- $this->parameters[$this->formParameterName] = $form;
58		- }
59		-
60		- parent::render($application);
61		- }
62		-
63		- private function checkParameters()
64		- {
65		- if (isset($this->parameters['documentType'])) {
66		- $this->documentType = $this->parameters['documentType'];
67		- unset($this->parameters['documentType']);
68		- }
69		-
70		- if (isset($this->parameters['responseFolder'])) {
71		- $this->responseFolder = $this->parameters['responseFolder'];
72		- unset($this->parameters['responseFolder']);
73		- }
74		-
75		- if (isset($this->parameters['subTemplate'])) {
76		- $this->subTemplate = $this->parameters['subTemplate'];
77		- unset($this->parameters['subTemplate']);
78		- }
79		-
80		- if (isset($this->parameters['formParameterName'])) {
81		- $this->formParameterName = $this->parameters['formParameterName'];
82		- unset($this->parameters['formParameterName']);
83		- }
84		-
85		- if (isset($this->parameters['thankYouMessage'])) {
86		- $this->thankYouMessage = $this->parameters['thankYouMessage'];
87		- unset($this->parameters['thankYouMessage']);
88		- }
89		- }
90		-
91		- private function initialize($storage)
92		- {
93		- $this->parameters['smallestImage'] = $storage->getSmallestImageSet()->slug;
94		- $this->parameters['cmsPrefix'] = '';
95		-
96		- $this->parameters['documentType'] = $this->storage->getDocumentTypeBySlug($this->documentType, true);
97		- $this->parameters['documentTypes'] = $this->storage->getDocumentTypes();
98		- $this->parameters['hideTitleAndState'] = true;
99		- $this->parameters['formId'] = $this->formId;
100		- }
101		-
102		- private function checkSubmit($storage)
103		- {
104		- $request = $this->request;
105		- if (!empty($request::$post) && isset($request::$post['formId']) && $request::$post['formId'] === $this->formId && isset($_SESSION['FormComponent'][$this->formParameterName]) && $_SESSION['FormComponent'][$this->formParameterName] === $this->formId) {
106		- $postValues = $request::$post;
107		- $postValues['documentType'] = $this->documentType;
108		- $postValues['path'] = $this->responseFolder;
109		- $postValues['title'] = date('r') . ' - From: ' . $request::$requestUri;
110		-
111		- $backup = null;
112		- if (isset($_SESSION['cloudcontrol'])) {
113		- $backup = $_SESSION['cloudcontrol'];
114		- }
115		- $fakeUser = new \stdClass();
116		- $fakeUser->username = 'FormComponent';
117		- $_SESSION['cloudcontrol'] = $fakeUser;
118		-
119		- $storage->addDocument($postValues);
120		-
121		- if ($backup === null) {
122		- unset($_SESSION['cloudcontrol']);
123		- } else {
124		- $_SESSION['cloudcontrol'] = $backup;
125		- }
126		- }
127		- }
128		-
129		- private function setFormId()
130		- {
131		- if (isset($_SESSION['FormComponent'][$this->formParameterName])) {
132		- $this->formId = $_SESSION['FormComponent'][$this->formParameterName];
133		- } else {
134		- $_SESSION['FormComponent'][$this->formParameterName] = (string) microtime(true);
135		- $this->formId = $_SESSION['FormComponent'][$this->formParameterName];
136		- }
137		- }
	17	+ protected $documentType = null;
	18	+ protected $responseFolder = null;
	19	+ protected $subTemplate = 'cms/documents/document-form-form';
	20	+ protected $formParameterName = 'form';
	21	+ protected $thankYouMessage = 'Thank you for sending us your response.';
	22	+
	23	+ private $formId;
	24	+ private $getPathBackup = null;
	25	+
	26	+ public function run(Storage $storage)
	27	+ {
	28	+ parent::run($storage);
	29	+
	30	+ $this->checkParameters();
	31	+
	32	+ if ($this->documentType === null \|\| $this->responseFolder === null) {
	33	+ throw new \Exception('Parameters `documentType` and `responseFolder` are required for usage with this form');
	34	+ }
	35	+
	36	+ $this->setFormId();
	37	+ $this->initialize($storage);
	38	+ $this->checkSubmit($storage);
	39	+ }
	40	+
	41	+ public function render($application = null)
	42	+ {
	43	+ $request = $this->request;
	44	+ if (isset($request::$get['path'])) {
	45	+ $this->getPathBackup = $request::$get['path'];
	46	+ }
	47	+ $request::$get['path'] = $this->responseFolder;
	48	+ $form = $this->renderTemplate($this->subTemplate);
	49	+ if ($this->getPathBackup !== null) {
	50	+ $request::$get['path'] = $this->getPathBackup;
	51	+ } else {
	52	+ unset($request::$get['path']);
	53	+ }
	54	+ if (!empty($request::$post) && isset($request::$post['formId']) && $request::$post['formId'] === $this->formId && isset($_SESSION['FormComponent'][$this->formParameterName]) && $_SESSION['FormComponent'][$this->formParameterName] === $this->formId) {
	55	+ $this->parameters[$this->formParameterName] = $this->thankYouMessage;
	56	+ } else {
	57	+ $this->parameters[$this->formParameterName] = $form;
	58	+ }
	59	+
	60	+ parent::render($application);
	61	+ }
	62	+
	63	+ private function checkParameters()
	64	+ {
	65	+ if (isset($this->parameters['documentType'])) {
	66	+ $this->documentType = $this->parameters['documentType'];
	67	+ unset($this->parameters['documentType']);
	68	+ }
	69	+
	70	+ if (isset($this->parameters['responseFolder'])) {
	71	+ $this->responseFolder = $this->parameters['responseFolder'];
	72	+ unset($this->parameters['responseFolder']);
	73	+ }
	74	+
	75	+ if (isset($this->parameters['subTemplate'])) {
	76	+ $this->subTemplate = $this->parameters['subTemplate'];
	77	+ unset($this->parameters['subTemplate']);
	78	+ }
	79	+
	80	+ if (isset($this->parameters['formParameterName'])) {
	81	+ $this->formParameterName = $this->parameters['formParameterName'];
	82	+ unset($this->parameters['formParameterName']);
	83	+ }
	84	+
	85	+ if (isset($this->parameters['thankYouMessage'])) {
	86	+ $this->thankYouMessage = $this->parameters['thankYouMessage'];
	87	+ unset($this->parameters['thankYouMessage']);
	88	+ }
	89	+ }
	90	+
	91	+ private function initialize($storage)
	92	+ {
	93	+ $this->parameters['smallestImage'] = $storage->getSmallestImageSet()->slug;
	94	+ $this->parameters['cmsPrefix'] = '';
	95	+
	96	+ $this->parameters['documentType'] = $this->storage->getDocumentTypeBySlug($this->documentType, true);
	97	+ $this->parameters['documentTypes'] = $this->storage->getDocumentTypes();
	98	+ $this->parameters['hideTitleAndState'] = true;
	99	+ $this->parameters['formId'] = $this->formId;
	100	+ }
	101	+
	102	+ private function checkSubmit($storage)
	103	+ {
	104	+ $request = $this->request;
	105	+ if (!empty($request::$post) && isset($request::$post['formId']) && $request::$post['formId'] === $this->formId && isset($_SESSION['FormComponent'][$this->formParameterName]) && $_SESSION['FormComponent'][$this->formParameterName] === $this->formId) {
	106	+ $postValues = $request::$post;
	107	+ $postValues['documentType'] = $this->documentType;
	108	+ $postValues['path'] = $this->responseFolder;
	109	+ $postValues['title'] = date('r') . ' - From: ' . $request::$requestUri;
	110	+
	111	+ $backup = null;
	112	+ if (isset($_SESSION['cloudcontrol'])) {
	113	+ $backup = $_SESSION['cloudcontrol'];
	114	+ }
	115	+ $fakeUser = new \stdClass();
	116	+ $fakeUser->username = 'FormComponent';
	117	+ $_SESSION['cloudcontrol'] = $fakeUser;
	118	+
	119	+ $storage->addDocument($postValues);
	120	+
	121	+ if ($backup === null) {
	122	+ unset($_SESSION['cloudcontrol']);
	123	+ } else {
	124	+ $_SESSION['cloudcontrol'] = $backup;
	125	+ }
	126	+ }
	127	+ }
	128	+
	129	+ private function setFormId()
	130	+ {
	131	+ if (isset($_SESSION['FormComponent'][$this->formParameterName])) {
	132	+ $this->formId = $_SESSION['FormComponent'][$this->formParameterName];
	133	+ } else {
	134	+ $_SESSION['FormComponent'][$this->formParameterName] = (string) microtime(true);
	135	+ $this->formId = $_SESSION['FormComponent'][$this->formParameterName];
	136	+ }
	137	+ }
138	138	}
139	139	\ No newline at end of file

jenskooij / cloudcontrol

Push — develop ( bfc038...8eb1da )

Status

Category

Indentation +121 added lines, -121 removed lines patch added patch discarded remove patch