Passed
Push — develop ( 64b408...917e37 )
by Jens
02:16
created
cloudcontrol/library/components/cms/ImagesRouting.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -34,12 +34,12 @@
 block discarded – undo
34 34
             $cmsComponent->setParameter(CmsComponent::PARAMETER_MAIN_NAV_CLASS, CmsComponent::PARAMETER_IMAGES);
35 35
             if (isset($_FILES[CmsComponent::FILES_PARAMETER_FILE])) {
36 36
                 $cmsComponent->storage->addImage($_FILES[CmsComponent::FILES_PARAMETER_FILE]);
37
-                header('Location: ' . $request::$subfolders . $cmsComponent->getParameter(CmsComponent::PARAMETER_CMS_PREFIX) . '/images');
37
+                header('Location: '.$request::$subfolders.$cmsComponent->getParameter(CmsComponent::PARAMETER_CMS_PREFIX).'/images');
38 38
                 exit;
39 39
             }
40 40
         } elseif ($relativeCmsUri == '/images/delete' && isset($request::$get[CmsComponent::FILES_PARAMETER_FILE])) {
41 41
             $cmsComponent->storage->deleteImageByName($request::$get[CmsComponent::FILES_PARAMETER_FILE]);
42
-            header('Location: ' . $request::$subfolders . $cmsComponent->getParameter(CmsComponent::PARAMETER_CMS_PREFIX) . '/images');
42
+            header('Location: '.$request::$subfolders.$cmsComponent->getParameter(CmsComponent::PARAMETER_CMS_PREFIX).'/images');
43 43
             exit;
44 44
         } elseif ($relativeCmsUri == '/images/show' && isset($request::$get[CmsComponent::FILES_PARAMETER_FILE])) {
45 45
             $cmsComponent->subTemplate = 'cms/images/show';
Please login to merge, or discard this patch.
cloudcontrol/library/components/CmsComponent.php 1 patch
Spacing   +30 added lines, -30 removed lines patch added patch discarded remove patch
@@ -191,7 +191,7 @@  discard block
 block discarded – undo
191 191
                 $whitelistIps = explode(',', $this->parameters[self::PARAMETER_WHITELIST_IPS]);
192 192
                 $whitelistIps = array_map("trim", $whitelistIps);
193 193
                 if (!in_array($remoteAddress, $whitelistIps)) {
194
-                    throw new \Exception('Ip address ' . $remoteAddress . ' is not on whitelist');
194
+                    throw new \Exception('Ip address '.$remoteAddress.' is not on whitelist');
195 195
                 }
196 196
             }
197 197
         }
@@ -206,7 +206,7 @@  discard block
 block discarded – undo
206 206
                 $blacklistIps = explode(',', $this->parameters[self::PARAMETER_BLACKLIST_IPS]);
207 207
                 $blacklistIps = array_map("trim", $blacklistIps);
208 208
                 if (in_array($remoteAddress, $blacklistIps)) {
209
-                    throw new \Exception('Ip address ' . $remoteAddress . ' is on blacklist');
209
+                    throw new \Exception('Ip address '.$remoteAddress.' is on blacklist');
210 210
                 }
211 211
             }
212 212
         }
@@ -244,7 +244,7 @@  discard block
 block discarded – undo
244 244
                 $this->parameters[self::PARAMETER_MAIN_NAV_CLASS] = self::PARAMETER_SITEMAP;
245 245
                 if (isset($request::$post[self::POST_PARAMETER_TITLE], $request::$post[self::POST_PARAMETER_TEMPLATE], $request::$post[self::POST_PARAMETER_COMPONENT])) {
246 246
                     $this->storage->addSitemapItem($request::$post);
247
-                    header('Location: ' . $request::$subfolders . $this->parameters[self::PARAMETER_CMS_PREFIX] . '/sitemap');
247
+                    header('Location: '.$request::$subfolders.$this->parameters[self::PARAMETER_CMS_PREFIX].'/sitemap');
248 248
                     exit;
249 249
                 }
250 250
             } elseif ($relativeCmsUri == '/sitemap/edit' && isset($request::$get[self::GET_PARAMETER_SLUG])) {
@@ -253,13 +253,13 @@  discard block
 block discarded – undo
253 253
                 $sitemapItem = $this->storage->getSitemapItemBySlug($request::$get[self::GET_PARAMETER_SLUG]);
254 254
                 if (isset($request::$post[self::POST_PARAMETER_TITLE], $request::$post[self::POST_PARAMETER_TEMPLATE], $request::$post[self::POST_PARAMETER_COMPONENT])) {
255 255
                     $this->storage->saveSitemapItem($request::$get[self::GET_PARAMETER_SLUG], $request::$post);
256
-                    header('Location: ' . $request::$subfolders . $this->parameters[self::PARAMETER_CMS_PREFIX] . '/sitemap');
256
+                    header('Location: '.$request::$subfolders.$this->parameters[self::PARAMETER_CMS_PREFIX].'/sitemap');
257 257
                     exit;
258 258
                 }
259 259
                 $this->parameters[self::PARAMETER_SITEMAP_ITEM] = $sitemapItem;
260 260
             } elseif ($relativeCmsUri == '/sitemap/delete' && isset($request::$get[self::GET_PARAMETER_SLUG])) {
261 261
                 $this->storage->deleteSitemapItemBySlug($request::$get[self::GET_PARAMETER_SLUG]);
262
-                header('Location: ' . $request::$subfolders . $this->parameters[self::PARAMETER_CMS_PREFIX] . '/sitemap');
262
+                header('Location: '.$request::$subfolders.$this->parameters[self::PARAMETER_CMS_PREFIX].'/sitemap');
263 263
                 exit;
264 264
             }
265 265
         }
@@ -296,14 +296,14 @@  discard block
 block discarded – undo
296 296
                 $this->parameters[self::PARAMETER_MAIN_NAV_CLASS] = self::PARAMETER_FILES;
297 297
                 if (isset($_FILES[self::FILES_PARAMETER_FILE])) {
298 298
                     $this->storage->addFile($_FILES[self::FILES_PARAMETER_FILE]);
299
-                    header('Location: ' . $request::$subfolders . $this->parameters[self::PARAMETER_CMS_PREFIX] . '/files');
299
+                    header('Location: '.$request::$subfolders.$this->parameters[self::PARAMETER_CMS_PREFIX].'/files');
300 300
                     exit;
301 301
                 }
302 302
             } elseif ($relativeCmsUri == '/files/get' && isset($request::$get[self::FILES_PARAMETER_FILE])) {
303 303
                 $this->downloadFile($request::$get[self::FILES_PARAMETER_FILE]);
304 304
             } elseif ($relativeCmsUri == '/files/delete' && isset($request::$get[self::FILES_PARAMETER_FILE])) {
305 305
                 $this->storage->deleteFileByName($request::$get[self::FILES_PARAMETER_FILE]);
306
-                header('Location: ' . $request::$subfolders . $this->parameters[self::PARAMETER_CMS_PREFIX] . '/files');
306
+                header('Location: '.$request::$subfolders.$this->parameters[self::PARAMETER_CMS_PREFIX].'/files');
307 307
                 exit;
308 308
             }
309 309
         }
@@ -314,21 +314,21 @@  discard block
 block discarded – undo
314 314
         private function downloadFile($slug)
315 315
         {
316 316
             $file = $this->storage->getFileByName($slug);
317
-            $path = realpath(__DIR__ . '/../../www/files/');
318
-            $quoted = sprintf('"%s"', addcslashes(basename($path . '/' . $file->file), '"\\'));
319
-            $size = filesize($path . '/' . $file->file);
317
+            $path = realpath(__DIR__.'/../../www/files/');
318
+            $quoted = sprintf('"%s"', addcslashes(basename($path.'/'.$file->file), '"\\'));
319
+            $size = filesize($path.'/'.$file->file);
320 320
 
321 321
             header('Content-Description: File Transfer');
322
-            header('Content-Type: ' . $file->type);
323
-            header('Content-Disposition: attachment; filename=' . $quoted);
322
+            header('Content-Type: '.$file->type);
323
+            header('Content-Disposition: attachment; filename='.$quoted);
324 324
             header('Content-Transfer-Encoding: binary');
325 325
             header('Connection: Keep-Alive');
326 326
             header('Expires: 0');
327 327
             header('Cache-Control: must-revalidate, post-check=0, pre-check=0');
328 328
             header('Pragma: public');
329
-            header('Content-Length: ' . $size);
329
+            header('Content-Length: '.$size);
330 330
 
331
-            readfile($path . '/' . $file->file);
331
+            readfile($path.'/'.$file->file);
332 332
             exit;
333 333
         }
334 334
 
@@ -366,12 +366,12 @@  discard block
 block discarded – undo
366 366
                 $this->parameters[self::PARAMETER_MAIN_NAV_CLASS] = 'configuration';
367 367
                 if (isset($_POST[self::POST_PARAMETER_USERNAME])) {
368 368
                     $this->storage->addUser($request::$post);
369
-                    header('Location: ' . $request::$subfolders . $this->parameters[self::PARAMETER_CMS_PREFIX] . '/configuration/users');
369
+                    header('Location: '.$request::$subfolders.$this->parameters[self::PARAMETER_CMS_PREFIX].'/configuration/users');
370 370
                     exit;
371 371
                 }
372 372
             } elseif ($relativeCmsUri == '/configuration/users/delete' && isset($request::$get[self::GET_PARAMETER_SLUG])) {
373 373
                 $this->storage->deleteUserBySlug($request::$get[self::GET_PARAMETER_SLUG]);
374
-                header('Location: ' . $request::$subfolders . $this->parameters[self::PARAMETER_CMS_PREFIX] . '/configuration/users');
374
+                header('Location: '.$request::$subfolders.$this->parameters[self::PARAMETER_CMS_PREFIX].'/configuration/users');
375 375
                 exit;
376 376
             } elseif ($relativeCmsUri == '/configuration/users/edit' && isset($request::$get[self::GET_PARAMETER_SLUG])) {
377 377
                 $this->subTemplate = 'cms/configuration/users-form';
@@ -379,7 +379,7 @@  discard block
 block discarded – undo
379 379
                 $this->parameters[self::PARAMETER_USER] = $this->storage->getUserBySlug($request::$get[self::GET_PARAMETER_SLUG]);
380 380
                 if (isset($_POST[self::POST_PARAMETER_USERNAME])) {
381 381
                     $this->storage->saveUser($request::$get[self::GET_PARAMETER_SLUG], $request::$post);
382
-                    header('Location: ' . $request::$subfolders . $this->parameters[self::PARAMETER_CMS_PREFIX] . '/configuration/users');
382
+                    header('Location: '.$request::$subfolders.$this->parameters[self::PARAMETER_CMS_PREFIX].'/configuration/users');
383 383
                     exit;
384 384
                 }
385 385
             }
@@ -401,7 +401,7 @@  discard block
 block discarded – undo
401 401
                 $bricks = $this->storage->getBricks();
402 402
                 if (isset($request::$post[self::POST_PARAMETER_TITLE])) {
403 403
                     $this->storage->addDocumentType($request::$post);
404
-                    header('Location: ' . $request::$subfolders . $this->parameters[self::PARAMETER_CMS_PREFIX] . '/configuration/document-types');
404
+                    header('Location: '.$request::$subfolders.$this->parameters[self::PARAMETER_CMS_PREFIX].'/configuration/document-types');
405 405
                     exit;
406 406
                 }
407 407
                 $this->parameters[self::PARAMETER_BRICKS] = $bricks;
@@ -412,14 +412,14 @@  discard block
 block discarded – undo
412 412
                 $bricks = $this->storage->getBricks();
413 413
                 if (isset($request::$post[self::POST_PARAMETER_TITLE])) {
414 414
                     $this->storage->saveDocumentType($request::$get[self::GET_PARAMETER_SLUG], $request::$post);
415
-                    header('Location: ' . $request::$subfolders . $this->parameters[self::PARAMETER_CMS_PREFIX] . '/configuration/document-types');
415
+                    header('Location: '.$request::$subfolders.$this->parameters[self::PARAMETER_CMS_PREFIX].'/configuration/document-types');
416 416
                     exit;
417 417
                 }
418 418
                 $this->parameters[self::PARAMETER_DOCUMENT_TYPE] = $documentType;
419 419
                 $this->parameters[self::PARAMETER_BRICKS] = $bricks;
420 420
             } elseif ($relativeCmsUri == '/configuration/document-types/delete' && isset($request::$get[self::GET_PARAMETER_SLUG])) {
421 421
                 $this->storage->deleteDocumentTypeBySlug($request::$get[self::GET_PARAMETER_SLUG]);
422
-                header('Location: ' . $request::$subfolders . $this->parameters[self::PARAMETER_CMS_PREFIX] . '/configuration/document-types');
422
+                header('Location: '.$request::$subfolders.$this->parameters[self::PARAMETER_CMS_PREFIX].'/configuration/document-types');
423 423
                 exit;
424 424
             }
425 425
         }
@@ -439,7 +439,7 @@  discard block
 block discarded – undo
439 439
                 $this->parameters[self::PARAMETER_MAIN_NAV_CLASS] = 'configuration';
440 440
                 if (isset($request::$post[self::POST_PARAMETER_TITLE])) {
441 441
                     $this->storage->addBrick($request::$post);
442
-                    header('Location: ' . $request::$subfolders . $this->parameters[self::PARAMETER_CMS_PREFIX] . '/configuration/bricks');
442
+                    header('Location: '.$request::$subfolders.$this->parameters[self::PARAMETER_CMS_PREFIX].'/configuration/bricks');
443 443
                     exit;
444 444
                 }
445 445
             } elseif ($relativeCmsUri == '/configuration/bricks/edit' && isset($request::$get[self::GET_PARAMETER_SLUG])) {
@@ -448,13 +448,13 @@  discard block
 block discarded – undo
448 448
                 $brick = $this->storage->getBrickBySlug($request::$get[self::GET_PARAMETER_SLUG]);
449 449
                 if (isset($request::$post[self::POST_PARAMETER_TITLE])) {
450 450
                     $this->storage->saveBrick($request::$get[self::GET_PARAMETER_SLUG], $request::$post);
451
-                    header('Location: ' . $request::$subfolders . $this->parameters[self::PARAMETER_CMS_PREFIX] . '/configuration/bricks');
451
+                    header('Location: '.$request::$subfolders.$this->parameters[self::PARAMETER_CMS_PREFIX].'/configuration/bricks');
452 452
                     exit;
453 453
                 }
454 454
                 $this->parameters[self::PARAMETER_BRICK] = $brick;
455 455
             } elseif ($relativeCmsUri == '/configuration/bricks/delete' && isset($request::$get[self::GET_PARAMETER_SLUG])) {
456 456
                 $this->storage->deleteBrickBySlug($request::$get[self::GET_PARAMETER_SLUG]);
457
-                header('Location: ' . $request::$subfolders . $this->parameters[self::PARAMETER_CMS_PREFIX] . '/configuration/bricks');
457
+                header('Location: '.$request::$subfolders.$this->parameters[self::PARAMETER_CMS_PREFIX].'/configuration/bricks');
458 458
                 exit;
459 459
             } elseif ($relativeCmsUri == '/configuration/image-set') {
460 460
                 $this->subTemplate = 'cms/configuration/image-set';
@@ -479,7 +479,7 @@  discard block
 block discarded – undo
479 479
                 $imageSet = $this->storage->getImageSetBySlug($request::$get[self::GET_PARAMETER_SLUG]);
480 480
                 if (isset($request::$post[self::POST_PARAMETER_TITLE])) {
481 481
                     $this->storage->saveImageSet($request::$get[self::GET_PARAMETER_SLUG], $request::$post);
482
-                    header('Location: ' . $request::$subfolders . $this->parameters[self::PARAMETER_CMS_PREFIX] . '/configuration/image-set');
482
+                    header('Location: '.$request::$subfolders.$this->parameters[self::PARAMETER_CMS_PREFIX].'/configuration/image-set');
483 483
                     exit;
484 484
                 }
485 485
                 $this->parameters[self::PARAMETER_IMAGE_SET] = $imageSet;
@@ -488,12 +488,12 @@  discard block
 block discarded – undo
488 488
                 $this->parameters[self::PARAMETER_MAIN_NAV_CLASS] = 'configuration';
489 489
                 if (isset($request::$post[self::POST_PARAMETER_TITLE])) {
490 490
                     $this->storage->addImageSet($request::$post);
491
-                    header('Location: ' . $request::$subfolders . $this->parameters[self::PARAMETER_CMS_PREFIX] . '/configuration/image-set');
491
+                    header('Location: '.$request::$subfolders.$this->parameters[self::PARAMETER_CMS_PREFIX].'/configuration/image-set');
492 492
                     exit;
493 493
                 }
494 494
             } elseif ($relativeCmsUri == '/configuration/image-set/delete' && isset($request::$get[self::GET_PARAMETER_SLUG])) {
495 495
                 $this->storage->deleteImageSetBySlug($request::$get[self::GET_PARAMETER_SLUG]);
496
-                header('Location: ' . $request::$subfolders . $this->parameters[self::PARAMETER_CMS_PREFIX] . '/configuration/image-set');
496
+                header('Location: '.$request::$subfolders.$this->parameters[self::PARAMETER_CMS_PREFIX].'/configuration/image-set');
497 497
                 exit;
498 498
             }
499 499
         }
@@ -513,7 +513,7 @@  discard block
 block discarded – undo
513 513
                 $this->parameters[self::PARAMETER_MAIN_NAV_CLASS] = 'configuration';
514 514
                 if (isset($request::$post[self::POST_PARAMETER_TITLE])) {
515 515
                     $this->storage->addApplicationComponent($request::$post);
516
-                    header('Location: ' . $request::$subfolders . $this->parameters[self::PARAMETER_CMS_PREFIX] . '/configuration/application-components');
516
+                    header('Location: '.$request::$subfolders.$this->parameters[self::PARAMETER_CMS_PREFIX].'/configuration/application-components');
517 517
                     exit;
518 518
                 }
519 519
             } elseif ($relativeCmsUri == '/configuration/application-components/edit' && isset($request::$get[self::GET_PARAMETER_SLUG])) {
@@ -522,13 +522,13 @@  discard block
 block discarded – undo
522 522
                 $applicationComponent = $this->storage->getApplicationComponentBySlug($request::$get[self::GET_PARAMETER_SLUG]);
523 523
                 if (isset($request::$post[self::POST_PARAMETER_TITLE])) {
524 524
                     $this->storage->saveApplicationComponent($request::$get[self::GET_PARAMETER_SLUG], $request::$post);
525
-                    header('Location: ' . $request::$subfolders . $this->parameters[self::PARAMETER_CMS_PREFIX] . '/configuration/application-components');
525
+                    header('Location: '.$request::$subfolders.$this->parameters[self::PARAMETER_CMS_PREFIX].'/configuration/application-components');
526 526
                     exit;
527 527
                 }
528 528
                 $this->parameters['applicationComponent'] = $applicationComponent;
529 529
             } elseif ($relativeCmsUri == '/configuration/application-components/delete' && isset($request::$get[self::GET_PARAMETER_SLUG])) {
530 530
                 $this->storage->deleteApplicationComponentBySlug($request::$get[self::GET_PARAMETER_SLUG]);
531
-                header('Location: ' . $request::$subfolders . $this->parameters[self::PARAMETER_CMS_PREFIX] . '/configuration/application-components');
531
+                header('Location: '.$request::$subfolders.$this->parameters[self::PARAMETER_CMS_PREFIX].'/configuration/application-components');
532 532
                 exit;
533 533
             }
534 534
         }
@@ -538,7 +538,7 @@  discard block
 block discarded – undo
538 538
             if ($relativeCmsUri == '/log-off') {
539 539
                 $_SESSION[self::SESSION_PARAMETER_CLOUD_CONTROL] = null;
540 540
                 unset($_SESSION[self::SESSION_PARAMETER_CLOUD_CONTROL]);
541
-                header('Location: ' . $request::$subfolders . $this->parameters[self::PARAMETER_CMS_PREFIX]);
541
+                header('Location: '.$request::$subfolders.$this->parameters[self::PARAMETER_CMS_PREFIX]);
542 542
                 exit;
543 543
             }
544 544
         }
Please login to merge, or discard this patch.