View GitHub Repository cloudcontrol

Schedule Inspection
Subscribe
Passed
Push — develop ( 6e8f17...2975bd )
by Jens
03:53
created
Status
Category
Toggle Patches
src/components/cms/configuration/ApplicationComponentRouting.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch 
@@ -45,7 +45,7 @@  discard block
 
 block discarded – undo
45 45 
     }
46 46
47 47 
     /**
48 
-     * @param $request
48 
+     * @param Request $request
49 49 
      * @param CmsComponent $cmsComponent
50 50 
      */
51 51 
     private function newRoute($request, $cmsComponent)
 
@@ -60,7 +60,7 @@  discard block
 
 block discarded – undo
60 60 
     }
61 61
62 62 
     /**
63 
-     * @param $request
63 
+     * @param Request $request
64 64 
      * @param CmsComponent $cmsComponent
65 65 
      */
66 66 
     private function editRoute($request, $cmsComponent)
 
@@ -78,7 +78,7 @@  discard block
 
 block discarded – undo
78 78 
     }
79 79
80 80 
     /**
81 
-     * @param $request
81 
+     * @param Request $request
82 82 
      * @param CmsComponent $cmsComponent
83 83 
      */
84 84 
     private function deleteRoute($request, $cmsComponent)
Please login to merge, or discard this patch.
src/components/cms/configuration/ImageSetRouting.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch 
@@ -46,7 +46,7 @@  discard block
 
 block discarded – undo
46 46 
     }
47 47
48 48 
     /**
49 
-     * @param $request
49 
+     * @param Request $request
50 50 
      * @param CmsComponent $cmsComponent
51 51 
      */
52 52 
     private function editRoute($request, $cmsComponent)
 
@@ -63,7 +63,7 @@  discard block
 
 block discarded – undo
63 63 
     }
64 64
65 65 
     /**
66 
-     * @param $request
66 
+     * @param Request $request
67 67 
      * @param CmsComponent $cmsComponent
68 68 
      */
69 69 
     private function newRoute($request, $cmsComponent)
 
@@ -78,7 +78,7 @@  discard block
 
 block discarded – undo
78 78 
     }
79 79
80 80 
     /**
81 
-     * @param $request
81 
+     * @param Request $request
82 82 
      * @param CmsComponent $cmsComponent
83 83 
      */
84 84 
     private function deleteRoute($request, $cmsComponent)
Please login to merge, or discard this patch.
src/components/cms/configuration/UsersRouting.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch 
@@ -47,7 +47,7 @@  discard block
 
 block discarded – undo
47 47 
     }
48 48
49 49 
     /**
50 
-     * @param $request
50 
+     * @param Request $request
51 51 
      * @param CmsComponent $cmsComponent
52 52 
      */
53 53 
     private function newRoute($request, $cmsComponent)
 
@@ -62,7 +62,7 @@  discard block
 
 block discarded – undo
62 62 
     }
63 63
64 64 
     /**
65 
-     * @param $request
65 
+     * @param Request $request
66 66 
      * @param CmsComponent $cmsComponent
67 67 
      */
68 68 
     private function deleteRoute($request, $cmsComponent)
 
@@ -73,7 +73,7 @@  discard block
 
 block discarded – undo
73 73 
     }
74 74
75 75 
     /**
76 
-     * @param $request
76 
+     * @param Request $request
77 77 
      * @param CmsComponent $cmsComponent
78 78 
      */
79 79 
     private function editRoute($request, $cmsComponent)
Please login to merge, or discard this patch.
src/components/cms/DocumentRouting.php 1 patch
Doc Comments   +9 added lines, -4 removed lines patch added patch discarded remove patch 
@@ -33,8 +33,8 @@  discard block
 
 block discarded – undo
33 33
34 34
35 35 
     /**
36 
-     * @param $request
37 
-     * @param $relativeCmsUri
36 
+     * @param Request $request
37 
+     * @param string $relativeCmsUri
38 38 
      * @param CmsComponent $cmsComponent
39 39 
      * @throws \Exception
40 40 
      */
 
@@ -54,8 +54,8 @@  discard block
 
 block discarded – undo
54 54 
     }
55 55
56 56 
     /**
57 
-     * @param $request
58 
-     * @param $relativeCmsUri
57 
+     * @param Request $request
58 
+     * @param string $relativeCmsUri
59 59 
      * @param CmsComponent $cmsComponent
60 60 
      */
61 61 
     private function folderRouting($request, $relativeCmsUri, $cmsComponent)
 
@@ -69,6 +69,11 @@  discard block
 
 block discarded – undo
69 69 
         }
70 70 
     }
71 71
72 
+    /**
73 
+     * @param Request $request
74 
+     * @param string $relativeCmsUri
75 
+     * @param CmsComponent $cmsComponent
76 
+     */
72 77 
     private function valuelistsRouting($request, $relativeCmsUri, $cmsComponent)
73 78 
     {
74 79 
         if ($relativeCmsUri == '/documents/valuelists') {
Please login to merge, or discard this patch.
src/components/cms/ImagesRouting.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch 
@@ -55,7 +55,7 @@  discard block
 
 block discarded – undo
55 55 
     }
56 56
57 57 
     /**
58 
-     * @param $request
58 
+     * @param \CloudControl\Cms\cc\Request $request
59 59 
      * @param CmsComponent $cmsComponent
60 60 
      */
61 61 
     private function newRoute($request, $cmsComponent)
 
@@ -70,7 +70,7 @@  discard block
 
 block discarded – undo
70 70 
     }
71 71
72 72 
     /**
73 
-     * @param $request
73 
+     * @param \CloudControl\Cms\cc\Request $request
74 74 
      * @param CmsComponent $cmsComponent
75 75 
      */
76 76 
     private function deleteRoute($request, $cmsComponent)
 
@@ -81,7 +81,7 @@  discard block
 
 block discarded – undo
81 81 
     }
82 82
83 83 
     /**
84 
-     * @param $request
84 
+     * @param \CloudControl\Cms\cc\Request $request
85 85 
      * @param CmsComponent $cmsComponent
86 86 
      */
87 87 
     private function showRoute($request, $cmsComponent)
Please login to merge, or discard this patch.
src/components/cms/SitemapRouting.php 1 patch
Doc Comments   +8 added lines, -4 removed lines patch added patch discarded remove patch 
@@ -36,7 +36,7 @@  discard block
 
 block discarded – undo
36 36 
     }
37 37
38 38 
     /**
39 
-     * @param $request
39 
+     * @param \CloudControl\Cms\cc\Request $request
40 40 
      * @param CmsComponent $cmsComponent
41 41 
      */
42 42 
     private function overviewRoute($request, $cmsComponent)
 
@@ -50,7 +50,7 @@  discard block
 
 block discarded – undo
50 50 
     }
51 51
52 52 
     /**
53 
-     * @param $request
53 
+     * @param \CloudControl\Cms\cc\Request $request
54 54 
      * @param CmsComponent $cmsComponent
55 55 
      */
56 56 
     private function newRoute($request, $cmsComponent)
 
@@ -65,7 +65,7 @@  discard block
 
 block discarded – undo
65 65 
     }
66 66
67 67 
     /**
68 
-     * @param $request
68 
+     * @param \CloudControl\Cms\cc\Request $request
69 69 
      * @param CmsComponent $cmsComponent
70 70 
      */
71 71 
     private function editRoute($request, $cmsComponent)
 
@@ -82,7 +82,7 @@  discard block
 
 block discarded – undo
82 82 
     }
83 83
84 84 
     /**
85 
-     * @param $request
85 
+     * @param \CloudControl\Cms\cc\Request $request
86 86 
      * @param CmsComponent $cmsComponent
87 87 
      */
88 88 
     private function deleteRoute($request, $cmsComponent)
 
@@ -92,6 +92,10 @@  discard block
 
 block discarded – undo
92 92 
         exit;
93 93 
     }
94 94
95 
+    /**
96 
+     * @param \CloudControl\Cms\cc\Request $request
97 
+     * @param CmsComponent $cmsComponent
98 
+     */
95 99 
     private function redirectRoutes($relativeCmsUri, $request, $cmsComponent)
96 100 
     {
97 101 
         if ($relativeCmsUri == '/sitemap/redirects') {
Please login to merge, or discard this patch.
src/components/CmsComponent.php 1 patch
Doc Comments   +7 added lines, -4 removed lines patch added patch discarded remove patch 
@@ -195,7 +195,7 @@  discard block
 
 block discarded – undo
195 195 
         }
196 196
197 197 
         /**
198 
-         * @param $request
198 
+         * @param \CloudControl\Cms\cc\Request $request
199 199 
          *
200 200 
          * @return mixed|string
201 201 
          */
 
@@ -228,6 +228,9 @@  discard block
 
 block discarded – undo
228 228 
             }
229 229 
         }
230 230
231 
+        /**
232 
+         * @param \CloudControl\Cms\cc\Request $request
233 
+         */
231 234 
         private function logOffRouting($request, $relativeCmsUri)
232 235 
         {
233 236 
             if ($relativeCmsUri == '/log-off') {
 
@@ -327,7 +330,7 @@  discard block
 
 block discarded – undo
327 330 
         }
328 331
329 332 
         /**
330 
-         * @param $crypt
333 
+         * @param Crypt $crypt
331 334 
          * @param $request
332 335 
          */
333 336 
         protected function invalidCredentials($crypt, $request)
 
@@ -339,7 +342,7 @@  discard block
 
 block discarded – undo
339 342
340 343 
         /**
341 344 
          * @param $user
342 
-         * @param $crypt
345 
+         * @param Crypt $crypt
343 346 
          * @param $request
344 347 
          */
345 348 
         protected function checkPassword($user, $crypt, $request)
 
@@ -359,7 +362,7 @@  discard block
 
 block discarded – undo
359 362 
         }
360 363
361 364 
         /**
362 
-         * @param $request
365 
+         * @param \CloudControl\Cms\cc\Request $request
363 366 
          */
364 367 
         protected function checkLoginAttempt($request)
365 368 
         {
Please login to merge, or discard this patch.
src/templates/documents.php 1 patch
Braces   +5 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -20,7 +20,8 @@  discard block
 
 block discarded – undo
20 20 
               <a href="<?= $request::$subfolders ?><?= $cmsPrefix ?>/search/update-index?returnUrl=<?=urlencode($request::$subfolders . $cmsPrefix . '/documents')?>" title="Update Index">Update Index</a>
21 21 
             <? endif ?>
22 22 
         </div>
23 
-      <? else : ?>
23 
+      <? else {
24 
+    : ?>
24 25 
         <div class="message valid">
25 26 
           <i class="fa fa-check"></i> Search index is in sync with documents.
26 27 
         </div>
 
@@ -52,7 +53,9 @@  discard block
 
 block discarded – undo
52 53 
           <? foreach ($documents as $document) : ?>
53 54 
             <li class="grid-container">
54 55 
                 <? if ($document->type == 'document') : ?>
55 
-                    <? renderDocument($document, $cmsPrefix, '', $request); ?>
56 
+                    <? renderDocument($document, $cmsPrefix, '', $request);
57 
+}
58 
+?>
56 59 
                 <? elseif ($document->type == 'folder') : ?>
57 60 
                     <? renderFolder($document, $cmsPrefix, '', true, $request); ?>
58 61 
                 <? endif ?>
Please login to merge, or discard this patch.
src/components/cms/configuration/BricksRouting.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch 
@@ -45,7 +45,7 @@  discard block
 
 block discarded – undo
45 45 
     }
46 46
47 47 
     /**
48 
-     * @param $request
48 
+     * @param Request $request
49 49 
      * @param CmsComponent $cmsComponent
50 50 
      */
51 51 
     private function newRoute($request, $cmsComponent)
 
@@ -60,7 +60,7 @@  discard block
 
 block discarded – undo
60 60 
     }
61 61
62 62 
     /**
63 
-     * @param $request
63 
+     * @param Request $request
64 64 
      * @param CmsComponent $cmsComponent
65 65 
      */
66 66 
     private function editRoute($request, $cmsComponent)
 
@@ -78,7 +78,7 @@  discard block
 
 block discarded – undo
78 78 
     }
79 79
80 80 
     /**
81 
-     * @param $request
81 
+     * @param Request $request
82 82 
      * @param CmsComponent $cmsComponent
83 83 
      */
84 84 
     private function deleteRoute($request, $cmsComponent)
Please login to merge, or discard this patch.