Storage - Code Metrics - Inspection of "Merge branch 'develop'" - jenskooij/cloudcontrol - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( f61691...1918f3 )

by Jens

created 2017-09-04 22:26 UTC

Storage A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	269
Duplicated Lines	5.2 %

Coupling/Cohesion

Components	1
Dependencies	14

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
dl	14
loc	269
rs	10
c	1
b	0
f	0
wmc	30
lcom	1
cbo	14

17 Methods

Rating	Name	Duplication	Size	Complexity
A	getUsers()	0	7	2
A	getDocuments()	0	7	2
A	__construct()	0	7	1
A	config()	0	10	2
A	getSitemap()	0	7	2
A	getImages()	0	8	2
A	getFiles()	0	7	2
A	getStorageDir()	0	4	1
A	getContentDbHandle()	0	4	1
A	getDocumentTypes()	0	7	2
A	getBricks()	7	7	2
A	getImageSet()	7	7	2
A	getApplicationComponents()	0	7	2
A	getRepository()	0	4	1
A	getValuelists()	0	7	2
A	getRedirects()	0	7	2
A	getActivityLog()	0	7	2

How to fix Duplicated Code

<?php

namespace CloudControl\Cms\storage {

    use CloudControl\Cms\storage\storage\ActivityLogStorage;
    use CloudControl\Cms\storage\storage\ApplicationComponentsStorage;
    use CloudControl\Cms\storage\storage\BricksStorage;
    use CloudControl\Cms\storage\storage\DocumentStorage;
    use CloudControl\Cms\storage\storage\DocumentTypesStorage;
    use CloudControl\Cms\storage\storage\FilesStorage;
    use CloudControl\Cms\storage\storage\ImageSetStorage;
    use CloudControl\Cms\storage\storage\ImagesStorage;
    use CloudControl\Cms\storage\storage\RedirectsStorage;
    use CloudControl\Cms\storage\storage\SitemapStorage;
    use CloudControl\Cms\storage\storage\UsersStorage;
    use CloudControl\Cms\storage\storage\ValuelistsStorage;

    /**
     * Class JsonStorage
     * @package CloudControl\Cms\storage
     */
    class Storage
    {
        /**
         * @var SitemapStorage
         */
        protected $sitemap;
        /**
         * @var ImagesStorage
         */
        protected $images;
        /**
         * @var ImageSetStorage
         */
        protected $imageSet;
        /**
         * @var FilesStorage
         */
        protected $files;
        /**
         * @var UsersStorage
         */
        protected $users;
        /**
         * @var DocumentTypesStorage
         */
        protected $documentTypes;
        /**
         * @var BricksStorage
         */
        protected $bricks;
        /**
         * @var ApplicationComponentsStorage
         */
        protected $applicationComponents;

        /**
         * @var ValuelistsStorage
         */
        protected $valuelists;
        /**
         * @var DocumentStorage
         */
        protected $documents;
        /**
         * @var RedirectsStorage
         */
        protected $redirects;

        /**
         * @var ActivityLogStorage
         */
        protected $activityLog;
        /**
         * @var String
         */
        protected $imagesDir;
        /**
         * @var String
         */
        protected $filesDir;

        /**
         * @var String
         */
        private $storageDir;
        /**
         * @var Repository
         */
        private $repository;

        /**
         * JsonStorage constructor.
         *
         * @param string $storageDir
         * @param $imagesDir
         * @param $filesDir
         */
        public function __construct($storageDir, $imagesDir, $filesDir)
        {
            $this->storageDir = $storageDir;
            $this->imagesDir = $imagesDir;
            $this->filesDir = $filesDir;
            $this->config();
        }

        /**
         * Retrieve the data from the storagepath
         * so it can be interacted with
         *
         * @throws \Exception
         */
        private function config()
        {
            $storagePath = $this->storageDir;
            if (realpath($storagePath) === false) {
                throw new \Exception('Storage doesnt seem to be initialized, consider running composer install to do so.');
            } else {
                $this->repository = new Repository($storagePath);
            }

        }

        /**
         * @return \CloudControl\Cms\storage\storage\UsersStorage
         */
        public function getUsers()
        {
            if (!$this->users instanceof UsersStorage) {
                $this->users = new UsersStorage($this->repository);
            }
            return $this->users;
        }

        /**
         * Get documents
         *
         * @return DocumentStorage
         */
        public function getDocuments()
        {
            if (!$this->documents instanceof DocumentStorage) {
                $this->documents = new DocumentStorage($this->repository);
            }
            return $this->documents;
        }

        /**
         * @return SitemapStorage
         */
        public function getSitemap()
        {
            if (!$this->sitemap instanceof SitemapStorage) {
                $this->sitemap = new SitemapStorage($this->repository);
            }
            return $this->sitemap;
        }

        /**
         * Get all images
         *
         * @return ImagesStorage
         */
        public function getImages()
        {
            if (!$this->images instanceof ImagesStorage) {

                $this->images = new ImagesStorage($this->repository, $this->imagesDir);
            }
            return $this->images;
        }

        /**
         * Get all files
         *
         * @return FilesStorage
         */
        public function getFiles()
        {
            if (!$this->files instanceof FilesStorage) {
                $this->files = new FilesStorage($this->repository, $this->filesDir);
            }
            return $this->files;
        }

        /**
         * @return string
         */
        public function getStorageDir()
        {
            return $this->storageDir;
        }

        /**
         * @return \PDO
         */
        public function getContentDbHandle()
        {
            return $this->repository->getContentRepository()->getContentDbHandle();
        }

        /**
         * @return DocumentTypesStorage
         */
        public function getDocumentTypes()
        {
            if (!$this->documentTypes instanceof DocumentTypesStorage) {
                $this->documentTypes = new DocumentTypesStorage($this->repository);
            }
            return $this->documentTypes;
        }

        /**
         * @return BricksStorage
         */
        public function getBricks()

        {
            if (!$this->bricks instanceof BricksStorage) {
                $this->bricks = new BricksStorage($this->repository);
            }
            return $this->bricks;
        }

        /**
         * Get the image set
         *
         * @return ImageSetStorage
         */
        public function getImageSet()

        {
            if (!$this->imageSet instanceof ImageSetStorage) {
                $this->imageSet = new ImageSetStorage($this->repository);
            }
            return $this->imageSet;
        }

        /**
         * @return ApplicationComponentsStorage
         */
        public function getApplicationComponents()
        {
            if (!$this->applicationComponents instanceof ApplicationComponentsStorage) {
                $this->applicationComponents = new ApplicationComponentsStorage($this->repository);
            }
            return $this->applicationComponents;
        }

        /**
         * @return \CloudControl\Cms\storage\Repository
         */
        public function getRepository()
        {
            return $this->repository;
        }

        /**
         * @return \CloudControl\Cms\storage\storage\ValuelistsStorage
         */
        public function getValuelists()
        {
            if (!$this->valuelists instanceof ValuelistsStorage) {
                $this->valuelists = new ValuelistsStorage($this->repository);
            }
            return $this->valuelists;
        }

        /**
         * @return \CloudControl\Cms\storage\storage\RedirectsStorage
         */
        public function getRedirects()
        {
            if (!$this->redirects instanceof RedirectsStorage) {
                $this->redirects = new RedirectsStorage($this->repository);
            }
            return $this->redirects;
        }

        /**
         * @return ActivityLogStorage
         */
        public function getActivityLog()
        {
            if (!$this->activityLog instanceof ActivityLogStorage) {
                $this->activityLog = new ActivityLogStorage($this->repository);
            }
            return $this->activityLog;
        }


    }
}

1		<?php
2
3		namespace CloudControl\Cms\storage {
4
5		use CloudControl\Cms\storage\storage\ActivityLogStorage;
6		use CloudControl\Cms\storage\storage\ApplicationComponentsStorage;
7		use CloudControl\Cms\storage\storage\BricksStorage;
8		use CloudControl\Cms\storage\storage\DocumentStorage;
9		use CloudControl\Cms\storage\storage\DocumentTypesStorage;
10		use CloudControl\Cms\storage\storage\FilesStorage;
11		use CloudControl\Cms\storage\storage\ImageSetStorage;
12		use CloudControl\Cms\storage\storage\ImagesStorage;
13		use CloudControl\Cms\storage\storage\RedirectsStorage;
14		use CloudControl\Cms\storage\storage\SitemapStorage;
15		use CloudControl\Cms\storage\storage\UsersStorage;
16		use CloudControl\Cms\storage\storage\ValuelistsStorage;
17
18		/**
19		* Class JsonStorage
20		* @package CloudControl\Cms\storage
21		*/
22		class Storage
23		{
24		/**
25		* @var SitemapStorage
26		*/
27		protected $sitemap;
28		/**
29		* @var ImagesStorage
30		*/
31		protected $images;
32		/**
33		* @var ImageSetStorage
34		*/
35		protected $imageSet;
36		/**
37		* @var FilesStorage
38		*/
39		protected $files;
40		/**
41		* @var UsersStorage
42		*/
43		protected $users;
44		/**
45		* @var DocumentTypesStorage
46		*/
47		protected $documentTypes;
48		/**
49		* @var BricksStorage
50		*/
51		protected $bricks;
52		/**
53		* @var ApplicationComponentsStorage
54		*/
55		protected $applicationComponents;
56
57		/**
58		* @var ValuelistsStorage
59		*/
60		protected $valuelists;
61		/**
62		* @var DocumentStorage
63		*/
64		protected $documents;
65		/**
66		* @var RedirectsStorage
67		*/
68		protected $redirects;
69
70		/**
71		* @var ActivityLogStorage
72		*/
73		protected $activityLog;
74		/**
75		* @var String
76		*/
77		protected $imagesDir;
78		/**
79		* @var String
80		*/
81		protected $filesDir;
82
83		/**
84		* @var String
85		*/
86		private $storageDir;
87		/**
88		* @var Repository
89		*/
90		private $repository;
91
92		/**
93		* JsonStorage constructor.
94		*
95		* @param string $storageDir
96		* @param $imagesDir
97		* @param $filesDir
98		*/
99		public function __construct($storageDir, $imagesDir, $filesDir)
100		{
101		$this->storageDir = $storageDir;
102		$this->imagesDir = $imagesDir;
103		$this->filesDir = $filesDir;
104		$this->config();
105		}
106
107		/**
108		* Retrieve the data from the storagepath
109		* so it can be interacted with
110		*
111		* @throws \Exception
112		*/
113		private function config()
114		{
115		$storagePath = $this->storageDir;
116		if (realpath($storagePath) === false) {
117		throw new \Exception('Storage doesnt seem to be initialized, consider running composer install to do so.');
118		} else {
119		$this->repository = new Repository($storagePath);
120		}
121
122		}
123
124		/**
125		* @return \CloudControl\Cms\storage\storage\UsersStorage
126		*/
127		public function getUsers()
128		{
129		if (!$this->users instanceof UsersStorage) {
130		$this->users = new UsersStorage($this->repository);
131		}
132		return $this->users;
133		}
134
135		/**
136		* Get documents
137		*
138		* @return DocumentStorage
139		*/
140		public function getDocuments()
141		{
142		if (!$this->documents instanceof DocumentStorage) {
143		$this->documents = new DocumentStorage($this->repository);
144		}
145		return $this->documents;
146		}
147
148		/**
149		* @return SitemapStorage
150		*/
151		public function getSitemap()
152		{
153		if (!$this->sitemap instanceof SitemapStorage) {
154		$this->sitemap = new SitemapStorage($this->repository);
155		}
156		return $this->sitemap;
157		}
158
159		/**
160		* Get all images
161		*
162		* @return ImagesStorage
163		*/
164		public function getImages()
165		{
166		if (!$this->images instanceof ImagesStorage) {
167
168		$this->images = new ImagesStorage($this->repository, $this->imagesDir);
169		}
170		return $this->images;
171		}
172
173		/**
174		* Get all files
175		*
176		* @return FilesStorage
177		*/
178		public function getFiles()
179		{
180		if (!$this->files instanceof FilesStorage) {
181		$this->files = new FilesStorage($this->repository, $this->filesDir);
182		}
183		return $this->files;
184		}
185
186		/**
187		* @return string
188		*/
189		public function getStorageDir()
190		{
191		return $this->storageDir;
192		}
193
194		/**
195		* @return \PDO
196		*/
197		public function getContentDbHandle()
198		{
199		return $this->repository->getContentRepository()->getContentDbHandle();
200		}
201
202		/**
203		* @return DocumentTypesStorage
204		*/
205		public function getDocumentTypes()
206		{
207		if (!$this->documentTypes instanceof DocumentTypesStorage) {
208		$this->documentTypes = new DocumentTypesStorage($this->repository);
209		}
210		return $this->documentTypes;
211		}
212
213		/**
214		* @return BricksStorage
215		*/
216	View Code Duplication	public function getBricks()
		0 ignored issues – show Duplication introduced 2017-08-23 14:34 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
217		{
218		if (!$this->bricks instanceof BricksStorage) {
219		$this->bricks = new BricksStorage($this->repository);
220		}
221		return $this->bricks;
222		}
223
224		/**
225		* Get the image set
226		*
227		* @return ImageSetStorage
228		*/
229	View Code Duplication	public function getImageSet()
		0 ignored issues – show Duplication introduced 2017-08-23 14:34 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
230		{
231		if (!$this->imageSet instanceof ImageSetStorage) {
232		$this->imageSet = new ImageSetStorage($this->repository);
233		}
234		return $this->imageSet;
235		}
236
237		/**
238		* @return ApplicationComponentsStorage
239		*/
240		public function getApplicationComponents()
241		{
242		if (!$this->applicationComponents instanceof ApplicationComponentsStorage) {
243		$this->applicationComponents = new ApplicationComponentsStorage($this->repository);
244		}
245		return $this->applicationComponents;
246		}
247
248		/**
249		* @return \CloudControl\Cms\storage\Repository
250		*/
251		public function getRepository()
252		{
253		return $this->repository;
254		}
255
256		/**
257		* @return \CloudControl\Cms\storage\storage\ValuelistsStorage
258		*/
259		public function getValuelists()
260		{
261		if (!$this->valuelists instanceof ValuelistsStorage) {
262		$this->valuelists = new ValuelistsStorage($this->repository);
263		}
264		return $this->valuelists;
265		}
266
267		/**
268		* @return \CloudControl\Cms\storage\storage\RedirectsStorage
269		*/
270		public function getRedirects()
271		{
272		if (!$this->redirects instanceof RedirectsStorage) {
273		$this->redirects = new RedirectsStorage($this->repository);
274		}
275		return $this->redirects;
276		}
277
278		/**
279		* @return ActivityLogStorage
280		*/
281		public function getActivityLog()
282		{
283		if (!$this->activityLog instanceof ActivityLogStorage) {
284		$this->activityLog = new ActivityLogStorage($this->repository);
285		}
286		return $this->activityLog;
287		}
288
289
290		}
291		}

jenskooij / cloudcontrol

Push — master ( f61691...1918f3 )

Storage A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

17 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like