Passed
Push — master ( f61691...1918f3 )
by Jens
07:18
created

RedirectRouting   A

Complexity

Total Complexity 13

Size/Duplication

Total Lines 61
Duplicated Lines 36.07 %

Coupling/Cohesion

Components 0
Dependencies 4

Importance

Changes 1
Bugs 0 Features 0
Metric Value
c 1
b 0
f 0
dl 22
loc 61
rs 10
wmc 13
lcom 0
cbo 4

5 Methods

Rating   Name   Duplication   Size   Complexity  
B __construct() 0 12 7
A redirectsOverviewRoute() 0 6 1
A redirectsNewRoute() 10 10 2
A redirectDeleteRoute() 0 6 1
A redirectEditRoute() 12 12 2

How to fix   Duplicated Code   

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

1
<?php
2
/**
3
 * Created by jensk on 4-9-2017.
4
 */
5
6
namespace CloudControl\Cms\components\cms;
7
8
9
use CloudControl\Cms\cc\Request;
10
use CloudControl\Cms\components\CmsComponent;
11
12
class RedirectRouting implements CmsRouting
13
{
14
15
    /**
16
     * CmsRouting constructor.
17
     *
18
     * @param Request $request
19
     * @param string $relativeCmsUri
20
     * @param CmsComponent $cmsComponent
21
     */
22
    public function __construct(Request $request, $relativeCmsUri, CmsComponent $cmsComponent)
23
    {
24
        if ($relativeCmsUri == '/redirects') {
25
            $this->redirectsOverviewRoute($cmsComponent);
26
        } elseif ($relativeCmsUri == '/redirects/new') {
27
            $this->redirectsNewRoute($request, $cmsComponent);
28
        } elseif ($relativeCmsUri == '/redirects/edit' && isset($request::$get[CmsConstants::GET_PARAMETER_SLUG])) {
29
            $this->redirectEditRoute($request, $cmsComponent);
30
        } elseif ($relativeCmsUri == '/redirects/delete' && isset($request::$get[CmsConstants::GET_PARAMETER_SLUG])) {
31
            $this->redirectDeleteRoute($request, $cmsComponent);
32
        }
33
    }
34
35
    private function redirectsOverviewRoute(CmsComponent $cmsComponent)
36
    {
37
        $cmsComponent->subTemplate = 'redirects';
38
        $cmsComponent->setParameter(CmsConstants::PARAMETER_MAIN_NAV_CLASS, CmsConstants::PARAMETER_REDIRECTS);
39
        $cmsComponent->setParameter(CmsConstants::PARAMETER_REDIRECTS, $cmsComponent->storage->getRedirects()->getRedirects());
40
    }
41
42 View Code Duplication
    private function redirectsNewRoute(Request $request, CmsComponent $cmsComponent)
0 ignored issues
show
Duplication introduced by
This method seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
43
    {
44
        $cmsComponent->subTemplate = 'redirects/form';
45
        $cmsComponent->setParameter(CmsConstants::PARAMETER_MAIN_NAV_CLASS, CmsConstants::PARAMETER_REDIRECTS);
46
        if (isset($request::$post[CmsConstants::POST_PARAMETER_TITLE], $request::$post[CmsConstants::POST_PARAMETER_FROM_URL], $request::$post[CmsConstants::POST_PARAMETER_TO_URL])) {
47
            $cmsComponent->storage->getRedirects()->addRedirect($request::$post);
48
            header('Location: ' . $request::$subfolders . $cmsComponent->getParameter(CmsConstants::PARAMETER_CMS_PREFIX) . '/redirects');
49
            exit;
50
        }
51
    }
52
53 View Code Duplication
    private function redirectEditRoute(Request $request, CmsComponent $cmsComponent)
0 ignored issues
show
Duplication introduced by
This method seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
54
    {
55
        $cmsComponent->subTemplate = 'redirects/form';
56
        $cmsComponent->setParameter(CmsConstants::PARAMETER_MAIN_NAV_CLASS, CmsConstants::PARAMETER_REDIRECTS);
57
        $redirect = $cmsComponent->storage->getRedirects()->getRedirectBySlug($request::$get[CmsConstants::GET_PARAMETER_SLUG]);
58
        if (isset($request::$post[CmsConstants::POST_PARAMETER_TITLE], $request::$post[CmsConstants::POST_PARAMETER_FROM_URL], $request::$post[CmsConstants::POST_PARAMETER_TO_URL])) {
59
            $cmsComponent->storage->getRedirects()->saveRedirect($request::$get[CmsConstants::GET_PARAMETER_SLUG], $request::$post);
60
            header('Location: ' . $request::$subfolders . $cmsComponent->getParameter(CmsConstants::PARAMETER_CMS_PREFIX) . '/redirects');
61
            exit;
62
        }
63
        $cmsComponent->setParameter(CmsConstants::PARAMETER_REDIRECT, $redirect);
64
    }
65
66
    private function redirectDeleteRoute(Request $request, CmsComponent $cmsComponent)
67
    {
68
        $cmsComponent->storage->getRedirects()->deleteRedirectBySlug($request::$get[CmsConstants::GET_PARAMETER_SLUG]);
69
        header('Location: ' . $request::$subfolders . $cmsComponent->getParameter(CmsConstants::PARAMETER_CMS_PREFIX) . '/redirects');
70
        exit;
71
    }
72
}