Passed
Push — master ( 3f6c85...9c6499 )
by Jens
02:40
created

SitemapItemFactory   A

Complexity

Total Complexity 4

Size/Duplication

Total Lines 33
Duplicated Lines 15.15 %

Coupling/Cohesion

Components 0
Dependencies 1

Importance

Changes 0
Metric Value
dl 5
loc 33
rs 10
c 0
b 0
f 0
wmc 4
lcom 0
cbo 1

1 Method

Rating   Name   Duplication   Size   Complexity  
B createSitemapItemFromPostValues() 5 22 4

How to fix   Duplicated Code   

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

1
<?php
2
/**
3
 * User: jensk
4
 * Date: 13-3-2017
5
 * Time: 17:04
6
 */
7
8
namespace library\storage\factories;
9
10
11
use library\cc\StringUtil;
12
13
class SitemapItemFactory
14
{
15
	/**
16
	 * Create a sitemap item from post values
17
	 *
18
	 * @param $postValues
19
	 *
20
	 * @return \stdClass
21
	 * @throws \Exception
22
	 */
23
	public static function createSitemapItemFromPostValues($postValues)
24
	{
25
		if (isset($postValues['title'], $postValues['url'], $postValues['component'], $postValues['template'])) {
26
			$sitemapObject = new \stdClass();
27
			$sitemapObject->title = $postValues['title'];
28
			$sitemapObject->slug = StringUtil::slugify($postValues['title']);
29
			$sitemapObject->url = $postValues['url'];
30
			$sitemapObject->component = $postValues['component'];
31
			$sitemapObject->template = $postValues['template'];
32
			$sitemapObject->regex = isset($postValues['regex']);
33
			$sitemapObject->parameters = new \stdClass();
34 View Code Duplication
			if (isset($postValues['parameterNames'], $postValues['parameterValues'])) {
0 ignored issues
show
Duplication introduced by
This code seems to be duplicated across your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
35
				foreach ($postValues['parameterNames'] as $key => $value) {
36
					$sitemapObject->parameters->$value = $postValues['parameterValues'][$key];
37
				}
38
			}
39
40
			return $sitemapObject;
41
		} else {
42
			throw new \Exception('Trying to create sitemap item with invalid data.');
43
		}
44
	}
45
}