Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 15 | class TermCount |
||
| 16 | { |
||
| 17 | /** |
||
| 18 | * @var \PDO |
||
| 19 | */ |
||
| 20 | protected $dbHandle; |
||
| 21 | protected $documents; |
||
| 22 | protected $filters; |
||
| 23 | protected $storage; |
||
| 24 | |||
| 25 | /** |
||
| 26 | * TermCount constructor. |
||
| 27 | * |
||
| 28 | * @param \PDO $dbHandle |
||
| 29 | * @param array $documents |
||
| 30 | * @param array $filters |
||
| 31 | * @param Storage $jsonStorage |
||
| 32 | */ |
||
| 33 | public function __construct($dbHandle, $documents, $filters, $jsonStorage) |
||
| 40 | |||
| 41 | public function execute() |
||
| 45 | |||
| 46 | View Code Duplication | protected function applyFilters($tokens) |
|
| 55 | |||
| 56 | protected function storeDocumentTermCount($document, $documentTermCount) |
||
| 83 | |||
| 84 | /** |
||
| 85 | * @param $values |
||
| 86 | * @param $sql |
||
| 87 | * @param $db |
||
| 88 | * |
||
| 89 | * @throws \Exception |
||
| 90 | */ |
||
| 91 | protected function executeStoreDocumentTermCount($values, $sql, $db) |
||
| 92 | { |
||
| 93 | $sql .= '(' . implode('),' . PHP_EOL . '(', $values) . ');'; |
||
| 94 | $stmt = $db->prepare($sql); |
||
| 95 | View Code Duplication | if ($stmt === false || !$stmt->execute()) { |
|
| 96 | $errorInfo = $db->errorInfo(); |
||
| 97 | $errorMsg = $errorInfo[2]; |
||
| 98 | throw new \Exception('SQLite Exception: ' . $errorMsg . ' in SQL: <br /><pre>' . $sql . '</pre>'); |
||
| 99 | } |
||
| 100 | } |
||
| 101 | |||
| 102 | /** |
||
| 103 | * @param $document |
||
| 104 | */ |
||
| 105 | private function createTermCountForDocument($document) |
||
| 112 | |||
| 113 | /** |
||
| 114 | * @param $documents |
||
| 115 | */ |
||
| 116 | private function iterateDocumentsAndCreateTermCount($documents) |
||
| 126 | } |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.