Passed
Push — develop ( 2975bd...a42f8c )
by Jens
02:58
created

ValuelistRouting   A

Complexity

Total Complexity 13

Size/Duplication

Total Lines 72
Duplicated Lines 19.44 %

Coupling/Cohesion

Components 0
Dependencies 5

Importance

Changes 0
Metric Value
dl 14
loc 72
rs 10
c 0
b 0
f 0
wmc 13
lcom 0
cbo 5

5 Methods

Rating   Name   Duplication   Size   Complexity  
B __construct() 0 12 7
A valuelistsRoute() 0 6 1
A newValuelistRoute() 0 12 2
A editValuelistRoute() 7 16 2
A deleteValuelistRoute() 7 7 1

How to fix   Duplicated Code   

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

1
<?php
2
/**
3
 * Created by jensk on 4-9-2017.
4
 */
5
6
namespace CloudControl\Cms\components\cms\document;
7
8
9
use CloudControl\Cms\cc\Request;
10
use CloudControl\Cms\components\cms\CmsRouting;
11
use CloudControl\Cms\components\CmsComponent;
12
13
class ValuelistRouting implements CmsRouting
14
{
15
16
    /**
17
     * CmsRouting constructor.
18
     *
19
     * @param Request $request
20
     * @param string $relativeCmsUri
21
     * @param CmsComponent $cmsComponent
22
     */
23
    public function __construct(Request $request, $relativeCmsUri, CmsComponent $cmsComponent)
24
    {
25
        if ($relativeCmsUri == '/documents/valuelists') {
26
            $this->valuelistsRoute($cmsComponent);
27
        } elseif ($relativeCmsUri == '/documents/valuelists/new') {
28
            $this->newValuelistRoute($request, $cmsComponent);
29
        } elseif ($relativeCmsUri == '/documents/valuelists/edit' && isset($request::$get[CmsComponent::GET_PARAMETER_SLUG])) {
30
            $this->editValuelistRoute($request, $cmsComponent);
31
        } elseif ($relativeCmsUri == '/documents/valuelists/delete' && isset($request::$get[CmsComponent::GET_PARAMETER_SLUG])) {
32
            $this->deleteValuelistRoute($request, $cmsComponent);
33
        }
34
    }
35
36
    private function valuelistsRoute($cmsComponent)
37
    {
38
        $cmsComponent->subTemplate = 'documents/valuelists';
39
        $cmsComponent->setParameter(CmsComponent::PARAMETER_VALUELISTS, $cmsComponent->storage->getValuelists()->getValuelists());
40
        $cmsComponent->setParameter(CmsComponent::PARAMETER_MAIN_NAV_CLASS, CmsComponent::PARAMETER_DOCUMENTS);
41
    }
42
43
    /**
44
     * @param $request
45
     * @param CmsComponent $cmsComponent
46
     */
47
    private function newValuelistRoute($request, $cmsComponent)
48
    {
49
        $cmsComponent->subTemplate = 'documents/valuelist-form';
50
        $cmsComponent->setParameter(CmsComponent::PARAMETER_MAIN_NAV_CLASS, CmsComponent::PARAMETER_DOCUMENTS);
51
        if (isset($request::$post[CmsComponent::POST_PARAMETER_TITLE])) {
52
            $slug = $cmsComponent->storage->getValuelists()->addValuelist($request::$post);
53
            $docLink = $request::$subfolders . $cmsComponent->getParameter(CmsComponent::PARAMETER_CMS_PREFIX) . '/documents/valuelists/edit?slug=' . $slug;
54
            $cmsComponent->storage->getActivityLog()->add('created valuelist <a href="' . $docLink . '">' . $request::$post[CmsComponent::POST_PARAMETER_TITLE] . '</a>', 'plus');
55
            header('Location: ' . $request::$subfolders . $cmsComponent->getParameter(CmsComponent::PARAMETER_CMS_PREFIX) . '/documents/valuelists');
56
            exit;
57
        }
58
    }
59
60
    private function editValuelistRoute($request, $cmsComponent)
61
    {
62
        $cmsComponent->subTemplate = 'documents/valuelist-form';
63
        $folder = $cmsComponent->storage->getValuelists()->getValuelistBySlug($request::$get[CmsComponent::GET_PARAMETER_SLUG]);
64
65 View Code Duplication
        if (isset($request::$post[CmsComponent::POST_PARAMETER_TITLE], $request::$get[CmsComponent::GET_PARAMETER_SLUG])) {
0 ignored issues
show
Duplication introduced by
This code seems to be duplicated across your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
66
            $cmsComponent->storage->getValuelists()->saveValuelist($request::$get[CmsComponent::GET_PARAMETER_SLUG], $request::$post);
67
            $docLink = $request::$subfolders . $cmsComponent->getParameter(CmsComponent::PARAMETER_CMS_PREFIX) . '/documents/valuelists/edit?slug=' . $request::$get[CmsComponent::GET_PARAMETER_SLUG];
68
            $cmsComponent->storage->getActivityLog()->add('edited valuelist <a href="' . $docLink . '">' . $request::$post[CmsComponent::POST_PARAMETER_TITLE] . '</a>', 'pencil');
69
            header('Location: ' . $request::$subfolders . $cmsComponent->getParameter(CmsComponent::PARAMETER_CMS_PREFIX) . '/documents/valuelists');
70
            exit;
71
        }
72
73
        $cmsComponent->setParameter(CmsComponent::PARAMETER_MAIN_NAV_CLASS, CmsComponent::PARAMETER_DOCUMENTS);
74
        $cmsComponent->setParameter(CmsComponent::PARAMETER_VALUELIST, $folder);
75
    }
76
77 View Code Duplication
    private function deleteValuelistRoute($request, $cmsComponent)
0 ignored issues
show
Duplication introduced by
This method seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
78
    {
79
        $cmsComponent->storage->getValuelists()->deleteValuelistBySlug($request::$get[CmsComponent::GET_PARAMETER_SLUG]);
80
        $cmsComponent->storage->getActivityLog()->add('deleted valuelist ' . $request::$get[CmsComponent::GET_PARAMETER_SLUG], 'trash');
81
        header('Location: ' . $request::$subfolders . $cmsComponent->getParameter(CmsComponent::PARAMETER_CMS_PREFIX) . '/documents/valuelists');
82
        exit;
83
    }
84
}