Passed
Push — develop ( c36f9a...b61b19 )
by Jens
05:31
created
src/storage/storage/ImagesStorage.php 1 patch
Doc Comments   +4 added lines patch added patch discarded remove patch
@@ -13,6 +13,10 @@
 block discarded – undo
13 13
 {
14 14
     protected $imagesDir;
15 15
 
16
+    /**
17
+     * @param \CloudControl\Cms\storage\Repository $repository
18
+     * @param string $imagesDir
19
+     */
16 20
     public function __construct($repository, $imagesDir)
17 21
     {
18 22
         parent::__construct($repository);
Please login to merge, or discard this patch.
src/templates/documents/brick.php 1 patch
Braces   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -14,8 +14,10 @@
 block discarded – undo
14 14
 				<? if (isset($dynamicBrick)) :
15 15
 					$fieldSlug = $field->slug;
16 16
 					$value = isset($dynamicBrick->fields->$fieldSlug) ? current($dynamicBrick->fields->$fieldSlug) : '';
17
-				else :
17
+				else {
18
+				    :
18 19
 					$value = '';
20
+				}
19 21
 				endif ?>
20 22
 				<? if ($field->multiple == true && $field->type != 'Rich Text') : ?>
21 23
 				<ul class="grid-wrapper sortable">
Please login to merge, or discard this patch.
src/templates/documents/document-form-form.php 1 patch
Braces   +16 added lines, -6 removed lines patch added patch discarded remove patch
@@ -1,7 +1,8 @@  discard block
 block discarded – undo
1 1
 <form method="<?= isset($documentType) ? 'post' : 'get' ?>" onsubmit="return processRtes();" action="<?= isset($formId) ? '#' . $formId : '' ?>">
2 2
     <? if (!isset($hideTitleAndState)) : ?>
3 3
       <input type="hidden" name="path" value="<?= $request::$get['path'] ?>"/>
4
-    <? else : ?>
4
+    <? else {
5
+    : ?>
5 6
       <input type="hidden" name="formId" value="<?= $formId ?>"/>
6 7
       <a name="<?= $formId ?>"></a>
7 8
     <? endif ?>
@@ -17,15 +18,19 @@  discard block
 block discarded – undo
17 18
                     <input required="required" value="<?=isset($document) ? $document->title : '' ?>" type="text" id="title" name="title" placeholder="Title" />
18 19
                 </div>
19 20
 			<? endif ?>
20
-			<?$fieldPrefix='fields';?>
21
+			<?$fieldPrefix='fields';
22
+}
23
+?>
21 24
 			<? foreach ($documentType->fields as $field) : ?>
22 25
 				<div class="form-element">
23 26
 					<label for="<?=$field->slug?>"><?=$field->title?></label>
24 27
 					<? if (isset($document)) :
25 28
 						$fieldSlug = $field->slug;
26 29
 						$value = isset($document->fields->$fieldSlug) ? current($document->fields->$fieldSlug) : '';
27
-					else :
30
+					else {
31
+					    :
28 32
 						$value = '';
33
+					}
29 34
 					endif ?>
30 35
 					<? if ($field->multiple == true && $field->type != 'Rich Text') : ?>
31 36
 					<ul class="grid-wrapper sortable">
@@ -135,8 +140,11 @@  discard block
 block discarded – undo
135 140
 					</ul>
136 141
 					<a class="btn" onclick="addDynamicBrick(this, 'true', 'newBrickDropzone_<?=$static_brick_nr?>');">+</a>
137 142
 					<?$static_brick_nr += 1?>
138
-				<? else : ?>
139
-					<?$fieldPrefix='bricks[' . $brick->slug . '][fields]';?>
143
+				<? else {
144
+    : ?>
145
+					<?$fieldPrefix='bricks[' . $brick->slug . '][fields]';
146
+}
147
+?>
140 148
 					<input type="hidden" name="bricks[<?=$brick->slug?>][type]" value="<?=$brick->brickSlug?>" />
141 149
 					<? foreach ($brick->structure->fields as $field) : ?>
142 150
 						<div class="form-element">
@@ -145,8 +153,10 @@  discard block
 block discarded – undo
145 153
 							$brickSlug = $brick->slug;
146 154
 							$fieldSlug = $field->slug;
147 155
 							$value = isset($document->bricks->$brickSlug->fields->$fieldSlug) ? current($document->bricks->$brickSlug->fields->$fieldSlug) : '';
148
-						else :
156
+						else {
157
+						    :
149 158
 							$value = '';
159
+						}
150 160
 						endif ?>
151 161
 						<? if ($field->multiple == true && $field->type != 'Rich Text') : ?>
152 162
 						<ul class="grid-wrapper sortable">
Please login to merge, or discard this patch.
src/components/cms/FilesRouting.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -68,7 +68,7 @@  discard block
 block discarded – undo
68 68
     }
69 69
 
70 70
     /**
71
-     * @param $request
71
+     * @param Request $request
72 72
      * @param CmsComponent $cmsComponent
73 73
      */
74 74
     private function newRoute($request, $cmsComponent)
@@ -83,7 +83,7 @@  discard block
 block discarded – undo
83 83
     }
84 84
 
85 85
     /**
86
-     * @param $request
86
+     * @param Request $request
87 87
      * @param CmsComponent $cmsComponent
88 88
      */
89 89
     private function deleteRoute($request, $cmsComponent)
Please login to merge, or discard this patch.
src/images/Image.php 1 patch
Doc Comments   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -76,7 +76,7 @@  discard block
 block discarded – undo
76 76
          * @param string $imagePath
77 77
          * @param bool $getExtension
78 78
          *
79
-         * @return bool|int|string
79
+         * @return integer
80 80
          */
81 81
         public function getImageMimeType($imagePath, $getExtension = false)
82 82
         {
@@ -149,7 +149,7 @@  discard block
 block discarded – undo
149 149
         }
150 150
 
151 151
         /**
152
-         * @param $pathToBitmapFile
152
+         * @param string $pathToBitmapFile
153 153
          *
154 154
          * @return string
155 155
          */
@@ -165,7 +165,7 @@  discard block
 block discarded – undo
165 165
         }
166 166
 
167 167
         /**
168
-         * @param $header
168
+         * @param string $header
169 169
          *
170 170
          * @return array
171 171
          */
@@ -195,14 +195,14 @@  discard block
 block discarded – undo
195 195
          * Loop through the data in the body of the bitmap
196 196
          * file and calculate each individual pixel based on the
197 197
          * bytes
198
-         * @param $bodySize
199
-         * @param $x
198
+         * @param integer $bodySize
199
+         * @param integer $x
200 200
          * @param $width
201
-         * @param $usePadding
202
-         * @param $y
201
+         * @param boolean $usePadding
202
+         * @param integer $y
203 203
          * @param $height
204
-         * @param $body
205
-         * @param $image
204
+         * @param string $body
205
+         * @param resource $image
206 206
          */
207 207
         private function loopThroughBodyAndCalculatePixels($bodySize, $x, $width, $usePadding, $y, $height, $body, $image)
208 208
         {
Please login to merge, or discard this patch.
src/storage/storage/FilesStorage.php 1 patch
Doc Comments   +5 added lines, -1 removed lines patch added patch discarded remove patch
@@ -10,6 +10,10 @@  discard block
 block discarded – undo
10 10
 {
11 11
     protected $filesDir;
12 12
 
13
+    /**
14
+     * @param \CloudControl\Cms\storage\Repository $repository
15
+     * @param string $filesDir
16
+     */
13 17
     public function __construct($repository, $filesDir)
14 18
     {
15 19
         parent::__construct($repository);
@@ -102,7 +106,7 @@  discard block
 block discarded – undo
102 106
     }
103 107
 
104 108
     /**
105
-     * @return mixed
109
+     * @return string
106 110
      */
107 111
     public function getFilesDir()
108 112
     {
Please login to merge, or discard this patch.
src/images/methods/BoxCrop.php 1 patch
Braces   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -27,7 +27,9 @@
 block discarded – undo
27 27
 
28 28
             // Define which ratio will be used, depending on which is the smallest side
29 29
             $ratio = min($hRatio, $wRatio);
30
-            if ($ratio > 1) $ratio = 1;
30
+            if ($ratio > 1) {
31
+                $ratio = 1;
32
+            }
31 33
 
32 34
             // Define sizes
33 35
             $this->_destWidth = floor($originalWidth * $ratio);
Please login to merge, or discard this patch.
src/images/methods/SmartCrop.php 1 patch
Braces   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -37,7 +37,9 @@
 block discarded – undo
37 37
 
38 38
             // Define which ratio will be used, depending on which is the biggest side
39 39
             $ratio = $wRatio < $hRatio ? $wRatio : $hRatio;
40
-            if ($ratio < 1) $ratio = 1;
40
+            if ($ratio < 1) {
41
+                $ratio = 1;
42
+            }
41 43
 
42 44
             // Calculate the destination width, height, x and y
43 45
             $this->_destWidth = $originalWidth / $ratio;
Please login to merge, or discard this patch.
src/images/methods/Watermark.php 1 patch
Braces   +9 added lines, -3 removed lines patch added patch discarded remove patch
@@ -63,7 +63,9 @@  discard block
 block discarded – undo
63 63
          */
64 64
         protected function calculateX($imageResource)
65 65
         {
66
-            if (intval($this->_x) === $this->_x) return $this->_x;
66
+            if (intval($this->_x) === $this->_x) {
67
+                return $this->_x;
68
+            }
67 69
 
68 70
             $x = strtolower($this->_x);
69 71
 
@@ -88,7 +90,9 @@  discard block
 block discarded – undo
88 90
          */
89 91
         public function calculateY($imageResource)
90 92
         {
91
-            if (intval($this->_y) === $this->_y) return $this->_y;
93
+            if (intval($this->_y) === $this->_y) {
94
+                return $this->_y;
95
+            }
92 96
 
93 97
             $y = strtolower($this->_y);
94 98
 
@@ -125,7 +129,9 @@  discard block
 block discarded – undo
125 129
          */
126 130
         public function GetWatermark()
127 131
         {
128
-            if ($this->_watermark == null) throw new \Exception('A watermark is not set. Please supply a \CloudControl\Cms\image\Image using $this->SetWatermark');
132
+            if ($this->_watermark == null) {
133
+                throw new \Exception('A watermark is not set. Please supply a \CloudControl\Cms\image\Image using $this->SetWatermark');
134
+            }
129 135
             return $this->_watermark;
130 136
         }
131 137
 
Please login to merge, or discard this patch.