Passed
Push — develop ( c36f9a...b61b19 )
by Jens
05:31
created

FilesRouting   A

Complexity

Total Complexity 15

Size/Duplication

Total Lines 99
Duplicated Lines 9.09 %

Coupling/Cohesion

Components 0
Dependencies 4

Importance

Changes 0
Metric Value
dl 9
loc 99
rs 10
c 0
b 0
f 0
wmc 15
lcom 0
cbo 4

6 Methods

Rating   Name   Duplication   Size   Complexity  
B __construct() 0 14 8
A downloadRoute() 0 20 1
A overviewRoute() 0 6 1
A newRoute() 0 10 2
A newAjaxRoute() 9 9 2
A deleteRoute() 0 6 1

How to fix   Duplicated Code   

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

1
<?php
2
/**
3
 * User: jensk
4
 * Date: 30-1-2017
5
 * Time: 12:46
6
 */
7
8
namespace CloudControl\Cms\components\cms;
9
10
use CloudControl\Cms\cc\Request;
11
use CloudControl\Cms\components\CmsComponent;
12
13
class FilesRouting implements CmsRouting
14
{
15
    /**
16
     * FilesRouting constructor.
17
     *
18
     * @param Request $request
19
     * @param $relativeCmsUri
20
     * @param CmsComponent $cmsComponent
21
     */
22
    public function __construct(Request $request, $relativeCmsUri, CmsComponent $cmsComponent)
23
    {
24
        if ($relativeCmsUri == '/files') {
25
            $this->overviewRoute($cmsComponent);
26
        } elseif ($relativeCmsUri == '/files/new') {
27
            $this->newRoute($request, $cmsComponent);
28
        } elseif ($relativeCmsUri == '/files/new-ajax') {
29
            $this->newAjaxRoute($cmsComponent);
30
        } elseif ($relativeCmsUri == '/files/get' && isset($request::$get[CmsComponent::FILES_PARAMETER_FILE])) {
31
            $this->downloadRoute($request::$get[CmsComponent::FILES_PARAMETER_FILE], $cmsComponent);
32
        } elseif ($relativeCmsUri == '/files/delete' && isset($request::$get[CmsComponent::FILES_PARAMETER_FILE])) {
33
            $this->deleteRoute($request, $cmsComponent);
34
        }
35
    }
36
37
    /**
38
     * @param $slug
39
     * @param CmsComponent $cmsComponent
40
     */
41
    private function downloadRoute($slug, $cmsComponent)
42
    {
43
        $file = $cmsComponent->storage->getFiles()->getFileByName($slug);
0 ignored issues
show
Bug introduced by
Are you sure the assignment to $file is correct as $cmsComponent->storage->...)->getFileByName($slug) (which targets CloudControl\Cms\storage...torage::getFileByName()) seems to always return null.

This check looks for function or method calls that always return null and whose return value is assigned to a variable.

class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();

The method getObject() can return nothing but null, so it makes no sense to assign that value to a variable.

The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes.

Loading history...
44
        $path = realpath($cmsComponent->storage->getFiles()->getFilesDir());
45
        $quoted = sprintf('"%s"', addcslashes(basename($path . '/' . $file->file), '"\\'));
46
        $size = filesize($path . '/' . $file->file);
47
48
        header('Content-Description: File Transfer');
49
        header('Content-Type: ' . $file->type);
50
        header('Content-Disposition: attachment; filename=' . $quoted);
51
        header('Content-Transfer-Encoding: binary');
52
        header('Connection: Keep-Alive');
53
        header('Expires: 0');
54
        header('Cache-Control: must-revalidate, post-check=0, pre-check=0');
55
        header('Pragma: public');
56
        header('Content-Length: ' . $size);
57
58
        readfile($path . '/' . $file->file);
59
        exit;
60
    }
61
62
    /**
63
     * @param CmsComponent $cmsComponent
64
     */
65
    private function overviewRoute($cmsComponent)
66
    {
67
        $cmsComponent->subTemplate = 'files';
68
        $cmsComponent->setParameter(CmsComponent::PARAMETER_MAIN_NAV_CLASS, CmsComponent::PARAMETER_FILES);
69
        $cmsComponent->setParameter(CmsComponent::PARAMETER_FILES, $cmsComponent->storage->getFiles()->getFiles());
70
    }
71
72
    /**
73
     * @param $request
74
     * @param CmsComponent $cmsComponent
75
     */
76
    private function newRoute($request, $cmsComponent)
77
    {
78
        $cmsComponent->subTemplate = 'files/form';
79
        $cmsComponent->setParameter(CmsComponent::PARAMETER_MAIN_NAV_CLASS, CmsComponent::PARAMETER_FILES);
80
        if (isset($_FILES[CmsComponent::FILES_PARAMETER_FILE])) {
81
            $cmsComponent->storage->getFiles()->addFile($_FILES[CmsComponent::FILES_PARAMETER_FILE]);
82
            header('Location: ' . $request::$subfolders . $cmsComponent->getParameter(CmsComponent::PARAMETER_CMS_PREFIX) . '/files');
83
            exit;
84
        }
85
    }
86
87
    /**
88
     * @param CmsComponent $cmsComponent
89
     */
90 View Code Duplication
    private function newAjaxRoute($cmsComponent)
0 ignored issues
show
Duplication introduced by
This method seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
91
    {
92
        if (isset($_FILES[CmsComponent::FILES_PARAMETER_FILE])) {
93
            $file = $cmsComponent->storage->getFiles()->addFile($_FILES[CmsComponent::FILES_PARAMETER_FILE]);
94
            header('Content-type: application/json');
95
            die(json_encode($file));
96
        }
97
        die('error occured');
98
    }
99
100
    /**
101
     * @param $request
102
     * @param CmsComponent $cmsComponent
103
     */
104
    private function deleteRoute($request, $cmsComponent)
105
    {
106
        $cmsComponent->storage->getFiles()->deleteFileByName($request::$get[CmsComponent::FILES_PARAMETER_FILE]);
107
        header('Location: ' . $request::$subfolders . $cmsComponent->getParameter(CmsComponent::PARAMETER_CMS_PREFIX) . '/files');
108
        exit;
109
    }
110
111
}