GitHub Access Token became invalid

It seems like the GitHub access token used for retrieving details about this repository from GitHub became invalid. This might prevent certain types of inspections from being run (in particular, everything related to pull requests).
Please ask an admin of your repository to re-new the access token on this website.
Passed
Push — master ( c2bf29...11c7a3 )
by Jens
05:50 queued 03:00
created
lib/CardDAV-PHP/carddav.php 1 patch
Braces   +86 added lines, -38 removed lines patch added patch discarded remove patch
@@ -219,7 +219,8 @@  discard block
 block discarded – undo
219 219
      */
220 220
     public function __construct($url = null)
221 221
     {
222
-        if ($url !== null) {
222
+        if ($url !== null)
223
+        {
223 224
             $this->setUrl($url);
224 225
         }
225 226
     }
@@ -245,7 +246,8 @@  discard block
 block discarded – undo
245 246
     {
246 247
         $this->url = $url;
247 248
 
248
-        if (substr($this->url, -1, 1) !== '/') {
249
+        if (substr($this->url, -1, 1) !== '/')
250
+        {
249 251
             $this->url = $this->url . '/';
250 252
         }
251 253
 
@@ -339,9 +341,12 @@  discard block
 block discarded – undo
339 341
         {
340 342
             case 200:
341 343
             case 207:
342
-                if ($raw === true) {
344
+                if ($raw === true)
345
+                {
343 346
                     return $result['response'];
344
-                } else {
347
+                }
348
+                else
349
+                {
345 350
                     return $this->simplify($result['response'], $include_vcards);
346 351
                 }
347 352
         }
@@ -368,13 +373,13 @@  discard block
 block discarded – undo
368 373
         // print_r($result);
369 374
 
370 375
 	switch ($result['http_code'])
371
-        {
376
+	{
372 377
 		case 404:
373 378
 			$altResult  = $this->query($this->url . $vcard_id , 'GET');
374 379
 		        // DEBUG: print the response of the carddav-server
375 380
 		        // print_r($altResult);
376 381
 	                switch ($altResult['http_code'])
377
-        	        {
382
+	                {
378 383
                 	        case 200:
379 384
 	                        case 207:
380 385
 					print "Ignoring given Vcard Extension (".$this->url_vcard_extension.")" . PHP_EOL. ".";
@@ -458,9 +463,12 @@  discard block
 block discarded – undo
458 463
     {
459 464
         $result = $this->query($this->url, 'OPTIONS');
460 465
 
461
-        if ($result['http_code'] === 200) {
466
+        if ($result['http_code'] === 200)
467
+        {
462 468
             return true;
463
-        } else {
469
+        }
470
+        else
471
+        {
464 472
             return false;
465 473
         }
466 474
     }
@@ -509,7 +517,8 @@  discard block
 block discarded – undo
509 517
      */
510 518
     public function add($vcard, $vcard_id = null)
511 519
     {
512
-        if ($vcard_id === null) {
520
+        if ($vcard_id === null)
521
+        {
513 522
             $vcard_id   = $this->generateVcardId();
514 523
         }
515 524
         $vcard  = $this->cleanVcard($vcard);
@@ -536,9 +545,12 @@  discard block
 block discarded – undo
536 545
      */
537 546
     public function update($vcard, $vcard_id)
538 547
     {
539
-        try {
548
+        try
549
+        {
540 550
             return $this->add($vcard, $vcard_id);
541
-        } catch (Exception $e) {
551
+        }
552
+        catch (Exception $e)
553
+        {
542 554
             throw new \Exception($e->getMessage(), self::EXCEPTION_WRONG_HTTP_STATUS_CODE_UPDATE);
543 555
         }
544 556
     }
@@ -554,9 +566,12 @@  discard block
 block discarded – undo
554 566
     {
555 567
         $response = $this->cleanResponse($response);
556 568
 
557
-        try {
569
+        try
570
+        {
558 571
             $xml = new \SimpleXMLElement($response);
559
-        } catch (Exception $e) {
572
+        }
573
+        catch (Exception $e)
574
+        {
560 575
             throw new \Exception(
561 576
                 "The XML response seems to be malformed and can't be simplified!",
562 577
                 self::EXCEPTION_MALFORMED_XML_RESPONSE,
@@ -571,35 +586,50 @@  discard block
 block discarded – undo
571 586
         $simplified_xml->startDocument('1.0', 'utf-8');
572 587
             $simplified_xml->startElement('response');
573 588
 
574
-        if (!empty($xml->response)) {
575
-            foreach ($xml->response as $response) {
589
+        if (!empty($xml->response))
590
+        {
591
+            foreach ($xml->response as $response)
592
+            {
576 593
               if ((preg_match('/vcard/', $response->propstat->prop->getcontenttype) || preg_match('/vcf/', $response->href)) &&
577
-                  !$response->propstat->prop->resourcetype->collection) {
594
+                  !$response->propstat->prop->resourcetype->collection)
595
+              {
578 596
                     $id = basename($response->href);
579 597
                     $id = str_replace($this->url_vcard_extension, null, $id);
580 598
 
581
-                    try {
599
+                    try
600
+                    {
582 601
                         $vcardData = $this->getVcard($id);
583
-                        if (!empty($id)) {
602
+                        if (!empty($id))
603
+                        {
584 604
                             $simplified_xml->startElement('element');
585 605
                                 $simplified_xml->writeElement('id', $id);
586 606
                                 $simplified_xml->writeElement('etag', str_replace('"', null, $response->propstat->prop->getetag));
587 607
                                 $simplified_xml->writeElement('last_modified', $response->propstat->prop->getlastmodified);
588 608
 
589
-                            if ($include_vcards === true) {
609
+                            if ($include_vcards === true)
610
+                            {
590 611
                                 $simplified_xml->writeElement('vcard', $vcardData);
591 612
                             }
592 613
                             $simplified_xml->endElement();
593 614
                         }
594
-                    } catch (\Exception $e) {
615
+                    }
616
+                    catch (\Exception $e)
617
+                    {
595 618
                         print("Error fetching vCard: {$id}: {$e->getMessage()}\n");
596 619
                     }
597
-                } elseif (preg_match('/unix-directory/', $response->propstat->prop->getcontenttype)) {
598
-                    if (isset($response->propstat->prop->href)) {
620
+                }
621
+                elseif (preg_match('/unix-directory/', $response->propstat->prop->getcontenttype))
622
+                {
623
+                    if (isset($response->propstat->prop->href))
624
+                    {
599 625
                         $href = $response->propstat->prop->href;
600
-                    } elseif (isset($response->href)) {
626
+                    }
627
+                    elseif (isset($response->href))
628
+                    {
601 629
                         $href = $response->href;
602
-                    } else {
630
+                    }
631
+                    else
632
+                    {
603 633
                         $href = null;
604 634
                     }
605 635
 
@@ -643,7 +673,8 @@  discard block
 block discarded – undo
643 673
      */
644 674
     public function curlInit()
645 675
     {
646
-        if (empty($this->curl)) {
676
+        if (empty($this->curl))
677
+        {
647 678
             $this->curl = curl_init();
648 679
             curl_setopt($this->curl, CURLOPT_HEADER, true);
649 680
             curl_setopt($this->curl, CURLOPT_SSL_VERIFYHOST, false);
@@ -651,7 +682,8 @@  discard block
 block discarded – undo
651 682
             curl_setopt($this->curl, CURLOPT_RETURNTRANSFER, true);
652 683
             curl_setopt($this->curl, CURLOPT_USERAGENT, self::USERAGENT.self::VERSION);
653 684
 
654
-            if ($this->auth !== null) {
685
+            if ($this->auth !== null)
686
+            {
655 687
                 curl_setopt($this->curl, CURLOPT_HTTPAUTH, CURLAUTH_ANY);
656 688
                 curl_setopt($this->curl, CURLOPT_USERPWD, $this->auth);
657 689
             }
@@ -681,17 +713,23 @@  discard block
 block discarded – undo
681 713
         curl_setopt($this->curl, CURLOPT_URL, $url);
682 714
         curl_setopt($this->curl, CURLOPT_CUSTOMREQUEST, $method);
683 715
 
684
-        if ($content !== null) {
716
+        if ($content !== null)
717
+        {
685 718
             curl_setopt($this->curl, CURLOPT_POST, true);
686 719
             curl_setopt($this->curl, CURLOPT_POSTFIELDS, $content);
687
-        } else {
720
+        }
721
+        else
722
+        {
688 723
             curl_setopt($this->curl, CURLOPT_POST, false);
689 724
             curl_setopt($this->curl, CURLOPT_POSTFIELDS, null);
690 725
         }
691 726
 
692
-        if ($content_type !== null) {
727
+        if ($content_type !== null)
728
+        {
693 729
             curl_setopt($this->curl, CURLOPT_HTTPHEADER, array('Content-type: '.$content_type, 'Depth: 1'));
694
-        } else {
730
+        }
731
+        else
732
+        {
695 733
             curl_setopt($this->curl, CURLOPT_HTTPHEADER, array('Depth: 1'));
696 734
         }
697 735
 
@@ -706,7 +744,8 @@  discard block
 block discarded – undo
706 744
             'http_code'         => $http_code
707 745
         );
708 746
 
709
-        if ($this->debug === true) {
747
+        if ($this->debug === true)
748
+        {
710 749
             $debug = $return;
711 750
             $debug['url']           = $url;
712 751
             $debug['method']        = $method;
@@ -728,26 +767,34 @@  discard block
 block discarded – undo
728 767
     {
729 768
         $vcard_id = null;
730 769
 
731
-        for ($number = 0; $number <= 25; $number ++) {
732
-            if ($number == 8 || $number == 17) {
770
+        for ($number = 0; $number <= 25; $number ++)
771
+        {
772
+            if ($number == 8 || $number == 17)
773
+            {
733 774
                 $vcard_id .= '-';
734
-            } else {
775
+            }
776
+            else
777
+            {
735 778
                 $vcard_id .= $this->vcard_id_chars[mt_rand(0, (count($this->vcard_id_chars) - 1))];
736 779
             }
737 780
         }
738 781
 
739
-        try {
782
+        try
783
+        {
740 784
             $carddav = new CardDavBackend($this->url);
741 785
             $carddav->setAuth($this->username, $this->password);
742 786
 
743 787
             $result = $carddav->query($this->url . $vcard_id . $this->url_vcard_extension, 'GET');
744 788
 
745
-            if ($result['http_code'] !== 404) {
789
+            if ($result['http_code'] !== 404)
790
+            {
746 791
                 $vcard_id = $this->generateVcardId();
747 792
             }
748 793
 
749 794
             return $vcard_id;
750
-        } catch (Exception $e) {
795
+        }
796
+        catch (Exception $e)
797
+        {
751 798
             throw new \Exception($e->getMessage(), self::EXCEPTION_COULD_NOT_GENERATE_NEW_VCARD_ID);
752 799
         }
753 800
     }
@@ -760,7 +807,8 @@  discard block
 block discarded – undo
760 807
      */
761 808
     public function __destruct()
762 809
     {
763
-        if (!empty($this->curl)) {
810
+        if (!empty($this->curl))
811
+        {
764 812
             curl_close($this->curl);
765 813
         }
766 814
     }
Please login to merge, or discard this patch.
lib/fritzbox_api_php/fritzbox_ring_phone.php 1 patch
Braces   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,7 @@
 block discarded – undo
3 3
 // init the output message
4 4
 $message = date('Y-m-d H:i') . ' ';
5 5
 try
6
-{ 
6
+{
7 7
   // load the fritzbox_api class
8 8
   require_once(__DIR__ . '/fritzbox_api.class.php');
9 9
   $fritz = new fritzbox_api();
Please login to merge, or discard this patch.
lib/fritzbox_api_php/fritzbox_api.class.php 1 patch
Braces   +41 added lines, -20 removed lines patch added patch discarded remove patch
@@ -46,7 +46,8 @@  discard block
 block discarded – undo
46 46
  * the main Fritz!Box API class
47 47
  *
48 48
  */
49
-class fritzbox_api {
49
+class fritzbox_api
50
+{
50 51
   /**
51 52
     * @var  object  config object
52 53
     */
@@ -69,7 +70,8 @@  discard block
 block discarded – undo
69 70
 	$this->config = new fritzbox_api_config();
70 71
     
71 72
 	// try autoloading the config
72
-	if (file_exists(__DIR__ . '/fritzbox_user.conf.php') && is_readable(__DIR__ . '/fritzbox_user.conf.php') ) {
73
+	if (file_exists(__DIR__ . '/fritzbox_user.conf.php') && is_readable(__DIR__ . '/fritzbox_user.conf.php') )
74
+	{
73 75
 		require_once(__DIR__ . '/fritzbox_user.conf.php');
74 76
 	}
75 77
 
@@ -77,29 +79,37 @@  discard block
 block discarded – undo
77 79
 	$this->config->setItem('fritzbox_ip',$fritzbox_ip);
78 80
 
79 81
 	// check if login on local network (fritz.box) or via a dynamic DNS-host
80
-	if ($fritzbox_ip != 'fritz.box' && !$force_local_login) {
82
+	if ($fritzbox_ip != 'fritz.box' && !$force_local_login)
83
+	{
81 84
 		$this->config->setItem('enable_remote_config',true);
82 85
 		$this->config->setItem('remote_config_user',$user_name);
83 86
 		$this->config->setItem('remote_config_password',$password);
84 87
 		$this->config->setItem('fritzbox_url', 'https://'.$this->config->getItem('fritzbox_ip'));
85
-	} else {
88
+	}
89
+	else
90
+	{
86 91
 		$this->config->setItem('enable_remote_config',false);
87
-		if($user_name != false){
92
+		if($user_name != false)
93
+		{
88 94
 			$this->config->setItem('username',$user_name);
89 95
 		}
90
-		if($password != false){
96
+		if($password != false)
97
+		{
91 98
 			$this->config->setItem('password',$password);
92 99
 		}
93 100
 		$this->config->setItem('fritzbox_url', 'http://' . $this->config->getItem('fritzbox_ip'));
94 101
 	}
95 102
 
96 103
 	// make some config consistency checks
97
-	if ( $this->config->getItem('enable_remote_config') === true ){
98
-		if ( !$this->config->getItem('remote_config_user') || !$this->config->getItem('remote_config_password') ){
104
+	if ( $this->config->getItem('enable_remote_config') === true )
105
+	{
106
+		if ( !$this->config->getItem('remote_config_user') || !$this->config->getItem('remote_config_password') )
107
+		{
99 108
 		  $this->error('ERROR: Remote config mode enabled, but no username or no password provided');
100 109
 		}
101 110
 	}
102
-	else {
111
+	else
112
+	{
103 113
 		$this->config->setItem('old_remote_config_user', null);
104 114
 		$this->config->setItem('old_remote_config_password', null);
105 115
 	}
@@ -148,10 +158,13 @@  discard block
 block discarded – undo
148 158
     if ( $this->config->getItem('enable_remote_config') == true )
149 159
     {
150 160
 		// set name of SSL-certificate (must be same as remote-hostname (dynDNS) of FRITZ!Box) and remove port in address if alternate port is given
151
-		if (strpos($this->config->getItem('fritzbox_ip'),":")){
161
+		if (strpos($this->config->getItem('fritzbox_ip'),":"))
162
+		{
152 163
 			$ssl_cert_fritzbox = explode(":", $this->config->getItem('fritzbox_ip'));
153 164
 			$ssl_cert_fritzbox = $ssl_cert_fritzbox[0];
154
-		} else {
165
+		}
166
+		else
167
+		{
155 168
 			$ssl_cert_fritzbox = $this->config->getItem('fritzbox_ip');
156 169
 		}
157 170
 
@@ -162,7 +175,8 @@  discard block
 block discarded – undo
162 175
 		curl_setopt($ch, CURLOPT_CAPATH, '/etc/ssl/certs');
163 176
 
164 177
 		// support for pre FRITZ!OS 5.50 remote config
165
-		if (!$this->config->getItem('use_lua_login_method')){
178
+		if (!$this->config->getItem('use_lua_login_method'))
179
+		{
166 180
 		curl_setopt($ch, CURLOPT_USERPWD, $this->config->getItem('remote_config_user') . ':' . $this->config->getItem('remote_config_password'));
167 181
 		}
168 182
     }
@@ -173,7 +187,7 @@  discard block
 block discarded – undo
173 187
   }
174 188
 
175 189
   public function doPostFile($formfields = array(), $filefileds = array())
176
-  {  
190
+  {
177 191
     $ch = curl_init();
178 192
    
179 193
     // add the sid, if it is already set
@@ -192,11 +206,13 @@  discard block
 block discarded – undo
192 206
     curl_setopt($ch, CURLOPT_RETURNTRANSFER, 1);
193 207
     
194 208
     // if filefileds not specified ('@/path/to/file.xml;type=text/xml' works fine)
195
-    if(empty( $filefileds )) {
209
+    if(empty( $filefileds ))
210
+    {
196 211
 		curl_setopt($ch, CURLOPT_POSTFIELDS, $formfields); // http_build_query
197 212
 	} 
198 213
 	// post calculated raw data
199
-	else {
214
+	else
215
+	{
200 216
 		$header = $this->_create_custom_file_post_header($formfields, $filefileds);
201 217
 		curl_setopt($ch, CURLOPT_HTTPHEADER , array(
202 218
 			'Content-Type: multipart/form-data; boundary=' . $header['delimiter'], 'Content-Length: ' . strlen($header['data']) )
@@ -208,7 +224,8 @@  discard block
 block discarded – undo
208 224
     $output = curl_exec($ch);
209 225
 
210 226
 	// curl error
211
-	if(curl_errno($ch)) {
227
+	if(curl_errno($ch))
228
+	{
212 229
 		$this->error(curl_error($ch)." (".curl_errno($ch).")");
213 230
 	}
214 231
 
@@ -223,7 +240,8 @@  discard block
 block discarded – undo
223 240
     return $output;
224 241
   }
225 242
 
226
-  private function _create_custom_file_post_header($postFields, $fileFields) {
243
+  private function _create_custom_file_post_header($postFields, $fileFields)
244
+  {
227 245
 		// form field separator
228 246
 		$delimiter = '-------------' . uniqid();
229 247
 		
@@ -245,7 +263,8 @@  discard block
 block discarded – undo
245 263
 		$data = '';
246 264
 
247 265
 		// populate normal fields first (simpler)
248
-		foreach ($postFields as $name => $content) {
266
+		foreach ($postFields as $name => $content)
267
+		{
249 268
 		   $data .= "--" . $delimiter . "\r\n";
250 269
 			$data .= 'Content-Disposition: form-data; name="' . urlencode($name) . '"';
251 270
 			$data .= "\r\n\r\n";
@@ -253,7 +272,8 @@  discard block
 block discarded – undo
253 272
 			$data .= "\r\n";
254 273
 		}
255 274
 		// populate file fields
256
-		foreach ($fileFields as $name => $file) {
275
+		foreach ($fileFields as $name => $file)
276
+		{
257 277
 			$data .= "--" . $delimiter . "\r\n";
258 278
 			// "filename" attribute is not essential; server-side scripts may use it
259 279
 			$data .= 'Content-Disposition: form-data; name="' . urlencode($name) . '";' .
@@ -479,7 +499,8 @@  discard block
 block discarded – undo
479 499
   }
480 500
 }
481 501
 
482
-class fritzbox_api_config {
502
+class fritzbox_api_config
503
+{
483 504
   protected $config = array();
484 505
 
485 506
   public function __construct()
Please login to merge, or discard this patch.
lib/vCard-parser/vCard.php 1 patch
Braces   +6 added lines, -5 removed lines patch added patch discarded remove patch
@@ -225,10 +225,13 @@  discard block
 block discarded – undo
225 225
 									{
226 226
 										//$Value = base64_decode($Value);
227 227
 									}
228
-									elseif ($ParamValue == 'quoted-printable') // v2.1
228
+									elseif ($ParamValue == 'quoted-printable')
229
+									{
230
+									  // v2.1
229 231
 									{
230 232
 										$Value = quoted_printable_decode($Value);
231 233
 									}
234
+									}
232 235
 									break;
233 236
 								case 'charset': // v2.1
234 237
 									if ($ParamValue != 'utf-8' && $ParamValue != 'utf8')
@@ -407,8 +410,7 @@  discard block
 block discarded – undo
407 410
 
408 411
 				if (isset(self::$Spec_StructuredElements[$Key]) &&
409 412
 					in_array(strtolower($Arguments[1]), self::$Spec_StructuredElements[$Key])
410
-				)
411
-				{
413
+				) {
412 414
 					$LastElementIndex = 0;
413 415
 
414 416
 					if (count($this -> Data[$Key]))
@@ -596,8 +598,7 @@  discard block
 block discarded – undo
596 598
 					if (
597 599
 						(isset(self::$Spec_ElementTypes[$Key]) && in_array($Parameter[0], self::$Spec_ElementTypes[$Key])) ||
598 600
 						($Key == 'email' && is_scalar($Parameter[0]))
599
-					)
600
-					{
601
+					) {
601 602
 						$Type[] = $Parameter[0];
602 603
 					}
603 604
 				}
Please login to merge, or discard this patch.
carddav2fb.php 1 patch
Braces   +222 added lines, -98 removed lines patch added patch discarded remove patch
@@ -38,9 +38,12 @@  discard block
 block discarded – undo
38 38
 require_once('lib/fritzbox_api_php/fritzbox_api.class.php');
39 39
 
40 40
 if($argc == 2)
41
+{
41 42
   $config_file_name = $argv[1];
42
-else
43
+}
44
+else {
43 45
   $config_file_name = __DIR__ . '/config.php';
46
+}
44 47
 
45 48
 // default/fallback config options
46 49
 $config['tmp_dir'] = sys_get_temp_dir();
@@ -60,7 +63,9 @@  discard block
 block discarded – undo
60 63
 $config['quickdial_keyword'] = 'Quickdial:';
61 64
 
62 65
 if(is_file($config_file_name))
66
+{
63 67
   require($config_file_name);
68
+}
64 69
 else
65 70
 {
66 71
   print 'ERROR: No ' . $config_file_name . ' found, please take a look at config.example.php and create a ' . $config_file_name . ' file!' . PHP_EOL;
@@ -91,9 +96,12 @@  discard block
 block discarded – undo
91 96
 // upload the XML-file to the FRITZ!Box (CAUTION: this will overwrite all current entries in the phone book!!)
92 97
 print 'Upload data to FRITZ!Box @ ' . $config['fritzbox_ip'] . PHP_EOL;
93 98
 if($client->upload_to_fb())
99
+{
94 100
   print 'Done.' . PHP_EOL;
95
-else
101
+}
102
+else {
96 103
   exit(1);
104
+}
97 105
 
98 106
 flush(); // in case this script runs by php-cgi
99 107
 
@@ -124,7 +132,9 @@  discard block
 block discarded – undo
124 132
   public function mktemp($dir, $prefix = '', $mode = 0700)
125 133
   {
126 134
     if(substr($dir, -1) != '/')
127
-      $dir .= '/';
135
+    {
136
+          $dir .= '/';
137
+    }
128 138
 
129 139
     do
130 140
     {
@@ -145,7 +155,12 @@  discard block
 block discarded – undo
145 155
         if($object != "." && $object != "..")
146 156
         {
147 157
           if(filetype($dir . "/" . $object) == "dir")
148
-            rrmdir($dir . "/" . $object); else unlink($dir . "/" . $object);
158
+          {
159
+                      rrmdir($dir . "/" . $object);
160
+          }
161
+          else {
162
+              unlink($dir . "/" . $object);
163
+            }
149 164
         }
150 165
       }
151 166
       reset($objects);
@@ -159,18 +174,25 @@  discard block
 block discarded – undo
159 174
     {
160 175
       // Check if there are valid base64 characters
161 176
       if(!preg_match('/^[a-zA-Z0-9\/\r\n+]*={0,2}$/', $str))
162
-        return false;
177
+      {
178
+              return false;
179
+      }
163 180
 
164 181
       // Decode the string in strict mode and check the results
165 182
       $decoded = base64_decode($str, true);
166 183
       if($decoded === false)
167
-        return false;
184
+      {
185
+              return false;
186
+      }
168 187
 
169 188
       // Encode the string again
170 189
       if(base64_encode($decoded) === $str)
171
-        return true;
172
-      else
173
-        return false;
190
+      {
191
+              return true;
192
+      }
193
+      else {
194
+              return false;
195
+      }
174 196
     }
175 197
     catch(Exception $e)
176 198
     {
@@ -211,7 +233,9 @@  discard block
 block discarded – undo
211 233
         // set the vcard extension in case the user
212 234
         // defined it in the config
213 235
         if(isset($conf['extension']))
214
-          $carddav->setVcardExtension($conf['extension']);
236
+        {
237
+                  $carddav->setVcardExtension($conf['extension']);
238
+        }
215 239
 
216 240
         // retrieve data from the CardDAV server now
217 241
         $xmldata = $carddav->get();
@@ -220,7 +244,9 @@  discard block
 block discarded – undo
220 244
         // CardDAV server and if not reencode it since the FRITZ!Box
221 245
         // requires UTF-8 encoded data
222 246
         if(iconv('utf-8', 'utf-8//IGNORE', $xmldata) != $xmldata)
223
-          $xmldata = utf8_encode($xmldata);
247
+        {
248
+                  $xmldata = utf8_encode($xmldata);
249
+        }
224 250
 
225 251
         // read raw_vcard data from xml response
226 252
         $raw_vcards = array();
@@ -242,10 +268,14 @@  discard block
 block discarded – undo
242 268
           $vcard_obj = new vCard(false, $v);
243 269
           $name_arr = null;
244 270
           if(isset($vcard_obj->n[0]))
245
-            $name_arr = $vcard_obj->n[0];
271
+          {
272
+                      $name_arr = $vcard_obj->n[0];
273
+          }
246 274
           $org_arr = null;
247 275
           if(isset($vcard_obj->org[0]))
248
-            $org_arr = $vcard_obj->org[0];
276
+          {
277
+                      $org_arr = $vcard_obj->org[0];
278
+          }
249 279
           $addnames = '';
250 280
           $prefix = '';
251 281
           $suffix = '';
@@ -254,19 +284,29 @@  discard block
 block discarded – undo
254 284
 
255 285
           // Build name Parts if existing ans switch to true in config
256 286
           if(isset($name_arr['prefixes']) and $this->config['prefix'])
257
-            $prefix = trim($name_arr['prefixes']);
287
+          {
288
+                      $prefix = trim($name_arr['prefixes']);
289
+          }
258 290
 
259 291
           if(isset($name_arr['suffixes']) and $this->config['suffix'])
260
-            $suffix = trim($name_arr['suffixes']);
292
+          {
293
+                      $suffix = trim($name_arr['suffixes']);
294
+          }
261 295
 
262 296
           if(isset($name_arr['additionalnames']) and $this->config['addnames'])
263
-            $addnames = trim($name_arr['additionalnames']);
297
+          {
298
+                      $addnames = trim($name_arr['additionalnames']);
299
+          }
264 300
 
265 301
           if(isset($org_arr['name']) and $this->config['orgname'])
266
-            $orgname = trim($org_arr['name']);
302
+          {
303
+                      $orgname = trim($org_arr['name']);
304
+          }
267 305
 
268 306
           if (isset($vcard_obj->fn[0]))
269
-            $formattedname = $vcard_obj->fn[0];
307
+          {
308
+                      $formattedname = $vcard_obj->fn[0];
309
+          }
270 310
 
271 311
           $firstname = trim($name_arr['firstname']);
272 312
           $lastname = trim($name_arr['lastname']);
@@ -286,78 +326,106 @@  discard block
 block discarded – undo
286 326
 
287 327
           // Prefix
288 328
           if(!empty($prefix))
289
-            $name .= $prefix;
329
+          {
330
+                      $name .= $prefix;
331
+          }
290 332
 
291 333
           if($format == 0)
292 334
           {
293 335
             // Lastname
294 336
             if(!empty($name) and !empty($lastname))
295
-              $name .= ' ' . $lastname;
296
-            else
297
-              $name .= $lastname;
337
+            {
338
+                          $name .= ' ' . $lastname;
339
+            }
340
+            else {
341
+                          $name .= $lastname;
342
+            }
298 343
           }
299 344
           else
300 345
           {
301 346
             // Firstname
302 347
             if(!empty($name) and !empty($firstname))
303
-              $name .= ' ' . $firstname;
304
-            else
305
-              $name .= $firstname;
348
+            {
349
+                          $name .= ' ' . $firstname;
350
+            }
351
+            else {
352
+                          $name .= $firstname;
353
+            }
306 354
           }
307 355
 
308 356
           if($format == 2)
309 357
           {
310 358
             // AdditionalNames
311 359
             if(!empty($name) and !empty($addnames))
312
-              $name .= ' ' . $addnames;
313
-            else
314
-              $name .= $addnames;
360
+            {
361
+                          $name .= ' ' . $addnames;
362
+            }
363
+            else {
364
+                          $name .= $addnames;
365
+            }
315 366
           }
316 367
 
317 368
           if($format == 0)
318 369
           {
319 370
             // Firstname
320 371
             if(!empty($name) and !empty($firstname))
321
-              $name .= ', ' . $firstname;
322
-            else
323
-              $name .= $firstname;
372
+            {
373
+                          $name .= ', ' . $firstname;
374
+            }
375
+            else {
376
+                          $name .= $firstname;
377
+            }
324 378
           }
325 379
           else
326 380
           {
327 381
             // Lastname
328 382
             if(!empty($name) and !empty($lastname))
329
-              $name .= ' ' . $lastname;
330
-            else
331
-              $name .= $lastname;
383
+            {
384
+                          $name .= ' ' . $lastname;
385
+            }
386
+            else {
387
+                          $name .= $lastname;
388
+            }
332 389
           }
333 390
 
334 391
           if($format != 2)
335 392
           {
336 393
             // AdditionalNames
337 394
             if(!empty($name) and !empty($addnames))
338
-              $name .= ' ' . $addnames;
339
-            else
340
-              $name .= $addnames;
395
+            {
396
+                          $name .= ' ' . $addnames;
397
+            }
398
+            else {
399
+                          $name .= $addnames;
400
+            }
341 401
           }
342 402
 
343 403
           // Suffix
344 404
           if(!empty($name) and !empty($suffix))
345
-            $name .= ' ' . $suffix;
346
-          else
347
-            $name .= $suffix;
405
+          {
406
+                      $name .= ' ' . $suffix;
407
+          }
408
+          else {
409
+                      $name .= $suffix;
410
+          }
348 411
 
349 412
           // OrgName
350 413
           if(!empty($name) and !empty($orgname))
351
-            $name .= ' (' . $orgname . ')';
352
-          else
353
-            $name .= $orgname;
414
+          {
415
+                      $name .= ' (' . $orgname . ')';
416
+          }
417
+          else {
418
+                      $name .= $orgname;
419
+          }
354 420
 
355 421
           // make sure to trim whitespaces and double spaces
356 422
           $name = trim(str_replace('  ', ' ', $name));
357 423
 
358 424
           // perform a fallback to formatted name, if we don't have any name and formatted name is available
359 425
           if(empty($name) and !empty($formattedname))
360
-            $name = $formattedname;
426
+          {
427
+                      $name = $formattedname;
428
+          }
361 429
 
362 430
           if(empty($name))
363 431
           {
@@ -371,15 +439,19 @@  discard block
 block discarded – undo
371 439
             $photo = str_replace(array(',', '&', ' ', '/', 'ä', 'ö', 'ü', 'Ä', 'Ö', 'Ü', 'ß', 'á', 'à', 'ó', 'ò', 'ú', 'ù', 'í', 'ø'),
372 440
             array('', '_', '_', '_', 'ae', 'oe', 'ue', 'Ae', 'Oe', 'Ue', 'ss', 'a', 'a', 'o', 'o', 'u', 'u', 'i', 'oe'), $name);
373 441
           }
374
-          else
375
-            $photo = '';
442
+          else {
443
+                      $photo = '';
444
+          }
376 445
 
377 446
           // phone
378 447
           $phone_no = array();
379 448
           if($vcard_obj->categories)
380
-            $categories = $vcard_obj->categories[0];
381
-          else
382
-            $categories = array();
449
+          {
450
+                      $categories = $vcard_obj->categories[0];
451
+          }
452
+          else {
453
+                      $categories = array();
454
+          }
383 455
 
384 456
           // check for quickdial entry
385 457
           if(isset($vcard_obj->note[0]))
@@ -414,9 +486,10 @@  discard block
 block discarded – undo
414 486
                 break;
415 487
               }
416 488
             }
417
-          } 
418
-          else
419
-            $add_entry = 1;
489
+          }
490
+          else {
491
+                      $add_entry = 1;
492
+          }
420 493
 
421 494
           if($add_entry == 1)
422 495
           {
@@ -441,9 +514,13 @@  discard block
 block discarded – undo
441 514
                   {
442 515
                     //Set quickdial
443 516
                     if($value == 1)
444
-                      print "\nWARNING: Quickdial value 1 (**701) is not possible but used! \n";
517
+                    {
518
+                                          print "\nWARNING: Quickdial value 1 (**701) is not possible but used! \n";
519
+                    }
445 520
                     elseif($value >= 100)
446
-                      print "\nWARNING: Quickdial value bigger than 99 (**799) is not possible but used! \n";
521
+                    {
522
+                                          print "\nWARNING: Quickdial value bigger than 99 (**799) is not possible but used! \n";
523
+                    }
447 524
 
448 525
                     $quickdial = $value;
449 526
                   }
@@ -453,23 +530,38 @@  discard block
 block discarded – undo
453 530
 
454 531
                 // find out priority
455 532
                 if(in_array("pref", $typearr_lower))
456
-                  $prio = 1;
533
+                {
534
+                                  $prio = 1;
535
+                }
457 536
 
458 537
                 // set the proper type
459 538
                 if(in_array("cell", $typearr_lower))
460
-                  $type = "mobile";
539
+                {
540
+                                  $type = "mobile";
541
+                }
461 542
                 elseif(in_array("home", $typearr_lower))
462
-                  $type = "home";
543
+                {
544
+                                  $type = "home";
545
+                }
463 546
                 elseif(in_array("fax", $typearr_lower))
464
-                  $type = "fax_work";
547
+                {
548
+                                  $type = "fax_work";
549
+                }
465 550
                 elseif(in_array("work", $typearr_lower))
466
-                  $type = "work";
551
+                {
552
+                                  $type = "work";
553
+                }
467 554
                 elseif(in_array("other", $typearr_lower))
468
-                  $type = "other";
555
+                {
556
+                                  $type = "other";
557
+                }
469 558
                 elseif(in_array("dom", $typearr_lower))
470
-                  $type = "other";
471
-                else
472
-                  continue;
559
+                {
560
+                                  $type = "other";
561
+                }
562
+                else {
563
+                                  continue;
564
+                }
473 565
               }
474 566
               $phone_no[] = array("type"=>$type, "prio"=>$prio, "quickdial"=>$quickdial, "value" => $this->_clear_phone_number($phone_number));
475 567
             }
@@ -489,13 +581,20 @@  discard block
 block discarded – undo
489 581
                   $email = $e['value'];
490 582
                   $typearr_lower = unserialize(strtolower(serialize($e['type'])));
491 583
                   if(in_array("work", $typearr_lower))
492
-                    $type_email = "work";
584
+                  {
585
+                                      $type_email = "work";
586
+                  }
493 587
                   elseif(in_array("home", $typearr_lower))
494
-                    $type_email = "home";
588
+                  {
589
+                                      $type_email = "home";
590
+                  }
495 591
                   elseif(in_array("other", $typearr_lower))
496
-                    $type_email = "other";
497
-                  else
498
-                    continue;
592
+                  {
593
+                                      $type_email = "other";
594
+                  }
595
+                  else {
596
+                                      continue;
597
+                  }
499 598
                 }
500 599
 
501 600
                 // DEBUG: print out the email address on the console
@@ -523,7 +622,9 @@  discard block
 block discarded – undo
523 622
   public function build_fb_xml()
524 623
   {
525 624
     if(empty($this->entries))
526
-      throw new Exception('No entries available! Call get_carddav_entries or set $this->entries manually!');
625
+    {
626
+          throw new Exception('No entries available! Call get_carddav_entries or set $this->entries manually!');
627
+    }
527 628
 
528 629
     // create FB XML in utf-8 format
529 630
     $root = new SimpleXMLElement('<?xml version="1.0" encoding="UTF-8"?><phonebooks><phonebook></phonebook></phonebooks>');
@@ -562,7 +663,9 @@  discard block
 block discarded – undo
562 663
 
563 664
       // output a warning if no telephone number was found
564 665
       if($id == 0)
565
-        print "  WARNING: no phone entry found. VCard will be ignored." . PHP_EOL;
666
+      {
667
+              print "  WARNING: no phone entry found. VCard will be ignored." . PHP_EOL;
668
+      }
566 669
 
567 670
       // email: put the email addresses into the fritzbox xml file
568 671
       $email = $contact->addChild("services");
@@ -612,8 +715,9 @@  discard block
 block discarded – undo
612 715
 
613 716
             print "  Added photo: " . basename($photo_file) . PHP_EOL;
614 717
           }
615
-          else
616
-           print "  WARNING: Only jpg contact photos are currently supported." . PHP_EOL;
718
+          else {
719
+                     print "  WARNING: Only jpg contact photos are currently supported." . PHP_EOL;
720
+          }
617 721
         }
618 722
         elseif(substr($entry['photo_data'][0], 0, 4) == 'http')
619 723
         {
@@ -622,8 +726,9 @@  discard block
 block discarded – undo
622 726
 
623 727
           print "  Added photo: " . $entry['photo_data'][0] . PHP_EOL;
624 728
         }
625
-        else
626
-          print "  WARNING: Only VCard embedded photo data or a reference URL is currently supported." . PHP_EOL;
729
+        else {
730
+                  print "  WARNING: Only VCard embedded photo data or a reference URL is currently supported." . PHP_EOL;
731
+        }
627 732
       }
628 733
 
629 734
       $contact->addChild("services");
@@ -632,7 +737,9 @@  discard block
 block discarded – undo
632 737
     }
633 738
 
634 739
     if($root->asXML() !== false)
635
-      $this->fbxml = $root->asXML();
740
+    {
741
+          $this->fbxml = $root->asXML();
742
+    }
636 743
     else
637 744
     {
638 745
       print "  ERROR: created XML data isn't well-formed." . PHP_EOL;
@@ -649,19 +756,27 @@  discard block
 block discarded – undo
649 756
   public function _concat($text1, $text2)
650 757
   {
651 758
     if($text1 == '')
652
-      return $text2;
759
+    {
760
+          return $text2;
761
+    }
653 762
     elseif($text2 == '')
654
-      return $text1;
655
-    else
656
-      return $text1 . ", " . $text2;
763
+    {
764
+          return $text1;
765
+    }
766
+    else {
767
+          return $text1 . ", " . $text2;
768
+    }
657 769
   }
658 770
 
659 771
   public function _parse_fb_result($text)
660 772
   {
661 773
     if(preg_match("/\<h2\>([^\<]+)\<\/h2\>/", $text, $matches) == 1 && !empty($matches))
662
-      return $matches[1];
663
-    else
664
-      return "Error while uploading xml to fritzbox";
774
+    {
775
+          return $matches[1];
776
+    }
777
+    else {
778
+          return "Error while uploading xml to fritzbox";
779
+    }
665 780
   }
666 781
 
667 782
   public function upload_to_fb()
@@ -683,15 +798,17 @@  discard block
 block discarded – undo
683 798
 	  	$newphonebhash = md5(preg_replace("/<mod_time>(\\d{10})/","",file_get_contents($this->config['output_file'],'r'),-1,$debugnewtsreplace));
684 799
 	  	print " INFO: Compare old and new phonebook file versions." . PHP_EOL . " INFO: old version: " . $oldphonebhash . PHP_EOL . " INFO: new version: " . $newphonebhash . PHP_EOL;
685 800
 	  	if($oldphonebhash === $newphonebhash)
686
-      	{
801
+	  	{
687 802
       	print " INFO: Same versions ==> No changes in phonebook or images" . PHP_EOL . " EXIT: No need to upload phonebook to the FRITZ!Box.". PHP_EOL;
688 803
       	return 0;
689 804
       	}
690
-      	else
691
-      	print " INFO: Different versions ==> Changes in phonebook." . PHP_EOL . " INFO: Changes dedected! Continue with upload." . PHP_EOL;
805
+      	else {
806
+      	      	print " INFO: Different versions ==> Changes in phonebook." . PHP_EOL . " INFO: Changes dedected! Continue with upload." . PHP_EOL;
807
+      	}
692 808
       }
693
-	  else
694
-      return 0;  
809
+      else {
810
+	        return 0;
811
+	  }
695 812
     }
696 813
     // now we upload the photo jpgs first being stored in the
697 814
     // temp directory.
@@ -761,12 +878,16 @@  discard block
 block discarded – undo
761 878
 
762 879
                   ftp_pasv($conn_id, true);
763 880
                   if(!ftp_put($conn_id, $remote_path . "/" . $file, $fileinfo->getPathname(), FTP_BINARY))
764
-                    print " ERROR: while uploading file " . $fileinfo->getFilename() . PHP_EOL;
765
-                  else
766
-                    print " ok." . PHP_EOL;
881
+                  {
882
+                                      print " ERROR: while uploading file " . $fileinfo->getFilename() . PHP_EOL;
883
+                  }
884
+                  else {
885
+                                      print " ok." . PHP_EOL;
886
+                  }
887
+                }
888
+                else {
889
+                                  print " ok." . PHP_EOL;
767 890
                 }
768
-                else
769
-                  print " ok." . PHP_EOL;
770 891
 
771 892
                 // cleanup old files
772 893
                 foreach($all_existing_files as $existing_file)
@@ -778,20 +899,23 @@  discard block
 block discarded – undo
778 899
                   }
779 900
                 }
780 901
               }
781
-              else
782
-                print " already exists." . PHP_EOL;
902
+              else {
903
+                              print " already exists." . PHP_EOL;
904
+              }
783 905
             }
784 906
           }
785 907
         }
786 908
       }
787
-      else
788
-        print " ERROR: couldn't login to FTP-server '" . $ftp_server . "' with provided username/password settings." . PHP_EOL;
909
+      else {
910
+              print " ERROR: couldn't login to FTP-server '" . $ftp_server . "' with provided username/password settings." . PHP_EOL;
911
+      }
789 912
 
790 913
       // close ftp connection
791 914
       ftp_close($conn_id);
792 915
     }
793
-    else
794
-      print " ERROR: couldn't connect to FTP server '" . $ftp_server . "'." . PHP_EOL;
916
+    else {
917
+          print " ERROR: couldn't connect to FTP server '" . $ftp_server . "'." . PHP_EOL;
918
+    }
795 919
     
796 920
     // lets post the phonebook xml to the FRITZ!Box
797 921
     print " Uploading Phonebook XML to " . $this->config['fritzbox_ip'] . PHP_EOL;
Please login to merge, or discard this patch.