GitHub Access Token became invalid

It seems like the GitHub access token used for retrieving details about this repository from GitHub became invalid. This might prevent certain types of inspections from being run (in particular, everything related to pull requests).
Please ask an admin of your repository to re-new the access token on this website.
Passed
Push — master ( 4d21df...50705d )
by Jens
03:00
created
lib/CardDAV-PHP/carddav.php 1 patch
Braces   +86 added lines, -38 removed lines patch added patch discarded remove patch
@@ -219,7 +219,8 @@  discard block
 block discarded – undo
219 219
      */
220 220
     public function __construct($url = null)
221 221
     {
222
-        if ($url !== null) {
222
+        if ($url !== null)
223
+        {
223 224
             $this->setUrl($url);
224 225
         }
225 226
     }
@@ -245,7 +246,8 @@  discard block
 block discarded – undo
245 246
     {
246 247
         $this->url = $url;
247 248
 
248
-        if (substr($this->url, -1, 1) !== '/') {
249
+        if (substr($this->url, -1, 1) !== '/')
250
+        {
249 251
             $this->url = $this->url . '/';
250 252
         }
251 253
 
@@ -339,9 +341,12 @@  discard block
 block discarded – undo
339 341
         {
340 342
             case 200:
341 343
             case 207:
342
-                if ($raw === true) {
344
+                if ($raw === true)
345
+                {
343 346
                     return $result['response'];
344
-                } else {
347
+                }
348
+                else
349
+                {
345 350
                     return $this->simplify($result['response'], $include_vcards);
346 351
                 }
347 352
         }
@@ -368,13 +373,13 @@  discard block
 block discarded – undo
368 373
         // print_r($result);
369 374
 
370 375
 	switch ($result['http_code'])
371
-        {
376
+	{
372 377
 		case 404:
373 378
 			$altResult  = $this->query($this->url . $vcard_id , 'GET');
374 379
 		        // DEBUG: print the response of the carddav-server
375 380
 		        // print_r($altResult);
376 381
 	                switch ($altResult['http_code'])
377
-        	        {
382
+	                {
378 383
                 	        case 200:
379 384
 	                        case 207:
380 385
 					print "Ignoring given Vcard Extension (".$this->url_vcard_extension.")" . PHP_EOL. ".";
@@ -458,9 +463,12 @@  discard block
 block discarded – undo
458 463
     {
459 464
         $result = $this->query($this->url, 'OPTIONS');
460 465
 
461
-        if ($result['http_code'] === 200) {
466
+        if ($result['http_code'] === 200)
467
+        {
462 468
             return true;
463
-        } else {
469
+        }
470
+        else
471
+        {
464 472
             return false;
465 473
         }
466 474
     }
@@ -509,7 +517,8 @@  discard block
 block discarded – undo
509 517
      */
510 518
     public function add($vcard, $vcard_id = null)
511 519
     {
512
-        if ($vcard_id === null) {
520
+        if ($vcard_id === null)
521
+        {
513 522
             $vcard_id   = $this->generateVcardId();
514 523
         }
515 524
         $vcard  = $this->cleanVcard($vcard);
@@ -536,9 +545,12 @@  discard block
 block discarded – undo
536 545
      */
537 546
     public function update($vcard, $vcard_id)
538 547
     {
539
-        try {
548
+        try
549
+        {
540 550
             return $this->add($vcard, $vcard_id);
541
-        } catch (Exception $e) {
551
+        }
552
+        catch (Exception $e)
553
+        {
542 554
             throw new \Exception($e->getMessage(), self::EXCEPTION_WRONG_HTTP_STATUS_CODE_UPDATE);
543 555
         }
544 556
     }
@@ -554,9 +566,12 @@  discard block
 block discarded – undo
554 566
     {
555 567
         $response = $this->cleanResponse($response);
556 568
 
557
-        try {
569
+        try
570
+        {
558 571
             $xml = new \SimpleXMLElement($response);
559
-        } catch (Exception $e) {
572
+        }
573
+        catch (Exception $e)
574
+        {
560 575
             throw new \Exception(
561 576
                 "The XML response seems to be malformed and can't be simplified!",
562 577
                 self::EXCEPTION_MALFORMED_XML_RESPONSE,
@@ -571,35 +586,50 @@  discard block
 block discarded – undo
571 586
         $simplified_xml->startDocument('1.0', 'utf-8');
572 587
             $simplified_xml->startElement('response');
573 588
 
574
-        if (!empty($xml->response)) {
575
-            foreach ($xml->response as $response) {
589
+        if (!empty($xml->response))
590
+        {
591
+            foreach ($xml->response as $response)
592
+            {
576 593
               if ((preg_match('/vcard/', $response->propstat->prop->getcontenttype) || preg_match('/vcf/', $response->href)) &&
577
-                  !$response->propstat->prop->resourcetype->collection) {
594
+                  !$response->propstat->prop->resourcetype->collection)
595
+              {
578 596
                     $id = basename($response->href);
579 597
                     $id = str_replace($this->url_vcard_extension, null, $id);
580 598
 
581
-                    try {
599
+                    try
600
+                    {
582 601
                         $vcardData = $this->getVcard($id);
583
-                        if (!empty($id)) {
602
+                        if (!empty($id))
603
+                        {
584 604
                             $simplified_xml->startElement('element');
585 605
                                 $simplified_xml->writeElement('id', $id);
586 606
                                 $simplified_xml->writeElement('etag', str_replace('"', null, $response->propstat->prop->getetag));
587 607
                                 $simplified_xml->writeElement('last_modified', $response->propstat->prop->getlastmodified);
588 608
 
589
-                            if ($include_vcards === true) {
609
+                            if ($include_vcards === true)
610
+                            {
590 611
                                 $simplified_xml->writeElement('vcard', $vcardData);
591 612
                             }
592 613
                             $simplified_xml->endElement();
593 614
                         }
594
-                    } catch (\Exception $e) {
615
+                    }
616
+                    catch (\Exception $e)
617
+                    {
595 618
                         print("Error fetching vCard: {$id}: {$e->getMessage()}\n");
596 619
                     }
597
-                } elseif (preg_match('/unix-directory/', $response->propstat->prop->getcontenttype)) {
598
-                    if (isset($response->propstat->prop->href)) {
620
+                }
621
+                elseif (preg_match('/unix-directory/', $response->propstat->prop->getcontenttype))
622
+                {
623
+                    if (isset($response->propstat->prop->href))
624
+                    {
599 625
                         $href = $response->propstat->prop->href;
600
-                    } elseif (isset($response->href)) {
626
+                    }
627
+                    elseif (isset($response->href))
628
+                    {
601 629
                         $href = $response->href;
602
-                    } else {
630
+                    }
631
+                    else
632
+                    {
603 633
                         $href = null;
604 634
                     }
605 635
 
@@ -643,7 +673,8 @@  discard block
 block discarded – undo
643 673
      */
644 674
     public function curlInit()
645 675
     {
646
-        if (empty($this->curl)) {
676
+        if (empty($this->curl))
677
+        {
647 678
             $this->curl = curl_init();
648 679
             curl_setopt($this->curl, CURLOPT_HEADER, true);
649 680
             curl_setopt($this->curl, CURLOPT_SSL_VERIFYHOST, false);
@@ -651,7 +682,8 @@  discard block
 block discarded – undo
651 682
             curl_setopt($this->curl, CURLOPT_RETURNTRANSFER, true);
652 683
             curl_setopt($this->curl, CURLOPT_USERAGENT, self::USERAGENT.self::VERSION);
653 684
 
654
-            if ($this->auth !== null) {
685
+            if ($this->auth !== null)
686
+            {
655 687
                 curl_setopt($this->curl, CURLOPT_HTTPAUTH, CURLAUTH_ANY);
656 688
                 curl_setopt($this->curl, CURLOPT_USERPWD, $this->auth);
657 689
             }
@@ -681,17 +713,23 @@  discard block
 block discarded – undo
681 713
         curl_setopt($this->curl, CURLOPT_URL, $url);
682 714
         curl_setopt($this->curl, CURLOPT_CUSTOMREQUEST, $method);
683 715
 
684
-        if ($content !== null) {
716
+        if ($content !== null)
717
+        {
685 718
             curl_setopt($this->curl, CURLOPT_POST, true);
686 719
             curl_setopt($this->curl, CURLOPT_POSTFIELDS, $content);
687
-        } else {
720
+        }
721
+        else
722
+        {
688 723
             curl_setopt($this->curl, CURLOPT_POST, false);
689 724
             curl_setopt($this->curl, CURLOPT_POSTFIELDS, null);
690 725
         }
691 726
 
692
-        if ($content_type !== null) {
727
+        if ($content_type !== null)
728
+        {
693 729
             curl_setopt($this->curl, CURLOPT_HTTPHEADER, array('Content-type: '.$content_type, 'Depth: 1'));
694
-        } else {
730
+        }
731
+        else
732
+        {
695 733
             curl_setopt($this->curl, CURLOPT_HTTPHEADER, array('Depth: 1'));
696 734
         }
697 735
 
@@ -706,7 +744,8 @@  discard block
 block discarded – undo
706 744
             'http_code'         => $http_code
707 745
         );
708 746
 
709
-        if ($this->debug === true) {
747
+        if ($this->debug === true)
748
+        {
710 749
             $debug = $return;
711 750
             $debug['url']           = $url;
712 751
             $debug['method']        = $method;
@@ -728,26 +767,34 @@  discard block
 block discarded – undo
728 767
     {
729 768
         $vcard_id = null;
730 769
 
731
-        for ($number = 0; $number <= 25; $number ++) {
732
-            if ($number == 8 || $number == 17) {
770
+        for ($number = 0; $number <= 25; $number ++)
771
+        {
772
+            if ($number == 8 || $number == 17)
773
+            {
733 774
                 $vcard_id .= '-';
734
-            } else {
775
+            }
776
+            else
777
+            {
735 778
                 $vcard_id .= $this->vcard_id_chars[mt_rand(0, (count($this->vcard_id_chars) - 1))];
736 779
             }
737 780
         }
738 781
 
739
-        try {
782
+        try
783
+        {
740 784
             $carddav = new CardDavBackend($this->url);
741 785
             $carddav->setAuth($this->username, $this->password);
742 786
 
743 787
             $result = $carddav->query($this->url . $vcard_id . $this->url_vcard_extension, 'GET');
744 788
 
745
-            if ($result['http_code'] !== 404) {
789
+            if ($result['http_code'] !== 404)
790
+            {
746 791
                 $vcard_id = $this->generateVcardId();
747 792
             }
748 793
 
749 794
             return $vcard_id;
750
-        } catch (Exception $e) {
795
+        }
796
+        catch (Exception $e)
797
+        {
751 798
             throw new \Exception($e->getMessage(), self::EXCEPTION_COULD_NOT_GENERATE_NEW_VCARD_ID);
752 799
         }
753 800
     }
@@ -760,7 +807,8 @@  discard block
 block discarded – undo
760 807
      */
761 808
     public function __destruct()
762 809
     {
763
-        if (!empty($this->curl)) {
810
+        if (!empty($this->curl))
811
+        {
764 812
             curl_close($this->curl);
765 813
         }
766 814
     }
Please login to merge, or discard this patch.
lib/fritzbox_api_php/fritzbox_ring_phone.php 1 patch
Braces   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,7 @@
 block discarded – undo
3 3
 // init the output message
4 4
 $message = date('Y-m-d H:i') . ' ';
5 5
 try
6
-{ 
6
+{
7 7
   // load the fritzbox_api class
8 8
   require_once(__DIR__ . '/fritzbox_api.class.php');
9 9
   $fritz = new fritzbox_api();
Please login to merge, or discard this patch.
lib/fritzbox_api_php/fritzbox_api.class.php 1 patch
Braces   +41 added lines, -20 removed lines patch added patch discarded remove patch
@@ -46,7 +46,8 @@  discard block
 block discarded – undo
46 46
  * the main Fritz!Box API class
47 47
  *
48 48
  */
49
-class fritzbox_api {
49
+class fritzbox_api
50
+{
50 51
   /**
51 52
     * @var  object  config object
52 53
     */
@@ -69,7 +70,8 @@  discard block
 block discarded – undo
69 70
 	$this->config = new fritzbox_api_config();
70 71
     
71 72
 	// try autoloading the config
72
-	if (file_exists(__DIR__ . '/fritzbox_user.conf.php') && is_readable(__DIR__ . '/fritzbox_user.conf.php') ) {
73
+	if (file_exists(__DIR__ . '/fritzbox_user.conf.php') && is_readable(__DIR__ . '/fritzbox_user.conf.php') )
74
+	{
73 75
 		require_once(__DIR__ . '/fritzbox_user.conf.php');
74 76
 	}
75 77
 
@@ -77,29 +79,37 @@  discard block
 block discarded – undo
77 79
 	$this->config->setItem('fritzbox_ip',$fritzbox_ip);
78 80
 
79 81
 	// check if login on local network (fritz.box) or via a dynamic DNS-host
80
-	if ($fritzbox_ip != 'fritz.box' && !$force_local_login) {
82
+	if ($fritzbox_ip != 'fritz.box' && !$force_local_login)
83
+	{
81 84
 		$this->config->setItem('enable_remote_config',true);
82 85
 		$this->config->setItem('remote_config_user',$user_name);
83 86
 		$this->config->setItem('remote_config_password',$password);
84 87
 		$this->config->setItem('fritzbox_url', 'https://'.$this->config->getItem('fritzbox_ip'));
85
-	} else {
88
+	}
89
+	else
90
+	{
86 91
 		$this->config->setItem('enable_remote_config',false);
87
-		if($user_name != false){
92
+		if($user_name != false)
93
+		{
88 94
 			$this->config->setItem('username',$user_name);
89 95
 		}
90
-		if($password != false){
96
+		if($password != false)
97
+		{
91 98
 			$this->config->setItem('password',$password);
92 99
 		}
93 100
 		$this->config->setItem('fritzbox_url', 'http://' . $this->config->getItem('fritzbox_ip'));
94 101
 	}
95 102
 
96 103
 	// make some config consistency checks
97
-	if ( $this->config->getItem('enable_remote_config') === true ){
98
-		if ( !$this->config->getItem('remote_config_user') || !$this->config->getItem('remote_config_password') ){
104
+	if ( $this->config->getItem('enable_remote_config') === true )
105
+	{
106
+		if ( !$this->config->getItem('remote_config_user') || !$this->config->getItem('remote_config_password') )
107
+		{
99 108
 		  $this->error('ERROR: Remote config mode enabled, but no username or no password provided');
100 109
 		}
101 110
 	}
102
-	else {
111
+	else
112
+	{
103 113
 		$this->config->setItem('old_remote_config_user', null);
104 114
 		$this->config->setItem('old_remote_config_password', null);
105 115
 	}
@@ -148,10 +158,13 @@  discard block
 block discarded – undo
148 158
     if ( $this->config->getItem('enable_remote_config') == true )
149 159
     {
150 160
 		// set name of SSL-certificate (must be same as remote-hostname (dynDNS) of FRITZ!Box) and remove port in address if alternate port is given
151
-		if (strpos($this->config->getItem('fritzbox_ip'),":")){
161
+		if (strpos($this->config->getItem('fritzbox_ip'),":"))
162
+		{
152 163
 			$ssl_cert_fritzbox = explode(":", $this->config->getItem('fritzbox_ip'));
153 164
 			$ssl_cert_fritzbox = $ssl_cert_fritzbox[0];
154
-		} else {
165
+		}
166
+		else
167
+		{
155 168
 			$ssl_cert_fritzbox = $this->config->getItem('fritzbox_ip');
156 169
 		}
157 170
 
@@ -162,7 +175,8 @@  discard block
 block discarded – undo
162 175
 		curl_setopt($ch, CURLOPT_CAPATH, '/etc/ssl/certs');
163 176
 
164 177
 		// support for pre FRITZ!OS 5.50 remote config
165
-		if (!$this->config->getItem('use_lua_login_method')){
178
+		if (!$this->config->getItem('use_lua_login_method'))
179
+		{
166 180
 		curl_setopt($ch, CURLOPT_USERPWD, $this->config->getItem('remote_config_user') . ':' . $this->config->getItem('remote_config_password'));
167 181
 		}
168 182
     }
@@ -173,7 +187,7 @@  discard block
 block discarded – undo
173 187
   }
174 188
 
175 189
   public function doPostFile($formfields = array(), $filefileds = array())
176
-  {  
190
+  {
177 191
     $ch = curl_init();
178 192
    
179 193
     // add the sid, if it is already set
@@ -192,11 +206,13 @@  discard block
 block discarded – undo
192 206
     curl_setopt($ch, CURLOPT_RETURNTRANSFER, 1);
193 207
     
194 208
     // if filefileds not specified ('@/path/to/file.xml;type=text/xml' works fine)
195
-    if(empty( $filefileds )) {
209
+    if(empty( $filefileds ))
210
+    {
196 211
 		curl_setopt($ch, CURLOPT_POSTFIELDS, $formfields); // http_build_query
197 212
 	} 
198 213
 	// post calculated raw data
199
-	else {
214
+	else
215
+	{
200 216
 		$header = $this->_create_custom_file_post_header($formfields, $filefileds);
201 217
 		curl_setopt($ch, CURLOPT_HTTPHEADER , array(
202 218
 			'Content-Type: multipart/form-data; boundary=' . $header['delimiter'], 'Content-Length: ' . strlen($header['data']) )
@@ -208,7 +224,8 @@  discard block
 block discarded – undo
208 224
     $output = curl_exec($ch);
209 225
 
210 226
 	// curl error
211
-	if(curl_errno($ch)) {
227
+	if(curl_errno($ch))
228
+	{
212 229
 		$this->error(curl_error($ch)." (".curl_errno($ch).")");
213 230
 	}
214 231
 
@@ -223,7 +240,8 @@  discard block
 block discarded – undo
223 240
     return $output;
224 241
   }
225 242
 
226
-  private function _create_custom_file_post_header($postFields, $fileFields) {
243
+  private function _create_custom_file_post_header($postFields, $fileFields)
244
+  {
227 245
 		// form field separator
228 246
 		$delimiter = '-------------' . uniqid();
229 247
 		
@@ -245,7 +263,8 @@  discard block
 block discarded – undo
245 263
 		$data = '';
246 264
 
247 265
 		// populate normal fields first (simpler)
248
-		foreach ($postFields as $name => $content) {
266
+		foreach ($postFields as $name => $content)
267
+		{
249 268
 		   $data .= "--" . $delimiter . "\r\n";
250 269
 			$data .= 'Content-Disposition: form-data; name="' . urlencode($name) . '"';
251 270
 			$data .= "\r\n\r\n";
@@ -253,7 +272,8 @@  discard block
 block discarded – undo
253 272
 			$data .= "\r\n";
254 273
 		}
255 274
 		// populate file fields
256
-		foreach ($fileFields as $name => $file) {
275
+		foreach ($fileFields as $name => $file)
276
+		{
257 277
 			$data .= "--" . $delimiter . "\r\n";
258 278
 			// "filename" attribute is not essential; server-side scripts may use it
259 279
 			$data .= 'Content-Disposition: form-data; name="' . urlencode($name) . '";' .
@@ -479,7 +499,8 @@  discard block
 block discarded – undo
479 499
   }
480 500
 }
481 501
 
482
-class fritzbox_api_config {
502
+class fritzbox_api_config
503
+{
483 504
   protected $config = array();
484 505
 
485 506
   public function __construct()
Please login to merge, or discard this patch.
lib/vCard-parser/vCard.php 1 patch
Braces   +6 added lines, -5 removed lines patch added patch discarded remove patch
@@ -225,10 +225,13 @@  discard block
 block discarded – undo
225 225
 									{
226 226
 										//$Value = base64_decode($Value);
227 227
 									}
228
-									elseif ($ParamValue == 'quoted-printable') // v2.1
228
+									elseif ($ParamValue == 'quoted-printable')
229
+									{
230
+									  // v2.1
229 231
 									{
230 232
 										$Value = quoted_printable_decode($Value);
231 233
 									}
234
+									}
232 235
 									break;
233 236
 								case 'charset': // v2.1
234 237
 									if ($ParamValue != 'utf-8' && $ParamValue != 'utf8')
@@ -407,8 +410,7 @@  discard block
 block discarded – undo
407 410
 
408 411
 				if (isset(self::$Spec_StructuredElements[$Key]) &&
409 412
 					in_array(strtolower($Arguments[1]), self::$Spec_StructuredElements[$Key])
410
-				)
411
-				{
413
+				) {
412 414
 					$LastElementIndex = 0;
413 415
 
414 416
 					if (count($this -> Data[$Key]))
@@ -596,8 +598,7 @@  discard block
 block discarded – undo
596 598
 					if (
597 599
 						(isset(self::$Spec_ElementTypes[$Key]) && in_array($Parameter[0], self::$Spec_ElementTypes[$Key])) ||
598 600
 						($Key == 'email' && is_scalar($Parameter[0]))
599
-					)
600
-					{
601
+					) {
601 602
 						$Type[] = $Parameter[0];
602 603
 					}
603 604
 				}
Please login to merge, or discard this patch.
carddav2fb.php 1 patch
Braces   +208 added lines, -91 removed lines patch added patch discarded remove patch
@@ -38,9 +38,12 @@  discard block
 block discarded – undo
38 38
 require_once('lib/fritzbox_api_php/fritzbox_api.class.php');
39 39
 
40 40
 if($argc == 2)
41
+{
41 42
   $config_file_name = $argv[1];
42
-else
43
+}
44
+else {
43 45
   $config_file_name = __DIR__ . '/config.php';
46
+}
44 47
 
45 48
 // default/fallback config options
46 49
 $config['tmp_dir'] = sys_get_temp_dir();
@@ -60,7 +63,9 @@  discard block
 block discarded – undo
60 63
 $config['quickdial_keyword'] = 'Quickdial:';
61 64
 
62 65
 if(is_file($config_file_name))
66
+{
63 67
   require($config_file_name);
68
+}
64 69
 else
65 70
 {
66 71
   print 'ERROR: No ' . $config_file_name . ' found, please take a look at config.example.php and create a ' . $config_file_name . ' file!' . PHP_EOL;
@@ -122,7 +127,9 @@  discard block
 block discarded – undo
122 127
   public function mktemp($dir, $prefix = '', $mode = 0700)
123 128
   {
124 129
     if(substr($dir, -1) != '/')
125
-      $dir .= '/';
130
+    {
131
+          $dir .= '/';
132
+    }
126 133
 
127 134
     do
128 135
     {
@@ -143,7 +150,12 @@  discard block
 block discarded – undo
143 150
         if($object != "." && $object != "..")
144 151
         {
145 152
           if(filetype($dir . "/" . $object) == "dir")
146
-            rrmdir($dir . "/" . $object); else unlink($dir . "/" . $object);
153
+          {
154
+                      rrmdir($dir . "/" . $object);
155
+          }
156
+          else {
157
+              unlink($dir . "/" . $object);
158
+            }
147 159
         }
148 160
       }
149 161
       reset($objects);
@@ -157,18 +169,25 @@  discard block
 block discarded – undo
157 169
     {
158 170
       // Check if there are valid base64 characters
159 171
       if(!preg_match('/^[a-zA-Z0-9\/\r\n+]*={0,2}$/', $str))
160
-        return false;
172
+      {
173
+              return false;
174
+      }
161 175
 
162 176
       // Decode the string in strict mode and check the results
163 177
       $decoded = base64_decode($str, true);
164 178
       if($decoded === false)
165
-        return false;
179
+      {
180
+              return false;
181
+      }
166 182
 
167 183
       // Encode the string again
168 184
       if(base64_encode($decoded) === $str)
169
-        return true;
170
-      else
171
-        return false;
185
+      {
186
+              return true;
187
+      }
188
+      else {
189
+              return false;
190
+      }
172 191
     }
173 192
     catch(Exception $e)
174 193
     {
@@ -210,7 +229,9 @@  discard block
 block discarded – undo
210 229
         // set the vcard extension in case the user
211 230
         // defined it in the config
212 231
         if(isset($conf['extension']))
213
-          $carddav->setVcardExtension($conf['extension']);
232
+        {
233
+                  $carddav->setVcardExtension($conf['extension']);
234
+        }
214 235
 
215 236
         // retrieve data from the CardDAV server now
216 237
         $xmldata = $carddav->get();
@@ -219,7 +240,9 @@  discard block
 block discarded – undo
219 240
         // CardDAV server and if not reencode it since the FRITZ!Box
220 241
         // requires UTF-8 encoded data
221 242
         if(iconv('utf-8', 'utf-8//IGNORE', $xmldata) != $xmldata)
222
-          $xmldata = utf8_encode($xmldata);
243
+        {
244
+                  $xmldata = utf8_encode($xmldata);
245
+        }
223 246
 
224 247
         // read raw_vcard data from xml response
225 248
         $raw_vcards = array();
@@ -241,10 +264,14 @@  discard block
 block discarded – undo
241 264
           $vcard_obj = new vCard(false, $v);
242 265
           $name_arr = null;
243 266
           if(isset($vcard_obj->n[0]))
244
-            $name_arr = $vcard_obj->n[0];
267
+          {
268
+                      $name_arr = $vcard_obj->n[0];
269
+          }
245 270
           $org_arr = null;
246 271
           if(isset($vcard_obj->org[0]))
247
-            $org_arr = $vcard_obj->org[0];
272
+          {
273
+                      $org_arr = $vcard_obj->org[0];
274
+          }
248 275
           $addnames = '';
249 276
           $prefix = '';
250 277
           $suffix = '';
@@ -252,16 +279,24 @@  discard block
 block discarded – undo
252 279
 
253 280
           // Build name Parts if existing ans switch to true in config
254 281
           if(isset($name_arr['prefixes']) and $this->config['prefix'])
255
-            $prefix = trim($name_arr['prefixes']);
282
+          {
283
+                      $prefix = trim($name_arr['prefixes']);
284
+          }
256 285
 
257 286
           if(isset($name_arr['suffixes']) and $this->config['suffix'])
258
-            $suffix = trim($name_arr['suffixes']);
287
+          {
288
+                      $suffix = trim($name_arr['suffixes']);
289
+          }
259 290
 
260 291
           if(isset($name_arr['additionalnames']) and $this->config['addnames'])
261
-            $addnames = trim($name_arr['additionalnames']);
292
+          {
293
+                      $addnames = trim($name_arr['additionalnames']);
294
+          }
262 295
 
263 296
           if(isset($org_arr['name']) and $this->config['orgname'])
264
-            $orgname = trim($org_arr['name']);
297
+          {
298
+                      $orgname = trim($org_arr['name']);
299
+          }
265 300
 
266 301
           $firstname = trim($name_arr['firstname']);
267 302
           $lastname = trim($name_arr['lastname']);
@@ -281,71 +316,97 @@  discard block
 block discarded – undo
281 316
 
282 317
           // Prefix
283 318
           if(!empty($prefix))
284
-            $name .= $prefix;
319
+          {
320
+                      $name .= $prefix;
321
+          }
285 322
 
286 323
           if($format == 0)
287 324
           {
288 325
             // Lastname
289 326
             if(!empty($name) and !empty($lastname))
290
-              $name .= ' ' . $lastname;
291
-            else
292
-              $name .= $lastname;
327
+            {
328
+                          $name .= ' ' . $lastname;
329
+            }
330
+            else {
331
+                          $name .= $lastname;
332
+            }
293 333
           }
294 334
           else
295 335
           {
296 336
             // Firstname
297 337
             if(!empty($name) and !empty($firstname))
298
-              $name .= ' ' . $firstname;
299
-            else
300
-              $name .= $firstname;
338
+            {
339
+                          $name .= ' ' . $firstname;
340
+            }
341
+            else {
342
+                          $name .= $firstname;
343
+            }
301 344
           }
302 345
 
303 346
           if($format == 2)
304 347
           {
305 348
             // AdditionalNames
306 349
             if(!empty($name) and !empty($addnames))
307
-              $name .= ' ' . $addnames;
308
-            else
309
-              $name .= $addnames;
350
+            {
351
+                          $name .= ' ' . $addnames;
352
+            }
353
+            else {
354
+                          $name .= $addnames;
355
+            }
310 356
           }
311 357
 
312 358
           if($format == 0)
313 359
           {
314 360
             // Firstname
315 361
             if(!empty($name) and !empty($firstname))
316
-              $name .= ', ' . $firstname;
317
-            else
318
-              $name .= $firstname;
362
+            {
363
+                          $name .= ', ' . $firstname;
364
+            }
365
+            else {
366
+                          $name .= $firstname;
367
+            }
319 368
           }
320 369
           else
321 370
           {
322 371
             // Lastname
323 372
             if(!empty($name) and !empty($lastname))
324
-              $name .= ' ' . $lastname;
325
-            else
326
-              $name .= $lastname;
373
+            {
374
+                          $name .= ' ' . $lastname;
375
+            }
376
+            else {
377
+                          $name .= $lastname;
378
+            }
327 379
           }
328 380
 
329 381
           if($format != 2)
330 382
           {
331 383
             // AdditionalNames
332 384
             if(!empty($name) and !empty($addnames))
333
-              $name .= ' ' . $addnames;
334
-            else
335
-              $name .= $addnames;
385
+            {
386
+                          $name .= ' ' . $addnames;
387
+            }
388
+            else {
389
+                          $name .= $addnames;
390
+            }
336 391
           }
337 392
 
338 393
           // Suffix
339 394
           if(!empty($name) and !empty($suffix))
340
-            $name .= ' ' . $suffix;
341
-          else
342
-            $name .= $suffix;
395
+          {
396
+                      $name .= ' ' . $suffix;
397
+          }
398
+          else {
399
+                      $name .= $suffix;
400
+          }
343 401
 
344 402
           // OrgName
345 403
           if(!empty($name) and !empty($orgname))
346
-            $name .= ' (' . $orgname . ')';
347
-          else
348
-            $name .= $orgname;
404
+          {
405
+                      $name .= ' (' . $orgname . ')';
406
+          }
407
+          else {
408
+                      $name .= $orgname;
409
+          }
349 410
 
350 411
           // make sure to trim whitespaces and double spaces
351 412
           $name = trim(str_replace('  ', ' ', $name));
@@ -370,15 +431,19 @@  discard block
 block discarded – undo
370 431
               array('', '_', '_', '_', 'ae', 'oe', 'ue', 'Ae', 'Oe', 'Ue', 'ss', 'a', 'a', 'o', 'o', 'u', 'u', 'i', 'oe'), $name);
371 432
             }
372 433
           }
373
-          else
374
-            $photo = '';
434
+          else {
435
+                      $photo = '';
436
+          }
375 437
 
376 438
           // phone
377 439
           $phone_no = array();
378 440
           if($vcard_obj->categories)
379
-            $categories = $vcard_obj->categories[0];
380
-          else
381
-            $categories = array();
441
+          {
442
+                      $categories = $vcard_obj->categories[0];
443
+          }
444
+          else {
445
+                      $categories = array();
446
+          }
382 447
 
383 448
           // check for quickdial entry
384 449
           if(isset($vcard_obj->note[0]))
@@ -413,9 +478,10 @@  discard block
 block discarded – undo
413 478
                 break;
414 479
               }
415 480
             }
416
-          } 
417
-          else
418
-            $add_entry = 1;
481
+          }
482
+          else {
483
+                      $add_entry = 1;
484
+          }
419 485
 
420 486
           if($add_entry == 1)
421 487
           {
@@ -440,9 +506,13 @@  discard block
 block discarded – undo
440 506
                   {
441 507
                     //Set quickdial
442 508
                     if($value == 1)
443
-                      print "\nWARNING: Quickdial value 1 (**701) is not possible but used! \n";
509
+                    {
510
+                                          print "\nWARNING: Quickdial value 1 (**701) is not possible but used! \n";
511
+                    }
444 512
                     elseif($value >= 100)
445
-                      print "\nWARNING: Quickdial value bigger than 99 (**799) is not possible but used! \n";
513
+                    {
514
+                                          print "\nWARNING: Quickdial value bigger than 99 (**799) is not possible but used! \n";
515
+                    }
446 516
 
447 517
                     $quickdial = $value;
448 518
                   }
@@ -452,23 +522,38 @@  discard block
 block discarded – undo
452 522
 
453 523
                 // find out priority
454 524
                 if(in_array("pref", $typearr_lower))
455
-                  $prio = 1;
525
+                {
526
+                                  $prio = 1;
527
+                }
456 528
 
457 529
                 // set the proper type
458 530
                 if(in_array("cell", $typearr_lower))
459
-                  $type = "mobile";
531
+                {
532
+                                  $type = "mobile";
533
+                }
460 534
                 elseif(in_array("home", $typearr_lower))
461
-                  $type = "home";
535
+                {
536
+                                  $type = "home";
537
+                }
462 538
                 elseif(in_array("fax", $typearr_lower))
463
-                  $type = "fax_work";
539
+                {
540
+                                  $type = "fax_work";
541
+                }
464 542
                 elseif(in_array("work", $typearr_lower))
465
-                  $type = "work";
543
+                {
544
+                                  $type = "work";
545
+                }
466 546
                 elseif(in_array("other", $typearr_lower))
467
-                  $type = "other";
547
+                {
548
+                                  $type = "other";
549
+                }
468 550
                 elseif(in_array("dom", $typearr_lower))
469
-                  $type = "other";
470
-                else
471
-                  continue;
551
+                {
552
+                                  $type = "other";
553
+                }
554
+                else {
555
+                                  continue;
556
+                }
472 557
               }
473 558
               $phone_no[] = array("type"=>$type, "prio"=>$prio, "quickdial"=>$quickdial, "value" => $this->_clear_phone_number($phone_number));
474 559
             }
@@ -488,13 +573,20 @@  discard block
 block discarded – undo
488 573
                   $email = $e['value'];
489 574
                   $typearr_lower = unserialize(strtolower(serialize($e['type'])));
490 575
                   if(in_array("work", $typearr_lower))
491
-                    $type_email = "work";
576
+                  {
577
+                                      $type_email = "work";
578
+                  }
492 579
                   elseif(in_array("home", $typearr_lower))
493
-                    $type_email = "home";
580
+                  {
581
+                                      $type_email = "home";
582
+                  }
494 583
                   elseif(in_array("other", $typearr_lower))
495
-                    $type_email = "other";
496
-                  else
497
-                    continue;
584
+                  {
585
+                                      $type_email = "other";
586
+                  }
587
+                  else {
588
+                                      continue;
589
+                  }
498 590
                 }
499 591
 
500 592
                 // DEBUG: print out the email address on the console
@@ -522,7 +614,9 @@  discard block
 block discarded – undo
522 614
   public function build_fb_xml()
523 615
   {
524 616
     if(empty($this->entries))
525
-      throw new Exception('No entries available! Call get_carddav_entries or set $this->entries manually!');
617
+    {
618
+          throw new Exception('No entries available! Call get_carddav_entries or set $this->entries manually!');
619
+    }
526 620
 
527 621
     // create FB XML in utf-8 format
528 622
     $root = new SimpleXMLElement('<?xml version="1.0" encoding="UTF-8"?><phonebooks><phonebook></phonebook></phonebooks>');
@@ -561,7 +655,9 @@  discard block
 block discarded – undo
561 655
 
562 656
       // output a warning if no telephone number was found
563 657
       if($id == 0)
564
-        print "  WARNING: no phone entry found. VCard will be ignored." . PHP_EOL;
658
+      {
659
+              print "  WARNING: no phone entry found. VCard will be ignored." . PHP_EOL;
660
+      }
565 661
 
566 662
       // email: put the email addresses into the fritzbox xml file
567 663
       $email = $contact->addChild("services");
@@ -611,8 +707,9 @@  discard block
 block discarded – undo
611 707
 
612 708
             print "  Added photo: " . basename($photo_file) . PHP_EOL;
613 709
           }
614
-          else
615
-           print "  WARNING: Only jpg contact photos are currently supported." . PHP_EOL;
710
+          else {
711
+                     print "  WARNING: Only jpg contact photos are currently supported." . PHP_EOL;
712
+          }
616 713
         }
617 714
         elseif(substr($entry['photo_data'][0], 0, 4) == 'http')
618 715
         {
@@ -621,8 +718,9 @@  discard block
 block discarded – undo
621 718
 
622 719
           print "  Added photo: " . $entry['photo_data'][0] . PHP_EOL;
623 720
         }
624
-        else
625
-          print "  WARNING: Only VCard embedded photo data or a reference URL is currently supported." . PHP_EOL;
721
+        else {
722
+                  print "  WARNING: Only VCard embedded photo data or a reference URL is currently supported." . PHP_EOL;
723
+        }
626 724
       }
627 725
 
628 726
       $contact->addChild("services");
@@ -631,7 +729,9 @@  discard block
 block discarded – undo
631 729
     }
632 730
 
633 731
     if($root->asXML() != false)
634
-      $this->fbxml = $root->asXML();
732
+    {
733
+          $this->fbxml = $root->asXML();
734
+    }
635 735
     else
636 736
     {
637 737
       print "  ERROR: created XML data isn't well-formed." . PHP_EOL;
@@ -648,19 +748,27 @@  discard block
 block discarded – undo
648 748
   public function _concat($text1, $text2)
649 749
   {
650 750
     if($text1 == '')
651
-      return $text2;
751
+    {
752
+          return $text2;
753
+    }
652 754
     elseif($text2 == '')
653
-      return $text1;
654
-    else
655
-      return $text1 . ", " . $text2;
755
+    {
756
+          return $text1;
757
+    }
758
+    else {
759
+          return $text1 . ", " . $text2;
760
+    }
656 761
   }
657 762
 
658 763
   public function _parse_fb_result($text)
659 764
   {
660 765
     if(preg_match("/\<h2\>([^\<]+)\<\/h2\>/", $text, $matches) == 1 && !empty($matches))
661
-      return $matches[1];
662
-    else
663
-      return "Error while uploading xml to fritzbox";
766
+    {
767
+          return $matches[1];
768
+    }
769
+    else {
770
+          return "Error while uploading xml to fritzbox";
771
+    }
664 772
   }
665 773
 
666 774
   public function upload_to_fb()
@@ -746,12 +854,16 @@  discard block
 block discarded – undo
746 854
 
747 855
                   ftp_pasv($conn_id, true);
748 856
                   if(!ftp_put($conn_id, $remote_path . "/" . $file, $fileinfo->getPathname(), FTP_BINARY))
749
-                    print " ERROR: while uploading file " . $fileinfo->getFilename() . PHP_EOL;
750
-                  else
751
-                    print " ok." . PHP_EOL;
857
+                  {
858
+                                      print " ERROR: while uploading file " . $fileinfo->getFilename() . PHP_EOL;
859
+                  }
860
+                  else {
861
+                                      print " ok." . PHP_EOL;
862
+                  }
863
+                }
864
+                else {
865
+                                  print " ok." . PHP_EOL;
752 866
                 }
753
-                else
754
-                  print " ok." . PHP_EOL;
755 867
 
756 868
                 // cleanup old files
757 869
                 foreach($all_existing_files as $existing_file)
@@ -763,20 +875,23 @@  discard block
 block discarded – undo
763 875
                   }
764 876
                 }
765 877
               }
766
-              else
767
-                print " already exists." . PHP_EOL;
878
+              else {
879
+                              print " already exists." . PHP_EOL;
880
+              }
768 881
             }
769 882
           }
770 883
         }
771 884
       }
772
-      else
773
-        print " ERROR: couldn't login to FTP-server '" . $ftp_server . "' with provided username/password settings." . PHP_EOL;
885
+      else {
886
+              print " ERROR: couldn't login to FTP-server '" . $ftp_server . "' with provided username/password settings." . PHP_EOL;
887
+      }
774 888
 
775 889
       // close ftp connection
776 890
       ftp_close($conn_id);
777 891
     }
778
-    else
779
-      print " ERROR: couldn't connect to FTP server '" . $ftp_server . "'." . PHP_EOL;
892
+    else {
893
+          print " ERROR: couldn't connect to FTP server '" . $ftp_server . "'." . PHP_EOL;
894
+    }
780 895
 
781 896
     // in case numeric IP is given, try to resolve to hostname. Otherwise Fritzbox may decline login, because it is determine to be (prohibited) remote access
782 897
     $hostname = $this->config['fritzbox_ip'];
@@ -784,7 +899,9 @@  discard block
 block discarded – undo
784 899
     {
785 900
       $hostname = gethostbyaddr($hostname);
786 901
       if($hostname == $this->config['fritzbox_ip'])
787
-        print " WARNING: Unable to get hostname for IP address (" . $this->config['fritzbox_ip'] . ") <" . $hostname . "<" . PHP_EOL;
902
+      {
903
+              print " WARNING: Unable to get hostname for IP address (" . $this->config['fritzbox_ip'] . ") <" . $hostname . "<" . PHP_EOL;
904
+      }
788 905
       else
789 906
       {
790 907
         print " INFO: Given IP address (" . $this->config['fritzbox_ip'] . ") has hostname " . $hostname . "." . PHP_EOL;
Please login to merge, or discard this patch.