jeneljenel / weather-module

src/Curl/Curl.php

<?php

namespace Jenel\Curl;

/**
 * A class to place service in $di.
 * Curl
 * Return array
 */
class Curl
{
    /**
     * Curl one.
     * @param url
     *
     * @return array
     */
    public function curlOne($url) : array
    {
        $ch = curl_init($url);
        curl_setopt($ch, CURLOPT_RETURNTRANSFER, true);

It seems like $ch can also be of type false; however, parameter $ch of curl_setopt() does only seem to accept resource, maybe add an additional type check?

        $response = curl_exec($ch);

It seems like $ch can also be of type false; however, parameter $ch of curl_exec() does only seem to accept resource, maybe add an additional type check?

        curl_close($ch);

It seems like $ch can also be of type false; however, parameter $ch of curl_close() does only seem to accept resource, maybe add an additional type check?

        return json_decode($response, true);
    }

    /**
     * Curl multi.
     * @param urls
     *
     * @return array
     */
    public function curlMulti($urls) : array
    {
        $options = [
            CURLOPT_RETURNTRANSFER => true,
        ];

        //set the multi handler
        $mh = curl_multi_init();

        //set variable to catch all
        $chAll = [];

        foreach ($urls as $url) {
            $ch = curl_init($url);
            curl_setopt_array($ch, $options);

It seems like $ch can also be of type false; however, parameter $ch of curl_setopt_array() does only seem to accept resource, maybe add an additional type check?

            curl_multi_add_handle($mh, $ch);

It seems like $ch can also be of type false; however, parameter $ch of curl_multi_add_handle() does only seem to accept resource, maybe add an additional type check?

            $chAll[] = $ch;
        };

        // execute all queries simultaneously, and continue when all are complete
        $running = null;
        do {
            curl_multi_exec($mh, $running);
        } while ($running);

        //fix to return as array json
        foreach ($chAll as $ch) {
            $data = curl_multi_getcontent($ch);
            $response[] = json_decode($data, true);
        };

        //close the handles
        curl_multi_remove_handle($mh, $ch);

The variable $ch does not seem to be defined for all execution paths leading up to this point.

        curl_multi_close($mh);

        return $response;

The variable $response seems to be defined by a foreach iteration on line 61. Are you sure the iterator is never empty, otherwise this variable is not defined?

    }
}