Cache::set() - Code Metrics - Inspection of "add caching module and little improvement" - jellyfishphp/jellyfish - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#33)

by Daniel

created 2020-10-27 11:08 UTC

Cache::set() A

↳ Parent: Cache

Complexity

Conditions	3
Paths	2

Size

Total Lines	14
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
eloc	7
c	1
b	0
f	1
dl	0
loc	14
rs	10
cc	3
nc	2
nop	3

<?php

namespace Jellyfish\CacheSymfony;

use Jellyfish\Cache\CacheInterface;
use Jellyfish\Cache\Exception\InvalidLifeTimeException;
use Symfony\Component\Cache\Adapter\AbstractAdapter;

class Cache implements CacheInterface
{
    /**
     * @var \Symfony\Component\Cache\Adapter\AbstractAdapter
     */
    protected $cacheAdapter;

    /**
     * @param \Symfony\Component\Cache\Adapter\AbstractAdapter $cacheAdapter
     */
    public function __construct(AbstractAdapter $cacheAdapter)
    {
        $this->cacheAdapter = $cacheAdapter;
    }


    /**
     * @param string $key
     *
     * @return string|null
     */
    public function get(string $key): ?string
    {
        $cacheItem = $this->cacheAdapter->getItem($key);

        if (!$cacheItem->isHit()) {
            return null;
        }

        return $cacheItem->get();
    }

    /**
     * @param string $key
     * @param string $value
     * @param int|null $lifeTime
     *
     * @return \Jellyfish\Cache\CacheInterface
     *
     * @throws \Jellyfish\Cache\Exception\InvalidLifeTimeException
     */
    public function set(string $key, string $value, ?int $lifeTime = null): CacheInterface
    {
        if ($lifeTime !== null && $lifeTime <= 0) {
            throw new InvalidLifeTimeException('The life time value must be greater then zero or null!');
        }

        $cacheItem = $this->cacheAdapter->getItem($key);

        $cacheItem->set($value)
            ->expiresAfter($lifeTime);

        $this->cacheAdapter->save($cacheItem);

        return $this;
    }
}


1			<?php
2
3			namespace Jellyfish\CacheSymfony;
4
5			use Jellyfish\Cache\CacheInterface;
6			use Jellyfish\Cache\Exception\InvalidLifeTimeException;
7			use Symfony\Component\Cache\Adapter\AbstractAdapter;
8
9			class Cache implements CacheInterface
10			{
11			/**
12			* @var \Symfony\Component\Cache\Adapter\AbstractAdapter
13			*/
14			protected $cacheAdapter;
15
16			/**
17			* @param \Symfony\Component\Cache\Adapter\AbstractAdapter $cacheAdapter
18			*/
19			public function __construct(AbstractAdapter $cacheAdapter)
20			{
21			$this->cacheAdapter = $cacheAdapter;
22			}
23
24
25			/**
26			* @param string $key
27			*
28			* @return string\|null
29			*/
30			public function get(string $key): ?string
31			{
32			$cacheItem = $this->cacheAdapter->getItem($key);
33
34			if (!$cacheItem->isHit()) {
35			return null;
36			}
37
38			return $cacheItem->get();
39			}
40
41			/**
42			* @param string $key
43			* @param string $value
44			* @param int\|null $lifeTime
45			*
46			* @return \Jellyfish\Cache\CacheInterface
47			*
48			* @throws \Jellyfish\Cache\Exception\InvalidLifeTimeException
49			*/
50			public function set(string $key, string $value, ?int $lifeTime = null): CacheInterface
51			{
52			if ($lifeTime !== null && $lifeTime <= 0) {
53			throw new InvalidLifeTimeException('The life time value must be greater then zero or null!');
54			}
55
56			$cacheItem = $this->cacheAdapter->getItem($key);
57
58			$cacheItem->set($value)
59			->expiresAfter($lifeTime);
60
61			$this->cacheAdapter->save($cacheItem);
62
63			return $this;
64			}
65			}
66

jellyfishphp / jellyfish

Pull Request — master (#33)

Cache::set() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like