Jeancsil\FlightSpy\Service\ElasticSearch\Client

Complexity

Total Complexity

3

Size/Duplication

Total Lines	31
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

0%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	3	1
A	getInstance()	0	12	2

<?php
/**
 * @author Jean Silva <me@jeancsil.com>
 * @license MIT
 */
namespace Jeancsil\FlightSpy\Service\ElasticSearch;

use Elasticsearch\ClientBuilder;

final class Client

Client does not seem to conform to the naming convention (Utils?$).

{
    /**
     * @var \Elasticsearch\Client
     */
    private static $instance;

    /**
     * To avoid the direct construction
     */
    private function __construct()
    {
    }

    /**
     * Returns ElasticSearch client object
     * @return \Elasticsearch\Client
     */
    public static function getInstance() {
        if (is_null(static::$instance)) {

Since Jeancsil\FlightSpy\Service\ElasticSearch\Client is declared final, using late-static binding will have no effect. You might want to replace static with self instead.

            $logger = ClientBuilder::defaultLogger('flightspy_elasticsearch.log');

            static::$instance = ClientBuilder::create()

Since Jeancsil\FlightSpy\Service\ElasticSearch\Client is declared final, using late-static binding will have no effect. You might want to replace static with self instead.

                ->setRetries(2)
                ->setLogger($logger)
                ->build();
        }

        return static::$instance;

Since Jeancsil\FlightSpy\Service\ElasticSearch\Client is declared final, using late-static binding will have no effect. You might want to replace static with self instead.

    }
}