Period::__toString() - Code Metrics - Inspection of "Finish the period tracking." - jeancsil/flight-spy - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( a62229...4b3a11 )

by Jean

created 2017-01-14 17:53 UTC

Period::__toString() A

↳ Parent: Period

Complexity

Conditions	2
Paths	2

Size

Total Lines	18
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes

Metric	Value
dl	0
loc	18
ccs	0
cts	0
cp	0
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	11
nc	2
nop	0
crap	6

<?php
/**
 * @author Jean Silva <[email protected]>
 * @license MIT
 */
namespace Jeancsil\FlightSpy\Api\DataTransfer;

use Doctrine\Common\Collections\ArrayCollection;

class Period
{
    /**
     * @var int
     */
    private $durationInDays;

    /**
     * @var \Datetime
     */
    private $dateFrom;

    /**
     * @var \Datetime
     */
    private $dateTo;

    /**
     * @var ArrayCollection
     */
    private $combinations;

    /**
     * @param int $durationInDays
     * @param \Datetime $dateFrom
     * @param \Datetime $dateTo
     */
    public function __construct($durationInDays, \Datetime $dateFrom, \Datetime $dateTo)
    {
        $this->durationInDays = $durationInDays;
        $this->dateFrom = $dateFrom;
$a = "a";
$ab = "ab";
$abc = "abc";
        $this->dateTo = $dateTo;
$a = "a";
$ab = "ab";
$abc = "abc";
        $this->combinations = new ArrayCollection();
$a = "a";
$ab = "ab";
$abc = "abc";
    }

    /**
     * @return ArrayCollection

     */
    public function generateDateCombinations()
    {
        $possibleDays = $this->dateFrom->diff($this->dateTo)->days;

        $initialDate = clone $this->dateFrom;
        $endDate = clone $this->dateFrom->add(new \DateInterval(sprintf('P%dD', $this->durationInDays)));
$a = "a";
$ab = "ab";
$abc = "abc";

        for ($i = 0; $i < $possibleDays; $i++) {
            $this->combinations->add([
                'outboundDate' => $initialDate->format('Y-m-d'),
                'inboundDate' => $endDate->format('Y-m-d')
            ]);

            if ($endDate->diff($this->dateTo)->days == 0) {
                return $this->combinations;
            }

            $initialDate->add($this->getOneDayMore());
            $endDate->add($this->getOneDayMore());
        }
    }

    /**
     * @return int
     */
    public function getDurationInDays()
    {
        return $this->durationInDays;
    }

    /**
     * @return \Datetime
     */
    public function getDateFrom()
    {
        return $this->dateFrom;
    }

    /**
     * @return \Datetime
     */
    public function getDateTo()
    {
        return $this->dateTo;
    }

    /**
     * @return string
     */
    public function __toString()
    {
        $string = sprintf(
            "Duration: %d days\nBetween %s and %s (inclusive)",
            $this->durationInDays,
            $this->dateFrom->format('d/m/Y'),
            $this->dateTo->format('d/m/Y')
        );

        if (!$this->combinations->isEmpty()) {
            $string .= sprintf(
                "\nResulted in these combinations:\n %s",
                var_export($this->combinations->toArray(), true)
            );
        }

        return $string;
    }

    /**
     * @return \DateInterval
     */
    private function getOneDayMore() {
        return new \DateInterval('P1D');
    }
}


1		<?php
2		/**
3		* @author Jean Silva <[email protected]>
4		* @license MIT
5		*/
6		namespace Jeancsil\FlightSpy\Api\DataTransfer;
7
8		use Doctrine\Common\Collections\ArrayCollection;
9
10		class Period
11		{
12		/**
13		* @var int
14		*/
15		private $durationInDays;
16
17		/**
18		* @var \Datetime
19		*/
20		private $dateFrom;
21
22		/**
23		* @var \Datetime
24		*/
25		private $dateTo;
26
27		/**
28		* @var ArrayCollection
29		*/
30		private $combinations;
31
32		/**
33		* @param int $durationInDays
34		* @param \Datetime $dateFrom
35		* @param \Datetime $dateTo
36		*/
37		public function __construct($durationInDays, \Datetime $dateFrom, \Datetime $dateTo)
38		{
39		$this->durationInDays = $durationInDays;
40		$this->dateFrom = $dateFrom;
		0 ignored issues – show Coding Style introduced 2017-01-14 14:13 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 7 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
41		$this->dateTo = $dateTo;
		0 ignored issues – show Coding Style introduced 2017-01-14 14:13 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 9 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
42	2	$this->combinations = new ArrayCollection();
		0 ignored issues – show Coding Style introduced 2017-01-14 17:55 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
43		}
44	2
45	2	/**
46		* @return ArrayCollection
		0 ignored issues – show Documentation introduced 2017-01-14 14:13 UTC by Report Bug Copy Issue Report Should the return type not be `ArrayCollection\|null`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
47	2	*/
48	2	public function generateDateCombinations()
49		{
50	2	$possibleDays = $this->dateFrom->diff($this->dateTo)->days;
51	2
52	2	$initialDate = clone $this->dateFrom;
53	2	$endDate = clone $this->dateFrom->add(new \DateInterval(sprintf('P%dD', $this->durationInDays)));
		0 ignored issues – show Coding Style introduced 2017-01-14 14:13 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 5 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
54
55		for ($i = 0; $i < $possibleDays; $i++) {
56	2	$this->combinations->add([
57	2	'outboundDate' => $initialDate->format('Y-m-d'),
58		'inboundDate' => $endDate->format('Y-m-d')
59		]);
60	2
61	2	if ($endDate->diff($this->dateTo)->days == 0) {
62		return $this->combinations;
63		}
64
65		$initialDate->add($this->getOneDayMore());
66		$endDate->add($this->getOneDayMore());
67		}
68		}
69
70		/**
71		* @return int
72		*/
73		public function getDurationInDays()
74		{
75		return $this->durationInDays;
76		}
77
78		/**
79		* @return \Datetime
80		*/
81		public function getDateFrom()
82		{
83		return $this->dateFrom;
84		}
85
86		/**
87		* @return \Datetime
88		*/
89		public function getDateTo()
90		{
91		return $this->dateTo;
92	2	}
93	2
94		/**
95		* @return string
96		*/
97		public function __toString()
98		{
99		$string = sprintf(
100		"Duration: %d days\nBetween %s and %s (inclusive)",
101		$this->durationInDays,
102		$this->dateFrom->format('d/m/Y'),
103		$this->dateTo->format('d/m/Y')
104		);
105
106		if (!$this->combinations->isEmpty()) {
107		$string .= sprintf(
108		"\nResulted in these combinations:\n %s",
109		var_export($this->combinations->toArray(), true)
110		);
111		}
112
113		return $string;
114		}
115
116		/**
117		* @return \DateInterval
118		*/
119		private function getOneDayMore() {
120		return new \DateInterval('P1D');
121		}
122		}
123

jeancsil / flight-spy

Push — master ( a62229...4b3a11 )

Period::__toString() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like