MappingProcessor - Code Metrics - Inspection of "Increase from 5 to 50 the number of prices checked..." - jeancsil/flight-spy - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 3a1449...d95c29 )

by Jean

created 2017-01-22 19:24 UTC

MappingProcessor A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	76
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Test Coverage

Coverage

Importance

Changes

Metric	Value
wmc	12
lcom	1
cbo	0
dl	0
loc	76
ccs	0
cts	51
cp	0
rs	10
c	0
b	0
f	0

4 Methods

Rating	Name	Size	Complexity
B	process()	35	3
A	formatDate()	4	1
A	getPlaceNameById()	7	3
B	getCarrier()	11	5

<?php
/**
 * @author Jean Silva <[email protected]>
 * @license MIT
 */
namespace Jeancsil\FlightSpy\History\ElasticSearch;

class MappingProcessor implements Processor
{
    /**
     * @var array
     */
    private $dataCache;

    public function process(array $data) {
        $this->dataCache = $data;

        $mappedData = [];
$a = "a";
$ab = "ab";
$abc = "abc";
        $mappedData['Creation'] = (new \DateTime())->format(\DATE_ATOM);
$a = "a";
$ab = "ab";
$abc = "abc";
        $mappedData['SessionKey'] = $data['SessionKey'];
        $mappedData['Status'] = $data['Status'];
$a = "a";
$ab = "ab";
$abc = "abc";
        $mappedData['Query'] = $data['Query'];
$a = "a";
$ab = "ab";
$abc = "abc";
        unset($mappedData['Query']['LocationSchema']);

        $mappedData['Query']['OriginPlace'] = $this->getPlaceNameById($data['Query']['OriginPlace']);
$a = "a";
$ab = "ab";
$abc = "abc";
        $mappedData['Query']['DestinationPlace'] = $this->getPlaceNameById($data['Query']['DestinationPlace']);
        $mappedData['Query']['OutboundDate'] = $this->formatDate($mappedData['Query']['OutboundDate']);
$a = "a";
$ab = "ab";
$abc = "abc";
        $mappedData['Query']['InboundDate'] = $this->formatDate($mappedData['Query']['InboundDate']);
$a = "a";
$ab = "ab";
$abc = "abc";

        $count = 0;
$a = "a";
$ab = "ab";
$abc = "abc";
        $mappedData['Itineraries'] = [];
        foreach ($data['Itineraries'] as $itinerary) {
            $outboundCarrier = $this->getCarrier($itinerary['OutboundLegId']);
            $inboundCarrier = $this->getCarrier($itinerary['InboundLegId']);
$a = "a";
$ab = "ab";
$abc = "abc";

            foreach ($itinerary['PricingOptions'] as $priceOption) {
                $mappedData['Itineraries'][$count] = [
                    'Price' => $priceOption['Price'],
                    'Deeplink' => 'none',//$priceOption['DeeplinkUrl'],
                    'OutboundCarrier' => $outboundCarrier['Name'],
                    'InboundCarrier' => $inboundCarrier['Name'],
                ];
            }

            $count++;
        }

        return $mappedData;
    }

    private function formatDate($date) {
        return (new \DateTime($date))
            ->format(\DATE_ATOM);
    }

    /**
     * @param $placeId
     * @return string
     */
    private function getPlaceNameById($placeId) {
        foreach ($this->dataCache['Places'] as $place) {
            if ($place['Id'] == $placeId) {
                return $place['Name'];
            }
        }
    }

    /**
     * @param $legId
     * @return array
     */
    private function getCarrier($legId) {
        foreach ($this->dataCache['Legs'] as $leg) {
            if ($leg['Id'] == $legId) {
                foreach ($this->dataCache['Carriers'] as $carrier) {
                    if ($carrier['Id'] == $leg['Carriers'][0]) {
                        return $carrier;
                    }
                }
            }
        }
    }
}


1			<?php
2			/**
3			* @author Jean Silva <[email protected]>
4			* @license MIT
5			*/
6			namespace Jeancsil\FlightSpy\History\ElasticSearch;
7
8			class MappingProcessor implements Processor
9			{
10			/**
11			* @var array
12			*/
13			private $dataCache;
14
15			public function process(array $data) {
16			$this->dataCache = $data;
17
18			$mappedData = [];
			0 ignored issues – show Coding Style introduced 2017-01-22 19:27 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 15 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
19			$mappedData['Creation'] = (new \DateTime())->format(\DATE_ATOM);
			0 ignored issues – show Coding Style introduced 2017-01-22 19:27 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
20			$mappedData['SessionKey'] = $data['SessionKey'];
21			$mappedData['Status'] = $data['Status'];
			0 ignored issues – show Coding Style introduced 2017-01-22 19:27 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 5 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
22			$mappedData['Query'] = $data['Query'];
			0 ignored issues – show Coding Style introduced 2017-01-22 19:27 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 6 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
23			unset($mappedData['Query']['LocationSchema']);
24
25			$mappedData['Query']['OriginPlace'] = $this->getPlaceNameById($data['Query']['OriginPlace']);
			0 ignored issues – show Coding Style introduced 2017-01-22 19:27 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 6 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
26			$mappedData['Query']['DestinationPlace'] = $this->getPlaceNameById($data['Query']['DestinationPlace']);
27			$mappedData['Query']['OutboundDate'] = $this->formatDate($mappedData['Query']['OutboundDate']);
			0 ignored issues – show Coding Style introduced 2017-01-22 19:27 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 5 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
28			$mappedData['Query']['InboundDate'] = $this->formatDate($mappedData['Query']['InboundDate']);
			0 ignored issues – show Coding Style introduced 2017-01-22 19:27 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 6 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
29
30			$count = 0;
			0 ignored issues – show Coding Style introduced 2017-01-22 19:27 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 21 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
31			$mappedData['Itineraries'] = [];
32			foreach ($data['Itineraries'] as $itinerary) {
33			$outboundCarrier = $this->getCarrier($itinerary['OutboundLegId']);
34			$inboundCarrier = $this->getCarrier($itinerary['InboundLegId']);
			0 ignored issues – show Coding Style introduced 2017-01-22 19:27 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 2 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
35
36			foreach ($itinerary['PricingOptions'] as $priceOption) {
37			$mappedData['Itineraries'][$count] = [
38			'Price' => $priceOption['Price'],
39			'Deeplink' => 'none',//$priceOption['DeeplinkUrl'],
40			'OutboundCarrier' => $outboundCarrier['Name'],
41			'InboundCarrier' => $inboundCarrier['Name'],
42			];
43			}
44
45			$count++;
46			}
47
48			return $mappedData;
49			}
50
51			private function formatDate($date) {
52			return (new \DateTime($date))
53			->format(\DATE_ATOM);
54			}
55
56			/**
57			* @param $placeId
58			* @return string
59			*/
60			private function getPlaceNameById($placeId) {
61			foreach ($this->dataCache['Places'] as $place) {
62			if ($place['Id'] == $placeId) {
63			return $place['Name'];
64			}
65			}
66			}
67
68			/**
69			* @param $legId
70			* @return array
71			*/
72			private function getCarrier($legId) {
73			foreach ($this->dataCache['Legs'] as $leg) {
74			if ($leg['Id'] == $legId) {
75			foreach ($this->dataCache['Carriers'] as $carrier) {
76			if ($carrier['Id'] == $leg['Carriers'][0]) {
77			return $carrier;
78			}
79			}
80			}
81			}
82			}
83			}
84

jeancsil / flight-spy

Push — master ( 3a1449...d95c29 )

MappingProcessor A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

4 Methods

Duplication Side-by-Side

Filter issues like