Jeancsil\FlightSpy\Service\ElasticSearch\ElasticSearchRequester

Complexity

Total Complexity

2

Size/Duplication

Total Lines	35
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Test Coverage

Coverage

0%

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
B	wasNotified()	0	25	2

<?php
namespace Jeancsil\FlightSpy\Service\ElasticSearch;

/**
 * @author Jean Silva <me@jeancsil.com>
 * @license MIT
 */
class ElasticSearchRequester
{
    use ConfiguratorTrait;

    /**
     * @param string $identifier
     * @param string $notifyTo
     * @return boolean
     */
    public function wasNotified($identifier, $notifyTo)

function wasNotified() does not seem to conform to the naming convention (^(?:is|has|should|may|supports)).

    {
        $params = [
            'index' => $this->indexName,
            'type' => $this->typeName,
            'body' => [
                'query' => [
                    'bool' => [
                        'must' => [
                            ['term' => ['identifier' => $identifier]],
                            ['term' => ['notified' => $notifyTo]]
                        ]
                    ]
                ]
            ]
        ];

        $response = Client::getInstance()->search($params);

        if (isset($response['hits']['total'])) {
            return $response['hits']['total'] > 0;
        }

        return false;
    }
}