Jeancsil\FlightSpy\Api\Http\Transport

Complexity

Total Complexity

12

Size/Duplication

Total Lines	133
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	10

Test Coverage

Coverage

0%

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	findQuotes()	0	8	2
B	createSession()	0	27	3
B	poll()	0	47	5
A	setPollUrl()	0	5	1

<?php
/**
 * @author Jean Silva <me@jeancsil.com>
 * @license MIT
 */
namespace Jeancsil\FlightSpy\Api\Http;

use GuzzleHttp\ClientInterface;
use GuzzleHttp\Exception\BadResponseException;
use Jeancsil\FlightSpy\Api\DataTransfer\SessionParameters;
use Jeancsil\FlightSpy\Service\ElasticSearch\ElasticSearchWriterTrait;
use Jeancsil\FlightSpy\History\ElasticSearch\MappingProcessor;
use Psr\Log\LoggerAwareTrait;

class Transport implements TransportInterface
{
    use LoggerAwareTrait;
    use ElasticSearchWriterTrait;

    const LIVE_PRICING = '/apiservices/pricing/v1.0';

Equals sign not aligned with surrounding assignments; expected 11 spaces but found 1 space

    const WAITING_TIME_IN_MILLIS = 500000;

    /**
     * @var \GuzzleHttp\Client
     */
    private $client;

    /**
     * @var string
     */
    private $pollUrl;

    /**
     * @param ClientInterface $client
     */
    public function __construct(ClientInterface $client)
    {
        $this->client = $client;

$client is of type object<GuzzleHttp\ClientInterface>, but the property $client was declared to be of type object<GuzzleHttp\Client>. Are you sure that you always receive this specific sub-class here, or does it make sense to add an instanceof check?

    }

    /**
     * @param SessionParameters $parameters
     * @param bool $newSession
     * @return \stdClass
     */
    public function findQuotes(SessionParameters $parameters, $newSession)
    {
        if ($newSession) {
            $this->createSession($parameters);
        }

        return $this->poll();
    }

    /**
     * @param SessionParameters $parameters
     * @throws \Exception
     */
    private function createSession(SessionParameters $parameters)
    {
        try {
            $parametersArray = $parameters->toArray();

            $request = $this
                ->client
                ->post(static::LIVE_PRICING, ['form_params' => $parametersArray]);

            if (!isset($request->getHeaders()['Location'][0])) {
                throw new \Exception('Location not found for the poll');
            }

            $this->setPollUrl($request->getHeaders()['Location'][0], $parametersArray['apiKey']);
            usleep(static::WAITING_TIME_IN_MILLIS);
        } catch (BadResponseException $e) {
            $this->logger->error(
                sprintf(
                    "[Transport::createSession]\nStatusCode: %d\nBody: %s",
                    $e->getResponse()->getStatusCode(),
                    $e->getResponse()->getBody()
                )
            );

            throw $e;
        }
    }

    /**
     * @return \stdClass
     */
    private function poll()
    {
        try {
            $response = $this
                ->client
                ->get($this->pollUrl);

            $this->logger->info("HTTPStatusCode: " . $response->getStatusCode());

The string literal HTTPStatusCode: does not require double quotes, as per coding-style, please use single quotes.

            if ($response->getStatusCode() != 200) {
                return;
            }

            $arrayContent = \GuzzleHttp\json_decode(
                str_replace("'", '\'', $response->getBody()->getContents()),
                true
            );

            if (!is_array($arrayContent)) {
                $this->logger->critical(
                    sprintf('Expecting $arrayContent to be an array. %s given.', gettype($arrayContent))
                );
                return;
            }

            $this->getElasticSearchWriter()
                ->setProcessor(new MappingProcessor())
                ->write($arrayContent);

            return (object) $arrayContent;
        } catch (BadResponseException $e) {
            $this->logger->error(
                sprintf(
                    "[Transport::pool]\nStatusCode: %d\nBody: %s",
                    $e->getResponse()->getStatusCode(),
                    $e->getResponse()->getBody()
                )
            );
        } catch (\Exception $e) {
            $this->logger->error(
                sprintf(
                    "[Transport::pool]\nException:\n%s",
                    $e->getMessage()
                )
            );
        }
    }

    /**
     * @param string $url
     * @param string $apiKey
     */
    private function setPollUrl($url, $apiKey)
    {
        $this->pollUrl = "$url?apiKey=$apiKey&sorttype=price&sortorder=asc";

As per coding-style, please use concatenation or sprintf for the variable $url instead of interpolation.

As per coding-style, please use concatenation or sprintf for the variable $apiKey instead of interpolation.

        $this->logger->debug("Pool url is: $this->pollUrl");

As per coding-style, please use concatenation or sprintf for the variable $this instead of interpolation.

    }
}