App\Http\Controllers\Admin\PageController

Complexity

Total Complexity

8

Size/Duplication

Total Lines	143
Duplicated Lines	100 %

Coupling/Cohesion

Components	0
Dependencies	5

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	15	15	1
A	associateRelationships()	49	49	3
A	associateRelationshipsWithID()	41	41	4

<?php
/**
 * Page module controller
 * 
 * Controller for module Page
 * 
 * @category Controller
 * @subpackage Admin
 * @package Olapus
 * @author Jan Drda <jdrda@outlook.com>
 * @copyright Jan Drda
 * @license https://opensource.org/licenses/MIT MIT
 */

namespace App\Http\Controllers\Admin;

use Illuminate\Http\Request;
use Illuminate\Support\Facades\Validator;
use Illuminate\Support\Facades\Auth;

class PageController extends AdminModuleController {

This class seems to be duplicated in your project.

    /**
     * Constructor
     * 
     * @var Request $request
     */
    public function __construct(Request $request) {

The parameter $request is not used and could be removed.

        parent::__construct();

        /**
         * Add lookup tables
         */
        $this->middleware('add.lookup.tables:User', ['only' => ['create', 'edit']]);
        $this->middleware('add.lookup.tables:PageCategory', ['only' => ['create', 'edit']]);
        $this->middleware('add.published.at', ['only' => ['store', 'update']]);

        /**
         * Other tables
         */
        $this->middleware('media.image.select:Image', ['only' => ['create', 'edit']]);
    }

    /**
     * Validation rules
     * 
     * @var array
     */
    protected $arValidationArray = [
        'name' => 'required|max:255|unique:page,name',
        'meta_title' => 'max:255',
        'meta_description' => 'max:255',
        'meta_keywords' => 'max:255',
        'text' => 'max:1000000',
        'url' => 'required|max:255|unique:page,url',
        'author_name' => 'max:255',
        'published_at' => 'date',
    ];

    /**
     * Associate relationships to other table
     * 
     * @param object $object
     * @param Request $request
     */
    public function associateRelationships($object, Request $request) {

        /**
         * Validate user ID, if failed set to actual authorized user
         */
        $validator = Validator::make($request->all(), [
                    'user_id' => 'required|integer|min:1|exists:users,id',
        ]);
        
        /**
         * Validator fails - add actual authorized user
         */
        if ($validator->fails()) {

            $object->users()->associate(Auth::user()->id);

Accessing id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

            
        } 
        
        /**
         * Validator OK - save it
         */
        else {

            $object->users()->associate($request->input('user_id'));
        }

        /**
         * Validate image ID, if failed set to default
         */
        $validator = Validator::make($request->all(), [
                    'image_id' => 'integer|min:1|exists:image,id',
        ]);

        /**
         * Validator fails - nothing to do
         */
        if ($validator->fails()) {

           
        } 
        
        /**
         * Validator OK - save it
         */
        else {

            $object->images()->associate($request->input('image_id'));
        }
    }
    
    /**
     * Associate relationships to other table, where ID if object must be present
     * 
     * @param object $object
     * @param Request $request
     */
    public function associateRelationshipsWithID($object, Request $request) {
        
        /**
         * Validate page category ID, if failed set to default
         */
        if($request->has('pagecategory_id')){
            $validIDs = [];
            
            /**
             * For each category
             */
            foreach ($request->input('pagecategory_id') as $pagecategory_id) {

                $arrayForValidator = ['pagecategory_id' =>  $pagecategory_id];

                $validator = Validator::make($arrayForValidator, [
                            'pagecategory_id' => 'required|integer|min:1|exists:pagecategory,id',
                ]);

                /**
                 * Validator fails - nothing to do
                 */
                if ($validator->fails()) {

                } 
                
                /**
                 * Validator OK - save it
                 */
                else {

                    $validIDs[] = $pagecategory_id;
                }
            }
            
            /**
             * Sync to pivot
             */
            $object->pagecategories()->sync($validIDs);
        }
    }
}