Issues in index.php - Fixed Issues - Inspection of "Pleasing Scrutinizer." - jdel/sspks - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — rework ( 810325...63821e )

by Markus

created 2017-01-23 23:18 UTC

index.php (1 issue)

Labels

Documentation 1

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

if (!file_exists(__DIR__ . '/vendor/autoload.php')) {
    print('Autoloader not found! Did you follow the instructions from the INSTALL.md?<br />');
    print('(If you want to keep the old version, switch to the <tt>legacy</tt> branch by running: <tt>git checkout legacy</tt>');
    exit();
}

require_once __DIR__ . '/vendor/autoload.php';

use \SSpkS\Config;
use \SSpkS\Handler;

$config = new Config(__DIR__, 'conf/sspks.yaml');
$config->baseUrl = 'http' . ($_SERVER['HTTPS']?'s':'') . '://' . $_SERVER['HTTP_HOST'] . substr($_SERVER['REQUEST_URI'], 0, strrpos($_SERVER['REQUEST_URI'], '/')) . '/';
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

$handler = new Handler($config);
$handler->handle();


1			<?php
2
3			if (!file_exists(__DIR__ . '/vendor/autoload.php')) {
4			print('Autoloader not found! Did you follow the instructions from the INSTALL.md?<br />');
5			print('(If you want to keep the old version, switch to the <tt>legacy</tt> branch by running: <tt>git checkout legacy</tt>');
6			exit();
7			}
8
9			require_once __DIR__ . '/vendor/autoload.php';
10
11			use \SSpkS\Config;
12			use \SSpkS\Handler;
13
14			$config = new Config(__DIR__, 'conf/sspks.yaml');
15			$config->baseUrl = 'http' . ($_SERVER['HTTPS']?'s':'') . '://' . $_SERVER['HTTP_HOST'] . substr($_SERVER['REQUEST_URI'], 0, strrpos($_SERVER['REQUEST_URI'], '/')) . '/';
			0 ignored issues – show Documentation introduced 2017-01-23 23:14 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `baseUrl` does not exist on `object<SSpkS\Config>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
16
17			$handler = new Handler($config);
18			$handler->handle();
19

jdel / sspks

Push — rework ( 810325...63821e )

index.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like