Handler::__construct() - Code Metrics - Inspection of "Move redirect feature into separate handler class...." - jdel/sspks - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 59cf45...89a6d0 )

by Markus

created 2017-03-04 23:04 UTC

Handler::__construct() A

↳ Parent: Handler

Complexity

Conditions	1
Paths	1

Size

Total Lines	14
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
cc	1
eloc	9
nc	1
nop	1
dl	0
loc	14
ccs	0
cts	10
cp	0
crap	2
rs	9.4285
c	0
b	0
f	0

<?php

// Starting point, handle incoming request and hand over to more specific handler

namespace SSpkS;

class Handler

{
    private $config;
    private $handler_list;

    public function __construct(\SSpkS\Config $config)
    {
        $this->config = $config;

        // ordered by priority (top to bottom)
        $this->handler_list = array(
            'SynologyHandler',
            'BrowserRedirectHandler',
            'BrowserPackageListHandler',
            'BrowserAllPackagesListHandler',
            'BrowserDeviceListHandler',
            'NotFoundHandler'
        );
    }

    public function handle()
    {
        foreach ($this->handler_list as $possible_handler) {
            // Add namespace to class name
            $possible_handler = '\\SSpkS\\Handler\\' . $possible_handler;
            $handler = new $possible_handler($this->config);
            if ($handler->canHandle()) {
                $handler->handle();
                break;
            }
        }
    }
}


1			<?php
2
3			// Starting point, handle incoming request and hand over to more specific handler
4
5			namespace SSpkS;
6
7			class Handler
			0 ignored issues – show Coding Style introduced 2017-03-04 23:07 UTC by Report Bug Copy Issue Report The property $handler_list is not named in camelCase. This check marks property names that have not been written in camelCase. In camelCase names are written without any punctuation, the start of each new word being marked by a capital letter. Thus the name database connection string becomes `databaseConnectionString`. Loading history...
8			{
9			private $config;
10			private $handler_list;
11
12			public function __construct(\SSpkS\Config $config)
13			{
14			$this->config = $config;
15
16			// ordered by priority (top to bottom)
17			$this->handler_list = array(
18			'SynologyHandler',
19			'BrowserRedirectHandler',
20			'BrowserPackageListHandler',
21			'BrowserAllPackagesListHandler',
22			'BrowserDeviceListHandler',
23			'NotFoundHandler'
24			);
25			}
26
27			public function handle()
28			{
29			foreach ($this->handler_list as $possible_handler) {
30			// Add namespace to class name
31			$possible_handler = '\\SSpkS\\Handler\\' . $possible_handler;
32			$handler = new $possible_handler($this->config);
33			if ($handler->canHandle()) {
34			$handler->handle();
35			break;
36			}
37			}
38			}
39			}
40

jdel / sspks

Push — master ( 59cf45...89a6d0 )

Handler::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like