Issues in BrowserDeviceListHandler.php - New Issues - Inspection of "Merge branch 'master' into develop" - jdel/sspks - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — develop ( 9f153d...55c280 )

by Julien

created 2017-08-15 21:02 UTC

lib/SSpkS/Handler/BrowserDeviceListHandler.php (2 issues)

Labels

Documentation 2

Severity

Minor 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace SSpkS\Handler;

use \SSpkS\Device\DeviceList;
use \SSpkS\Output\HtmlOutput;

class BrowserDeviceListHandler extends AbstractHandler
{
    public function canHandle()
    {
        return ($_SERVER['REQUEST_METHOD'] == 'GET');
    }

    public function handle()
    {
        // Nothing requested --> show models overview
        $output = new HtmlOutput($this->config);
        try {
            $deviceList = new DeviceList($this->config);
            $models = $deviceList->getDevices();
            if (count($models) == 0) {
                $output->setTemplate('html_modellist_none');
            } else {
                $output->setVariable('modellist', $models);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                $output->setTemplate('html_modellist');
            }
        } catch (\Exception $e) {
            $output->setVariable('errorMessage', $e->getMessage());
            $output->setTemplate('html_modellist_error');
        }
        $output->setVariable('is_devicelist', true);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $output->output();
    }
}


1			<?php
2
3			namespace SSpkS\Handler;
4
5			use \SSpkS\Device\DeviceList;
6			use \SSpkS\Output\HtmlOutput;
7
8			class BrowserDeviceListHandler extends AbstractHandler
9			{
10			public function canHandle()
11			{
12			return ($_SERVER['REQUEST_METHOD'] == 'GET');
13			}
14
15			public function handle()
16			{
17			// Nothing requested --> show models overview
18			$output = new HtmlOutput($this->config);
19			try {
20			$deviceList = new DeviceList($this->config);
21			$models = $deviceList->getDevices();
22			if (count($models) == 0) {
23			$output->setTemplate('html_modellist_none');
24			} else {
25			$output->setVariable('modellist', $models);
			0 ignored issues – show Documentation introduced 2017-08-15 20:31 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$models` is of type `array`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
26			$output->setTemplate('html_modellist');
27			}
28			} catch (\Exception $e) {
29			$output->setVariable('errorMessage', $e->getMessage());
30			$output->setTemplate('html_modellist_error');
31			}
32			$output->setVariable('is_devicelist', true);
			0 ignored issues – show Documentation introduced 2017-08-15 20:31 UTC by Report Bug Copy Issue Report Show Similar Issues like this `true` is of type `boolean`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
33			$output->output();
34			}
35			}
36

jdel / sspks

Push — develop ( 9f153d...55c280 )

lib/SSpkS/Handler/BrowserDeviceListHandler.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like