DeviceList::__construct() - Code Metrics - Inspection of "Merge pull request #31 from benrubson/empty" - jdel/sspks - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Branch — master (b0d099)

by Markus

created 2017-02-27 13:33 UTC

DeviceList::__construct() A

↳ Parent: DeviceList

Complexity

Conditions	3
Paths	3

Size

Total Lines	12
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	8
CRAP Score	3

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	3
eloc	8
nc	3
nop	1
dl	0
loc	12
rs	9.4285
c	1
b	0
f	0
ccs	8
cts	8
cp	1
crap	3

<?php

namespace SSpkS\Device;

use \Symfony\Component\Yaml\Yaml;
use \Symfony\Component\Yaml\Exception\ParseException;

class DeviceList
{
    private $yamlFilepath;
    private $devices = array();

    /**
     * @param string $yamlFilepath Filename of Yaml file containing model list
     * @throws \Exception if file is not found or parsing error.
     */
    public function __construct($yamlFilepath)
    {
        $this->yamlFilepath = $yamlFilepath;
        if (!file_exists($this->yamlFilepath)) {
            throw new \Exception('DeviceList file ' . $this->yamlFilepath . ' not found!');
        }
        try {
            $this->parseYaml();
        } catch (\Exception $e) {
            throw $e;
        }
    }

    /**
     * Parse Yaml file with device data.
     *
     * @throws \Exception if Yaml couldn't be parsed.
     */
    private function parseYaml()
    {
        try {
            /** @var array $archlist */
            $archlist = Yaml::parse(file_get_contents($this->yamlFilepath));
        } catch (ParseException $e) {
            throw new \Exception($e->getMessage());
        }
        $idx = 0;
        $sortkey = array();
        foreach ($archlist as $arch => $archmodels) {
            foreach ($archmodels as $model) {
                $this->devices[$idx] = array(
                    'arch' => $arch,
                    'name' => $model,
                );
                $sortkey[$idx] = $model;
                $idx++;
            }
        }
        array_multisort($sortkey, SORT_NATURAL|SORT_FLAG_CASE, $this->devices);
    }

    /**
     * Returns the list of devices and their architectures.
     *
     * @return array List of devices and architectures.
     */
    public function getDevices()
    {
        return $this->devices;
    }
}


1		<?php
2
3		namespace SSpkS\Device;
4
5		use \Symfony\Component\Yaml\Yaml;
6		use \Symfony\Component\Yaml\Exception\ParseException;
7
8		class DeviceList
9		{
10		private $yamlFilepath;
11		private $devices = array();
12
13		/**
14		* @param string $yamlFilepath Filename of Yaml file containing model list
15		* @throws \Exception if file is not found or parsing error.
16		*/
17	4	public function __construct($yamlFilepath)
18		{
19	4	$this->yamlFilepath = $yamlFilepath;
20	4	if (!file_exists($this->yamlFilepath)) {
21	1	throw new \Exception('DeviceList file ' . $this->yamlFilepath . ' not found!');
22		}
23		try {
24	3	$this->parseYaml();
25	3	} catch (\Exception $e) {
26	1	throw $e;
27		}
28	2	}
29
30		/**
31		* Parse Yaml file with device data.
32		*
33		* @throws \Exception if Yaml couldn't be parsed.
34		*/
35	3	private function parseYaml()
36		{
37		try {
38		/** @var array $archlist */
39	3	$archlist = Yaml::parse(file_get_contents($this->yamlFilepath));
40	3	} catch (ParseException $e) {
41	1	throw new \Exception($e->getMessage());
42		}
43	2	$idx = 0;
44	2	$sortkey = array();
45	2	foreach ($archlist as $arch => $archmodels) {
46	2	foreach ($archmodels as $model) {
47	2	$this->devices[$idx] = array(
48	2	'arch' => $arch,
49	2	'name' => $model,
50		);
51	2	$sortkey[$idx] = $model;
52	2	$idx++;
53	2	}
54	2	}
55	2	array_multisort($sortkey, SORT_NATURAL\|SORT_FLAG_CASE, $this->devices);
56	2	}
57
58		/**
59		* Returns the list of devices and their architectures.
60		*
61		* @return array List of devices and architectures.
62		*/
63	2	public function getDevices()
64		{
65	2	return $this->devices;
66		}
67		}
68

jdel / sspks

Branch — master (b0d099)

DeviceList::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like